From: Li Qiang <liqiang01@kylinos.cn>
To: akpm@linux-foundation.org, david@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
mhocko@suse.com
Subject: Re: [PATCH] mm: memory: Force-inline PTE/PMD zapping functions
Date: Wed, 6 Aug 2025 13:40:53 +0800 [thread overview]
Message-ID: <20250806054053.1507456-1-liqiang01@kylinos.cn> (raw)
In-Reply-To: <a4491b54-4e08-4bcc-bcd3-3bae20a490b2@suse.cz>
On 8/5/25 13:15 PM, Vlastimil Babka wrote:
> Is the before/after swapped here? This output suggests some functions
> became NOT inlined.
>
> If I'm right the output binary becomes slightly larger. But it doesn't
> matter.
Thank you for your careful review. You're absolutely right - the
before/after columns in my previous data table were accidentally
reversed. I've corrected this in the updated measurements below:
[root@localhost linux_old1]# ./scripts/bloat-o-meter befor.vmlinux after.vmlinux
add/remove: 0/6 grow/shrink: 1/0 up/down: 4747/-4569 (178)
Function old new delta
unmap_page_range 1018 5765 +4747
__pfx_zap_pte_range 16 - -16
__pfx_zap_present_ptes.constprop 16 - -16
__pfx_zap_pmd_range.isra 16 - -16
zap_pmd_range.isra 589 - -589
zap_pte_range 1236 - -1236
zap_present_ptes.constprop 2696 - -2696
Total: Before=35379608, After=35379786, chg +0.00%
[root@localhost linux_old1]#
next prev parent reply other threads:[~2025-08-06 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 12:39 [PATCH] mm: memory: Force-inline PTE/PMD zapping functions for performance Li Qiang
2025-08-04 12:51 ` David Hildenbrand
2025-08-04 13:01 ` Nadav Amit
2025-08-04 13:30 ` David Hildenbrand
2025-08-05 12:04 ` Li Qiang
2025-08-05 13:15 ` Vlastimil Babka
2025-08-06 5:40 ` Li Qiang [this message]
2025-08-05 13:35 ` Lorenzo Stoakes
2025-08-06 5:51 ` Li Qiang
2025-08-07 10:25 ` Vlastimil Babka
2025-08-04 13:15 ` Vlastimil Babka
2025-08-04 13:29 ` Lorenzo Stoakes
2025-08-04 13:59 ` Lorenzo Stoakes
2025-08-04 14:41 ` Vlastimil Babka
2025-08-04 14:50 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250806054053.1507456-1-liqiang01@kylinos.cn \
--to=liqiang01@kylinos.cn \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox