Re: [PATCH v2] mm/damon: update expired description of damos_action

[SeongJae Park <sj@kernel.org>]

Hello Sang-Heon,

On Mon,  4 Aug 2025 23:38:16 +0900 Sang-Heon Jeon <ekffu200098@gmail.com> wrote:

> Nowadays, damos operation actions support more various operation set.
> But comments(also, generated documentation) doesn't updated.
> So, fix the comments with current support status.
> 
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
> Changes from v1 [1]:
> 1. change baseline from damon/next to mm/mm-new
> 2. Add note about DAMOS_PAGEOUT and demotion.

Thank you for making this revision!

> 
> [1] https://lore.kernel.org/all/20250731132230.80046-1-ekffu200098@gmail.com/
> 
> ---
> I also watch your comment from [1]. Thank you for not forgetting :)
> 
> [1] https://lore.kernel.org/damon/20250801233942.1614-1-sj@kernel.org/
> 
> ---
>  include/linux/damon.h | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index f13664c62ddd..d4b3ffd6144d 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -110,7 +110,7 @@ struct damon_target {
>   *
>   * @DAMOS_WILLNEED:	Call ``madvise()`` for the region with MADV_WILLNEED.
>   * @DAMOS_COLD:		Call ``madvise()`` for the region with MADV_COLD.
> - * @DAMOS_PAGEOUT:	Call ``madvise()`` for the region with MADV_PAGEOUT.
> + * @DAMOS_PAGEOUT:	Reclaim the region.
>   * @DAMOS_HUGEPAGE:	Call ``madvise()`` for the region with MADV_HUGEPAGE.
>   * @DAMOS_NOHUGEPAGE:	Call ``madvise()`` for the region with MADV_NOHUGEPAGE.
>   * @DAMOS_LRU_PRIO:	Prioritize the region on its LRU lists.
> @@ -123,8 +123,10 @@ struct damon_target {
>   * The support of each action is up to running &struct damon_operations.
>   * &enum DAMON_OPS_VADDR and &enum DAMON_OPS_FVADDR supports all actions except
>   * &enum DAMOS_LRU_PRIO and &enum DAMOS_LRU_DEPRIO.  &enum DAMON_OPS_PADDR
> - * supports only &enum DAMOS_PAGEOUT, &enum DAMOS_LRU_PRIO, &enum
> - * DAMOS_LRU_DEPRIO, and &DAMOS_STAT.
> + * supports all actions except &enum DAMOS_WILLNEED, &enum DAMOS_COLD,
> + * &enum DAMOS_HUGEPAGE, &enum DAMOS_NOHUGEPAGE.

I think we agreed[1] to add a reference to the design doc, instead of keeping
this duplicated.  Am I missing something?

> + *
> + * Note that DAMOS_PAGEOUT doesn't trigger demotions.
>   */
>  enum damos_action {
>  	DAMOS_WILLNEED,
> -- 
> 2.43.0

[1] https://lore.kernel.org/CABFDxMGh7-vDgNzepJKtrhdOF40_U7=NT6Jvm85qtdwGpBZawg@mail.gmail.com


Thanks,
SJ