Re: [PATCH v3 10/15] pinctrl: make struct pinfunction a pointer in struct function_desc

[kernel test robot <lkp@intel.com>]

Hi Bartosz,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 05adbee3ad528100ab0285c15c91100e19e10138]

url:    https://github.com/intel-lab-lkp/linux/commits/Bartosz-Golaszewski/lib-provide-kmemdup_const/20250724-172620
base:   05adbee3ad528100ab0285c15c91100e19e10138
patch link:    https://lore.kernel.org/r/20250724-pinctrl-gpio-pinfuncs-v3-10-af4db9302de4%40linaro.org
patch subject: [PATCH v3 10/15] pinctrl: make struct pinfunction a pointer in struct function_desc
config: x86_64-buildonly-randconfig-002-20250725 (https://download.01.org/0day-ci/archive/20250726/202507261937.Txq9shpv-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250726/202507261937.Txq9shpv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202507261937.Txq9shpv-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/pinmux.c:917:7: warning: cast from 'void (*)(const void *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
     917 |                                          (void (*)(void *))kfree_const,
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/device/devres.h:166:34: note: expanded from macro 'devm_add_action_or_reset'
     166 |         __devm_add_action_or_reset(dev, action, data, #action)
         |                                         ^~~~~~
   1 warning generated.


vim +917 drivers/pinctrl/pinmux.c

   883	
   884	/**
   885	 * pinmux_generic_add_pinfunction() - adds a function group
   886	 * @pctldev: pin controller device
   887	 * @func: pinfunction structure describing the function group
   888	 * @data: pin controller driver specific data
   889	 */
   890	int pinmux_generic_add_pinfunction(struct pinctrl_dev *pctldev,
   891					   const struct pinfunction *func, void *data)
   892	{
   893		struct function_desc *function;
   894		int selector, error;
   895	
   896		selector = pinmux_func_name_to_selector(pctldev, func->name);
   897		if (selector >= 0)
   898			return selector;
   899	
   900		selector = pctldev->num_functions;
   901	
   902		function = devm_kzalloc(pctldev->dev, sizeof(*function), GFP_KERNEL);
   903		if (!function)
   904			return -ENOMEM;
   905	
   906		function->func = kmemdup_const(func, sizeof(*func), GFP_KERNEL);
   907		if (!function->func)
   908			return -ENOMEM;
   909	
   910		/*
   911		 * FIXME: It's generally a bad idea to use devres in subsystem core
   912		 * code - managed interfaces are aimed at drivers - but pinctrl already
   913		 * uses it all over the place so it's a larger piece of technical debt
   914		 * to fix.
   915		 */
   916		error = devm_add_action_or_reset(pctldev->dev,
 > 917						 (void (*)(void *))kfree_const,
   918						 (void *)function->func);
   919		if (error)
   920			return error;
   921	
   922		function->data = data;
   923	
   924		error = radix_tree_insert(&pctldev->pin_function_tree, selector, function);
   925		if (error)
   926			return error;
   927	
   928		pctldev->num_functions++;
   929	
   930		return selector;
   931	}
   932	EXPORT_SYMBOL_GPL(pinmux_generic_add_pinfunction);
   933	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki