linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jinjiang Tu <tujinjiang@huawei.com>
To: <tujinjiang@huawei.com>
Cc: <akpm@linux-foundation.org>, <andrii@kernel.org>,
	<avagin@gmail.com>, <baolin.wang@linux.alibaba.com>,
	<brahmajit.xyz@gmail.com>, <catalin.marinas@arm.com>,
	<christophe.leroy@csgroup.eu>, <david@redhat.com>,
	<dev.jain@arm.com>, <hughd@google.com>, <joern@logfs.org>,
	<linux-mm@kvack.org>, <lorenzo.stoakes@oracle.com>,
	<mhocko@suse.com>, <rientjes@google.com>, <ryan.roberts@arm.com>,
	<superman.xpt@gmail.com>, <thiago.bauermann@linaro.org>,
	<wangkefeng.wang@huawei.com>
Subject: [PATCH] mm/memory-failure: hold PTL in hwpoison_hugetlb_range
Date: Fri, 25 Jul 2025 11:31:12 +0800	[thread overview]
Message-ID: <20250725033112.2690158-1-tujinjiang@huawei.com> (raw)
In-Reply-To: <20250724090958.455887-1-tujinjiang@huawei.com>

Hold PTL in hwpoison_hugetlb_range() to avoid operating on stale page, as
hwpoison_pte_range() have done.

Signed-off-by: Jinjiang Tu <tujinjiang@huawei.com>
---
 mm/memory-failure.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index b91a33fb6c69..0ad3d55d1d09 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -837,11 +837,17 @@ static int hwpoison_hugetlb_range(pte_t *ptep, unsigned long hmask,
 			    struct mm_walk *walk)
 {
 	struct hwpoison_walk *hwp = walk->private;
-	pte_t pte = huge_ptep_get(walk->mm, addr, ptep);
 	struct hstate *h = hstate_vma(walk->vma);
+	spinlock_t *ptl;
+	pte_t pte;
+	int ret;
 
-	return check_hwpoisoned_entry(pte, addr, huge_page_shift(h),
-				      hwp->pfn, &hwp->tk);
+	ptl = huge_pte_lock(h, walk->mm, ptep);
+	pte = huge_ptep_get(walk->mm, addr, ptep);
+	ret = check_hwpoisoned_entry(pte, addr, huge_page_shift(h),
+					hwp->pfn, &hwp->tk);
+	spin_unlock(ptl);
+	return ret;
 }
 #else
 #define hwpoison_hugetlb_range	NULL
-- 
2.43.0



  parent reply	other threads:[~2025-07-25  3:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24  9:09 [PATCH v2 0/3] hold PTL for several .hugetlb_entry callbacks Jinjiang Tu
2025-07-24  9:09 ` [PATCH v2 1/3] mm/smaps: fix race between smaps_hugetlb_range and migration Jinjiang Tu
2025-07-24 16:27   ` David Hildenbrand
2025-07-24  9:09 ` [PATCH v2 2/3] fs/proc/task_mmu: hold PTL in pagemap_hugetlb_range and gather_hugetlb_stats Jinjiang Tu
2025-07-24 16:27   ` David Hildenbrand
2025-07-24  9:09 ` [PATCH v2 3/3] mm/mincore: hold PTL in mincore_hugetlb Jinjiang Tu
2025-07-24 16:29   ` David Hildenbrand
2025-07-24 16:26 ` [PATCH v2 0/3] hold PTL for several .hugetlb_entry callbacks David Hildenbrand
2025-07-25  2:02   ` Jinjiang Tu
2025-07-25  3:31 ` Jinjiang Tu [this message]
2025-07-25 15:48   ` [PATCH] mm/memory-failure: hold PTL in hwpoison_hugetlb_range David Hildenbrand
2025-07-25 23:29   ` Andrew Morton
2025-07-26  0:28     ` Jinjiang Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250725033112.2690158-1-tujinjiang@huawei.com \
    --to=tujinjiang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrii@kernel.org \
    --cc=avagin@gmail.com \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=brahmajit.xyz@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=david@redhat.com \
    --cc=dev.jain@arm.com \
    --cc=hughd@google.com \
    --cc=joern@logfs.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mhocko@suse.com \
    --cc=rientjes@google.com \
    --cc=ryan.roberts@arm.com \
    --cc=superman.xpt@gmail.com \
    --cc=thiago.bauermann@linaro.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox