From: Huan Yang <link@vivo.com>
To: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Rik van Riel <riel@surriel.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Harry Yoo <harry.yoo@oracle.com>, Xu Xin <xu.xin16@zte.com.cn>,
Chengming Zhou <chengming.zhou@linux.dev>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Zi Yan <ziy@nvidia.com>,
Matthew Brost <matthew.brost@intel.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>, Byungchul Park <byungchul@sk.com>,
Gregory Price <gourry@gourry.net>,
Ying Huang <ying.huang@linux.alibaba.com>,
Alistair Popple <apopple@nvidia.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Huan Yang <link@vivo.com>, Christian Brauner <brauner@kernel.org>,
Usama Arif <usamaarif642@gmail.com>, Yu Zhao <yuzhao@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: [RFC PATCH 1/9] mm: introduce PAGE_TYPE_SHIFT
Date: Thu, 24 Jul 2025 16:44:29 +0800 [thread overview]
Message-ID: <20250724084441.380404-2-link@vivo.com> (raw)
In-Reply-To: <20250724084441.380404-1-link@vivo.com>
The current shift value for page_type is 24. To avoid hardcode, define
a macro called PAGE_TYPE_SHIFT and PAGE_TYPE_MASK.
No functional change.
Signed-off-by: Huan Yang <link@vivo.com>
---
include/linux/page-flags.h | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h
index 4fe5ee67535b..3c7103c2eee4 100644
--- a/include/linux/page-flags.h
+++ b/include/linux/page-flags.h
@@ -961,9 +961,12 @@ enum pagetype {
PGTY_mapcount_underflow = 0xff
};
+#define PAGE_TYPE_SHIFT 24
+#define PAGE_TYPE_MASK ((1 << PAGE_TYPE_SHIFT) - 1)
+
static inline bool page_type_has_type(int page_type)
{
- return page_type < (PGTY_mapcount_underflow << 24);
+ return page_type < (PGTY_mapcount_underflow << PAGE_TYPE_SHIFT);
}
/* This takes a mapcount which is one more than page->_mapcount */
@@ -980,7 +983,8 @@ static inline bool page_has_type(const struct page *page)
#define FOLIO_TYPE_OPS(lname, fname) \
static __always_inline bool folio_test_##fname(const struct folio *folio) \
{ \
- return data_race(folio->page.page_type >> 24) == PGTY_##lname; \
+ return data_race(folio->page.page_type >> PAGE_TYPE_SHIFT) \
+ == PGTY_##lname; \
} \
static __always_inline void __folio_set_##fname(struct folio *folio) \
{ \
@@ -988,7 +992,8 @@ static __always_inline void __folio_set_##fname(struct folio *folio) \
return; \
VM_BUG_ON_FOLIO(data_race(folio->page.page_type) != UINT_MAX, \
folio); \
- folio->page.page_type = (unsigned int)PGTY_##lname << 24; \
+ folio->page.page_type = (unsigned int)PGTY_##lname \
+ << PAGE_TYPE_SHIFT; \
} \
static __always_inline void __folio_clear_##fname(struct folio *folio) \
{ \
@@ -1002,14 +1007,16 @@ static __always_inline void __folio_clear_##fname(struct folio *folio) \
FOLIO_TYPE_OPS(lname, fname) \
static __always_inline int Page##uname(const struct page *page) \
{ \
- return data_race(page->page_type >> 24) == PGTY_##lname; \
+ return data_race(page->page_type >> PAGE_TYPE_SHIFT) \
+ == PGTY_##lname; \
} \
static __always_inline void __SetPage##uname(struct page *page) \
{ \
if (Page##uname(page)) \
return; \
VM_BUG_ON_PAGE(data_race(page->page_type) != UINT_MAX, page); \
- page->page_type = (unsigned int)PGTY_##lname << 24; \
+ page->page_type = (unsigned int)PGTY_##lname \
+ << PAGE_TYPE_SHIFT; \
} \
static __always_inline void __ClearPage##uname(struct page *page) \
{ \
--
2.34.1
next prev parent reply other threads:[~2025-07-24 8:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 8:44 [RFC PATCH 0/9] introduce PGTY_mgt_entry page_type Huan Yang
2025-07-24 8:44 ` Huan Yang [this message]
2025-07-24 8:44 ` [RFC PATCH 2/9] mm: add page_type value helper Huan Yang
2025-07-24 8:44 ` [RFC PATCH 3/9] mm/rmap: simplify rmap_walk invoke Huan Yang
2025-07-24 8:44 ` [RFC PATCH 4/9] mm/rmap: add args in rmap_walk_control done hook Huan Yang
2025-07-24 8:44 ` [RFC PATCH 5/9] mm/rmap: introduce exit hook Huan Yang
2025-07-24 8:44 ` [RFC PATCH 6/9] mm/rmap: introduce migrate_walk_arg Huan Yang
2025-07-24 8:44 ` [RFC PATCH 7/9] mm/migrate: rename rmap_walk_arg folio Huan Yang
2025-07-24 8:44 ` [RFC PATCH 8/9] mm/migrate: infrastructure for migrate entry page_type Huan Yang
2025-07-24 8:44 ` [RFC PATCH 9/9] mm/migrate: apply " Huan Yang
2025-07-24 8:59 ` [RFC PATCH 0/9] introduce PGTY_mgt_entry page_type David Hildenbrand
2025-07-24 9:09 ` Huan Yang
2025-07-24 9:12 ` David Hildenbrand
2025-07-24 9:20 ` David Hildenbrand
2025-07-24 9:32 ` David Hildenbrand
2025-07-24 9:36 ` Huan Yang
2025-07-24 9:45 ` Lorenzo Stoakes
2025-07-24 9:56 ` Huan Yang
2025-07-24 9:58 ` Lorenzo Stoakes
2025-07-24 10:01 ` Huan Yang
2025-07-24 9:15 ` Lorenzo Stoakes
2025-07-24 9:29 ` Huan Yang
2025-07-25 1:37 ` Huang, Ying
2025-07-25 1:47 ` Huan Yang
2025-07-25 9:26 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724084441.380404-2-link@vivo.com \
--to=link@vivo.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=byungchul@sk.com \
--cc=chengming.zhou@linux.dev \
--cc=david@redhat.com \
--cc=gourry@gourry.net \
--cc=harry.yoo@oracle.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=matthew.brost@intel.com \
--cc=mhocko@suse.com \
--cc=rakie.kim@sk.com \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=usamaarif642@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=xu.xin16@zte.com.cn \
--cc=ying.huang@linux.alibaba.com \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox