From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8A8FC83F1A for ; Mon, 21 Jul 2025 11:50:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7BA848E0002; Mon, 21 Jul 2025 07:50:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7923B8E0001; Mon, 21 Jul 2025 07:50:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CF0E8E0002; Mon, 21 Jul 2025 07:50:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5D3548E0001 for ; Mon, 21 Jul 2025 07:50:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 21BFB5A844 for ; Mon, 21 Jul 2025 11:50:08 +0000 (UTC) X-FDA: 83688103296.17.ACC77A1 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf08.hostedemail.com (Postfix) with ESMTP id 3F7F4160010 for ; Mon, 21 Jul 2025 11:50:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mtYaiOEt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753098606; a=rsa-sha256; cv=none; b=f2AM3xH9DrTz0C/NdaseU6CiOPvdaEvltHQPFJvH9dG0KGNieQ4emzjiGadWCCBsftRkMg geawQhajw4k9QdvOlnRRr3QUIkg5dg96duhlo7318EkATfORPjINm/s/c68VqqHeDSYeja jP9avY6yUuMfJllb6vTY/aGL6JiD3rk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mtYaiOEt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753098606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dZt6Ai9hbl1LalOlbqZoo6RUDZ53C0t7j4pmRLMyXOU=; b=qnD/P9YcWruQD+LTvgbAnCo0VvqN8wQ4zSWIDwFkc58cCbdNVFqS/plsMhY1oURv8KkWQd k5fclHp/oSj1G+JweR5iRFc2nRZh0JkAhhMU/VT5wnFpkBuwYYT7fjEpOjHct1015/xVjq JWCSWohEHRrpZ5A4gNHZDnP/94RuMic= Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-b321bd36a41so3314609a12.2 for ; Mon, 21 Jul 2025 04:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753098605; x=1753703405; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dZt6Ai9hbl1LalOlbqZoo6RUDZ53C0t7j4pmRLMyXOU=; b=mtYaiOEt7vFyYbZ2iEBUozOFmAoJxbm6fRaO7sqUNoxBShWiZ4AquB8i6nPCTY85I1 xV971lv12J2Qk2xDzG55Co8TKez+cBnGlihjN+khhqaLEwsxdcKmUtMGkC2bOBxPUTjN Zrsj12rO2I2yDg0OWwdE3XCWDXNqhbITcVEvqrr2x2KDdJFt/tpZMWeRKEBb72mUz4vA A/ROhU9NZAoncw97UgrloE1qQKaswK6h3n+zEbRdugc0F4JsKaGVDWnD8jR+JtPFhwZW gkBoNwHTZhQDyfN2bRDEDzNaEe1UTBwIlgh7t1rn8mMDO+9fZFnmx+hUk/9sUV4HR2lU kG+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753098605; x=1753703405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dZt6Ai9hbl1LalOlbqZoo6RUDZ53C0t7j4pmRLMyXOU=; b=oPx45j2fuKQcO5ZrzZSntXIFju8zpG+lq+xE8Vm+VVDPHZ8cw4/uekDkxlnCh39rzQ zv81bE1icSc3HE3WqnaH0o+qwvbL4xvIWtiC/GgcstaL4xpMgob4ZCH6ennXLjTEvcns TFh4m6qrsACIQC6TrN4K2uF9WFcFootkLvB0KdvhoboRj9PPycj8whMAP9S12pvODeO7 t8mbL/qCZaTmiil4JTg/frpADvcFo5oxRPFg/H37CD4E5Zu2YWkQL4d3BJUnFIevcDqj motUtwVLnZGlH8ktQFZN6nd6Ko93c46jVC2pxL6Dw74fDMYZti/jJTsNjgQEXgxPJCEK 9kKg== X-Forwarded-Encrypted: i=1; AJvYcCWbssBPTqZ+snxF4YzuPl7uveWVz+fFj2cUZo40Ekil1k3IVJ2CXdjfSpVdbu+tx7TTpG1QpQTk9w==@kvack.org X-Gm-Message-State: AOJu0YyZ/Aq7s54fqM2gtDg9QLmGBfEAjCxhq1WRuq3q90vpKwDocEHH 5tJpfqhheBH9i4nZk72f0ECcc9/2F9jeFaZ9BGU3s6T1Vgr1JXf1OAn1 X-Gm-Gg: ASbGncseHEelp98xJFCHdD5mVhTrMgfl8PPwoYewD0CfM7YuihT8CTTaPQroVAYn8Tk hs6WlrFXb2Kl6awou4+hjA/hT9F6Skcg2lqaZBlWZIKeMpQQpsYy6D5Ghuina5u+R5Odbfz1pEF iW7G4C9IFLtx/e1ZggG6xpxyX41dPnJNdOwtybisldTQUo0wuSKdMbCKBQ0FvuffpGmZsb2Oh3z r9+ZPSbhryiDkuw4FXNbcCEZqsxs5Yqqz6W0znRLD0xyiCdXc6CtL484kH11giHn6uHe3DA98Yt v7qrVuZPP60G5aKUUpIwbWFWddBWQGp2s7ttxcwsF89i+TfX/1znj51EnsItok5Ug+tdRNY255s XH4cP8gIJb1iVp4JySWL1SlFlHvy1JsXipN5hYqtrJ1i1AHaq X-Google-Smtp-Source: AGHT+IFE7JIwPmyMIlr6q+RLOHnV3iGmcVeYhfH5eAK9q7J9P+g3vPHm0C/5R0C/KXXmvmvV/UTK6A== X-Received: by 2002:a05:6a21:62c1:b0:216:1476:f5c with SMTP id adf61e73a8af0-23812b50d6cmr33562059637.25.1753098603508; Mon, 21 Jul 2025 04:50:03 -0700 (PDT) Received: from DESKTOP-GIED850.localdomain ([114.247.113.178]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-759cbe61e38sm5559229b3a.161.2025.07.21.04.49.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jul 2025 04:50:03 -0700 (PDT) From: wang lian To: david@redhat.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, broonie@kernel.org, gkwang@linx-info.com, jannh@google.com, lianux.mm@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, ludovico.zy.wu@gmail.com, p1ucky0923@gmail.com, richard.weiyang@gmail.com, ryncsn@gmail.com, shuah@kernel.org, sj@kernel.org, vbabka@suse.cz, zijing.zhang@proton.me, ziy@nvidia.com Subject: Re: [PATCH 1/2] selftests/mm: reuse FORCE_READ to replace "asm volatile("" : "+r" (XXX));" Date: Mon, 21 Jul 2025 19:49:50 +0800 Message-ID: <20250721114950.42139-1-lianux.mm@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <42db9f05-11cc-453b-8259-39cee70f137d@redhat.com> References: <42db9f05-11cc-453b-8259-39cee70f137d@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3F7F4160010 X-Stat-Signature: 4ebmh89gnqrq3hd3367cmfhiokqj6qcf X-Rspam-User: X-HE-Tag: 1753098606-915068 X-HE-Meta: U2FsdGVkX18c+2FecLG7GUQ+BSvThDeIRxh6kRcTs2eNfQvGi5z5Nkwe8rLB3s77udipPq8KlYsUrsRR6E9JjpUCXnPK1VDmcHKfFeuecrGMfy4xN0dKRnaGn1sCzhZhKFLnrJZXUayzLqKDVuuTOpKM2Uz6aeyTqurGmiBdy0/2oCgYFD5vGnUJEwzno1Ifg362S8owDOJyoq3Q4mGItzi4x3cM7UDtTBtz++6fyri85Vn0cZbpgG/OMl+42hySb859/Pz0wFuPLjQJqiVKqN1UUYa3sVgcleA6y2BmEHTv6eJIV7Abx28kVXLATEK54LT1ROWGnT41tb3fUn6sWulXKE7jZi0rTJ4axcbjOMWfJMFTds000mPVlPfvAdt5ZleQjYzQ4gR0Wckv0vj8fet2gtDxSkEtUpsjWyVcFs1qQISLjd5qp+67UyKKB1ewE9ONqWKe/nrN1L8xTIeMeBuKdpnoX605B/5dvazZUCH+oC5EqWOKMusioqcQMpAYAVldntP3f5Vm+tuxN2iYV5I5p87832x0jceI8PclhETbf67M8KAp6UIOkEhUx5+WtFfiVFZbsxeEty+8QUVqMKymYytE0yKQVbTFOm6QXDyndjo80WB9MfBj02ht2v4SJ3VZY0DPK/0+gBhy+1Icprc4vZ94Kvzvf7/J7tKWFhq8na6ytvDJZUsJ1keOlhr6OU6c4qycveLYYzKJyTaM7VNcLUglm6K7ObF9P7wGgDzNOkeqe/Zz2jcYmK5P2J58pZaeQHKbxPtn86JTMfBLCcF4DF5BvobKLfQYEfywy3tsZGxdd3EZH2JVGKNsOI0Jd+008UEQiwEfNL4Y4EYV8kIc1OWRk8jvq/V4uSlXMb5ur5450MZycVTVi3CL8usTS61lWGBSQnOw6lICJFpj2m1HU17ZbN2ZkG9BYrpSlpPxTTEFPe3r86kApYYZY7dddJ1dIDErc70N9iRGCNR M/p+Y+wX S4ehdtT89m1dJCg5U9O4XzNCdC+1urxbzF1aaHkExz2wexs4E5jpVoCxW0G9tKzV7XUHHFgu2hTcCT1tve6NC/ziei174QDLg+xhlJvjijHSXb96+rjZqY6IHo1yMu+PdblDmy71DpEwieNwehvjWF1GLJGdlzg0a/SVgucjF8UCypR41KxZ3v4XE1WfvjiScxBK627MYyupC/C0LiVSRBOcqT5cpBS9xJY209Ie5c9696tsaHFkM1brpLfLHAz16FC+n6inoshjDEHF3Jf2uM659Qlll9wQfuj9EbJZBES1sy0P/WOBhJkUcnhBIZqPXW8lHqpjSNp1Rq287564q3xiidq5IzB0vhxb9I9YTSuaFoiF5PsV2xnJIVGj3IEAW6pI+Xe7tbfUWaxR7527au/FfyDo7M9sCjOt0OaE9N6LmhqAGcmeBCgk7y1//3NDCsv7DoP25PFV4ZvBhXzFRZRytRBRBikqL2EJlDxFlZecobBH1yIs7DFm8UgMgQqOdqXlJiDIrsw7yVxpTmGm+wyYSV194DIO52T/u0crAE3aWMg8ycX/1kOPT0NNTt0YsvQqknhskfyA3Q/fT92ev6zLIEOsQtAXr8oL7N9HxN4czl9F7ojLi17htrrzh01IFXn0zKI/V3FdyzfdrX9l/XKlhlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On 17.07.25 15:18, wang lian wrote: > > Several mm selftests use the `asm volatile("" : "+r" (variable));` > > construct to force a read of a variable, preventing the compiler from > > optimizing away the memory access. This idiom is cryptic and duplicated > > across multiple test files. > > > > Following a suggestion from David[1], this patch refactors this > > common pattern into a FORCE_READ() macro > > > > [1] https://lore.kernel.org/lkml/4a3e0759-caa1-4cfa-bc3f-402593f1eee3@redhat.com/ > > > > Signed-off-by: wang lian > > Reviewed-by: Lorenzo Stoakes > > --- Hi David, Thank you for the review and the Acked-by tag. I appreciate it. > Acked-by: David Hildenbrand > -- > Cheers, > David / dhildenb Best regards, Wang Lian