From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBA3C87FC5 for ; Mon, 21 Jul 2025 06:42:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6691F6B008A; Mon, 21 Jul 2025 02:42:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 640396B008C; Mon, 21 Jul 2025 02:42:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 556026B0093; Mon, 21 Jul 2025 02:42:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3E7986B008A for ; Mon, 21 Jul 2025 02:42:48 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 97087160663 for ; Mon, 21 Jul 2025 06:42:47 +0000 (UTC) X-FDA: 83687328774.20.C0485DE Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf20.hostedemail.com (Postfix) with ESMTP id BBF881C0005 for ; Mon, 21 Jul 2025 06:42:45 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=bDfUUXio; dkim=pass header.d=linutronix.de header.s=2020e header.b=GqCH6LtS; spf=pass (imf20.hostedemail.com: domain of t-8ch@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=t-8ch@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753080166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tyczl2pXIS5un450KeY12IY1AEuLzrL/JOTCmCTx0/Y=; b=soOrDC7Fs+827FIadIEG1DJBW3lqnoP/Eiq6zjYEKy8av25oINOja4td+ketazzPSFx//z BRkBc2zLiWeeF3uZaXZFnmRbXXIuqb4gT/+QDh+S4vKFZu/RWQaO2AH1hN4nfuhEQ8LRR4 m0HG3X6NeGe3JxHC0MRl+mX8+0kfMVg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=bDfUUXio; dkim=pass header.d=linutronix.de header.s=2020e header.b=GqCH6LtS; spf=pass (imf20.hostedemail.com: domain of t-8ch@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=t-8ch@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753080166; a=rsa-sha256; cv=none; b=CUsJfBcErVQxA572+RFLmelGx/L0fmXk2ePy2KIwSGryRtO3LzrU9B9QLVZoba1hLBhbuh EG7KW1Ox9iAvZ7LndCKDxwaaQLY8Pt/N4gGHGR40Wnkxeq8AynLCpcC2Pbj/nixGRkm8kP fzE+PL1YAgOI8UfAq7HkjxREwN/HsSM= Date: Mon, 21 Jul 2025 08:42:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1753080163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tyczl2pXIS5un450KeY12IY1AEuLzrL/JOTCmCTx0/Y=; b=bDfUUXioek9CJPvHOobeJUFRkzBLUB4SxeE7NHC9ODhWlWmij0QEEU8AaC+a4Y8vHB+v/r vjqq+jqE5ZJPQU9dvC9XKUfiDg9mOwznhjswrKSpysrWTHy5bRLE8uikKkLAD5Zj0iFTjz YXKOIGPO6+m9pAIAi/Nk6QdDKFHyxPdQvI8ZCZgn0G+D8O2rGhRAhX4avhjPm65L3mMfhM eLvE5drLzj0rJJtQaAS8tyxQnx5wSj6EFvrjmz8b2CZyh0b1b4xFdszwhisYWCEd4xlKfm pCtRWmAXiLHgtnDgqW1LBlID3Jn6KiabOxhgfhscrpLFti4df0DlUCjKu7wZSQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1753080163; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tyczl2pXIS5un450KeY12IY1AEuLzrL/JOTCmCTx0/Y=; b=GqCH6LtSDPllEmiW8hSXADeWdGxHElcJ8pEB2JVXeLV0OpRpMGQktzjDkwXz4EWuGmvo5Z z33lXSs4UrMWhWAA== From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Al Viro Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , Willy Tarreau , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Brendan Higgins , David Gow , Rae Moar , Shuah Khan , Jonathan Corbet , Nicolas Schier , Kees Cook , Christian Brauner , Jan Kara , Christoph Hellwig , Luis Chamberlain , Christophe Leroy , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, workflows@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support Message-ID: <20250721075849-b3cf33b6-2516-4707-bab6-53fe95afbffa@linutronix.de> References: <20250717-kunit-kselftests-v5-0-442b711cde2e@linutronix.de> <20250717-kunit-kselftests-v5-6-442b711cde2e@linutronix.de> <20250718164412.GD2580412@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250718164412.GD2580412@ZenIV> X-Rspam-User: X-Rspamd-Queue-Id: BBF881C0005 X-Rspamd-Server: rspam06 X-Stat-Signature: wuz1zn7teu9ehdg1h1ihaau646gnfx75 X-HE-Tag: 1753080165-680489 X-HE-Meta: U2FsdGVkX180cA8gB9MVgooXsyUKWEzjsKIUJcdQq40Jgio8A4S7JVLv8raSvaYoRd8TQHa16g2gwajo7x0NNFzVabad02jWlGK+rACVE758AhnjLA+bD4JLEMx8QwOummfNGVs+1XHVQ0aze5Gv422X6ni/egZY3Oh/lREec4IU8ZqJXe5mf3qQBAv71nKh1bmuj7v+rYsmMhhvYSEiKzdp4MzlWWhIe8jc8c1ZKsMxpbGE81zzlht9Xsn3v8MBsVL93XxaG5rbvTE+1IquQ9UfERKIidpP446ZUXqKooWucV3LMy+B1g8qA43tOivmh9Gya6S7auTFLCRcbpiwLhu04BSPU27pnpW4NQFMTM7GiaZf322y6XyUzc0N/9zUj1mcU1Eqs3bKi3Mr9PPEYvJvqCiKL2bK52iCpvSpY034JUf4qy0WS/t/owG3iF6xbu74YrMJl6qvQirbCq8Lwm7YKocvjZVu/GQU24mXhfJyRMEq3+1ut+sG+tNJEEU+EA0qe4CUH5fWyX2MRzXg0E142vV5wPdT345HV9U9GHrWoDoCKEJYGGc+LtqxtfHmFbygqRrYgxucVCT5frPNXtBp+9MAZtBJaUaVv5TQnjXPGnDGNeBHYUVeNLSCiZcOGWTWjzK/39wE/GFg3mDkHYBrRO61f5AVcjBKrESfGWnoB8/ecEF4o8x3A/iIznuhVxb1ms5Tcy/Rm6Mfq3o8RaH6b0txouWXJBR69HjlPPKv5gIlxF0Dj156vH9r5VosyY+y5q8KCIVurkjQsDrX4vYhPo3jEU8tsOPd8oSRQIPrajcSS/Naqaqh1XQv/bCyb4YGTrl88T9gTJ+PcE7Hqtpr1StoToUFnWnvR43a21Tr9k5EpexAtVPxvsb7vtyq7fszj2Zm8pNjPGtVyUIPhSEzfBwTk3ugCHJN7wu7nJnR7WTnLL5eJsRL8a/xbJnkiuVDk+1MdZDlGEKgAmb 6/7JuA7B 49BnvsXYtAvySTbG+ov7gNlJ3eV2iErMVPXCK9dQDodNPbVuntpfaFMiJFwmxBS0MHgv56fFrsKG7s/+Q5jYnUR+sbM9P2+Z+CQ8KwFPxOCMOdJUZRSYjRoIYT6wOlg4OOyww9TJP82awhBklzp8b6qsfurSoncePr8UgSdpfZYLtvEKtwzJLONf8gYwELHj9OqhJtQ1PpV0U9UdwCAVEX+guJdgHi4whLEO7q9RaHxaoeOtASm+oYV3B61IusYbrhRAyazBriShKm9rASOIMSUXDuj3fioAmuptWxX0JKNsi3WR8ohyHMCEHacxegb/3aMmL0J1KzkrEQ1yS+VXtKa+KaC21Hd4QEp58PDEwyEysRSlVCNNjHIHlTWx5NSe/I+HS4AXF14Mbw2a/4CamDEIrhpva/eNjlB1zTe7rVpXjG77BIv07p6T/zw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 18, 2025 at 05:44:12PM +0100, Al Viro wrote: > On Thu, Jul 17, 2025 at 10:48:08AM +0200, Thomas Weißschuh wrote: > > The KUnit UAPI infrastructure starts userspace processes. > > As it should be able to be built as a module, export the necessary symbols. > > > > Signed-off-by: Thomas Weißschuh > > No. This is just plain wrong. This is way too low-level; teach kernel/umh.c > to provide what you need, but do *not* add more kernel_execve() callers. Sounds good. > And the situation with ramfs needs cleaning up, but "export put_filesystem()" > is not a solution. Cleaning up would mean to stop calling put_filesystem(), as it is a no-op here anyways, right? This would still leave the exports for replace_fd(), create_pipe_files() and set_fs_pwd(). Instead of using kernel/umh.c, I can also extend kernel/usermode_driver.c to provide these in a way that works for me. But kernel/usermode_driver.c is dead code, unused since commit 98e20e5e13d2 ("bpfilter: remove bpfilter") Would it be fine to export those symbols? And delete usermode_driver.c, as carrying around an unused generic framework seems pointless. Thomas