From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92257C87FC5 for ; Mon, 21 Jul 2025 07:20:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A4486B008A; Mon, 21 Jul 2025 03:20:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12E8A6B008C; Mon, 21 Jul 2025 03:20:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01CFE6B0093; Mon, 21 Jul 2025 03:20:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E18256B008A for ; Mon, 21 Jul 2025 03:20:44 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 91DBF130CAB for ; Mon, 21 Jul 2025 07:20:44 +0000 (UTC) X-FDA: 83687424408.11.67ECF3D Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP id CA4D4C0006 for ; Mon, 21 Jul 2025 07:20:42 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=pass (policy=none) header.from=lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753082443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eMQWl40cu8KRmfNJ9WRPbsDp8xY1+3mQFZuMiL8tOxw=; b=furUyuSUojXNQj276xG7ETp3gSByH3h1UQFasMbaC5AQZxMHhqQuRY7WYQRmJw5mYzgJ/7 VsdMuN5Y6w/GWozerLS5LhEHPVsmT/k0A1sxzYL5ac4dT+AqUuSk3M3yBqfuFyTsxpTQUo 7mUOKs9PmL6P8jctlBW98HIsM6n/oH8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=pass (policy=none) header.from=lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753082443; a=rsa-sha256; cv=none; b=TFy1R1CV00h7N5ZSAEWQFSFhKhZoUPI+5nHh5VFQpTHGs+z1n06Q7P7KJRPI8HgnpOVdlE Zd7JDNPcdNzaIOdnjDMeASTDNOhOnUOkyPv35ROsm/VOSrZvltgKt4PfcrvgyNtPsfHt9n oH12iHc4xjAq2EnE+5xAZ85Q2Ox/VcU= Received: by verein.lst.de (Postfix, from userid 2407) id 9683668B05; Mon, 21 Jul 2025 09:20:33 +0200 (CEST) Date: Mon, 21 Jul 2025 09:20:33 +0200 From: Christoph Hellwig To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Al Viro , Masahiro Yamada , Nathan Chancellor , Andrew Morton , Willy Tarreau , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Brendan Higgins , David Gow , Rae Moar , Shuah Khan , Jonathan Corbet , Nicolas Schier , Kees Cook , Christian Brauner , Jan Kara , Christoph Hellwig , Luis Chamberlain , Christophe Leroy , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, workflows@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support Message-ID: <20250721072033.GA30175@lst.de> References: <20250717-kunit-kselftests-v5-0-442b711cde2e@linutronix.de> <20250717-kunit-kselftests-v5-6-442b711cde2e@linutronix.de> <20250718164412.GD2580412@ZenIV> <20250721075849-b3cf33b6-2516-4707-bab6-53fe95afbffa@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250721075849-b3cf33b6-2516-4707-bab6-53fe95afbffa@linutronix.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: CA4D4C0006 X-Rspamd-Server: rspam06 X-Stat-Signature: yi1eobra7goiq1kndx41qi75g981z91e X-HE-Tag: 1753082442-162249 X-HE-Meta: U2FsdGVkX1+XcfZKcXpvCJaN7mnU6EhvoUtTGeYH2bldESMnbHMvn0ck3MJYniBrE0fN1jHc31agSUmeNbX9+LI7bTUoOX6H0yD61S+W1va8I4hzHtCDAwB7jnoNZIh10HYBdgEmxoA8An1l957bssDt6i3toI6OUhJU/fN5DLM3rOL5xzIMTZFOCJwhgq6yV0YiKfYQ6rMWKslgWW2PicQQ8j1311/82HuyngvlViybeYK/JInUjW82MYb1BrFCimxRN1XWAjpj9wc4awT/1Uq+vD2gWcme6TuOSVeO2RAd6t8jKbZZBpXAYGbFXsF5bHCuaSHixB5rSGhvnFsz3+DxFQqrdNoFTs68xjtpEooeqXRrgMexd8F/XTi6jVdhA2PsefcelwGPTMNU3RTAHN8D+I+ZrPIg/KiSAgVjMSqnXGnix+qQuOfLXgoDns+g7sPNfUnubUHIpnc91yGm4gNqzqo4JLm9TWgjnH85VX7JaJ4M0s/Pqba/ALtKvCTk5MG1tgKNpdJQ3OUWA5wLfhotsiID8YuzxWGotlXlDd+sne+d12MLQ/ZBtcbbzsZWoYv0j+s2JM0XTEJPwyzaEiGurlPIXe0rCpnmB3h4+LTzywtzce6I8kMDrbfFUvvaFigRT7Cx6rqpr7dGJLvJciEWmwAtmsLPrFOWmNbl2MI4+H63vSvSmuISCfEG3M4TyBAuHnNOO9bAlg5mpOxY8DPk1tedOtu2nAdXKi3LXVh01GHMJa92lqCPkL6mz/J/mAoGNFeA5eTF7Hs7zVNqqm3jzaDV2eHFHqdU2citH88/DL7sxebKkLLLrU5bflScpCIngRbpNEsgZ6zdsROlMbhuK7uLkmbq/+BOGNh/rHZM1BQEVLt8HgLNo35Qw3ldSYwd5NxAiTob3grY+qFe7LttaXe4JOXUjPJZdcOLlH1O0dKwN3UJn55XEdwG4S+TjyUbJbkVZBFxDCqa3x4 q6Qj3KCo h7xsaO+p5Oqn8l3YSrgKFDhfQmF+PbjjIIdLT8gOkYjP1pWFNVSKNmIv3H7EvbYSzl0YSKLGrUtzqVmBqbkeJy480aAmFAUiuf1K5UOD9a79viW2ZAy04VmN0D/ko+H6BlqlgrFYkx+ycySJC7lKaCxjMRA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 21, 2025 at 08:42:40AM +0200, Thomas Weißschuh wrote: > This would still leave the exports for replace_fd(), create_pipe_files() > and set_fs_pwd(). Instead of using kernel/umh.c, Please look into a way to just run your userspace tests from userspace. It's not that hard, people have done this novel concept for at least a few decades if you look into it. > I can also extend > kernel/usermode_driver.c to provide these in a way that works for me. > But kernel/usermode_driver.c is dead code, unused since commit > 98e20e5e13d2 ("bpfilter: remove bpfilter") > Would it be fine to export those symbols? And delete usermode_driver.c, > as carrying around an unused generic framework seems pointless. Unused code should always go away. Weirdly enough USERMODE_DRIVER is selected by BPF_PRELOAD despite that not really using any code from it, though.