From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D170FC83F1A for ; Sun, 20 Jul 2025 11:10:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59C656B009E; Sun, 20 Jul 2025 07:10:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 573E76B009F; Sun, 20 Jul 2025 07:10:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 489D96B00A0; Sun, 20 Jul 2025 07:10:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 34C5E6B009E for ; Sun, 20 Jul 2025 07:10:57 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A58C359392 for ; Sun, 20 Jul 2025 11:10:56 +0000 (UTC) X-FDA: 83684375712.23.4540D2F Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf11.hostedemail.com (Postfix) with ESMTP id E32ED40006 for ; Sun, 20 Jul 2025 11:10:54 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=ZJxe0xae; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf11.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753009855; a=rsa-sha256; cv=none; b=uEJfBkqD62xtpfKRFySpqEuziFGKfoUoyNra9rjGEeQvlRsZ886JZOfos5oZsveK1cbUfs gAZkqez64n/SVDlJUwMz+p+sAfYSdLhJv0+XzzY7HdpFPBEqN1dHCgIYkt0eiCfQ2z6LNu lGgqW6gPxcM+pgjs5WJFlg2iGkORuUU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=ZJxe0xae; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf11.hostedemail.com: domain of gregkh@linuxfoundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753009855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C/y9OgZFsrxATPBnKSpZB4iBLVsC3uM/Um/aXCsCRKc=; b=zS2S6JSHUGScxkZ84sEa9wYA7aXvy18u6aZ4hlzi5mbHBYI2HggSYyEOecQZUFXtMh9TqG RcWzFPWHZaNxw2DgiuUPYMDENRATN2GHw32VbcIfum/9RnnQF87W0SHpdIY5aaDrtecPVa DTawgX1JPwChsQdYA0iH4lKKOnLZYfA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id A86DB4374B; Sun, 20 Jul 2025 11:10:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29DD1C4CEE7; Sun, 20 Jul 2025 11:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1753009853; bh=g6RN/P3+AMwSYEbq7xszkzjjlTYqV1BCTxY1zp2kC1c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZJxe0xaek+yG2RCDWC3DwPKw0qX4OEHwwj5EnajXHuO6vPin1SWH/WW2T6XH55vcm K4M6VKlDQXkahTKJ6dZDcojMXzuXPVuGFKch9Wtg1tshvv+bCZauvhcPltydPe72// Qcgh9CB0QP+o9AZdw0d8I3ay34mV0bhZ5Z0NJwVE= Date: Sun, 20 Jul 2025 13:10:48 +0200 From: Greg KH To: Huacai Chen Cc: Huacai Chen , Andrew Morton , linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH V2] init: Handle bootloader identifier in kernel parameters Message-ID: <2025072056-gambling-ranger-5b0f@gregkh> References: <20250720105509.2914898-1-chenhuacai@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250720105509.2914898-1-chenhuacai@loongson.cn> X-Rspamd-Queue-Id: E32ED40006 X-Stat-Signature: d6xr8qw9ozsy9za1krnq6wrid3uqafs7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1753009854-893560 X-HE-Meta: U2FsdGVkX18DTgxAu+CocfF2bVOn1OgrbmDpuhDY0AsL+qcaY8/GFGjJ8ZZcRDqK37P3J3L5OQ5L6W9cgduh45rBNo8etSjnLEjbTgJTtVpxGejdvbgoW8l/pnD3vCpcUNK5fJ5W+xzEMJFNo6DmNT3xdf8V+ny1wS4PSrOHe1FAvu+d/1+eUgnM/KfDViWqM2NpPZpRF6rMdxKduBiT4vdkkLUleBGA9M2XI++ElPcfJvgjhmwhPb0o2Rsg5P+q7aTYgds4I9iU2pP0Ge8/bif4b191rB1NDKmZt0BDr9xzmwDhHS71LDbx3CYgynT+2SZZ9N146nIqOyxsJkQn2oYYlEUA0pmv7JOCoglauj2Bc+vWq51AKoANn/OPwCsT+3CMwvWxICgGqtV8jqqcNg10DpfFDpYEXtZN+vCJ5xsIqd/h82xNKOR04XaBgrJgQFGTOj5EmKafDnMx+TKKdoBDnfdPOjn+1Ehzk0fuqeQCQJ3jd2O9Gso5NIcpRgaZAyrBQa4bD7DKOBFa4RuHsZLgns9TRcF09ihZFlhrEDOrso0TvjwKB6PTjLfsA7b/YHP5H0tJXIfz5ayw4YtQtkijohHH+sAaJUKAtEP8VZeJvVAXqHd2KZHUoBzADEgOO6Rp95nqkhTX6Rie/0142KQGjzAud2K/8F8NwSXDtfYxgJCHVzjfxTq3TsnI9+OHf1QaX1jqP1B4CC6h23H/DaXxrFAmmkibQ6SbMm1x27+CDeMfsAf4BXoduWG8kjT4XTBlj19OkLgLST5ILewiVw+2gnTCEsHXKdzQs+oAPiN90GShFB45OKx4rDLML3uK38cT6vRRrTLv+Yh6Ba+vf5zZI+juoSNeyCFW+N0XHLtyMnaO+5CgKpMXLSGdM55TNQsNVPNYGr8CnDTY8d/exqJiHQy3IyYZ8q796zWga30xsFsmG0P3hiQwmVzkqRzp4jDJXw2PRvhLKkzr9+j MAU2O1nK BvAMwte2Jr4pjd8aUdJIkViZCFmNIfCrYGYaK7EcGjz2DkxVvjeR7gLSRpzWjdyoLzXdDX7x6gZK22V3b8FnYmAS6zRbNZ1LFuEZ6GgjZRgGDo7k4jhS3prfJW+PIdQKreCP92aXBbL2CdYf1oFdEydHFevvL4TvOCP1O3wYccxkzf0ppDeJi5KarH0mSWMWwEKfrbtNwtGOV8j9E1rMn/NjnXIrWmwBTMz9uS/JDiIiUfLAB1VrB2MV2hppjPIkpzsVXWlepaF48mCMbvLmM9MvxCjLojWEAxvmppu8FyLjFPvTcfvtksy3toarmyCQDSW46zQxbycA0r2sZviHc2Wm9Kgbvsdsdq2VEJXU40U9HwmGlvyJIO6jDbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jul 20, 2025 at 06:55:09PM +0800, Huacai Chen wrote: > BootLoader (Grub, LILO, etc) may pass an identifier such as "BOOT_IMAGE= > /boot/vmlinuz-x.y.z" to kernel parameters. But these identifiers are not > recognized by the kernel itself so will be passed to user space. However > user space init program also doesn't recognized it. > > KEXEC may also pass an identifier such as "kexec" on some architectures. > > We cannot change BootLoader's behavior, because this behavior exists for > many years, and there are already user space programs search BOOT_IMAGE= > in /proc/cmdline to obtain the kernel image locations: > > https://github.com/linuxdeepin/deepin-ab-recovery/blob/master/util.go > (search getBootOptions) > https://github.com/linuxdeepin/deepin-ab-recovery/blob/master/main.go > (search getKernelReleaseWithBootOption) > > So the the best way is handle (ignore) it by the kernel itself, which > can avoid such boot warnings (if we use something like init=/bin/bash, > bootloader identifier can even cause a crash): > > Kernel command line: BOOT_IMAGE=(hd0,1)/vmlinuz-6.x root=/dev/sda3 ro console=tty > Unknown kernel command line parameters "BOOT_IMAGE=(hd0,1)/vmlinuz-6.x", will be passed to user space. > > Cc: stable@vger.kernel.org > Signed-off-by: Huacai Chen > --- > V2: Update comments and commit messages. > > init/main.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/init/main.c b/init/main.c > index 225a58279acd..c53863e5ad82 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -545,6 +545,7 @@ static int __init unknown_bootoption(char *param, char *val, > const char *unused, void *arg) > { > size_t len = strlen(param); > + const char *bootloader[] = { "BOOT_IMAGE=", "kexec", NULL }; Where is this magic set of values now documented? Each of these need to be strongly documented as to why we are ignoring them and who is adding them and why they can't be fixed for whatever reason. thanks, greg k-h