From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E611C83F1A for ; Sun, 20 Jul 2025 18:58:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09F176B00A0; Sun, 20 Jul 2025 14:58:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 025E86B00AD; Sun, 20 Jul 2025 14:58:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E30116B00B0; Sun, 20 Jul 2025 14:58:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D0BE76B00A0 for ; Sun, 20 Jul 2025 14:58:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 862F3111A38 for ; Sun, 20 Jul 2025 18:58:29 +0000 (UTC) X-FDA: 83685553938.10.74A0E1B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 0B5A840005 for ; Sun, 20 Jul 2025 18:58:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UWJyWLpy; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753037908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=fY3lKpL+3+5CjbAuJKbb8wTJ9tnx4SDlrod4kLenFq0=; b=o6RKh6LhflogYDDyR1GxNL2on00AjvFcrRZ9G3VN2nOpSengEssdYv3UmrnH3qunIyoy3g qHz20vSnsKI0zlWsRk+fmm7vp6KrQSY13Kqm+PSVzdHay+DEBl2KvZag5EsNpCUqKe3+A9 ZMz1vFIHxh6CBKQRp82YZaL2spCLFSM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753037908; a=rsa-sha256; cv=none; b=yXCvAn+8zr3zfQwNtL59lAIwnsLqypxpN+B1SevRpyMkTUUKyxBtQ8hiMFB7eG/6/3r4nn kjwpAp3mHYxUaqZM1VPxEuYneui7DtWgtCHdR3USkEbsL3IMKWokOB/n3DRIr++mG4UOdT aaL5h+VjkWUZpBwtzNem5wespYKaxMQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UWJyWLpy; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 74985A5275B; Sun, 20 Jul 2025 18:58:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0169AC4CEE7; Sun, 20 Jul 2025 18:58:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753037907; bh=Z4K/L8iVI8412mIfKRLloP1W+n/XlOZFFt9DKKoURFg=; h=From:To:Cc:Subject:Date:From; b=UWJyWLpyXtMe4KYH3Ztyry35J19Ro8R2rER8oyZh6JGgNMnlVXYl+OE2S7ggDWLg2 z6ZmJjf2j4FW2J2mv83Lgll2m8yB4EcoxaQLyDclqT8HZtboSXYoLbTCd6tz6w/Ioa 1qTLh0Fw9iRuYgVUlvCIEhW/U9IZy0cfWHgWCLCaXNLZa1gqS1nHd4qp0F2G9/2QJJ wm7xmqpzIkKQsxfCczGpGdcYYiMdfuRD+nt+3ND8bAbzwNjE61tj6PUkZ0U6Z1YWND 4C7UYd5U5CE5qk1Jl0N/UkOA/bQnxhs+Tf7zr+R1Kst8YTKxP9QmACHFRER4PqR5cX zy9aRfDiA+7+Q== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Honggyu Kim , Hyeongtak Ji , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: [PATCH] mm/damon/ops-common: ignore migration request to invalid nodes Date: Sun, 20 Jul 2025 11:58:22 -0700 Message-Id: <20250720185822.1451-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0B5A840005 X-Stat-Signature: 1u5cxnf7r76kzx9dk48j3zhus678kkn7 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1753037907-965086 X-HE-Meta: U2FsdGVkX19Qa+GfLW9no7uBht9IiGsLcuas/VuQ6tZlv2cyMIFd6IaVsvx09YUoq4zikV6UfRvRxJTFBD6SBvfBaPsSNySPuTc/dFCcgvBH1cWUKEIkft+Lo9NrV8FjXGIFvb/vUck0s6amQLEXsP8uwkzNEqWmDKqrNtPDDJ8z99yefD99j3nhHfrfqMoyjgX61r9I05vHoJlyMeKo46BrjXzOXyGuZSQBS3teuS28Y53L657dwij7W0PRcKxfrp5BkCTlSBknTKMZuWqhfjHGCXm4MsPG0yET3483w6RNB/LtePRo/Lir1LuQsBAU5YrU8e5P6uv7biX14HU7JDoCgZEepfWM5j4E0WDUDAykyJagDX4Yxwd1htLnLjqTDhb6MwGrNVGwsLgNdyZWxHl41+AzdXiNBLXfA7lIj57T8VvHvShXXFks2Jrxd3AFU/fOOERtoam2sHeMggbQ/bXD49HQ+z4Jt3e6FZAAshSR3e7eaMNOzMlIVSiFXpRAlfPy1X6KumryJ33SSRIBcEIVKu+rR4t0GaYBt459tamtrBdgE4oxUjPU7WcF4ZQasYHNB75KPUNMAHIeKZGfflDld8PLCQi4d0GJnhiFSz/eMa0oexLb34cJAFDdFHc3Ca0a8tshnbyfXjuz6yoduV9qNJMCEIZYliu3jvDN359SvjhCP2mpMpxi4pdEa/gCMK9NXL/rXXlrIAGGFzV+HIPpk4ries5dxA4eEnTny3sHMdTzq+zJ1RhCGj4u2fs7hIdQRn1NL5CokYsmjh1o9CtC2/e9jDK/GgCw3ixjNvDM8xZz1IYSBEynaDGOlL5uMsBMVcBvOhQ0kLC3O9QTskvDu4zpcaIuzR9KCqGHw46QlbwAElxSME8tS2/sDQ0dufKLHRg7iE4tGtr/r/KhTMs55f+0tavNYuw0Go2R0nG1sDPzhbeXIWO4/YzFSIz0R0qiLbmruf9NrZwS7rz oYK5CvtZ QbwJjXbmFRZVSDodsbRgzg+2bsTkWIUlBoKP79TCpeLMzjKy6Hvxshd9wIcrI8xDhl3Y2Z39FoeeBpk81X6P0EyJo9WiKnGe7Hgx28wc1LZJJCJPgNqhprQefO3j7eelG4uCqYvelBNqfVNZ5k19Xsw37RX/eDewgsuAnHG2PdWtaf6g/69887z5f9Ub974160dNKcgbw41Qpbnt25u3MAfB6PgHe5Tv3irscYBZS6EBok5b/+TDmNt22JlNgUSPD33jonhLWhVKaLNdxPUovo+4fFKOYgd4mGQ1OKuUXmYTcHywTY5O5nBJoK0NiW03PmKpU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_migrate_pages() try migration even if the target node is invalid. If users mistakenly make such invalid requests via DAMOS_MIGRATE_{HOT,COLD} action, below kernel BUG can happen. [ 7831.883495] BUG: unable to handle page fault for address: 0000000000001f48 [ 7831.884160] #PF: supervisor read access in kernel mode [ 7831.884681] #PF: error_code(0x0000) - not-present page [ 7831.885203] PGD 0 P4D 0 [ 7831.885468] Oops: Oops: 0000 [#1] SMP PTI [ 7831.885852] CPU: 31 UID: 0 PID: 94202 Comm: kdamond.0 Not tainted 6.16.0-rc5-mm-new-damon+ #93 PREEMPT(voluntary) [ 7831.886913] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-4.el9 04/01/2014 [ 7831.887777] RIP: 0010:__alloc_frozen_pages_noprof (include/linux/mmzone.h:1724 include/linux/mmzone.h:1750 mm/page_alloc.c:4936 mm/page_alloc.c:5137) [...] [ 7831.895953] Call Trace: [ 7831.896195] [ 7831.896397] __folio_alloc_noprof (mm/page_alloc.c:5183 mm/page_alloc.c:5192) [ 7831.896787] migrate_pages_batch (mm/migrate.c:1189 mm/migrate.c:1851) [ 7831.897228] ? __pfx_alloc_migration_target (mm/migrate.c:2137) [ 7831.897735] migrate_pages (mm/migrate.c:2078) [ 7831.898141] ? __pfx_alloc_migration_target (mm/migrate.c:2137) [ 7831.898664] damon_migrate_folio_list (mm/damon/ops-common.c:321 mm/damon/ops-common.c:354) [ 7831.899140] damon_migrate_pages (mm/damon/ops-common.c:405) [...] Add a target node validity check in damon_migrate_pages(). The validity check is stolen from that of do_pages_move(), which is being used for move_pages() system call. Fixes: b51820ebea65 ("mm/damon/paddr: introduce DAMOS_MIGRATE_COLD action for demotion") # 6.11.x Cc: stable@vger.kernel.org Cc: Honggyu Kim Signed-off-by: SeongJae Park --- mm/damon/ops-common.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c index 6a9797d1d7ff..99321ff5cb92 100644 --- a/mm/damon/ops-common.c +++ b/mm/damon/ops-common.c @@ -383,6 +383,10 @@ unsigned long damon_migrate_pages(struct list_head *folio_list, int target_nid) if (list_empty(folio_list)) return nr_migrated; + if (target_nid < 0 || target_nid >= MAX_NUMNODES || + !node_state(target_nid, N_MEMORY)) + return nr_migrated; + noreclaim_flag = memalloc_noreclaim_save(); nid = folio_nid(lru_to_folio(folio_list)); base-commit: e2c90d41402c324ea81fa3d9c2c1d0f61906c161 -- 2.39.5