From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03862C83F22 for ; Sun, 20 Jul 2025 17:17:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8E5936B00AB; Sun, 20 Jul 2025 13:17:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86F9C6B00AC; Sun, 20 Jul 2025 13:17:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E9A16B00AD; Sun, 20 Jul 2025 13:17:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 50EEA6B00AB for ; Sun, 20 Jul 2025 13:17:20 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1DB8D80569 for ; Sun, 20 Jul 2025 17:17:20 +0000 (UTC) X-FDA: 83685299040.18.F33A60E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 2CA9318000E for ; Sun, 20 Jul 2025 17:17:17 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O6FYk7+F; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753031838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i0MQo+HhSsm78d+zmHX2T13VxIypm8SJZBih894dzZQ=; b=7RvIkBukKX4KL2vtlfXAKuESbQRbMYxmhNDSJ1zIcCsV+uyEvmU5zftU2mefxR9uz19weA 5FrP710GNagvA9MSnPIO6GX3KHnsAqeYmwXvQ7uOtK370PoLiaFzAVhcspjN4Yma1cQAMT OPnZDc79wtlYcMaFXKDd1+mN/i8Lg9I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753031838; a=rsa-sha256; cv=none; b=psOk/OtPhcLUgQIwbFcoGHiWiXIlNA6XJ4f8mnuTJpNAzN/YisXQK/v38PKGl8CqV9ABai pMLrwNatFGd66xom8i8LYZOoUAEcG/7oF3NaRUw8NZ8BKz/lIJlgv6mzJjUEMVRMKfgD6U eWX7UxhgQhrcGGOiS+RGTnkw1jwVzcc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=O6FYk7+F; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 68F055C5903; Sun, 20 Jul 2025 17:17:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2FF0C4CEE7; Sun, 20 Jul 2025 17:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753031837; bh=XaEwHmsTCEj3MYPTKjfzApW/gRohngxzmhlfcQnc+6k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O6FYk7+FjY2JFzMMV/RSnEMvOGF6gOf+bdziruxGPA3qqqOs33FyJmu+nWZrQQkqj Wjs+G4n5fXv03zT9S3DSxG/bXjRV37UmpJGZS1WhLe5gFaZjK2dF27r0JcY39Fg6g+ 96Wc5nVV1mgyYieftkotK9xmG0JgtTuRDc8lHB3gZEDoQXzPm5a9baklAObWMyoDw5 gptlsEF78FxELQHH25WNL65NWs8iaI+15piasMmEvJrdxsZF2llhDoo4dPm0DYYd/D s8dae4vLtcEsyJsnhl9cwNrVcCYV7Lz1wTLZZaNYeklx70AL2oNvzKvhagYwrV8k1y fJeIFmccr3MCg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 19/22] selftests/damon/sysfs.py: generalize monitoring attributes commit assertion Date: Sun, 20 Jul 2025 10:16:49 -0700 Message-Id: <20250720171652.92309-20-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250720171652.92309-1-sj@kernel.org> References: <20250720171652.92309-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4fxbpobkifwkqg5zn7ajbnbezgjkk7kw X-Rspamd-Queue-Id: 2CA9318000E X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1753031837-525645 X-HE-Meta: U2FsdGVkX197yz7qC2vrNs8v91nULUcVB+W+xtnVF60WTQrcxDne4aaJNl7P2Mzl7+dTPdT49CvlKCkNy9ecDFgfgUswupJHYk0CtbQpdkjxY4zTnk04nCrvItaxEhrofWfc9iM/BfmMznUXwU0JEd+93HdrhhKvrWYtKCygq4wN8mTbEiEBOhv2OrJI6ncCNaWgE04LILmq7LfvS9TA2zMGzf738JfqWcVgQHwNOYNyQBvPsSBZ/+a85wECdoKaLsF05YMAZbI91DgOjmFku7Sn1dPsoxgjptzsg0Y3n6ZgnOr1STd8xqs7vZzNUCXSigFYgERc5Mi1IG3wF3yV7pMO/mHIfcI6i3eXLQP5IDK26cf6j6lSvZ9bbJzXGRPBxw2yAocaB3eGhGxdt50O+JFLJUbXfQdTcmboWvTEO84naMM9+cICLrldv8Hao6C6dp2z5dCzV4QOnX6FjwbierlSBAwU57Scgff1/YqGItQ2ajFG9OC2k8+XwKlckrm3/b27WWouWxF5wEtnOcBDd/vZ0dm8qAvYliV2469gLmv/z9P7cB7eAja4GLQknzRa0Itct0FIYg+sYITOS+jVmVMs+Acq58ha/4J8Ie6uqVIjl+ZV51Bq37dC7OVtz/EIz9eg/GqxvsKcFYjNApRQfGOwSpYRTreBiQJzDIMTwxojloT7Xj5kaHEZaMcSP8QfUb+y9ks86Gj8TdGS8JixrOmhjgYoEcUJUFYdq6+BXj66FpEgex0VpVwF8UHkCFg7N5CDrn++jAFEy66r/+OjbUFsmiGBg5owhi+vVbBqqsYV2BNDYnZzqkUIWSpgAct2j67P/7Bx1CZB/61Uvib/jGi/drSN5b6KBZElaR2hKd8+urHOdn2LWwO2nXGKRu8xApD5fNHJc9nDTATrVD6zrY1xmjDgxLplOqEf1pizh8KTHl8O0BVnyoCgWdfPlPaVuaIPwGy9jR15qJo7PIS u7AlSOfu kn3bX6t287S03pdOa9phTaIku/Wi5KfY0Lqee5adOaW6eSwQ7uv+1QiZTfpyDQymbaTI9FSqUJ0oTmMCdPg5n8flzLR9UWGRhob/kYsiwlQYOzh3uehgGzUxmbd8PVK9YLe6x53yG1m7SfuBSSVTCuDPm4/E1M/EwQt+F7Jtc7Rjdo5CMM5I3eY6j0d/g8o8/hI7rxVFKkxEQpXtlrn72CTRudJuJ7Rnyci/dHxTCT3h0Xks= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON monitoring attributes commitment assertion is hard-coded for a specific test case. Split it out into a general version that can be reused for different test cases. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/sysfs.py | 42 +++++++++++++++----------- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py index 9e5c72804edf..ed4c3e9fc972 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py @@ -137,6 +137,29 @@ def assert_schemes_committed(schemes, dump): for idx, scheme in enumerate(schemes): assert_scheme_committed(scheme, dump[idx]) +def assert_monitoring_attrs_committed(attrs, dump): + assert_true(dump['sample_interval'] == attrs.sample_us, 'sample_interval', + dump) + assert_true(dump['aggr_interval'] == attrs.aggr_us, 'aggr_interval', dump) + assert_true(dump['intervals_goal']['access_bp'] == + attrs.intervals_goal.access_bp, 'access_bp', + dump['intervals_goal']) + assert_true(dump['intervals_goal']['aggrs'] == attrs.intervals_goal.aggrs, + 'aggrs', dump['intervals_goal']) + assert_true(dump['intervals_goal']['min_sample_us'] == + attrs.intervals_goal.min_sample_us, 'min_sample_us', + dump['intervals_goal']) + assert_true(dump['intervals_goal']['max_sample_us'] == + attrs.intervals_goal.max_sample_us, 'max_sample_us', + dump['intervals_goal']) + + assert_true(dump['ops_update_interval'] == attrs.update_us, + 'ops_update_interval', dump) + assert_true(dump['min_nr_regions'] == attrs.min_nr_regions, + 'min_nr_regions', dump) + assert_true(dump['max_nr_regions'] == attrs.max_nr_regions, + 'max_nr_regions', dump) + def main(): kdamonds = _damon_sysfs.Kdamonds( [_damon_sysfs.Kdamond( @@ -158,23 +181,8 @@ def main(): fail('number of contexts', status) ctx = status['contexts'][0] - attrs = ctx['attrs'] - if attrs['sample_interval'] != 5000: - fail('sample interval', status) - if attrs['aggr_interval'] != 100000: - fail('aggr interval', status) - if attrs['ops_update_interval'] != 1000000: - fail('ops updte interval', status) - - if attrs['intervals_goal'] != { - 'access_bp': 0, 'aggrs': 0, - 'min_sample_us': 0, 'max_sample_us': 0}: - fail('intervals goal') - - if attrs['min_nr_regions'] != 10: - fail('min_nr_regions') - if attrs['max_nr_regions'] != 1000: - fail('max_nr_regions') + + assert_monitoring_attrs_committed(_damon_sysfs.DamonAttrs(), ctx['attrs']) if ctx['adaptive_targets'] != [ { 'pid': 0, 'nr_regions': 0, 'regions_list': []}]: -- 2.39.5