From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD03C83F22 for ; Sun, 20 Jul 2025 17:17:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D041C6B00A4; Sun, 20 Jul 2025 13:17:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8DBE6B00A5; Sun, 20 Jul 2025 13:17:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7E1E6B00A6; Sun, 20 Jul 2025 13:17:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9C6F76B00A4 for ; Sun, 20 Jul 2025 13:17:14 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 64D72140582 for ; Sun, 20 Jul 2025 17:17:14 +0000 (UTC) X-FDA: 83685298788.30.66852F9 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf06.hostedemail.com (Postfix) with ESMTP id BA3A2180005 for ; Sun, 20 Jul 2025 17:17:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n7URi843; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753031832; a=rsa-sha256; cv=none; b=LcSWSbIDutTcpH5NheOhdRtgN3qTA2eJ4mcduX2jVHqqTsjzpuX44rdS0/2XZYXauLy87J azomPXLPoggxtuLbxSTNMW1hePPlIlANVbyq42uG+AMvK28reYApRoW/Ez7Gr3aKUCWL8N EzBuw9BiBqP+WtoyAV6VRnEOoFw+a70= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n7URi843; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753031832; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZsnTr3l2a4Y1u8xtpc6/DqxGIODlqn5wFXOXh8fu1QU=; b=l1ULzmlWISxKIiQ3UZ3Is+dkjKYXZp4IwsX3OTXE/+sNnhIO+jurGfM+BCddwFKhEWQVQX Kjt+KTgUboRJHMeShM4m5ypuWv3NxdPERzDgC3hznWpD5T1MKUm6JjsM9ZMJkNr2QPJCzV TiNxcWiJzln3DpzpPTZ8UI6Mku4xA0w= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C915445077; Sun, 20 Jul 2025 17:17:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8340BC4CEE7; Sun, 20 Jul 2025 17:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753031831; bh=kZP9TMK44j+18HVVnFB5kNP/rbjB4yM/tzS9BLvJR7I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=n7URi843ye5z+FYnT5BlTEizCjI5a7L/inkAcz+qOdP3nV0HjVFbUM2oDweGXvjK4 DsOgf0HimSDZnjX1VF5VpxGMBfZab7VheCvgpESZIPfR6h3/r6xRIM0At9EdfyXVLI nueEeNBt9h0tUZ72XHVidSoMzo9G9s5VYRKHDnCZPFySmtgVXE+huEB/5FaXU3u8fm gSScyR8q5ojarz26PFQTX4g2Y/o6pqEuHW3c+LjLywBZDblU5fdHRQGUYZHTEhFx3Y 0MpA1Raifm+YLhKfucKL6iZlbsMNuTbeKn1TQ4r2JnQgfOTj63ExdCGaA0GfzF1mAi 7MBBxVxXpQh5A== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 14/22] selftests/damon/sysfs.py: test quota goal commitment Date: Sun, 20 Jul 2025 10:16:44 -0700 Message-Id: <20250720171652.92309-15-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250720171652.92309-1-sj@kernel.org> References: <20250720171652.92309-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4zxgf3jtowyxkct4qgt6d7k1pj3zkis7 X-Rspam-User: X-Rspamd-Queue-Id: BA3A2180005 X-Rspamd-Server: rspam02 X-HE-Tag: 1753031832-331076 X-HE-Meta: U2FsdGVkX18BBETTDZjFj030rai/rAYHUUlh4Was4MJJO6lQwdzMMhAdhlrp7eTm40qckpxaGo0w7gM25zzj/Te2seCScTPinZ7raWbPD5VEJ9wVchSG4YPuTzAj5ktfeGT4dHrSnTh6zmISxa0Ps9Yt8fo7JvW2bxplxaEPHBL0F3RpooBZHzAEIZpIjur2lKh6TCWLHPojIDS+XcNJZo2RJW0/03hguKInpOXtj7ovZr7oKI4O1aqxqC1xdxQwLW7rvM3rFfrhMMl7uJGXgCxs1bZdubwefEJb4Bye7By7x1rZfEEpfjm7lys1/RGkKcyvTKz/aRdI0A6NI6NWw8BcO3bJnddf5dV38fShwY3WMtFeIZMPrCeesawOqQYH24zdEfUNwD8hkAnahrIhx5NboY+oZvCOe9NTZttEkb+CbHWWs/yj+n7FdlyR0nGyD8O6tGfefKnE2ljzbL4/gPAgApcB76EEXkiaR17C8bQy3ltb1kYPPwhroGD2Ekc5ssLwA42Mk2Q1NGbDJwf98VXMFAjaka5x8+TlaaDa5WxkfCyVlMjY5Bp0V8pX6m9CIi43wf+DsAWqnjWcONLnuDkWxVCc5h9igUCI4VcCExd9/c1gWHRqp7Fp0cwGqZB3PTpM4Og6d0IbGCyb4IiOQIOuLUJP3fn0JuUk3tS8xnb9IqJeGtVzoIdKG6Eno8yIi6d00LEL3uWydS4ENXIx8oXRj8yb0Rs2ZSEiTqsAk87O3jnB1NtjQUQIbTrW1Bn5mWbauA6zaocpK5qxmKhbiopEpM+LhOaaVz7Yp3rHXDw9E9g+rq0dpxkLYKDlgCquP6MMfmdbMClH8rq4poFweJTgOXDbwKBfObgeZAih7oD0eHTksKl1GlaPuhpE7q2RtBfW/UOnY2jZYPJW45DEX6Na6DZzxBZXVpxHUJV6fkoArgNQyJrmR8joid1tw9cLWbt17M87xoQq5JSyBrU J/FSG6wP 1iR1UhEY+imvNZiVxWrdwwfiYpd1RKPm8mP7LXr4CE0krS7Ologw1jHvVvHJtQc4CTinaYFo4Gdc2gK1+djREMLce1/CdzINIuJr2igFhdib0Phc7N4n1dRjbu+t9g1Pevh2LHqJGynRLX72SMaO/46YsjSuXBx5COGPj/9ukcTIl6UWeDm2PVzocC8DILdQ7d7GHLWgPUh0NTdsu6yNNcBSSaML3V6f5vO28au+vy6koXQU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Current DAMOS quota commitment assertion is not testing quota goal commitment. Add the test. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/sysfs.py | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py index dbe9f1a3b976..93f20c5c6780 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py @@ -41,12 +41,28 @@ def assert_watermarks_committed(watermarks, dump): assert_true(dump['mid'] == watermarks.mid, 'mid', dump) assert_true(dump['low'] == watermarks.low, 'low', dump) +def assert_quota_goal_committed(qgoal, dump): + metric_val = { + 'user_input': 0, + 'some_mem_psi_us': 1, + 'node_mem_used_bp': 2, + 'node_mem_free_bp': 3, + } + assert_true(dump['metric'] == metric_val[qgoal.metric], 'metric', dump) + assert_true(dump['target_value'] == qgoal.target_value, 'target_value', + dump) + if qgoal.metric == 'user_input': + assert_true(dump['current_value'] == qgoal.current_value, + 'current_value', dump) + assert_true(dump['nid'] == qgoal.nid, 'nid', dump) + def assert_quota_committed(quota, dump): assert_true(dump['reset_interval'] == quota.reset_interval_ms, 'reset_interval', dump) assert_true(dump['ms'] == quota.ms, 'ms', dump) assert_true(dump['sz'] == quota.sz, 'sz', dump) - # TODO: assert goals are committed + for idx, qgoal in enumerate(quota.goals): + assert_quota_goal_committed(qgoal, dump['goals'][idx]) assert_true(dump['weight_sz'] == quota.weight_sz_permil, 'weight_sz', dump) assert_true(dump['weight_nr_accesses'] == quota.weight_nr_accesses_permil, 'weight_nr_accesses', dump) -- 2.39.5