From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11713C83F22 for ; Sun, 20 Jul 2025 10:55:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DDBA8E0002; Sun, 20 Jul 2025 06:55:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B5BE8E0001; Sun, 20 Jul 2025 06:55:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CB5D8E0002; Sun, 20 Jul 2025 06:55:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6D3148E0001 for ; Sun, 20 Jul 2025 06:55:51 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 215CFB9A49 for ; Sun, 20 Jul 2025 10:55:51 +0000 (UTC) X-FDA: 83684337702.29.DBE3002 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by imf12.hostedemail.com (Postfix) with ESMTP id 82CBC40006 for ; Sun, 20 Jul 2025 10:55:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; spf=pass (imf12.hostedemail.com: domain of chenhuacai@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=chenhuacai@loongson.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1753008949; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=z4+MilFT5iUlAGavw9EuJbp2wWr42zpmlyJLyzgJt6k=; b=KxsnAr7oZLu7wvcjEorbZrc5VBv0ESALEHB2BExM8RxhFLXjh0KeEaDQ1LD50Q0ow6QG0y 3uBhhAlsiwCOGIa49gQvd9qpQ/RoeK1yVXKpvdLJsKiUrpWGMxFQkdVzVskzVUg/eVHpIY TmyiOBJiLUtp61LSRy24M5SbLDFfDNk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1753008949; a=rsa-sha256; cv=none; b=ewXpr8qsd/P/XYq9AvJVBXThGp4jaPIO2s+URlC4i8QNQDt06EjlS+Ha+bKDoGMMInQjL0 VAgFAz0VyngZ132C6KyLe1vOJ0OIQKGqOufj9wZZd24rwiv5FYEV9bK6eU9IyGx4JLHAWH k4KDYcvxApUyEZMNiV38wbxuISDG6/4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf12.hostedemail.com: domain of chenhuacai@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=chenhuacai@loongson.cn Received: from loongson.cn (unknown [223.64.68.193]) by gateway (Coremail) with SMTP id _____8AxlnAwy3xoTikuAQ--.28291S3; Sun, 20 Jul 2025 18:55:44 +0800 (CST) Received: from localhost.localdomain (unknown [223.64.68.193]) by front1 (Coremail) with SMTP id qMiowJDxscIYy3xoyY8eAA--.18430S2; Sun, 20 Jul 2025 18:55:42 +0800 (CST) From: Huacai Chen To: Huacai Chen , Andrew Morton Cc: linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , linux-kernel@vger.kernel.org, Huacai Chen , stable@vger.kernel.org Subject: [PATCH V2] init: Handle bootloader identifier in kernel parameters Date: Sun, 20 Jul 2025 18:55:09 +0800 Message-ID: <20250720105509.2914898-1-chenhuacai@loongson.cn> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:qMiowJDxscIYy3xoyY8eAA--.18430S2 X-CM-SenderInfo: hfkh0x5xdftxo6or00hjvr0hdfq/ X-Coremail-Antispam: 1Uk129KBj93XoW7tw4fCr1rCFW3GF1xXr17XFc_yoW8uw43pF s2qryrW3ykGw45Cr4kWrWvgrySvwnxZa17GanxWan8XFn8tFy0qrWFkF4aga4Dtr4fKF42 qFnrZF18CF17CFXCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUkFb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv 67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41l42xK82IYc2 Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s02 6x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0x vE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE 42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6x kF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07URa0PUUUUU= X-Rspamd-Queue-Id: 82CBC40006 X-Stat-Signature: 7mp63h8sjj9xuy41r3ayyhact8tf1oqa X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1753008948-308277 X-HE-Meta: U2FsdGVkX1+teWqrLDZSgEqVa4kQljYTtw7X23sF4BX40vk9hkgdZKR6rwi5Oho0ub1tVZJRkjrj/GeM36YhdEsRd3xIh6ZlALbkNGuiJxRfC2/RRNtL7EnAYAu2y82YAeJ6wy7+jJknI4kM3O4Z5cdkkTvzeYrN5E/r24cJuG6C+Gn1w5/s0PJTpwxUb3eKVmqDRcvbGOf019++fqNMKeShzeXX8+L5/kza4kAbDQ3rhCPJuRRK5QIE0oArg3vsWtjwC76RaCEUVEGAZucHNdRhMZseecdpmkeD/96BqvfgZQVttGyPZFgtuAKYq9FUvh8RO35r6YMEKS0rGFvJIS0xW65bQcX8x7aTl0pqgPn3VbhntcEJ+8uk3Ahi6m8wqBRwKTMt0lD8qURKVfFNcxq+xDcKePEAuqktXRHxSYEkpoPARqoL6GhKFIkxnsb2Y7XQXWwejzaiUEV5DgsOz1iz4SyFx4X3EZ8TWGYBy3HdWfVxc4t5+lH+I40KqRI1E9bl5pdcJQRyvdqRCPZMPodCQcATTR89SGkbZxfGDQGWEsqQ/lmosdcnnkAymKHfZ8j6zWoDM17xtvnKCgZwbdK0lbjN/MeT9qvcM7iGcG0sPgkUzDNfcGNmCm/bpAu8H9gb8ygE3MzRDTQlpHFMh07CeB+IqUOiGvWMlxVuNsjB1otFPFbwThCLLyFuiTj8RNv8MU2f8FtAgy6V7mWa/jyUn09MG1aohTcdvDs3pn4GZiaVXrC+SAFOfwS+1nA651bDYT9jaVv8uF/YMXdm4i+DBFPtMXwZy7H3CL8MLltIBR+RAu4FdY3zW/Plj9WW99TZD/VBzLEWBXQ1VaUAu5vvCLTGTHAOoZDohnKw6oF3Cs0TbBZ3ZiWwi8pWzXR7eUu+CWrEf/qTqjNHfAhR2t4errQk1T20ryzVTDqeTl8l/k0Z5HDCK0TDnUgOe0rGc6AQJYUBIc1vS570ZYo dvuvEI7u AlvjGKeugQBicplvlY5lCecxoMG4dFUwpQcNOUZM6AdZN3qw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: BootLoader (Grub, LILO, etc) may pass an identifier such as "BOOT_IMAGE= /boot/vmlinuz-x.y.z" to kernel parameters. But these identifiers are not recognized by the kernel itself so will be passed to user space. However user space init program also doesn't recognized it. KEXEC may also pass an identifier such as "kexec" on some architectures. We cannot change BootLoader's behavior, because this behavior exists for many years, and there are already user space programs search BOOT_IMAGE= in /proc/cmdline to obtain the kernel image locations: https://github.com/linuxdeepin/deepin-ab-recovery/blob/master/util.go (search getBootOptions) https://github.com/linuxdeepin/deepin-ab-recovery/blob/master/main.go (search getKernelReleaseWithBootOption) So the the best way is handle (ignore) it by the kernel itself, which can avoid such boot warnings (if we use something like init=/bin/bash, bootloader identifier can even cause a crash): Kernel command line: BOOT_IMAGE=(hd0,1)/vmlinuz-6.x root=/dev/sda3 ro console=tty Unknown kernel command line parameters "BOOT_IMAGE=(hd0,1)/vmlinuz-6.x", will be passed to user space. Cc: stable@vger.kernel.org Signed-off-by: Huacai Chen --- V2: Update comments and commit messages. init/main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/init/main.c b/init/main.c index 225a58279acd..c53863e5ad82 100644 --- a/init/main.c +++ b/init/main.c @@ -545,6 +545,7 @@ static int __init unknown_bootoption(char *param, char *val, const char *unused, void *arg) { size_t len = strlen(param); + const char *bootloader[] = { "BOOT_IMAGE=", "kexec", NULL }; /* Handle params aliased to sysctls */ if (sysctl_is_alias(param)) @@ -552,6 +553,12 @@ static int __init unknown_bootoption(char *param, char *val, repair_env_string(param, val); + /* Handle bootloader identifier */ + for (int i = 0; bootloader[i]; i++) { + if (!strncmp(param, bootloader[i], strlen(bootloader[i]))) + return 0; + } + /* Handle obsolete-style parameters */ if (obsolete_checksetup(param)) return 0; -- 2.47.3