From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B475C83F3D for ; Sat, 19 Jul 2025 18:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1F448D0003; Sat, 19 Jul 2025 14:29:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA9438D0001; Sat, 19 Jul 2025 14:29:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4B098D0003; Sat, 19 Jul 2025 14:29:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A98448D0001 for ; Sat, 19 Jul 2025 14:29:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 76AA81DA315 for ; Sat, 19 Jul 2025 18:29:10 +0000 (UTC) X-FDA: 83681851260.01.ADE44C5 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) by imf20.hostedemail.com (Postfix) with ESMTP id B78841C000A for ; Sat, 19 Jul 2025 18:29:08 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vcqDc4Du; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of 38-N7aAYKCPQoqnajXckkcha.Ykihejqt-iigrWYg.knc@flex--surenb.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=38-N7aAYKCPQoqnajXckkcha.Ykihejqt-iigrWYg.knc@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752949748; a=rsa-sha256; cv=none; b=xetHOEwwR14SnkGiLaxkVoMP+wJTPsxCf96LLTsK9nUAPbdkYMyQRN0HPw3R2/GRrtP5A3 QINx/iy5cPOCTDIzE0FJLqPA1E9Bp9AM9QGOG6MQ9EPq0oeXsgVQ5pNhh8y4u6Bu6ZG8DN 4ldiIiOHgo8TMeS9M4+7CezMYPxuxo8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vcqDc4Du; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of 38-N7aAYKCPQoqnajXckkcha.Ykihejqt-iigrWYg.knc@flex--surenb.bounces.google.com designates 209.85.216.74 as permitted sender) smtp.mailfrom=38-N7aAYKCPQoqnajXckkcha.Ykihejqt-iigrWYg.knc@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752949748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wv6Rc6knLCwk0bVTU7Jho39C3VrUJugHZkg7EchZAig=; b=7WN+T85SP2myuCAz7LHOV24uOvq2qoh0GiWOjyn1l3Jt5ZcadSozPeyfYKamHtJW4z8Z5W TsVrkJ7zJToM5I3/fVi37ov2b7vwr1glIRR03leO7E8vC3T4j1KmSC9+Gzw7CdfIEjOMeo dX06yf+KOI7q2c1xOiTOgmhiU/aTL8g= Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-311ef4fb5fdso3744066a91.1 for ; Sat, 19 Jul 2025 11:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752949748; x=1753554548; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Wv6Rc6knLCwk0bVTU7Jho39C3VrUJugHZkg7EchZAig=; b=vcqDc4DuduBief3P08/Ikyfy7vmy390oxQXS+Y/9wjEto3BtxwfkwSotJVi9dJvUvy eE8BannyIMMw/blxHqB8313Igb66rE4h4x5Vx/CIpUyjPZndS2ueK7yXU1BFheBIGd5p GS0Z4Ksw2Thc4rD3DU05lWUz7gbaTuHv4Iq+UZwEmwqLre74eK+fdZRMkcbxRkETQKIt uRHsNf76Rn3RvqnyXeDT3sOz3OO+lBzpuuyiwbpGIT0QQL32dheqiQddcSUvnZjQV53V jueaMdsVCEggqLqr9tUdvh/x163oxt/ZEQ1X4HoNtdd0IvqdmNN2PIFreht4n+ZMg+fg WcSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752949748; x=1753554548; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wv6Rc6knLCwk0bVTU7Jho39C3VrUJugHZkg7EchZAig=; b=QHNxTA4Bv1tMFyNQ9NYi3Be+FpU4dJwpD66vv2Sb5GanOX2kgJoq51E9r1pCCJPw8p jWG/TE6j2mNTWA9Oc9klDsL7ieiv+VmbDGs5XLcH0mXTfkEeRxw4WiUu0MwUT6Hbpv4+ uKfdzOlQf3evZLme0ylgostsKcV4uo+7uNc9Ei1mYaY74jjmcj9p+iRCHWW1rAd2N/kt yVDMbhzvyMg8PzgAH1jcQe1KGg0h+lq51gbkAl4t2Gir+nGwLNH/Mxtxc1/hawsSW55j 6cHJaZqEZaRWdvxCUv3xyS/ED8FTzkdCNpB9ZlyyJpJaqfXhG6LIWhTIgRXdoihi22P8 Xx8g== X-Forwarded-Encrypted: i=1; AJvYcCWgf8tTx7iVeQ/hpjHwgT2meL5WOrB3XQdEtotOEVkxo6Xph93ecln57rxe2/v51Cmpb+FIlsjLyg==@kvack.org X-Gm-Message-State: AOJu0YyibpzOwltBXUxfKr+04+iyxC5JDQBCzb7HZZOniW7nBbCg1YFY nAuhocjlym0w0GqjM7BeYXPQQb6B/naXu6kFfy22KeZO60kgUGSZ25dtOA7gmf444ayhJntFTyy 1Aczxog== X-Google-Smtp-Source: AGHT+IFF+l8YOMdVgdfAKyd00OGIBIw32C6yb0RlsDUFxpfFgJAmPbDpH0QnnK8+9k8e/WhkoyFB5zF8/XQ= X-Received: from pjmm4.prod.google.com ([2002:a17:90b:5804:b0:312:3b05:5f44]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:48c8:b0:315:b07a:ac12 with SMTP id 98e67ed59e1d1-31c9e6f71b8mr24466775a91.14.1752949747704; Sat, 19 Jul 2025 11:29:07 -0700 (PDT) Date: Sat, 19 Jul 2025 11:28:53 -0700 In-Reply-To: <20250719182854.3166724-1-surenb@google.com> Mime-Version: 1.0 References: <20250719182854.3166724-1-surenb@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250719182854.3166724-6-surenb@google.com> Subject: [PATCH v8 5/6] fs/proc/task_mmu: remove conversion of seq_file position to unsigned From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: x31um663tfj8kqrtn5mswp49e6cwx1jz X-Rspam-User: X-Rspamd-Queue-Id: B78841C000A X-Rspamd-Server: rspam02 X-HE-Tag: 1752949748-246587 X-HE-Meta: U2FsdGVkX1+dH+yFXsMQgmr1EaE3mIM39Rivnm5TVFK20oiszEj8z6o7EBKfi1nWyQ+ztKnUQeVjVRQh6tjnAuCLcZFEx8bH0r8hyzM2b5cEcr9FD+HOM4nVaszwa/TvzZMzkVyHtJtDqzxVCIFZOK3ISUSQHYag8ubk7M53OXlPafKwImkfuTflozMQykQOgTOeQPLOb/pzO7lI6fZ+pCnht2FJ9KTWZJjg9kRL21o/5gwmGiYHzERpdcto4ijsbh8NaEC312tZlI+T1X6TCcIxJiAQ05Ejxcmyi2JPTuaFxu0WhGL1FuLh0HIN4jCRI1NJ0m6BIoS0p8pojOS58hNV+rwKwN/X9Ouk+KptYjNTbxDDqturMrpWw7RfdgumBA0eiBUgEIvX8p7riDI/8WBN2KcePuP0HbESoaqc7SQ3PUTn5ZatTbuQd5tIbEsyHRb6KhInqQCOZ2zo1dlUgbnjl1FPyL81+v1EhHxVnV7huprPeb4jt5ijHYHwDUdtaclxouQdfifZzCLeGAjqj3llQCtvIL1vcSudoz/nw8DmSeLDUBfdDm7PpOpWPmg40Cvow2bLIZwk0oyvgPIo3ZnU/tw9+EUDvdaLGQwUjR9WMRcN9IQDncnCF/aj4JK/qPOUgl/6kni6JlZN5jDXngtgqKBaf83KUPC6dSYw6RXLNDp3L9nnLAJpcpZHAf7JhaGArPOcVJs6erAuGa1Ie1aHBRnb9y/yXu3G4oppIp3FIcJlrRnyxkauucxe5hsOgqGVGN/IG1H4F8KRs2cqevXmTb9TQSysokQMzUuscoSqofGZVyzCzQPf0PYl+4AbpTEo3WrWPyrJclOofKTZJuXHIQMbKJqrdyzOzDodwj2RvbZbdQv7xdbwP/JCxEGl83HzDZ3NqerzxUkMalFHRNR68rGpzuGJm3sLTPuUTYHsggZU2VcfqJIquZRw0RmrzQqmPBaI5WxG3D+K94U 0NwCbTwR xRQdgaOEhzDHoC4lMXXbV7eC9xkdzu/5NreDFoRrT22o8XlhNi2zhtkOGYC6E3HMpazZySmHTcoSoraz+HItUBNbfqCDgX+3wH6gxdYNqVK5kJ7ByyLoL6k45QFNez1Ch9U/A6jb49J62fyTcu/YYEjzcW1r+Q8gvGAIDnfA7IbUfACnKeXLZs5yvk4XY60C872xou1g2nY343nh7i6mVlF5ZtUy+yU47U8cZRhjcY31Zm33MMZRMAUDWqwnEXbk9K6N9FmF6rKkMdlSL0fWOlkmCbW7b2o8LoyOZTFleVulVXJhpFsG5TEdjfbKOaYmjp0IlnggLGeFa/DhWikrO1pb3C2KHx3ObAuXEhQDZrHmhtOsX3jCIh/aUGrHiyoa0KNo1c6QqP4C1J3oppg9XhhbUdlIdgww8ASt77revWYUpreT/oBVssUGjoAGB5snIIt9E1SDCFvsBTFRyk7MaiNM49uszX5K8BdjvdOMKqqOYRyao/wADF/yAqGZqold9ApQVGhgnWWU42amqT6DFEA41gsb3VjXpGaw8aE+//r7+578pOLo/VlANYmp1KjJc7Sfitv4VAjj9aESTZgo30kjgcf6+3WYxxMWLbtR8vO/zLDmt5hk0hraxKlz+JOqJViOrf+f7c1sYLe1cei0rgY8II9+6RvqpvRi5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Back in 2.6 era, last_addr used to be stored in seq_file->version variable, which was unsigned long. As a result, sentinels to represent gate vma and end of all vmas used unsigned values. In more recent kernels we don't used seq_file->version anymore and therefore conversion from loff_t into unsigned type is not needed. Similarly, sentinel values don't need to be unsigned. Remove type conversion for set_file position and change sentinel values to signed. While at it, change the hardcoded sentinel values with named definitions for better documentation. Signed-off-by: Suren Baghdasaryan Reviewed-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka Acked-by: David Hildenbrand --- fs/proc/task_mmu.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 751479eb128f..90237df1ed33 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -29,6 +29,9 @@ #include #include "internal.h" +#define SENTINEL_VMA_END -1 +#define SENTINEL_VMA_GATE -2 + #define SEQ_PUT_DEC(str, val) \ seq_put_decimal_ull_width(m, str, (val) << (PAGE_SHIFT-10), 8) void task_mem(struct seq_file *m, struct mm_struct *mm) @@ -135,7 +138,7 @@ static struct vm_area_struct *proc_get_vma(struct proc_maps_private *priv, if (vma) { *ppos = vma->vm_start; } else { - *ppos = -2UL; + *ppos = SENTINEL_VMA_GATE; vma = get_gate_vma(priv->mm); } @@ -145,11 +148,11 @@ static struct vm_area_struct *proc_get_vma(struct proc_maps_private *priv, static void *m_start(struct seq_file *m, loff_t *ppos) { struct proc_maps_private *priv = m->private; - unsigned long last_addr = *ppos; + loff_t last_addr = *ppos; struct mm_struct *mm; /* See m_next(). Zero at the start or after lseek. */ - if (last_addr == -1UL) + if (last_addr == SENTINEL_VMA_END) return NULL; priv->task = get_proc_task(priv->inode); @@ -170,9 +173,9 @@ static void *m_start(struct seq_file *m, loff_t *ppos) return ERR_PTR(-EINTR); } - vma_iter_init(&priv->iter, mm, last_addr); + vma_iter_init(&priv->iter, mm, (unsigned long)last_addr); hold_task_mempolicy(priv); - if (last_addr == -2UL) + if (last_addr == SENTINEL_VMA_GATE) return get_gate_vma(mm); return proc_get_vma(priv, ppos); @@ -180,8 +183,8 @@ static void *m_start(struct seq_file *m, loff_t *ppos) static void *m_next(struct seq_file *m, void *v, loff_t *ppos) { - if (*ppos == -2UL) { - *ppos = -1UL; + if (*ppos == SENTINEL_VMA_GATE) { + *ppos = SENTINEL_VMA_END; return NULL; } return proc_get_vma(m->private, ppos); -- 2.50.0.727.gbf7dc18ff4-goog