From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27E56C83F34 for ; Sat, 19 Jul 2025 23:38:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F88D6B0093; Sat, 19 Jul 2025 19:38:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A9776B0095; Sat, 19 Jul 2025 19:38:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BEA86B0096; Sat, 19 Jul 2025 19:38:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7D4F16B0093 for ; Sat, 19 Jul 2025 19:38:12 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 02C571603CB for ; Sat, 19 Jul 2025 23:38:11 +0000 (UTC) X-FDA: 83682630024.18.F52F753 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 5D4181A0006 for ; Sat, 19 Jul 2025 23:38:10 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rF5ZMXi7; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752968290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f/NKN8I9hz43R0+wZdhsQ1ZzuJVq909LpN31j4wD22s=; b=wV/5R7nC9wVVFFaGtVI1+fBnWwWDmPWfT/HR4sG229Gsmnp+BYasB/RICKRNclkxpaD79s bj2fbCVgPU7MuIob51ZxYlzSWKcY5X3kcNOuuX/Hnq9VlqSE36Eyyien5nnlF5LYy+FCTy XgrrqyhESi4MHDrzUCSRfYzpBqT7s/g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752968290; a=rsa-sha256; cv=none; b=ys22AR8rNulQ9MtaoIkCXcBFAf+ECrtTOdnxHIqQNF1HF+Kw58I03sty4E3/7+nMo66G5q 7DaybsaXu0T2Q/KukxoNQUw0UH1lKkkc1c+lH58HmGrhJ1H+xfBp+p5Hp7w3OahmzsEVRx OP3ApylUCQqUXwnHKVAPiJnmzb9B5xQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=rF5ZMXi7; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3F06A5C45DC; Sat, 19 Jul 2025 23:38:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AFA9C4CEE3; Sat, 19 Jul 2025 23:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1752968288; bh=PaV4HcuG8Z9WXy5NHbKnBdf1/nYAFp4jEzTMozwL6Q4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rF5ZMXi7XMfw526opy/XVRlsafUH4J8JA3+dYf50xsqNwtJaLcYSDv/t66z+fpE0S kFOfOrl4zKPlar3UgxBqlS3NHv4SBxUWJnDrxsyXOkAgSasDg3RHXi4BFbTNgRqIj2 0IVaEuYIw/PFY2bTk+K3RKGzDztMSv5/O7Er/U5E= Date: Sat, 19 Jul 2025 16:38:07 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: kernel test robot , Ye Liu , David Hildenbrand , Davidlohr Bueso , "Paul E. McKenney" , Josh Triplett , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Boqun Feng , Uladzislau Rezki , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Ye Liu , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Dietmar Eggemann , Ben Segall , Mel Gorman , Valentin Schneider Subject: Re: [PATCH] mm: Replace (20 - PAGE_SHIFT) with common macros for pages<->MB conversion Message-Id: <20250719163807.068d4cb349c6a3395183167b@linux-foundation.org> In-Reply-To: <87dff86f-94b8-47aa-b2e1-7560a9f60818@lucifer.local> References: <20250718024134.1304745-1-ye.liu@linux.dev> <202507190319.0rqhQw5l-lkp@intel.com> <87dff86f-94b8-47aa-b2e1-7560a9f60818@lucifer.local> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5D4181A0006 X-Stat-Signature: 4h6qmufu5jn9jqscusgdnbr5mk51k9tc X-Rspam-User: X-HE-Tag: 1752968290-496358 X-HE-Meta: U2FsdGVkX1+opqlwt42oR+oqhm4tyw+cDOhaVRdkTezCNjP3yk94s1eFgdZ7Bzhz1dleCJo4M8s31hCW2ApyHsXjaay6bYz8XJqk2TTgLNil7XIyfNLLEKToz4V4ZxfBAJRxNONr5GH3EbRmhQideSGg7D9V+d0C85FDJFbqQkPeQ4/kpFSczmf6eHQnEduRO1yu90vSl82a6351FIUs2R48dd6rO3cYR0UlV2BQk7Jg10JC5YG1WuF8DEphmB/C8msIHb/VzCSetMQqra+v5aOatakWOUCj/a5sbVSKeLAf04e6o52k4l9wzHuUBziosQo/TMWc+KA8certxP9dQDp5/PrdrJ070Di721pLVP5d6G+cCD9XzCXPnTu/aBIHiG3raH8FsBsBN7QPRNzH7MqMGVLTmoCryWfQX17EPDAKpPnANcNCqfOIqBp4J3Ot+5LIkQYWZu6zB5vABrAC+n3iM3+MoMn+YW1Tn2rEBVF3LmRAsUAPALWdc9IP3U/phKTdz3DP4ZZ9D5ucflvn3yHrXSwGFIhNk9uA/XxthtbkcbCYAjbYKDi/bix0aZLNI+BR6y3DYsMd7reK0vrzWekB2AYoVWsrOuJhIt55sJq/A01AU+gcLNADAaPXR+xJhqIV2KMKaO2t9+EkPBYar9ZGA9A+sXj/DM64RZuVu6cHCXrn7cSGPwwJmeKZ/2e+hKPHOb7rugXRhbBQXnpVduo/mm9a55zgqOwcIZpogoFCKBFA3EyvJw2Jccm/tulDZ+cvdZcSsnuZd/iQD2mON3fzYxPG8TijmZ9Al9YnImE7ePreey27+PWuA6gbcpJgylgCF/wx+KbgV5BL+OKVJM3WUxfurBcOYoolsEGdsAnoRd6CyPqasLJd2gorwRYu4ZIPYPdOOaxCtfGV713B/yvKUYTgcNPfiJStwdR13+q2Aymb2IYg54CDNkEuHxW+LmnfcxBw57oGJ+rRRyo 5dYd6aKw JPbZHezKIrZ3yNebf9ncSvq3Jn9kIuqZoi4gHYC7uJ99QX6lN5u1oxpcyfUkBwPPVs4l5A9yD3PkuBLZiRY924KWuIc7+pFNhT3/Vnb8/dR4Y6RkxraIamhtwrkEVhHU967DNzjB+hV61+6am9GtKgI1Icdz07dnOJmnGMYCu8W/1uPk2YA7Ft39Z57MkiNRleMWSfkgj0ozBDKJKEWDG4wOn9mv/vcXkZN9RyysNTypOTKi69o3uTBH4Jg0n1EClmv6jI4nuMKSV/VTTRPawyB8EAehvnIYYaMcnw+fMcAibJzcNYdW5e4cUKhFwwT8QjA1qAJr91dKdZLh+wRinR+B4rtr/eq2+bvLzxksL6YhenRy8/sgWhxXvyidLA9jr9EzNXRqDQXGUZ6k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 19 Jul 2025 07:56:16 +0100 Lorenzo Stoakes wrote: > Ah yeah looks like this is already defined for arc only (!) in > arch/arc/include/asm/arcregs.h. > > Maybe pop in a #ifndef PAGES_TO_MB ? It seems to be equivalent. Well, those arc helpers /* Helpers */ #define TO_KB(bytes) ((bytes) >> 10) #define TO_MB(bytes) (TO_KB(bytes) >> 10) #define PAGES_TO_KB(n_pages) ((n_pages) << (PAGE_SHIFT - 10)) #define PAGES_TO_MB(n_pages) (PAGES_TO_KB(n_pages) >> 10) are simply in the wrong place. I was thinking move all four into mm.h (for the lack of a better place). Then someone can make a career out of hunting down all the code sites which can use them. eg, hp2:/usr/src/linux-6.16-rc5> fgrep -r ">> 10" . | wc -l 886