From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A9FC83F17 for ; Fri, 18 Jul 2025 16:44:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 171986B00A4; Fri, 18 Jul 2025 12:44:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1224F6B00A5; Fri, 18 Jul 2025 12:44:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 010C56B00A6; Fri, 18 Jul 2025 12:44:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DF9B26B00A4 for ; Fri, 18 Jul 2025 12:44:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 712328011C for ; Fri, 18 Jul 2025 16:44:45 +0000 (UTC) X-FDA: 83677959330.23.27FA89C Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf21.hostedemail.com (Postfix) with ESMTP id 68D0A1C000C for ; Fri, 18 Jul 2025 16:44:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=rBc4oqcI; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf21.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752857083; a=rsa-sha256; cv=none; b=c5PPNiuS/2DUA9KtNZg8XBtZwOXwiM1deNFkAQJNn9aJFA1T44K3bLjlr2//mHVJLpf2Vc wcC5Iz82I6R1/Ot2mnihL/PsfcMP92Hx7w+5dMuIk7UGcutwFlIP1UtVM+yxVEuXpLqg+W V7RbH85oheWNPFF7lepTOd2EOV8IV9I= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=rBc4oqcI; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf21.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752857083; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+0KHRWq6i37ZM7MezYdHPmtRz/2NspRTQD/ZZBbyTv0=; b=NfLVsxcVrxA+MS6qXoURfjeud6P1Bx+dDBJOOzTAHQ7C9WXfUY/A9MXXSFVIyFBNiUlagP 2QUl2AsYceYD6WE1ad2AMI13C1I6pvSzQIiuQhPi4g77+8qwHqpLMoPY3tayf8G7ajgqYO UkXan5XIC0w7Ow/TFGXbSWAK2j8Hmrc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=+0KHRWq6i37ZM7MezYdHPmtRz/2NspRTQD/ZZBbyTv0=; b=rBc4oqcIYo5r0vfEnlB/XqXlky M5UHceSwD77kirjCboTRNk2dVrD7IF8NF7+QQfNFgzIn2Twsc97+JsVC0ORwNG18ssxg8d19OzjUE ARligVVJNckW8nH/IQRvSwmhuIP+H02qICEJzIIIx5tLpLFvupfRA1/tIq1Z58HfavsxSe23bqkaP 9BwDhmBxba/wJsS7ZJKvwRFahWhorfM65kduv+yaTCMOWmAkKDCH1CojtBfk4tXMuidgo2sdPfmDj pBCxg/jBoDJwbRtBH8f6SVeSnkV/4n8eo5x5jsJgnVr7I79QlszalVck1qgUqv5560DI8nMnkoECu M0Wer/bg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1ucoBw-0000000CMH5-3Ggd; Fri, 18 Jul 2025 16:44:12 +0000 Date: Fri, 18 Jul 2025 17:44:12 +0100 From: Al Viro To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Masahiro Yamada , Nathan Chancellor , Andrew Morton , Willy Tarreau , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Brendan Higgins , David Gow , Rae Moar , Shuah Khan , Jonathan Corbet , Nicolas Schier , Kees Cook , Christian Brauner , Jan Kara , Christoph Hellwig , Luis Chamberlain , Christophe Leroy , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, workflows@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v5 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support Message-ID: <20250718164412.GD2580412@ZenIV> References: <20250717-kunit-kselftests-v5-0-442b711cde2e@linutronix.de> <20250717-kunit-kselftests-v5-6-442b711cde2e@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250717-kunit-kselftests-v5-6-442b711cde2e@linutronix.de> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 68D0A1C000C X-Stat-Signature: dkn6s4jt19xasg5a6pqs8qy4jpouza74 X-Rspam-User: X-HE-Tag: 1752857083-366175 X-HE-Meta: U2FsdGVkX18BWxcICMJcMV0paxMMJYiQoBKVD6zGlopy7IQ7GSlC7q4cBCwRTS2GThujOCCX/+rp3iPcPmFX5ZHPMZOGkqptG1T3rS72CIACzuDrJ8uj7Mh6IPFFB+++q0ASuyGTFrsWb6317RShZJo8uG7ppRV/tS1LuQuO8PEae9653jT/09DduzDaXAibE51YRkOoFqEksnjYvhP48dP4c5Hzu0qyop+TgooJvphRGNNKPkJRGiuonymLPukJ6mVsLZLsG3JV9AMyrBsgxYRLI8m85i0Ks7t27ntFLgEe/lYTjhW6/rHd0Hs4icSusNKIx7dDGbM2kHvHwpccVCy6wFU+DuKs/ur3NSpN3/Zizl4aQ6Y4smmLfcI2SxHiTDaodhfwROrrAGj8U31wGO8eyfxC5Q2Wx8NIcD/1lgoPHSalzqY4LInjzwXDmzeCOtvFRMhRn623sb17fJOeCK0QXRW7ZBYScM58NuWw9M6NYyl0WTT8+WtwnqSEwCjhnSbPC/LFzwzCOy+KDuU6r8EF6PYNfxShewpCn3jdBmcrM5zo9OlpuFciheOhhTRjjsoPM6te7p+JSHaXVRHIMCFa8uwiyHtudVRsRbb4EUEher1YKeL7vOHnzHocLhUwAnSyJimqpXV1EpIuISQWkYmymwKlHSZwsLzs5pxoyVokZSujkiukgA5kwZHFxrWdoTVriChHOGvc0qOnRt0IKH56WCOd2lUap7o84cvq0FVwGeDCnPHfOJWmNZt2GFEfSEq+loc3dsnn3e1sRHap0/JefbWKLIqdOOakI7CeT7/Vu60gu1W2Z+TVxZ3+sqlOu28N2GxXplTGyqO852jYD/XSz0BPHO21fjPHpcEyStpUF+XvBiv+YksR4SjbF0JUuBLuIuZk9i5orAJDwuYZBBk73+oCWiJTKR9jooHljmyK2q/bvhI3ndaxNnWEEVvATi7K+yrPdk8TJWy/8AO O/C2snBL Yl4AaTCbffx8J2wKdGydUCLj70ypHi6syek0Ax8R6t+wEGO0PbNozwxzAibJgW38rZluNKSI/EL7M5wqtEBdVBkgaQc4emMpbm3UHkesmzXnQ0CGiTiATvnGIv3qMpLx6SG8ChwpSya9iG4cO4Z/A+eThUZ94TuID+AqWUUDXgbyHP4sEB7Qbr7H1vH7nBrgxvbYDovKE3IvAbqSY4C8Kn4942ZJDB5XtugknKVmLBU6RuXynTuBT7dDlXP23Ex8AWJWcnpfzvYvaFIsSJlJf5wHCUqGIX3ZbxevRLRTHW5HigszEHrRhyJTLExA8WQ0bXDAsohQ/7oXzsiP8++UU5fi4B2+RDRPX7UO6hsIct8KKxcimKvkiOtWwcUFL1oUQhIiu4J/hHwXIWZ+XTr2c05uZsV5RpzDKq6/jHjXlL+pTwgI4RCF34qneW+ACAR2rpipzBZKWY5kwKfkDJzQjG9VKTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 17, 2025 at 10:48:08AM +0200, Thomas Weißschuh wrote: > The KUnit UAPI infrastructure starts userspace processes. > As it should be able to be built as a module, export the necessary symbols. > > Signed-off-by: Thomas Weißschuh No. This is just plain wrong. This is way too low-level; teach kernel/umh.c to provide what you need, but do *not* add more kernel_execve() callers. And the situation with ramfs needs cleaning up, but "export put_filesystem()" is not a solution.