From: Yonatan Maman <ymaman@nvidia.com>
To: "Jérôme Glisse" <jglisse@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>
Cc: Lyude Paul <lyude@redhat.com>, Danilo Krummrich <dakr@kernel.org>,
"David Airlie" <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Alistair Popple <apopple@nvidia.com>,
Ben Skeggs <bskeggs@nvidia.com>,
Michael Guralnik <michaelgur@nvidia.com>,
Or Har-Toov <ohartoov@nvidia.com>,
Daisuke Matsuda <dskmtsd@gmail.com>,
Shay Drory <shayd@nvidia.com>, <linux-mm@kvack.org>,
<linux-rdma@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<nouveau@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
"Yonatan Maman" <Ymaman@Nvidia.com>,
Gal Shalom <GalShalom@Nvidia.com>
Subject: [PATCH v2 4/5] RDMA/mlx5: Enable P2P DMA with fallback mechanism
Date: Fri, 18 Jul 2025 14:51:11 +0300 [thread overview]
Message-ID: <20250718115112.3881129-5-ymaman@nvidia.com> (raw)
In-Reply-To: <20250718115112.3881129-1-ymaman@nvidia.com>
From: Yonatan Maman <Ymaman@Nvidia.com>
Add support for P2P for MLX5 NIC devices with automatic fallback to
standard DMA when P2P mapping fails.
The change introduces P2P DMA requests by default using the
HMM_PFN_ALLOW_P2P flag. If P2P mapping fails with -EFAULT error, the
operation is retried without the P2P flag, ensuring a fallback to
standard DMA flow (using host memory).
Signed-off-by: Yonatan Maman <Ymaman@Nvidia.com>
Signed-off-by: Gal Shalom <GalShalom@Nvidia.com>
---
drivers/infiniband/hw/mlx5/odp.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/infiniband/hw/mlx5/odp.c b/drivers/infiniband/hw/mlx5/odp.c
index f6abd64f07f7..6a0171117f48 100644
--- a/drivers/infiniband/hw/mlx5/odp.c
+++ b/drivers/infiniband/hw/mlx5/odp.c
@@ -715,6 +715,10 @@ static int pagefault_real_mr(struct mlx5_ib_mr *mr, struct ib_umem_odp *odp,
if (odp->umem.writable && !downgrade)
access_mask |= HMM_PFN_WRITE;
+ /*
+ * try fault with HMM_PFN_ALLOW_P2P flag
+ */
+ access_mask |= HMM_PFN_ALLOW_P2P;
np = ib_umem_odp_map_dma_and_lock(odp, user_va, bcnt, access_mask, fault);
if (np < 0)
return np;
@@ -724,6 +728,18 @@ static int pagefault_real_mr(struct mlx5_ib_mr *mr, struct ib_umem_odp *odp,
* ib_umem_odp_map_dma_and_lock already checks this.
*/
ret = mlx5r_umr_update_xlt(mr, start_idx, np, page_shift, xlt_flags);
+ if (ret == -EFAULT) {
+ /*
+ * Indicate P2P Mapping Error, retry with no HMM_PFN_ALLOW_P2P
+ */
+ mutex_unlock(&odp->umem_mutex);
+ access_mask &= ~(HMM_PFN_ALLOW_P2P);
+ np = ib_umem_odp_map_dma_and_lock(odp, user_va, bcnt, access_mask, fault);
+ if (np < 0)
+ return np;
+ ret = mlx5r_umr_update_xlt(mr, start_idx, np, page_shift, xlt_flags);
+ }
+
mutex_unlock(&odp->umem_mutex);
if (ret < 0) {
--
2.34.1
next prev parent reply other threads:[~2025-07-18 11:52 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 11:51 [PATCH v2 0/5] *** GPU Direct RDMA (P2P DMA) for Device Private Pages *** Yonatan Maman
2025-07-18 11:51 ` [PATCH v2 1/5] mm/hmm: HMM API to enable P2P DMA for device private pages Yonatan Maman
2025-07-18 14:17 ` Matthew Wilcox
2025-07-18 14:44 ` Jason Gunthorpe
2025-07-21 0:11 ` Alistair Popple
2025-07-21 13:23 ` Matthew Wilcox
2025-07-22 0:49 ` Alistair Popple
2025-07-23 3:51 ` Jason Gunthorpe
2025-07-23 4:10 ` Alistair Popple
2025-07-24 8:52 ` David Hildenbrand
2025-07-25 0:31 ` Alistair Popple
2025-07-25 9:51 ` David Hildenbrand
2025-08-01 16:40 ` Jason Gunthorpe
2025-08-01 16:50 ` David Hildenbrand
2025-08-01 16:57 ` Jason Gunthorpe
2025-08-04 1:51 ` Alistair Popple
2025-08-05 14:09 ` Jason Gunthorpe
2025-08-04 7:48 ` David Hildenbrand
2025-07-21 6:59 ` Christoph Hellwig
2025-07-22 5:42 ` Yonatan Maman
2025-08-01 16:52 ` Jason Gunthorpe
2025-07-18 11:51 ` [PATCH v2 2/5] nouveau/dmem: HMM P2P DMA for private dev pages Yonatan Maman
2025-07-21 7:00 ` Christoph Hellwig
2025-07-22 5:23 ` Yonatan Maman
2025-07-18 11:51 ` [PATCH v2 3/5] IB/core: P2P DMA for device private pages Yonatan Maman
2025-07-18 11:51 ` Yonatan Maman [this message]
2025-07-21 7:03 ` [PATCH v2 4/5] RDMA/mlx5: Enable P2P DMA with fallback mechanism Christoph Hellwig
2025-07-23 3:55 ` Jason Gunthorpe
2025-07-24 7:30 ` Christoph Hellwig
2025-08-01 16:46 ` Jason Gunthorpe
2025-07-18 11:51 ` [PATCH v2 5/5] RDMA/mlx5: Enabling ATS for ODP memory Yonatan Maman
2025-07-20 10:30 ` [PATCH v2 0/5] *** GPU Direct RDMA (P2P DMA) for Device Private Pages *** Leon Romanovsky
2025-07-20 21:03 ` Yonatan Maman
2025-07-21 6:49 ` Leon Romanovsky
2025-07-23 4:03 ` Jason Gunthorpe
2025-07-23 8:44 ` Leon Romanovsky
2025-07-21 6:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718115112.3881129-5-ymaman@nvidia.com \
--to=ymaman@nvidia.com \
--cc=GalShalom@Nvidia.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=bskeggs@nvidia.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dskmtsd@gmail.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=michaelgur@nvidia.com \
--cc=nouveau@lists.freedesktop.org \
--cc=ohartoov@nvidia.com \
--cc=shayd@nvidia.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox