From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07674C83F34 for ; Thu, 17 Jul 2025 23:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8DC306B00A6; Thu, 17 Jul 2025 19:56:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B3CF6B00B2; Thu, 17 Jul 2025 19:56:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A26F6B00A7; Thu, 17 Jul 2025 19:56:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6584B6B00B2 for ; Thu, 17 Jul 2025 19:56:12 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 23490B7B78 for ; Thu, 17 Jul 2025 23:56:12 +0000 (UTC) X-FDA: 83675417784.10.2C74F54 Received: from buffalo.birch.relay.mailchannels.net (buffalo.birch.relay.mailchannels.net [23.83.209.24]) by imf10.hostedemail.com (Postfix) with ESMTP id 8559CC000C for ; Thu, 17 Jul 2025 23:56:09 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=qBwI34VU; spf=pass (imf10.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.24 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752796569; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7RtXfbLTQpUPXpNyLf5XdWP2Y2W1eG50TeXk0MP1i58=; b=NU/yXUOU5Ho/ppA5zb1x6pEzC+PPANo/AVvqzvzyls8mAuZFIn2LcEpLK+54UvpTfFEMK7 DB8+/cayzX96a3y4ueTUdGWAjlZ2nsf0y4j1zcFgO7H4see+dwiUKqXLFrHtj9T0mh1YNS KMtA4aLrw74qpdGUoTIscapbmcoW+ng= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=qBwI34VU; spf=pass (imf10.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.24 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1752796569; a=rsa-sha256; cv=pass; b=gDfpdf5BTshZv1rf4m83B4wUL6plqfGrKoJWJfHvs6ZkYMj4PaL8NIYB5UD2R9fMDcj1ur igM5pMp3mZ3sjZQ9TU03oMj7Dsok4i06lPN529+dZDZzREE8gy611BMALBMC+OyndC9JBi LGnIDIx4ksyF32pmAlyCecMWkAV9CvI= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 29B0D2C5271; Thu, 17 Jul 2025 23:56:08 +0000 (UTC) Received: from pdx1-sub0-mail-a241.dreamhost.com (trex-blue-4.trex.outbound.svc.cluster.local [100.120.55.68]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id ADD942C5504; Thu, 17 Jul 2025 23:56:07 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1752796567; a=rsa-sha256; cv=none; b=NRsSXWScKWUs2N7ILQaBsLnfAmaEl2yf+1zp2IvGw5TG2LaE7XxxoMtVfUodMFQbbps8+4 cSvodcFFTlFR624QN8Wup8TfpGRNwvIgTWVGIBT8NeE9H4LIcMh0VgoPIq3NGDH2wFsAhW Y0AOKyzhJmFOhGM8AHhm3giZ5/pzRaNy9zx3eELidRXXDwHLocs4YpHVFEhjWRM3+gL+i9 BTaXK2SxbNY+SQWo5EMNNdNVbnxqKkQNKb4P8y1L2W2qEzMB2tQ6ZaJwlz86QYek182V8j 2pMjzVw1Iy1Rr7kQqno7SKzqof8z+J6v+26idvip6/ItJ5ereFZq8fMSamkOUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1752796567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7RtXfbLTQpUPXpNyLf5XdWP2Y2W1eG50TeXk0MP1i58=; b=DnjoKp9GOuzBwEQ7mDN4WF4q10YoLdabqOLAZP+HaZR4mbHepyQB9q8hHrKrR045n7euY6 oEbaccFWzhMx44yINV+R3yklnbnvsgQZWq9o9WGYc7l5abL4cRt0Rmpf7dEOm4wSg/tq1p 2aNkpvnPd4Q/EnbsahYF0tvfEvaDDocjVCxLx2/RvgVnEdwGVU+k8qT1NDMAVQzPvOM+kp yPFZNlO+4lJ3P/TSmT6sPV2tVnr4wynP2y6QnNEH/5UP+ST5OBk9JYU5W8EtLIZG6yWuOw 0NTCP46PpTq11zHhm02Wqr+QqJIZk1bCZdTu8bafptYqwRRuCdA3DWR9aW9GFg== ARC-Authentication-Results: i=1; rspamd-57f6596c64-h8lcm; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Cure-Average: 736961736fca3a37_1752796567971_656183971 X-MC-Loop-Signature: 1752796567971:2821274669 X-MC-Ingress-Time: 1752796567971 Received: from pdx1-sub0-mail-a241.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.55.68 (trex/7.1.3); Thu, 17 Jul 2025 23:56:07 +0000 Received: from offworld (syn-076-167-199-067.res.spectrum.com [76.167.199.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a241.dreamhost.com (Postfix) with ESMTPSA id 4bjqZH1HtGzJZ; Thu, 17 Jul 2025 16:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1752796567; bh=7RtXfbLTQpUPXpNyLf5XdWP2Y2W1eG50TeXk0MP1i58=; h=Date:From:To:Cc:Subject:Content-Type:Content-Transfer-Encoding; b=qBwI34VUD0DC5uzOIu1kZldwGkAkFxnYvaaszgSZZXdpos78DkN9GB6YID0u4ZOiK uP9N5ASyJwXFlyqygL3sWg96AS51cY1a2L2s+gtQzqWGuea/HtH9RUErUOKVct/fCJ h5UCCicDJH/QhQQsu3GtSOTB5AZF2QMcNZuyB5e9geHHlMqUpUWZd4wsMbJvHR+uGk 8OVsjePYIN2w/Za3mnaZCP2buEev1mpoUrHOq1neeF9z3HMNcPrfnlsq8YAoo10nLs lbDlsPPC4DuwnabUA0z0o/GPyrP2KQZckNcylnIFPUIKjG9GSwRBi+pqQKobF8+ohf o06Pjtsyx2BLA== Date: Thu, 17 Jul 2025 16:56:04 -0700 From: Davidlohr Bueso To: Andrew Morton Cc: Shakeel Butt , mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/memcg: make memory.reclaim interface generic Message-ID: <20250717235604.2atyx2aobwowpge3@offworld> Mail-Followup-To: Andrew Morton , Shakeel Butt , mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250623185851.830632-1-dave@stgolabs.net> <20250623185851.830632-3-dave@stgolabs.net> <20250717155246.1f2a90c76d71b401255f11b9@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20250717155246.1f2a90c76d71b401255f11b9@linux-foundation.org> User-Agent: NeoMutt/20220429 X-Rspam-User: X-Rspamd-Queue-Id: 8559CC000C X-Rspamd-Server: rspam06 X-Stat-Signature: nsccwtmdi143munbpucuceqsd18ywnx7 X-HE-Tag: 1752796569-524823 X-HE-Meta: U2FsdGVkX19UgZxhsQfRs6R51c7dTdrNyjZyKdIMBOrcsak+oyuZWfchTkjUafEsRybd8yhXDxz+hHokuvObA/Xp0KWGBPsAlaVDgLJLs7EilBn7C2kSgpt0Q3jBDHBE9UtqU9GQMOQLF8FzQlu4kqxewts1JU0trNaDoSJliL0WLrd8OJdRZZV2NvdDtL+I+N5SXLHN6evB5S8SRgcy34YzxWzEaqbKyISX4t80WZ+XJMkZI/wQiR+FTNktw5kjniyJzN8bAQm3IqS3KxvNoDcZyjsdmG1JubQHR3jjHrxEt0iO96VH93glCkGgQ8oGADEhpQ9hRIxoiCtCDpqe/LLU6nPHMzHGofz/W74f0MZyXYg0NF8Yu0kXaa/Mi8Rc1o79Qbk4oYzcLZtpzD83ZdxxqPjmQj2o5Z/yNf+Bgz6OODyxLim2AZHgJ27+t8eRikvYC3OegF5/A08ZkEhmLvApGKAqYUNYcmW/Nnipd9Y9co6z/mvNoyrOOCNgBjbTmKGdZgn035LCUTa5Ft46T+N7t3fr9QMui6no0+if/R3r8g9Xo3HnJaUQ1KdMq0fTCKdLQIRS/0mmmcy+PUfUkhSUGi9eD+LgQzxqq2mbwVV4lJKdK5XYWFNmSSDgqc4J4BATO6ooH37jdzQQurYo92dQmNM0OB+bV39s3tAEQ+7gZtNeavp90BQRiv4qUObPKkJbRBEAM8d9m/ttFtpNFxyYIg3w3K4H7cAkM5y8HUdLIGFgvBJGKCmdSdIaBA8TSrgMLTgdDOkFsPBftrn5pYfZdS+KeyP6HAcUB1csYR6cP9pcgR8kVqJTgiOYgtFkx+NUxfqfVYt2RwFHrP1pN3pG45fZSiq5ySarRul1J7I82SD+EK3EPZZXdn/Rb5Fh6zT/A9cIddDMNzOdMOJlX4t4zup+XbMaDwlVoWmQ+Od4cFfyqWbrVliJMi8rwPRSva3WROi4og9MMkjGoCI SFr7DTfb HbtPbeDXIIUzKBhH8wSClrjMCvxumtqhjqLj1nMRKjfq/Q+u9uT7Mtl3VR1FM2k1CAxaCMUk5+Py9ecB7+Xs9ZeLqwSnEcw6rYrG73ytE1qRyZByWZxpbLneMr0Dirj3rNpM9zb/GA1l5CR2tsqyQyMm7sBPPlzr4qQAVrh4ZeE2EAXR6N4BWu3V5Yy1x69FS+Ev4s1/2ripZhBoD/aho38N4au+fCL2G6S+vLe7sOqqqSzCbmtfU/fds/09HDaYfQZWwUm3aub5F/ttewAf0/NG7pErCuox6RJV7Ln96RyZmnY7Gj9LCXDoJzg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 17 Jul 2025, Andrew Morton wrote: >On Thu, 17 Jul 2025 15:17:09 -0700 Shakeel Butt w= rote: > >> On Mon, Jun 23, 2025 at 11:58:49AM -0700, Davidlohr Bueso wrote: >> > + >> > +int user_proactive_reclaim(char *buf, struct mem_cgroup *memcg, pg_da= ta_t *pgdat) >> > +{ >> > + unsigned int nr_retries =3D MAX_RECLAIM_RETRIES; >> > + unsigned long nr_to_reclaim, nr_reclaimed =3D 0; >> > + int swappiness =3D -1; >> > + char *old_buf, *start; >> > + substring_t args[MAX_OPT_ARGS]; >> > + >> > + if (!buf || (!memcg && !pgdat)) >> >> I don't think this series is adding a use-case where both memcg and >> pgdat are non-NULL, so let's error out on that as well. > >As a followup, please. This has been in -next for four weeks and I'd >prefer not to have to route around it (again). > =46rom: Davidlohr Bueso Date: Thu, 17 Jul 2025 16:53:24 -0700 Subject: [PATCH] mm-introduce-per-node-proactive-reclaim-interface-fix Both memcg and node is also a bogus case, per Shakeel. Signed-off-by: Davidlohr Bueso --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 4598d18ba256..d5f7b1703234 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -7758,7 +7758,7 @@ int user_proactive_reclaim(char *buf, substring_t args[MAX_OPT_ARGS]; gfp_t gfp_mask =3D GFP_KERNEL; =20 - if (!buf || (!memcg && !pgdat)) + if (!buf || (!memcg && !pgdat) || (memcg && pgdat)) return -EINVAL; =20 buf =3D strstrip(buf); --=20 2.39.5