From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08E6DC83F1A for ; Thu, 17 Jul 2025 16:26:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 875D48D0006; Thu, 17 Jul 2025 12:26:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 84D448D0001; Thu, 17 Jul 2025 12:26:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 763398D0006; Thu, 17 Jul 2025 12:26:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 684848D0001 for ; Thu, 17 Jul 2025 12:26:47 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2649880146 for ; Thu, 17 Jul 2025 16:26:47 +0000 (UTC) X-FDA: 83674285254.23.ED9D572 Received: from purple.birch.relay.mailchannels.net (purple.birch.relay.mailchannels.net [23.83.209.150]) by imf11.hostedemail.com (Postfix) with ESMTP id A0F2D4000D for ; Thu, 17 Jul 2025 16:26:44 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=cebLjYnC; dmarc=none; spf=pass (imf11.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.150 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1752769604; a=rsa-sha256; cv=pass; b=oVMtzuHOI7BJwN+VwXzO8HGumZvncUsEyzLZJapxV3bwpa7ZJuJJg0cW745B1DP5hbMiaN RQJdcNDwnF/SoL9HouzBAMcBNMxV+WUacgmj3ZEmHTLWIB7d2ly+ZaOnIR7FJc3gtDW3nQ m86vm2VmQ70BQwKcB6KhbV1Sjs6sz3c= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=cebLjYnC; dmarc=none; spf=pass (imf11.hostedemail.com: domain of dave@stgolabs.net designates 23.83.209.150 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752769604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=taTsbv8PIuQoZTsYWPkbrlOV1XuZ5ae2zw2+O37gSmU=; b=kmBvylIMryXKtFLa8Q+zT1F08/BefIKPyGWLbisCvZPaz0Zlfht08xn0VlWcG4lY93RMbB Wr/uYk99U3tC3N7IP/G8wnhlD0e7fi9dfuY+rtFxZRm/QFuYO4mgIYUhR0K7y+sNhbou2K 74EgGY/Mt/0YP3dYTmUhtUzh4qz/kjQ= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0A3C825211; Thu, 17 Jul 2025 16:26:43 +0000 (UTC) Received: from pdx1-sub0-mail-a235.dreamhost.com (trex-blue-1.trex.outbound.svc.cluster.local [100.120.34.184]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7BB2325490; Thu, 17 Jul 2025 16:26:40 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1752769602; a=rsa-sha256; cv=none; b=8SNnunmW3glvOQGheYQArNqKaFIV9vu1j9xUv4AC2DMJ4e0yAscjAUt2uNH8CNVfRbL0+1 TkNelkY+I5DCwXRhbmHqG0zlpIhL7/Oa8CogwRsFRr3IBOf1+FlSB8/4g46vE/C/bv7RmB CxxL33B/N/j9jdvySdsyho0bPtPMdG+A5sdlY2DFqdBDJctyZsBUcfx6e40GojWdz/vHfm 3alQJXFNB7LuF7sbI2Wm5U76XX4jYXtKVaUdmRbzFqdQeD8gdU5QqUWynCOjtsEsOtl5gP 8H0XE7N9nI3art4ilQ/qSMsWW/5FxSvZBhvpGgc75EO1a17/RzVBZXBJ4BhyEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1752769602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=taTsbv8PIuQoZTsYWPkbrlOV1XuZ5ae2zw2+O37gSmU=; b=R5GXCWgJOKGI7tEpnwH38NX59lm8WFocPPvNe6HK9zfXqHhbYg8Mt9rix3dbbk/twIwbvJ H7IK3iSATNH/cUtUT4lGK2MGvZTidz1l86O1RLNkdK/iRm+kPvgZBtxDGdx+XJiI2/ZDiK ve2QJ9zcj4ZjcYP4TN0TrGdl1nV81cqug8kyCTYkMvmo3fCKMkjOr99d/MB7l81dOxy+0W wZeAAAUl/ORl3Hb3Q6+oHyRicI7lJN0tCXyT5MGpbLX56NRgXB27dkz2blNcNyJeFYtd3v SIPrfqXeH2rwk005n7SrHRWvXhkkMvxVAMWsdPPDvgBVo5fmSIfPDH+2D4PksA== ARC-Authentication-Results: i=1; rspamd-57f6596c64-rd56w; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Chief-Tart: 2182cc7943e98074_1752769602819_2687924055 X-MC-Loop-Signature: 1752769602819:3382800013 X-MC-Ingress-Time: 1752769602819 Received: from pdx1-sub0-mail-a235.dreamhost.com (sub3.homie.mail.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.34.184 (trex/7.1.3); Thu, 17 Jul 2025 16:26:42 +0000 Received: from offworld (syn-076-167-199-067.res.spectrum.com [76.167.199.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a235.dreamhost.com (Postfix) with ESMTPSA id 4bjdbg6JpDzFr; Thu, 17 Jul 2025 09:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1752769600; bh=taTsbv8PIuQoZTsYWPkbrlOV1XuZ5ae2zw2+O37gSmU=; h=Date:From:To:Cc:Subject:Content-Type; b=cebLjYnC/cOReCK80TuPLfcrbAmyXLngzjEMblTHmfk0ILG6pygdHWD0VJJfK34pe 0v50QvLGbWyL/i3pgRh4dRr1jooSHpDzWYxaerf0CuHlnZcdA4QCNFNLmPSqWH40DU N7qQ/n71tHqXwFruPYW3b46EYMEBlAz5dAIemsrtRLLkYvkYAWE4rGCWvXQIuRXl9F 0k/T1LdK5vS8oBnY5ExY48PFsETmPORnBpL+6czCTjCC3G6JaFTedo/B9MSXjAxihx PtQzLP1zPy+UtlJlBLykAvZkOMpSutRR4rShlWoEUZDmtxP0Fz/6XDKKDAwvU5oEtZ HOKRkH2GHI9Zg== Date: Thu, 17 Jul 2025 09:26:37 -0700 From: Davidlohr Bueso To: Roman Gushchin Cc: akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, shakeel.butt@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mm: introduce per-node proactive reclaim interface Message-ID: <20250717162637.xz77hsj2byamivgm@offworld> Mail-Followup-To: Roman Gushchin , akpm@linux-foundation.org, mhocko@kernel.org, hannes@cmpxchg.org, shakeel.butt@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250623185851.830632-1-dave@stgolabs.net> <20250623185851.830632-5-dave@stgolabs.net> <87qzyfr0u6.fsf@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <87qzyfr0u6.fsf@linux.dev> User-Agent: NeoMutt/20220429 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A0F2D4000D X-Stat-Signature: 7m1kckwkme4c6hjh1ar8e5iwkt4ofz3x X-HE-Tag: 1752769604-133507 X-HE-Meta: U2FsdGVkX1+4mw/64wzzNHmpOUHBft61J31Xk3rmTIwPg3Fb7EngjAcxf93AjP5FVVHKdLREsPsY3WlhnNChmBf1L0fSbyVefAvh48nYqo2qXyNEISL66d9hzT5J7OMqBakKXH508s7YAly3NWmuI2hfDGaGQrctX36F32Z9IQdejpcYwKwCLPtfc3mMpwHF6zLBaRso7uGIbwep/ae+KMsM/A/lrBqCgdBeEowVculmaTaM/HPeN1mSMmAPTtih8yslgDrBkgqSovNYpE9aqECpw4mxs6ZvmKZtzxeopFvPmANmU8adt8Z4l/SsJs6+B+FUggMlgxm/igtr74+shXuCLeJtuXOauqHMR7rEE56uX6FqM3ZQwuB68+VVZ8zRFZv1MHl9g4kk7DuicHPL5u/gtmCBi/MQLb2pgFdnqPNNXvEiB1VUFwpYi9WowTYVYpcl9CWKjMTqH/QjAaMvOdMh6g65Bhgjb2sx/r9upvTOH+wtpMZlwqEpJ//QETWLBi2jxT7EBcBZzP8ZlFu23yt2zgzYiJLJDjcNb0fIZycXlHwUi7rWF428I86FXVKjg3KH2CgmCogMM6P72Qfg/MDTP1pfO92p1wqE1Pbeb7t/JTsTFfINbFOTS4dQqxD2QrbRkENi+aNbCi8zz6RQ64a98e6wNnrZDk0cXf5yNzZKS9m6jGzy/RpCzZgJ1W3tYDflKF2YG9J9M5qdYTy2bq/J3z+g3FoNhq7qOh4r5ELMNFbWD4p3z5bumq5duL5rHLj40oGCsya3Nx6FUlg9Du0aflJHdFVi0qmiN+B/H1xMPyBVlU8A1J1dj+cvneHTHUYab5CLfuy0142Fyra4NkBUTM6e451/BwVjiw9v8GsnlgYhdP+JUOT3TCu7kaVlubhp3YUJZQ6UpreSBetEhygGMZu9T/YuDq1B18VUm7+E9VmvNX/TpN5ZvUv64RSPy+JredonO7ujb0zA9Z/ 8sk4PW1H QsqhIpnIoGGA77LBSXKA73F09LRr3deoB4Y+5dbbqQrhq+QworxGcze8mZ5vus0/n+z1wId06VACsA2jHhUDnOPEMT3d2Kz4+CD3gT2NS+g1ByQalii7oGXcXo4eDXx7jDPqVUSiOTJq6TNWUfKmS0DFbv3COVegEcT0KpJZd/gUMgUIjZW+/ll5KyTy/lrBt70FTKRfExCrOScyXKwK0iRGUfPwgOSNOraN87XqUxgw+0EtT5kBXw5kPfwxUa4j/kse3d4KQYHLpFJHMzPGZGOX2DKLBmvz1FZVxHd2/WLxTf9AFE47L7Vpl8RPcKYT/66sUqaX1PnQusMP7/j5dFcAnQ489TZZjGzOY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Jul 2025, Roman Gushchin wrote: >Davidlohr Bueso writes: >> @@ -7792,11 +7792,29 @@ int user_proactive_reclaim(char *buf, struct mem_cgroup *memcg, pg_data_t *pgdat >> reclaim_options = MEMCG_RECLAIM_MAY_SWAP | >> MEMCG_RECLAIM_PROACTIVE; >> reclaimed = try_to_free_mem_cgroup_pages(memcg, >> - batch_size, GFP_KERNEL, >> + batch_size, gfp_mask, >> reclaim_options, >> swappiness == -1 ? NULL : &swappiness); >> } else { >> - return -EINVAL; >> + struct scan_control sc = { >> + .gfp_mask = current_gfp_context(gfp_mask), >> + .reclaim_idx = gfp_zone(gfp_mask), >> + .proactive_swappiness = swappiness == -1 ? NULL : &swappiness, >> + .priority = DEF_PRIORITY, >> + .may_writepage = !laptop_mode, >> + .nr_to_reclaim = max(batch_size, SWAP_CLUSTER_MAX), >> + .may_unmap = 1, >> + .may_swap = 1, >> + .proactive = 1, >> + }; >> + >> + if (test_and_set_bit_lock(PGDAT_RECLAIM_LOCKED, >> + &pgdat->flags)) >> + return -EAGAIN; > >Isn't EBUSY a better choice here? >At least to distinguish between no reclaimable memory left and >somebody else is abusing the same interface cases. Yes, I agree. Thanks, Davidlohr