From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E4BFC83F1A for ; Thu, 17 Jul 2025 16:24:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03AAA6B00BB; Thu, 17 Jul 2025 12:24:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00B376B00BC; Thu, 17 Jul 2025 12:24:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E63906B00BD; Thu, 17 Jul 2025 12:24:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D98F36B00BB for ; Thu, 17 Jul 2025 12:24:24 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AEA2910BBB3 for ; Thu, 17 Jul 2025 16:24:24 +0000 (UTC) X-FDA: 83674279248.13.74E206F Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf27.hostedemail.com (Postfix) with ESMTP id 4F50140018 for ; Thu, 17 Jul 2025 16:24:23 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cw3u2fdc; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752769463; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nFDkXS0oEG3lKsWS+7GLTu/ZgBh64kRpO5R1ePwDmUo=; b=wuYfhh3M/rED4YPxd9BK5aVrlM78c5InAt56QUQylTtGG1qdkkfVzgD9KgSwfY4DNjPStT R4kym9iuY9lF59Kk1C4RLEBKKa6GogYGzjRtYnLaCjgcX8x1fyl3HuNfLheuQIxNB9bwBl Jf+nkwXVF3+7AfiZ6KZ3T9GKFiiM/b8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752769463; a=rsa-sha256; cv=none; b=cahACa0PGsmGcbsWsUMOwC98kpBxMdEZplMyVvZGojGxguKpgWccAkdUQwQzNgaIVXzMWJ VXz2428EHiq61UC3T50Duyi7itFrtLd0vh+YA5B4cHQnrXZOMyR/tuAXy6033r9iLicpWg rwLiGafQSMImVDp+4Z/T17LzhoOq67A= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cw3u2fdc; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 93AAA613EF; Thu, 17 Jul 2025 16:24:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EB75C4CEE3; Thu, 17 Jul 2025 16:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752769462; bh=SlRUX2QyUFuoWdG6+bh41PuWc7RBR2qIqJuigQAHpAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cw3u2fdcZRlIVgwq9ee67CnU/L3kQKvlgjOFKhIxC7mX5BUYUD8z06OyooTphapbo PqNrhTuMp1y+WhyBUh/Jupq9irxxim5E0c9evkx8FzgNhgjF1YYErHT6aMLtZOJ7bj kTaHF73sbpf7yfwQXJVf8mjzXDxVTzTMR5tqMUpfs9uo4LFaATkVXEKO/B0mdJ/m4K gee/hEWxuCDlkLTwu0D6nopryjzREnKKEV600ZOK1QB3OqRRWDel2z8vXCrmRacg5y 3t3/20trtTvatWAODt6roekSG2EE4VZrcNUa8L+iBCHeuE01Op7666UqnmQUcMHKNx qeMQqq0XO/0SQ== From: SeongJae Park To: Enze Li Cc: SeongJae Park , shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, enze.li@gmx.com Subject: Re: [PATCH] selftests/damon: introduce _common.sh to host shared function Date: Thu, 17 Jul 2025 09:24:18 -0700 Message-Id: <20250717162418.64271-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250717091902.104466-1-lienze@kylinos.cn> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4F50140018 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: fdcyhyjn85syr1bem4ix1yees645ecqy X-HE-Tag: 1752769463-15722 X-HE-Meta: U2FsdGVkX1/U3XLnwEh9r7MvpkA7mXdzyRkkjs5cKq0BawijWNQDrreZ0xtrMRmGblLK++BptrCWe98pUEsln8JnfCKHcCnjLWt092muowhuNjc+g9gx0Ueycfpqsj2IqXmWktUPf/Kq4PSNat4eiwiDKJnFsiQBDC5heZu2rfpHDQp8C8pp4/jcDLafHetZxSRqd7PjxgxSJnACyrhcttqypE1tpI6ka8DgIFvwwSaDc4AmF0ky3yMixbXOZVTO7gNCQLQWXNEOOMZL4eNsTvWXGAVNcbucEI/kRl3+BvadljLrpOOpFuTi64XWEFjocnLKws/F4L3a045LVYhlAZN61YA17d3qhWtd5A58cB3BupshZkxI9/DQPjjP1DHdVgrSz8xxJciWfj0eBit11+2UnlUTC++yJlXMFAGZsvW81oGgOP6EADBlKBBqTlzxueYW8XYP6KRGE2HyuS0ieFD6nWbs5DAPOqkSKmMWhWgZonA8/oLmsqzeJe08pK0JaduOFHFp/KzFnkUOFzdk4utfugjtL9qV4kBT0rqHMkA5lRNGch6+v4IPjgosuP9K9zFSR027VC1XRK340ewOy/AfRiK3xx33G6WQHhb3jEytiP3P5OQEf3YsXmvo3cGkym0yamzZUToPXwOrMSA1LErFYMAPJpNb0KNkj3J4i6k28hbbo1Ypki0gERadYmy6avuUISs9a6MNVK7czbeTQPXo2brewacfWO5Lo/iMpGnHoIH/O6xpX7TLULgKSX6dTtIX34uhl1uZz41CEVZMdDov2TFuSp2vtl9VAm8My1HMNEiejGA8wOOh/piAnEDH00nnbAlimyJuTD+7BenZUyFkgH54a5+CGj3r4LqCwLRkz3auoV0FtpW+43hV2Iizh4kO7VuUVcod+KqWDJLOVr5r3KdeIa/me8s5XjSId082AKAyTTKWRHHvKidWAwrPcouHnohAqLVRWF2+5oN JZ6hNL4N N+dj2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Enze, On Thu, 17 Jul 2025 17:19:02 +0800 Enze Li wrote: > The current test scripts contain duplicated root permission checks > in multiple locations. This patch consolidates these checks into > _common.sh to eliminate code redundancy. Thank you for this patch! > > Signed-off-by: Enze Li > --- > tools/testing/selftests/damon/_common.sh | 14 ++++++++++++++ > tools/testing/selftests/damon/lru_sort.sh | 9 ++------- > tools/testing/selftests/damon/reclaim.sh | 9 ++------- > tools/testing/selftests/damon/sysfs.sh | 12 +----------- > .../damon/sysfs_update_removed_scheme_dir.sh | 9 ++------- > 5 files changed, 21 insertions(+), 32 deletions(-) > create mode 100644 tools/testing/selftests/damon/_common.sh > > diff --git a/tools/testing/selftests/damon/_common.sh b/tools/testing/selftests/damon/_common.sh > new file mode 100644 > index 000000000000..3920b619c30f > --- /dev/null > +++ b/tools/testing/selftests/damon/_common.sh > @@ -0,0 +1,14 @@ > +#!/bin/bash > +# SPDX-License-Identifier: GPL-2.0 > + > +# Kselftest frmework requirement - SKIP code is 4. > +ksft_skip=4 > + > +check_dependencies() > +{ > + if [ $EUID -ne 0 ] > + then > + echo "Run as root" > + exit $ksft_skip > + fi > +} > diff --git a/tools/testing/selftests/damon/lru_sort.sh b/tools/testing/selftests/damon/lru_sort.sh > index 61b80197c896..0d128d809fd3 100755 > --- a/tools/testing/selftests/damon/lru_sort.sh > +++ b/tools/testing/selftests/damon/lru_sort.sh > @@ -1,14 +1,9 @@ > #!/bin/bash > # SPDX-License-Identifier: GPL-2.0 > > -# Kselftest framework requirement - SKIP code is 4. > -ksft_skip=4 As Joshua also pointed out, let's keep ksft_skip definition in each file, unless there is no more use of the variable. > +source _common.sh > > -if [ $EUID -ne 0 ] > -then > - echo "Run as root" > - exit $ksft_skip > -fi > +check_dependencies > > damon_lru_sort_enabled="/sys/module/damon_lru_sort/parameters/enabled" > if [ ! -f "$damon_lru_sort_enabled" ] [...] Other than ksft_skip, looks good to me. Looking forward to your next version :) Thanks, SJ