From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2C7EC83F1A for ; Thu, 17 Jul 2025 22:52:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 336FE6B009D; Thu, 17 Jul 2025 18:52:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E5D36B00A2; Thu, 17 Jul 2025 18:52:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FD6D6B00A0; Thu, 17 Jul 2025 18:52:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 084076B009C for ; Thu, 17 Jul 2025 18:52:50 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A2682160285 for ; Thu, 17 Jul 2025 22:52:49 +0000 (UTC) X-FDA: 83675258058.12.0B0DE50 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf04.hostedemail.com (Postfix) with ESMTP id E41744000E for ; Thu, 17 Jul 2025 22:52:47 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JCMJhbXa; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752792768; a=rsa-sha256; cv=none; b=iRROGV/nYdJz4V/GongIxmJbZCxZH/evIE0Tgq2sgEwArzKT4/qX2wYnANvMNBptiLuZWH D2JoiPlSMmd8lV6+fc4d1o8V5lyYa35EIgKj8ZLsRwHYCwJ+WSulcAFgYcFPnSoudPf5cD p6Sobrp5MO/q9UfUaak2dDwYZYvSspo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JCMJhbXa; dmarc=none; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752792768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IQ1nuavDHij82ni/NB138j3S596IiKE/JCWuhNErabs=; b=JfDmC+uKhGPsEDqV1bN2xllzeOttfitfono0ml8K3uXhoCsC6LQ08eDEZ1XBZ8BOBVlBkp jEM4E6K/Ga/t8pAfsxoTREpbxhwpdyk00a9XQk72W3jYBHj8qtfwZ809qvLWGw/wICVsmu y4JwYrVwfiOvZnSGfLIcoaZj652jI1o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id E00CC440F4; Thu, 17 Jul 2025 22:52:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 816E9C4CEE3; Thu, 17 Jul 2025 22:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1752792766; bh=CSmc0JHp5Ls90DfiJWQpBqfObYBdpwcTd8QjfaVqd/I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JCMJhbXa7A202WishAfZaEuYxgBXTQ4WKne9zG5wtdJAkxYzfJcYxUh+rvT7QUKY6 0zs+IVKaWvl3b/NGvROX2pHwIP5eKqOs3NrGr6Z63VPtpGyX0L4H/UO0euEFu75cjN 7JbVT5FndhbLxQVPr/kYjYtallxbkOXPwE0i/ewk= Date: Thu, 17 Jul 2025 15:52:46 -0700 From: Andrew Morton To: Shakeel Butt Cc: Davidlohr Bueso , mhocko@kernel.org, hannes@cmpxchg.org, roman.gushchin@linux.dev, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] mm/memcg: make memory.reclaim interface generic Message-Id: <20250717155246.1f2a90c76d71b401255f11b9@linux-foundation.org> In-Reply-To: References: <20250623185851.830632-1-dave@stgolabs.net> <20250623185851.830632-3-dave@stgolabs.net> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E41744000E X-Stat-Signature: jsomhuq56rw5d7zjab98nn3r71hgroww X-HE-Tag: 1752792767-234285 X-HE-Meta: U2FsdGVkX183LCHAzGQ8KABglf1keG19yYl3LrdXZJbva4PsIo6hjJ44Cz/pcJKSvb0bHcA90vPQT/CUKV5Po1xoBdBf93hYDmC46MQDrS436og+uEySeHEt+NKvzq72YSqeYwUoBcM/7SmmeKrfBzhx6WmN0i7Jck8EpzLAoTuJlRxGmF8at2IC/IC+ReCT6peGH53muNbeN0xz6LTMpRuBPLEQWv5X0QJFCPB0TlB6n8F5l4K/Xmy22wmFepL5/QwYcKqmt8ME5IOMhjKB598IGr9scgbYs+H7Pha6IHvLLKOm+Xj3qJ0qCVspNNi7oftPAapW54ktWyX7IDUtJu76d0y9sF8H0B2LLa/DrsjaCP/BCh0VeMqdC8+6l07v7rWP1HXnwOerxbXoJuRzrEA162RY8O3He88H6ZlqmABs0lr4eJvVTSip4ShYw5hLS8B5rmIzHA3TDSDbdR89Ilra03aGXZ1SIYxfE5CnwFoERXQzvUiaZiGqsFHobq+KlZMXaohNTzD0SDno2ybVj4QtKnJeLRHAnqv6PsnYTlP5pksudP7Pu6HYxj7BfyXA5nVT7OFb5ToFvIjIKpFN8QCK72A8Ty1iLOcDYW3koPtmzuD1LmjG6UMmp6sHpmc8TcyIt+slnd955JIKnLPZ+TZajtveN9aI6SgzEG61aoaIlueOWa8RFMIdeTtv5G4ws10TjS2Gexio8aeciEPVexa7NkE90VhOLgl5GlHwgyGGpVcYd1pgOHmYw0r/IF4EB8GVQKg3jVcmIMOcmQUaJPCkDYcun/VP0WQ6dWpXwByo6851lVGzP2wTScjfY4W6iJ6Or4humJNgtiMG0+nVhjcAimiIr5eP0yqMbpfPCvfbjrHP1EfjWXzBx3Q5/hVawittmTS67SrGF18yc/5Au+2AGMOic/Tv7TjL6ewXUzaQ9Wt5olcJyDsn2XycSCVo/DhjHVMN0xK4EL9/yhg gt7Qzrv0 pPHIgzWAR482tkm7scFQcLkRIJT4LRLQ7chSXzbpOLwUqs2pw5p/X2LtorVbnqque2pfcFH1Vc+IqDINWfLdezeiC2ZHS61ZsYPy4+lVR0anXzkJILSXvMvi5rU6RJ8ZsLs8Qk4+uyzUXeFGwpMBESWQoxefdBfA0O4xKKz8k4F6ZoHQhwjmtK9AnQe7U3vOREjMaPkTRKBFQ1AmgWmkEeRqeByiGHxSVNF7gNlZUAyzcvZ4yPhwxlAdTQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 17 Jul 2025 15:17:09 -0700 Shakeel Butt wrote: > On Mon, Jun 23, 2025 at 11:58:49AM -0700, Davidlohr Bueso wrote: > > + > > +int user_proactive_reclaim(char *buf, struct mem_cgroup *memcg, pg_data_t *pgdat) > > +{ > > + unsigned int nr_retries = MAX_RECLAIM_RETRIES; > > + unsigned long nr_to_reclaim, nr_reclaimed = 0; > > + int swappiness = -1; > > + char *old_buf, *start; > > + substring_t args[MAX_OPT_ARGS]; > > + > > + if (!buf || (!memcg && !pgdat)) > > I don't think this series is adding a use-case where both memcg and > pgdat are non-NULL, so let's error out on that as well. As a followup, please. This has been in -next for four weeks and I'd prefer not to have to route around it (again).