From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0936DC83F1A for ; Thu, 17 Jul 2025 22:36:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A65E8D0002; Thu, 17 Jul 2025 18:36:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 956538D0001; Thu, 17 Jul 2025 18:36:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86CB08D0002; Thu, 17 Jul 2025 18:36:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 779E78D0001 for ; Thu, 17 Jul 2025 18:36:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1B3FA1601C7 for ; Thu, 17 Jul 2025 22:36:00 +0000 (UTC) X-FDA: 83675215680.16.02FCD34 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf03.hostedemail.com (Postfix) with ESMTP id 8288B2000E for ; Thu, 17 Jul 2025 22:35:58 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wjGC60aX; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752791758; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7a8mEduuugkdxYqlvAzxCYjjbL8ZW2eN+R1l7qCZXOA=; b=ouIrnHF2gLuxrlko/FXXY/BwJ5OSvelEGNxy3LZqCj/82VU8VA5dHr11baQoVxKYahtAti oMq5lGQenjB2BMgGjRCkI5MyNTjUql51hDTi72/wUvZcyqrjBqQEPo5kgTCPEr4qnUfHTu cEi6mwxSyNueGqy9/xeKJsCNZDOA7Os= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752791758; a=rsa-sha256; cv=none; b=Z4vUls3Tst40W1ESE/gBzGerWtWfE3kNCyDrUGRzw2gT2Bn1RVTvykHSuxCvoZaqAwdpiD ZCO02kKLt6eaf8dXOoupFthSVdXkGCYd91fqmhVm8sx483GtM9S7Y2ewrdGD/oHdkR0SJ9 enIlQVHW6Soc1vbXm6ch7b33Dxc0tpE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wjGC60aX; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id AB49760208; Thu, 17 Jul 2025 22:35:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B13FCC4CEE3; Thu, 17 Jul 2025 22:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1752791757; bh=Ey4NtoW0iae8Zcou1NVxFFvN4khbn8Mk3VWY0dDuxn0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wjGC60aXfpUKsGrjtYmKJoRNK7BkOm9Rz9u/1G2VPzrEm+eA0rVtmxCeWy9G4z49N 4TmWIBLOHG7xyA7H5Mzknft8+6O76uAu9thHtQEPBK+md2z492EojdWthh9nkOSwU0 W3c5Jch7dYIhyFq9K45oRXKClHMZLSnQFAqIYhy0= Date: Thu, 17 Jul 2025 15:35:55 -0700 From: Andrew Morton To: Lorenzo Stoakes Cc: Balbir Singh , Zi Yan , David Hildenbrand , linux-mm@kvack.org, Hugh Dickins , Kirill Shutemov , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] __folio_split() clean up. Message-Id: <20250717153555.18676fbf351eef2286b33cdb@linux-foundation.org> In-Reply-To: <1cb14f22-bb17-4997-bfb3-6f1d1f984d3c@lucifer.local> References: <20250714171823.3626213-1-ziy@nvidia.com> <1cb14f22-bb17-4997-bfb3-6f1d1f984d3c@lucifer.local> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8288B2000E X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: swideatdo675e4omskf9w3knbs443h8c X-HE-Tag: 1752791758-767329 X-HE-Meta: U2FsdGVkX18oJ1QqwMqhfRrBW5CXab9PnDVxNPvdtvK3nfTzO88AoKQwYELQ9r8NQcmbN/MdiPHKTyjfVggfsng5G9SXvHZzVqyuodu3jmTe2+Gvc9pI8IEKhWz0IUhzAbpAPaC2diAqT/zwUn9cfQ7PGX6aa2bqv0Wnfx7WGAP2yBV//IdULFlAo3nXl4m01WEDtBJiCKDzK7ZBsf35YaEmsJ70PDg3bzgoUUmnWSyglsBn3X9HAoSgfKc+tiKb7hPqVQQzijSd2BrP1whnDQpFbWZWrfoH74EzAQfO67nBOL9RQgzq2ivJwyL3sdPfN2LYgtP3WG2RXgHAvJMoP7uUNaCuIjkNTal4exf0YKL7z3V/3yhxmp+4oqN3nPJ0zPKQ7TZ5R7eAIugBKUxtfPkSDjs9rI0DrI1FjDZhW2MFC/Zrb4t1ZPkaKF2RfVcKXMP/qCKP5LiKEHwfu/eBMP/pVSJ0pxJbGqxQqCmD2d+SmIbEftzG5uC7VsuhZZtHYswzSk229PXQUmzgqQ6BHvoMRL3QNgnAkmkALnV8JmOKSzJovUb/1srZp6JJKmLbTU2lHtAIzB+bYZz+BerTLCXkaZiNdMDO0FoRHbRQ59crOHtL0psFmqeyBwBzhQqhwUEXDTAita9e9NxI585WaNhyZv5kHGz2e1U2w8QprrCn1P8M1NA4/7K0B3SOYTqesFc4exvwVdJFyeT7oj410vWZxV/lAWvf1Ohvuvb7NODjSg5vx09O3fjA2xLjXwOwBWwZQZDGvs3Lzowg4Xo5PgO1xoiAftH4E6PIHR8aeqi+t+8H/f60uIOBTwC0njzKDAFn0SdhbmncQ7O5nlnQ8Hc/yFszK63n4PH3GuETBIBlfxmEaTImMJJwBK72mjr9Ln6RoAfM1TfkCB+Ztgw1YZ1y8zglFp35l22Gg/U4qN0uDyNA6PtP/1l00rspSzKP+fEAfc1Vl2NOvTKMSGM UFiVbprZ IZAlK2d5q2fUWIMaLJITpzPTLfkEsybYmFRUpYwh4Orc6jRE7W12XskHD/weE10/pF7/eamDruY+RFdJjXydibcOKbuFDrhnPE44P0nCkk6K/DiyO1Qm2MMLyDV4nTLp15v22SjC3kQVBxsymwbx0Qbo28POrLAYPwAX9TX/LwFlQHcs9R2M+SMo3FODy/Hs8OrTncp9M4efIxBxSrC0pq5woo/M/BirINhEHjwoZT7YbrHN2Mrm4tNKmUvo4Ws8OHasO0uMCr7dcXcLV98cQAfe6c/YrsXrzFkQsTTYcpQnqBexTBp1wANwPIaok8lvi47kbCZtGQOZu9dke3UGEc9DEKdKX8IRo+IArZeDe2+FzJHw0ORgs7sdTWZEtbJvH2Akik/eSlH3QPRw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 17 Jul 2025 13:40:55 +0100 Lorenzo Stoakes wrote: > The patches are in the correct order, but the 2/2 patch, 'mm/huge_memory: use > folio_expected_ref_count() to calculate ref_count.' contains the cover letter > and has the suffix: > > This patch (of 2): > > Instead of open coding the ref_count calculation, use > folio_expected_ref_count() > > But immediately prior to it is 1/2 - mm/huge_memory: move unrelated code > out of __split_unmapped_folio() but with no cover letter reference. Doh, I placed the [0/2] inside [2/2] instead of [1/2]. Fixed, I'll hang onto the v3 series - it already has a TBU (to be updated) akpm-note-to-self.