From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA2FC83F1A for ; Thu, 17 Jul 2025 09:19:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C8AF8D0018; Thu, 17 Jul 2025 05:19:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 579A58D0001; Thu, 17 Jul 2025 05:19:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 442BC8D0018; Thu, 17 Jul 2025 05:19:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 314D68D0001 for ; Thu, 17 Jul 2025 05:19:44 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CEC7A12E9B2 for ; Thu, 17 Jul 2025 09:19:43 +0000 (UTC) X-FDA: 83673209046.06.DF775A2 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf27.hostedemail.com (Postfix) with ESMTP id 1E69F4000B for ; Thu, 17 Jul 2025 09:19:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; spf=pass (imf27.hostedemail.com: domain of lienze@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=lienze@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752743981; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=ZjIbFFlAk383AMBIg6BbOh+tlGcO2pZHimWGk6oA20A=; b=RFf1g6xE8UdmHEPZXe6WmxXFxVnHVE/eNiam+Lm7aBl6s97QCC2bNRh3IJpOgoKm3Yioef p1lkj7kjd2q3LJlI/NdIVyqBQ4NJ3z3dN2GGVaTlSsM94hiYqvzJTfCylQxU6lo3N9ypkt 0l6A37bD6/i6QiQzKBZcNqwBX9n9NW0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752743981; a=rsa-sha256; cv=none; b=FHt20LlK3kN7s0ARIdWQRodaZc/PcauiLKEJU8ilur6HxiQIPsrEy+9sa2K9f+MMloyEsY gSnnsRlZFz0NYq07WUnY3XWBS9V/0iQkglJecbPxp+C8xLWYFJ0rny2SYSJl2tTtykibyk 0JvJ1wxhom/0d9zTLLcvSp2H9Z6UgFw= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf27.hostedemail.com: domain of lienze@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=lienze@kylinos.cn X-UUID: 2466df3862ef11f0b29709d653e92f7d-20250717 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_TRUSTED, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS CIE_BAD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:d1cc04a4-92c2-4a47-9981-69cf60e6f942,IP:10, URL:0,TC:0,Content:31,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:26 X-CID-INFO: VERSION:1.1.45,REQID:d1cc04a4-92c2-4a47-9981-69cf60e6f942,IP:10,UR L:0,TC:0,Content:31,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:26 X-CID-META: VersionHash:6493067,CLOUDID:ad2b09e67e01a10f9c39128f94cd93f4,BulkI D:2507171717256IUM6FKL,BulkQuantity:1,Recheck:0,SF:17|19|24|44|66|78|102,T C:nil,Content:4|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:40,QS:nil,BEC:n il,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 2466df3862ef11f0b29709d653e92f7d-20250717 X-User: lienze@kylinos.cn Received: from kylin.. [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 334625521; Thu, 17 Jul 2025 17:19:29 +0800 From: Enze Li To: sj@kernel.org, shuah@kernel.org Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, enze.li@gmx.com, Enze Li Subject: [PATCH] selftests/damon: introduce _common.sh to host shared function Date: Thu, 17 Jul 2025 17:19:02 +0800 Message-ID: <20250717091902.104466-1-lienze@kylinos.cn> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 1E69F4000B X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: cwnxztw9qtx4owybhr4fwy7kpsd7wtyt X-HE-Tag: 1752743979-234639 X-HE-Meta: U2FsdGVkX1+ZibG3Tei0ji43WxFpzVpOzJCS6eATmajgegfW3tH0xWBb4QHwwOr+d38Zd9XXc3i7YDYlZsUAGqmO4miTSeifnPxrbjX+7zlEVB8zINVH2hdVYCxsGqMoGnytDEAYUFLIdJ3DfdUJQG37TfR8EBYg1oYJqaU7Mfb+BURzOL/LzYVMvBOt6hcX9PDpPimyTQDHgX5Kb94+7XQXo+WKx8YaP5mnFdgCsVRZNQIg5Wt2eCdwehh/iHHjFkMoxe6AVGIl3yo8T8nWsRtHWeP75BdRMGDDtxV+W1HqYr8KMIIpxSXFuNCAq5rF3aHSMQBm4wVCX+lArV2rGrh53ZryQCXAcNK5DAgMYfkJ1Wo0bDfxBj42bR2l+6cksrfjN92nvnHzRHHPURhP4uHKaKWwNlRh7DXAXg49EJGx8Tg7IJnITJ3Q3QA4FYsKg4XOvpBQLM0ql/GqmAe1mSH7gkQBDW9ruROLkeOKLYkgrVy3XgLlWOc9kW069ns8MMPW7EBCrUCkdoUwdZxUn/Ff4MjGi+6lscOJSC3oHUC8dq2H8uK7vrAh2pe8CnipcLZTq6iuiJKva2mKxISXq2Qp39JMCjNbLrncqXBaFeTr88YkmOlV08WRCVNFOTWHOKJjdrhBG4c3+a9Gnp+XNyeO33K3g01ASNg6jv32LXZIfYUNX8imfKo44mkr6QblYZDh7vRwAbr4uO5ikOdj+bkzfBPrvPzqMAxXDEBf81nHA3l5N3T15RnYptR+DOV/jZAxXKz+oa+uWXMhmtSM5wrmYy6zITVPp8QazSr1EcL5rucB5o3g7Q3FsQJ+JZvSFKj1cqDqtTK4gTQMu9n/4G9PWoD7MdK8dW+OcAgBF5Jak/O+yCbtDu++gtbOdBS+Ih3zTdhFrlV8ljKOwa2plDdUlqH2DFnMsZSlSb4x1FgljY7UzXmWxlareoxgpAYZWjpmp0htHAwCLSW4p2+ A2HSRDlF hVxMcCPEbQej3OaxIGxB74aq99WBBUYJLxeOxwpWDxc2BD2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The current test scripts contain duplicated root permission checks in multiple locations. This patch consolidates these checks into _common.sh to eliminate code redundancy. Signed-off-by: Enze Li --- tools/testing/selftests/damon/_common.sh | 14 ++++++++++++++ tools/testing/selftests/damon/lru_sort.sh | 9 ++------- tools/testing/selftests/damon/reclaim.sh | 9 ++------- tools/testing/selftests/damon/sysfs.sh | 12 +----------- .../damon/sysfs_update_removed_scheme_dir.sh | 9 ++------- 5 files changed, 21 insertions(+), 32 deletions(-) create mode 100644 tools/testing/selftests/damon/_common.sh diff --git a/tools/testing/selftests/damon/_common.sh b/tools/testing/selftests/damon/_common.sh new file mode 100644 index 000000000000..3920b619c30f --- /dev/null +++ b/tools/testing/selftests/damon/_common.sh @@ -0,0 +1,14 @@ +#!/bin/bash +# SPDX-License-Identifier: GPL-2.0 + +# Kselftest frmework requirement - SKIP code is 4. +ksft_skip=4 + +check_dependencies() +{ + if [ $EUID -ne 0 ] + then + echo "Run as root" + exit $ksft_skip + fi +} diff --git a/tools/testing/selftests/damon/lru_sort.sh b/tools/testing/selftests/damon/lru_sort.sh index 61b80197c896..0d128d809fd3 100755 --- a/tools/testing/selftests/damon/lru_sort.sh +++ b/tools/testing/selftests/damon/lru_sort.sh @@ -1,14 +1,9 @@ #!/bin/bash # SPDX-License-Identifier: GPL-2.0 -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 +source _common.sh -if [ $EUID -ne 0 ] -then - echo "Run as root" - exit $ksft_skip -fi +check_dependencies damon_lru_sort_enabled="/sys/module/damon_lru_sort/parameters/enabled" if [ ! -f "$damon_lru_sort_enabled" ] diff --git a/tools/testing/selftests/damon/reclaim.sh b/tools/testing/selftests/damon/reclaim.sh index 78dbc2334cbe..41e450a696ae 100755 --- a/tools/testing/selftests/damon/reclaim.sh +++ b/tools/testing/selftests/damon/reclaim.sh @@ -1,14 +1,9 @@ #!/bin/bash # SPDX-License-Identifier: GPL-2.0 -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 +source _common.sh -if [ $EUID -ne 0 ] -then - echo "Run as root" - exit $ksft_skip -fi +check_dependencies damon_reclaim_enabled="/sys/module/damon_reclaim/parameters/enabled" if [ ! -f "$damon_reclaim_enabled" ] diff --git a/tools/testing/selftests/damon/sysfs.sh b/tools/testing/selftests/damon/sysfs.sh index e9a976d296e2..0326b9ad55ca 100755 --- a/tools/testing/selftests/damon/sysfs.sh +++ b/tools/testing/selftests/damon/sysfs.sh @@ -1,8 +1,7 @@ #!/bin/bash # SPDX-License-Identifier: GPL-2.0 -# Kselftest frmework requirement - SKIP code is 4. -ksft_skip=4 +source _common.sh ensure_write_succ() { @@ -364,14 +363,5 @@ test_damon_sysfs() test_kdamonds "$damon_sysfs/kdamonds" } -check_dependencies() -{ - if [ $EUID -ne 0 ] - then - echo "Run as root" - exit $ksft_skip - fi -} - check_dependencies test_damon_sysfs "/sys/kernel/mm/damon/admin" diff --git a/tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh b/tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh index ade35576e748..730165bd7f03 100755 --- a/tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh +++ b/tools/testing/selftests/damon/sysfs_update_removed_scheme_dir.sh @@ -1,14 +1,9 @@ #!/bin/bash # SPDX-License-Identifier: GPL-2.0 -# Kselftest framework requirement - SKIP code is 4. -ksft_skip=4 +source _common.sh -if [ $EUID -ne 0 ] -then - echo "Run as root" - exit $ksft_skip -fi +check_dependencies damon_sysfs="/sys/kernel/mm/damon/admin" if [ ! -d "$damon_sysfs" ] base-commit: e2291551827fe5d2d3758c435c191d32b6d1350e -- 2.43.0