From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9AE8C83F1B for ; Wed, 16 Jul 2025 22:19:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D5F16B009E; Wed, 16 Jul 2025 18:19:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AD886B00A1; Wed, 16 Jul 2025 18:19:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EAD66B00A2; Wed, 16 Jul 2025 18:19:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3F8556B009E for ; Wed, 16 Jul 2025 18:19:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C851E12DF94 for ; Wed, 16 Jul 2025 22:19:41 +0000 (UTC) X-FDA: 83671545762.30.D8DB152 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf23.hostedemail.com (Postfix) with ESMTP id 35C25140005 for ; Wed, 16 Jul 2025 22:19:40 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RJ5feXq5; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752704380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VghLubV51ka6tKcyhcE+NZC5offZPOeqckAInAggcio=; b=U2jxyCeFYCaDakaDPlCwxABjW9qKY9bLNrO7hyuqUTCjYdCzWsRWimVSTRqPT+ncCL/Tf7 hcwOdSFxPacjEk+65nyon9Oh3SqEgBAmXowZO+AxTe8iV06s4Bv4hB56e7ttxrqQoJbYby J4PpMc6E/HnZx4ff6lpgtmZHgqEBRT0= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RJ5feXq5; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752704380; a=rsa-sha256; cv=none; b=KNXTvNeTa9F6jkdGmeCuBvDSYTrVSwNHGGtTRgPIes2cVkS33mavNg8zUndPP00eSxVi8E OUsrUIBLUOAqD6XVIjzQiXozqnhAEYhrjxdBmPERllUKYzooQx+2izeE2HZnCdhtG/aQub l/TsMec4ihHIVRcpqOnYI7KIRyBXO8c= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 416FC601CF; Wed, 16 Jul 2025 22:19:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73E90C4CEE7; Wed, 16 Jul 2025 22:19:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1752704378; bh=369vctLzkQfJIcj6VvksIN2X4tih54GQszHRWKgNRiM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RJ5feXq5pLgc88dpiwJc+b2qpUSbClRMdgXExifvb4nMprCUJpaItDkMskhDpS29F pusHWff6Ddjz0Uo1n5FIA4E0R12HtRf0WTfx/vIVta0xEA3aqVhjlukevmzADKs1a4 /YhcgXj1UUKRRzbJaaQrWR0qdxjKIDeVBtfBp7UI= Date: Wed, 16 Jul 2025 15:19:37 -0700 From: Andrew Morton To: David Hildenbrand Cc: Luiz Capitulino , willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, shivankg@amd.com, sj@kernel.org, harry.yoo@oracle.com Subject: Re: [PATCH v3 2/4] mm/util: introduce snapshot_page() Message-Id: <20250716151937.6dd71398bf764d073526dc8c@linux-foundation.org> In-Reply-To: <492025a7-4132-4944-b55b-90c6d6e40bba@redhat.com> References: <637a03a05cb2e3df88f84ff9e9f9642374ef813a.1752499009.git.luizcap@redhat.com> <900252c7-b16c-49b9-8c01-60e6a7a48683@redhat.com> <492025a7-4132-4944-b55b-90c6d6e40bba@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 35C25140005 X-Rspamd-Server: rspam06 X-Stat-Signature: ynfgqk1uasi9m7xhzsyr91nuyjw13oxc X-HE-Tag: 1752704380-924966 X-HE-Meta: U2FsdGVkX19McQkclUOytXpFW8cRS/dNBNVFfolIIimoNqnS8JOwRkQiU9e3k9bRNbcB761gdq2R8DNYR/4S/rd/1eRg6NS/LI/4IYBHUc27xuSoPprXHUi++QMsKAaS607hdKG6MFZIo25t2V5LYKIaiJjxUB3A8AC3k31KbT8MZJwkkuyBbVOObwfKJHU73qd4otysMc8LzPnR8CecKY/B5WdvbVClO/R3V22m2LSKn5R/vl4tQnEc77AejDgykdyvz0R2ZZh0NCSWxt5L5tEWewafkZ8TWnuXT48JLB0Nq+Z/7GtFhVPWKN3eo1slpQ0Xso9BlL7mg6PZTFM1BVzR//mAJ9Ld35kllBV7hErUlBVZ/nzLSUc0QVAfUCazIKZ/dhOr+rrbA/9SPhwvi4PCA5cKQjAAk9B3wrdmlgHXB19adaZfkOl83YrANA1J0on+uVgXOH9+Vi0++sjEDIlbzL60u3t5TVUQJYLcxfhS9dkTKN2eV7fxa9r6tTz84daGAZwoNuRgqfh+VbjBYJcCmX1W5JsHQmgh3uUUIn0kQ1YdnTWUGvhOQUmTCpjpuOuDpQWgJ9HL/fEP1cMw8G6n/70yxcqaJ45rHwrVw9gNxBqCp5G8aR+8n9lWJv56jP/sK9IZZiNaAM6dHQaQv2tWgrYdNUXgnXooQrJBWHd9D/GfoZm1JqXb+lztCDV0gXmqsCjz9yTeAPR06F+WzIbB5ckvZeWvuiFGg0h3NPaeuKY6b7i3/VhO+mBqEKbLSekhWIPQYCC9/9eUKEGJesET/N/YABA3YuqG1sRX+ET1XMekhT0+i95sx5YjW7dOfJaZXdmvLAfO5sndGJiJug9luKg5YqNwUd5Y30LnO2laRRgHLNGhUTQpQ1UJfok/+h1MGZFQKxnWB8gVa2fNB8hHFQ8QX7enPdHLG0/48ZmJVTtvj4C9WBR7PtFVDWBpFjBUzTmXPfDS+c8q0x4 Jv/ESh+w WtkwoemEpgaSyfeJu6SVq/2r0G10l/0um0gvW0Hd2Eqi7x++C5p64pRb1g/JmK7aCFk1TJId0dYEEikETXyEMY4iSCtATmJlLu//lvaqClDJJu3Wh8SoHm7Yq+TZbC9K62g27dMCmWXfK2uJcKhIVA97B2UnMZa1VUrbO1kf8RGzbjV+oFhmmcODaekNlBWWTCMCKoManlEm6/o6TtZ9Y6Y5GtPnTVf5IVwBppn48V5lojbzn8ofoUL8M1JI6F6mFZtjxxUhUBdjzp9tgFY8Y6ax9DQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 16 Jul 2025 20:18:00 +0200 David Hildenbrand wrote: > On 16.07.25 19:36, Luiz Capitulino wrote: > > Yes, good catch. This was from an earlier version. > > > > Is it fine if I fix only this with a follow up patch for Andrew in this > > thread or would you prefer that I post v4 with all the other changes as > > well? > > I think the series was part of mm-new, but now I only spot it in > mm-everything, weird. Maybe because of a conflict with the other > stable_page_flags() change? I think I removed v2 from mm-unstable and added v3 to mm-new. Maybe. > So whatever Andrew prefers, really :) Either is OK at this stage. I do prefer little fixes so that I and others can see what changed - it depends how tricky and large they are.