From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97753C83F27 for ; Wed, 16 Jul 2025 03:06:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 922606B00A0; Tue, 15 Jul 2025 23:06:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D25C6B00A1; Tue, 15 Jul 2025 23:06:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C0AE6B00A2; Tue, 15 Jul 2025 23:06:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 691256B00A0 for ; Tue, 15 Jul 2025 23:06:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2F146140244 for ; Wed, 16 Jul 2025 03:06:16 +0000 (UTC) X-FDA: 83668639152.07.A03F895 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) by imf04.hostedemail.com (Postfix) with ESMTP id 6197840007 for ; Wed, 16 Jul 2025 03:06:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Fes1ZifX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3JRd3aAYKCHoqspclZemmejc.amkjglsv-kkitYai.mpe@flex--surenb.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=3JRd3aAYKCHoqspclZemmejc.amkjglsv-kkitYai.mpe@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752635174; a=rsa-sha256; cv=none; b=7SlR7DCkVYE0AsJZ+t/BD+o04fHak51fcOe90DepPo9ko6RPJ0enWlV6jlHuRttWNOIk+8 gT5om9uB46OrjR/ihC9xHpDjP9+G493xx3DzFz3+fNsk1ngA4Cm43CqEgvcH9cDD7fiEBC kzqoM+XY0urlVjDnb6tyXFQ22CxyYcg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Fes1ZifX; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3JRd3aAYKCHoqspclZemmejc.amkjglsv-kkitYai.mpe@flex--surenb.bounces.google.com designates 209.85.215.201 as permitted sender) smtp.mailfrom=3JRd3aAYKCHoqspclZemmejc.amkjglsv-kkitYai.mpe@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752635174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JJyiXrcxEaOrLnExvfxF4iaGO8N7lUzqsD5ouhDVNBI=; b=BAlWat21j4uW7WdWM9q2IcmvyFZW9ORPRHXRs3Nd5PIBibUANt5Cl9ay5Fll6bTTKzTkNw sejpmJfcuOjn4kOLpYjxdsJv31qZnOhDOvaw+oGk8R3oIi713Cza3JcMP+qIH7hhc4B7iv 9XPM58YzYylOPjdCidC0S1WlY21Xx7s= Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b31bd4c3359so3460462a12.3 for ; Tue, 15 Jul 2025 20:06:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752635173; x=1753239973; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=JJyiXrcxEaOrLnExvfxF4iaGO8N7lUzqsD5ouhDVNBI=; b=Fes1ZifXkAXmLCVWyNRJ0KeT3q/mfXVBQAMxLcUmQz2wAr8Hgq3N35zhI95+lbtfGW OnJvwbwpVL1NR/gTLgpPFYTVowxI27sWhQISvxqbgB0CXPeQ4QimPCOyM3IEYQYUxNhx YGWTNw4V7p6cER3AfgimvoZv3Be8UI5xSkyBVh6L+wSuMcyhuqfzepzhC+C7Y6rgqclO wMBhhPl0t5oUnNZC96L4qyLmvm4z44Ymp60v5x6hE563K4unFf3tpDmRhV8BKvIN9ycp xt6vGPrIYy1tGVh3ACJ3b6uz4B5Q2hIGvXqFiYCUl40uzqmGTvO8+FOBL48D3rP8QEgB SFgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752635173; x=1753239973; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JJyiXrcxEaOrLnExvfxF4iaGO8N7lUzqsD5ouhDVNBI=; b=NBp10zdxdHvucpejM3A0rrfxqPLelGoaoobLD5JFJr5M1Yo3bw16XDtKUmNMP2zEYl 5lKE0n7Zpi5IF0251gl09b8wHCHk8ns/PtHzKde5YShEO6DkeeUmr5ihYmbZQ1tbt53O prdi2lXxfWk/fMBdteMVvf7DaskhWXotqDp9DHIZcRn51o555YbMgiAAFdssTAxvTc4/ yq7A9dSFwTRhMifScJ/ImZzHV2Ye2olTaiFsXsRpa0itGTtIykc4GkeedHo4DgsoCjjJ 4JIJZrJDEiccfudBFJwcC3ArYyRCJlVu8dH9uLVlKkpWI407n3RmSZ37AENqExNy4zUq SYjg== X-Forwarded-Encrypted: i=1; AJvYcCUfB+9+WRJkxoNsjZLkfk550v4c0NCoX+93ARjg13BrFEGfSDPVXTlFOtB6WpajpZVosOM8cFb3hg==@kvack.org X-Gm-Message-State: AOJu0YxaBRnKeC8jwhQkOIOeRDHlXxr99TCbQqnkdr64OOM3qhHZtP39 EFfGNJcK7cbKv2Kg1waCMg+Kf/+YEVJn7VO1qwKE/KwWABhGbiKiYGreestmLw2syQUaIDl6C0t Ro3rxag== X-Google-Smtp-Source: AGHT+IFDGwwmBom5R3AeCsNrmsJsGaDmKZ6nwxto47OpXfv54XBWKzi5o3ZDO8E9HG9YurznkyjmKbtvlxI= X-Received: from pjg12.prod.google.com ([2002:a17:90b:3f4c:b0:312:df0e:5f09]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:1fc3:b0:30c:540b:9ba with SMTP id 98e67ed59e1d1-31c9f44bc2dmr1486650a91.10.1752635173229; Tue, 15 Jul 2025 20:06:13 -0700 (PDT) Date: Tue, 15 Jul 2025 20:05:55 -0700 In-Reply-To: <20250716030557.1547501-1-surenb@google.com> Mime-Version: 1.0 References: <20250716030557.1547501-1-surenb@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250716030557.1547501-7-surenb@google.com> Subject: [PATCH v7 6/7] fs/proc/task_mmu: remove conversion of seq_file position to unsigned From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 6197840007 X-Stat-Signature: 3gzswtd95z6ayqzfqcfbsw3azpuxw1xd X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1752635174-254550 X-HE-Meta: U2FsdGVkX1+BU/2XtvB3sSl/UiwdcMtEFgxOxdyP+cxHQ5rLETyS3yruLGbPxNKcUZSEBtMmXNjRckgn3Q7GcKOaBw57WAQOj4d5zDQGLPdy2l2z4+JQx/zFuvccAABE5PdJHgB3AWf6t19cNb1Kx9JleUy5P5F5WGKv7904rYCQf7sTpePXwzE01HQA5yBK7y8an0WyRVtrXPKnzkCpSEpxQPvMJ4kmyB8GxSM3cpQ0Zci8Brp97C6y6SABa9QKBaj/k5YsDHsHaa2O3ljOxIGjYNHs3ChgfoH9bz0F8jwwITkGX394rM+ARobNFeCAFgrG+MRaPK9Suqi4AVJvgbwnz0dACKX/DfW9+wJk1TiGtcfUrtLHm7U/HIDMqkLsAMXlJ9Li69YnHZg5Pbrj2Mp3jMA4D65SnyNE0TrgiUSasZbAocYkX8rKzO6I9lL3mJBZw0ZfekeCv1W8MlW/BSnke91grbaLpmvT9UsmekChUT8wBQFiFmdXB2o/IVYPknOZ5lVnLsrDPSPUZDrk5qNw9/GCtDW1tB362YMWGsUNLKP2FgthlywTrnxLUm9C8HbIYdyszfQaP3AHxegYVlcnaLffRRCLuYXgkEdZIyS4TDwja2iamLV2R82iGaUZS/5ky0J7CdM/nfdoXuwQYbosyMMg1S31sCRgZ7XV8UuROsJq8F+G70rH9Op+sNCc/tDC+clZVjNPgSj1JYPCu8v0J6NvC5I7+4Q374DppviEDYO8qSXFcUhYGXiyK4Bi6U9Vg0doMKIoLUuK0kqg+C63+pHN4c882ZrmtnLYvz/so1NhqoQ+G20y5RAe4dLlFLUv2VgkseQrDsDhmRhE4GUf2Bxd1BssHW5iCbxoGTAAl5KIj09MIDkYze8lbCuRUTz99nwzCgTJoIeO81rVPDq/Ocs2NOZy+/aA087mtm7cBdchwz0UptnYy1FwtClfE1/DoMVe/+aLsl7Gk1P VvV1mKna nuAxxLV+dO9E0xg8LI8gZyYedF+x17TK0Kb8hxZWp5rINmxGM5Vp7HVsdgm6U0+Ude+CyyIkpxumv2bq50vzcqPICcak7AA7+sSugdFLayrYvix+uGvuYuqnLpq6SnKTjd4SMHHaHJPxW8SRROyzHtkLloXHagcaQbepe8qbDeExDmmkwvzPSdzt4e43ii7Gn+I8w6+SpFHlrcCDRtTYq82Mz4N9H6qrwcSBTwKZmjkHEICxFMPqv6Ktar8xmJoFdE/No9RrYmHg4I2Xww3ASxXrMBRzwgNwS+sTEmr5oeEmGNt0lfSUFQtwUktsY7dZKunTtFPegJA2p7YgMnGamtKOweEElfkgyuqmFtaB8SZ2UJn32zNRJ1FVXmM3/HApXTOu7YjVMgp3em/tQjsOOrX+UJGF1eIjn6tlfK9Y936EmF62n6eTZsOymGVQdLQFYe/l1AX3kGe0+2YojDcD7zUv0wWC8Lt3/BQ2t4UqDOhbjq6ygaZnI7CuPtLWum0ptW3SB1VPC2AP2Gn575FnqpaiM9DBRfMJfAXmrJ/SkiFKrLp24Q10Hh80qKKWG4pQQLET3AsP/9nOHOheqB1sPp7IxxZxyFoTfiTisp6OFqykKRnhhnrzen3x4WSGSGEqy2XqoKTa6X+CBP/8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Back in 2.6 era, last_addr used to be stored in seq_file->version variable, which was unsigned long. As a result, sentinels to represent gate vma and end of all vmas used unsigned values. In more recent kernels we don't used seq_file->version anymore and therefore conversion from loff_t into unsigned type is not needed. Similarly, sentinel values don't need to be unsigned. Remove type conversion for set_file position and change sentinel values to signed. Signed-off-by: Suren Baghdasaryan Reviewed-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka --- fs/proc/task_mmu.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 751479eb128f..b8bc06d05a72 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -135,7 +135,7 @@ static struct vm_area_struct *proc_get_vma(struct proc_maps_private *priv, if (vma) { *ppos = vma->vm_start; } else { - *ppos = -2UL; + *ppos = -2; vma = get_gate_vma(priv->mm); } @@ -145,11 +145,11 @@ static struct vm_area_struct *proc_get_vma(struct proc_maps_private *priv, static void *m_start(struct seq_file *m, loff_t *ppos) { struct proc_maps_private *priv = m->private; - unsigned long last_addr = *ppos; + loff_t last_addr = *ppos; struct mm_struct *mm; /* See m_next(). Zero at the start or after lseek. */ - if (last_addr == -1UL) + if (last_addr == -1) return NULL; priv->task = get_proc_task(priv->inode); @@ -170,9 +170,9 @@ static void *m_start(struct seq_file *m, loff_t *ppos) return ERR_PTR(-EINTR); } - vma_iter_init(&priv->iter, mm, last_addr); + vma_iter_init(&priv->iter, mm, (unsigned long)last_addr); hold_task_mempolicy(priv); - if (last_addr == -2UL) + if (last_addr == -2) return get_gate_vma(mm); return proc_get_vma(priv, ppos); @@ -180,8 +180,8 @@ static void *m_start(struct seq_file *m, loff_t *ppos) static void *m_next(struct seq_file *m, void *v, loff_t *ppos) { - if (*ppos == -2UL) { - *ppos = -1UL; + if (*ppos == -2) { + *ppos = -1; return NULL; } return proc_get_vma(m->private, ppos); -- 2.50.0.727.gbf7dc18ff4-goog