From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 175CAC83F27 for ; Wed, 16 Jul 2025 03:06:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1F016B0093; Tue, 15 Jul 2025 23:06:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A58FB6B0095; Tue, 15 Jul 2025 23:06:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 948516B0096; Tue, 15 Jul 2025 23:06:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F4506B0093 for ; Tue, 15 Jul 2025 23:06:12 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3F64A140243 for ; Wed, 16 Jul 2025 03:06:12 +0000 (UTC) X-FDA: 83668638984.21.C87E1E4 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) by imf29.hostedemail.com (Postfix) with ESMTP id 77214120007 for ; Wed, 16 Jul 2025 03:06:10 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BcBLUKAL; spf=pass (imf29.hostedemail.com: domain of 3IRd3aAYKCHYmolYhVaiiafY.Wigfchor-ggepUWe.ila@flex--surenb.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3IRd3aAYKCHYmolYhVaiiafY.Wigfchor-ggepUWe.ila@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752635170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wz+/Rb5/fWdnaWsOelI+A9jPFxhtbRCP90y3FqomvrU=; b=HbV+iSF6klVDiUybvMcTcW7SfAQiDS6CyyoEO8I6q+mXnjoBaH0/lYw6+IE6qxHIE5odtm /HdjOoAR9DzhyTWgtO6N6rJWJIxzSzTxX1sgppnlMaHsQCiRcHsSF/sxaH8TmvKdUMW8Ad 67Yg17u9WYAFvuFTMMeDxx7CncFWUP4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752635170; a=rsa-sha256; cv=none; b=q1UrX/cwL4fQOsIE8h7ieissSsyLfy+0YhT+B5CRGHYzfNt2P6x2qwe/sSAi/+992Ttp7h l4Qmdqcf4n9B0JKodedoruVx1grLINRtbpw8wYtw1XzsG50MLywnELHBrsWC6+q/m2S1hb awE1c/NiSNnaZwvWCfPFbIQgpa6KaTg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=BcBLUKAL; spf=pass (imf29.hostedemail.com: domain of 3IRd3aAYKCHYmolYhVaiiafY.Wigfchor-ggepUWe.ila@flex--surenb.bounces.google.com designates 209.85.210.201 as permitted sender) smtp.mailfrom=3IRd3aAYKCHYmolYhVaiiafY.Wigfchor-ggepUWe.ila@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-748f13ef248so5810315b3a.3 for ; Tue, 15 Jul 2025 20:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752635169; x=1753239969; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Wz+/Rb5/fWdnaWsOelI+A9jPFxhtbRCP90y3FqomvrU=; b=BcBLUKALakQ7dEVysVVFDQRBi9Er/DN2P7n8nV3s1GzSGVwyThaAdJoH3XyYgAuZWX Neyg5UiXUpCDS7hsI8ko3eTCFdSUnX1ZEWwFEuAR8fIdmhurjlzR9JddfjQn33Hctz6h QLiUKSBPxEiqLPELle9Jfcr/ErpmliYMThrc/b+oKTJTesMjINYxkiYqQhIgfoW02ePu ml7D5oHT+u8v61pfd1zUSMz8usthVtWZNpxdeqHkx16LeUxwn6pkeugKdTUC/+vfyqK1 2q0Y7GE9xKxASPZRovGJzUSUfz8QyUYY9/jhRFWrkYN2Y4r6oj1hYU/9obDN3XMaRmKC i7Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752635169; x=1753239969; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wz+/Rb5/fWdnaWsOelI+A9jPFxhtbRCP90y3FqomvrU=; b=JEUVRJXpT4B/rIgt7n4arkVpt/mjrXdRU6wf0nz8Xhb2B5r1Lih2H7eSMzu4ha/6Zx k1CwOZwZ3Fy1h4gU8TvKf31+bJyRkPg8ok91VWI/DpnP36K/QE5NQPFl4ImjsDgJf/L6 mxR1QooAqZUgX/Ob5yZ2kgSifo+/PfOAKjkKyFqf4SjpOkGWyXolDQ2C1+xgJHNnlaXU qDW97oAujCgLaqyBvNd3smx/mVhoWSeNWji4I/3VPZaoezxWBFsNtiDq9HSSDWqR8vWc fbsZ5Lp/uHFJ6gs/ivNEjx9v+zkKQUNBafvFK6X72cIWvYNpPbEfuQqPWMrb4dw4eGEU 4gsQ== X-Forwarded-Encrypted: i=1; AJvYcCUhEzRphhtUZpX7Tj2eiGIAF5TX22/DbxeaPhIUobu4UC8On3fmUpi5YUI/hQwp4cx7oSct76DRFQ==@kvack.org X-Gm-Message-State: AOJu0Yw3PXrc30v6/GSQcNQSiYOb8UCBx53FtvZXy77VpL+pa+GdfMzY 5fUUmoP/zPXFy5GmEsPJ8j4ddbeWpW175ZRqSwIWPs9VUoACL5UK6b7bT6xg2AXLB6/QL9ae1tX b8DA/Sg== X-Google-Smtp-Source: AGHT+IE5zlLJfJSiKDps9oa63lOpF1CpedYQdGtHutsY8b9qvB6aXOWJRFpftXMF7nK7d9tGDEfQnxjduYc= X-Received: from pfbjw38.prod.google.com ([2002:a05:6a00:92a6:b0:748:ec4d:30ec]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:3d1c:b0:220:e5e:5909 with SMTP id adf61e73a8af0-23813c6df02mr1420419637.20.1752635169133; Tue, 15 Jul 2025 20:06:09 -0700 (PDT) Date: Tue, 15 Jul 2025 20:05:53 -0700 In-Reply-To: <20250716030557.1547501-1-surenb@google.com> Mime-Version: 1.0 References: <20250716030557.1547501-1-surenb@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250716030557.1547501-5-surenb@google.com> Subject: [PATCH v7 4/7] selftests/proc: test PROCMAP_QUERY ioctl while vma is concurrently modified From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 77214120007 X-Stat-Signature: 54szrx9uq6z9ag1i5sz4hg9x8tcjmsny X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752635170-658710 X-HE-Meta: U2FsdGVkX1+hrCMN+ATbcWPx3sNsPQY9NL4xhKg3jKAK326nbu8Baa0K5NN3vjdqyEIEWUlBVl1hwBg0knHmX8v+s3fE8eM1BDGSbWS39LflLG0uPMXjn9uZzurKLwm5Dh+03G6ugIYwCRWYzg3KTyQIs/sAd9Ak+anmMtdhyu7IqG0vcIzk5aN7UaZi9zAZwYrnL4myVKjfmt1ULT4asCvhYA/GYcJ//RAOzwb/SAHtyp8fG7hmjAJqDfvNSb0cdFaejhoB5bKase3KYT4Db3O4PsQ9gG/ux348Tkag0zwz51/x0AX8aAWT+jmmwRUiuDo8wPZRaUjEiqM60fMutP/kWwxcBFH+2CPFizeuDybc8qrsPDtC4vynXYJRtjQuAM0tkaGBKZgDFPaZX1T0RczzpQbeuVqqLTklpRFp5/3oo2eqtURGteoLyMsCx9vtDEzwq8sXkVnt7Gb8Tmpq5Bs3QAynPfkCeqIdQumXaRaor/CmvA6fgslSCLb7mYFYw/peY54rD4aYfFGORP9+8SAU0WUVGXQLb3oBpF+xd2olr2DxWfZwRXti7VG7Fp5xCduFE3LUPFC9ooi8bnh3ciQSBl1yikjl7/v60h5+fgF4tfkMxGkuLryMPAzVcm8m96yTu0q6dOL/Xsv2hqCo1smioKLDkEhoc25uKWHHSbrPx6FxU2UwJaYuOynT6A/wZRkjAIlleuf5gug1/+3wTasBlV9R2VtkhSJ2LXv4ta0FROTR47yoY6i7iYKG7QXYP7IX8kAftV+vdII1pwRx3SP7qloCx8dtMekRKwgqqSKxQUFdeSpyzEZu0+yLPwQwRrQHLDiLgsV21jNymwJh7/FdWS+Ep91O7APwntZPBxuEVuNWT6JhDCijja3rxPWE+oplX1y2EL/W1/2l4lZvJTMzCjwgssVND9QP75i+PIVxuWRveVCuuB9k2H/WLvrd2JQ54eLH+zpg8OQfypC ffo3bZFq RXpjHk/uV70EbDlMulavJsSnSsp2Pb+0tPQRR2i6ak4YSU9t8xXN5iaMVXFLbpoeYwgVZzIqop0oAzSaN4Mi3MqtxKVKaCCCDY8DC/6EDAsRw9Zm/7zOt1wNHc/ynlATz1/2n98w1h1qYDDx4bIkMs45Ja1yigaZn6rKdEAqHHIyPyiFp1gKMwD5Juzio2v1z8ZsS+0pYTm1eaTvYkGyVXeTxW77dlDVSr8w1oYUmKfImaoLGwJFx/JSB3dfVudRRJWRCbFqXsCVZqOPv+actWOlDmL41h43YOjkMhlcnBUM3XwVcV99G7lqnM6FNG3nQRDmCT2UXowiy5bA6RjwG5xFwGX43ALsTCzI6pUh45d69V94rRzgsIN39AfY1IxlBrUS8DtSKYQE/NpSilBK38bGiUP1vbYS8c8DNsGo3R+ywSU22dVh4AIJkaEar7z2/JxUZVolEZhijmYXX4evLDVavNu8O9lph8uz1YLGL3H4wwvCW0/y3eLyXvh7IgxjXpj21l2Fsqi3N+OVey/Y68ipVFOOF7juR3Rh33jPHgH3fp8wtDW6C2KfkYz5tEhtntW1yFKX0mDJvKkD2ee4CO2Ntpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Extend /proc/pid/maps tearing test to verify PROCMAP_QUERY ioctl operation correctness while the vma is being concurrently modified. Signed-off-by: Suren Baghdasaryan --- tools/testing/selftests/proc/proc-maps-race.c | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) diff --git a/tools/testing/selftests/proc/proc-maps-race.c b/tools/testing/selftests/proc/proc-maps-race.c index 764821ffd63d..6acdafdac9db 100644 --- a/tools/testing/selftests/proc/proc-maps-race.c +++ b/tools/testing/selftests/proc/proc-maps-race.c @@ -30,6 +30,8 @@ #include #include #include +#include +#include #include #include #include @@ -239,6 +241,21 @@ static void capture_mod_pattern(int maps_fd, assert(strcmp(restored_first_line->text, first_line->text) == 0); } +static void query_addr_at(int maps_fd, void *addr, + unsigned long *vma_start, unsigned long *vma_end) +{ + struct procmap_query q; + + memset(&q, 0, sizeof(q)); + q.size = sizeof(q); + /* Find the VMA at the split address */ + q.query_addr = (unsigned long long)addr; + q.query_flags = 0; + assert(!ioctl(maps_fd, PROCMAP_QUERY, &q)); + *vma_start = q.vma_start; + *vma_end = q.vma_end; +} + static inline void split_vma(const struct vma_modifier_info *mod_info) { assert(mmap(mod_info->addr, page_size, mod_info->prot | PROT_EXEC, @@ -299,6 +316,8 @@ static void test_maps_tearing_from_split(int maps_fd, do { bool last_line_changed; bool first_line_changed; + unsigned long vma_start; + unsigned long vma_end; read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); @@ -329,6 +348,19 @@ static void test_maps_tearing_from_split(int maps_fd, first_line_changed = strcmp(new_first_line.text, first_line->text) != 0; assert(last_line_changed == first_line_changed); + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr + page_size, + &vma_start, &vma_end); + /* + * The vma at the split address can be either the same as + * original one (if read before the split) or the same as the + * first line in the second page (if read after the split). + */ + assert((vma_start == last_line->start_addr && + vma_end == last_line->end_addr) || + (vma_start == split_first_line.start_addr && + vma_end == split_first_line.end_addr)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); @@ -390,6 +422,9 @@ static void test_maps_tearing_from_resize(int maps_fd, clock_gettime(CLOCK_MONOTONIC_COARSE, &start_ts); do { + unsigned long vma_start; + unsigned long vma_end; + read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); /* Check if we read vmas after shrinking it */ @@ -409,6 +444,17 @@ static void test_maps_tearing_from_resize(int maps_fd, assert(!strcmp(new_last_line.text, restored_last_line.text) && !strcmp(new_first_line.text, restored_first_line.text)); } + + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr, &vma_start, &vma_end); + /* + * The vma should stay at the same address and have either the + * original size of 3 pages or 1 page if read after shrinking. + */ + assert(vma_start == last_line->start_addr && + (vma_end - vma_start == page_size * 3 || + vma_end - vma_start == page_size)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); @@ -479,6 +525,9 @@ static void test_maps_tearing_from_remap(int maps_fd, clock_gettime(CLOCK_MONOTONIC_COARSE, &start_ts); do { + unsigned long vma_start; + unsigned long vma_end; + read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); /* Check if we read vmas after remapping it */ @@ -498,6 +547,19 @@ static void test_maps_tearing_from_remap(int maps_fd, assert(!strcmp(new_last_line.text, restored_last_line.text) && !strcmp(new_first_line.text, restored_first_line.text)); } + + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr + page_size, &vma_start, &vma_end); + /* + * The vma should either stay at the same address and have the + * original size of 3 pages or we should find the remapped vma + * at the remap destination address with size of 1 page. + */ + assert((vma_start == last_line->start_addr && + vma_end - vma_start == page_size * 3) || + (vma_start == last_line->start_addr + page_size && + vma_end - vma_start == page_size)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); -- 2.50.0.727.gbf7dc18ff4-goog