From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADC5AC83F17 for ; Tue, 15 Jul 2025 11:05:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B35D6B00BC; Tue, 15 Jul 2025 07:05:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 463CA6B00BD; Tue, 15 Jul 2025 07:05:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32C296B00BE; Tue, 15 Jul 2025 07:05:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1CA4B6B00BC for ; Tue, 15 Jul 2025 07:05:22 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C054160464 for ; Tue, 15 Jul 2025 11:05:21 +0000 (UTC) X-FDA: 83666217642.18.A0A3861 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf07.hostedemail.com (Postfix) with ESMTP id B387240008 for ; Tue, 15 Jul 2025 11:05:19 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eTMZdxNU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752577519; a=rsa-sha256; cv=none; b=JfCkBblsBQhJCvtPnEBegYaw1N5fHB5iVAl2ykNS8Zv9QEUPW1WaMBkucIQ98lKm0QBCoa SZdBB+X4w319iIlpyPCrH33Xrhduke/NyUI3HxM2CUCgKUPIbVehxk7sAkNW5OQsu5AkJL dhH27PmmWmaUd7viVmQpYsKZFw8CJM8= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eTMZdxNU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752577519; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PdyrYF2somcJWeVef/fvp9prs0ptIROm/PEHLAtgGIQ=; b=jJPGcIwMWrrRQJLgt54ARH6hua/NvvPptoIksHzHhZqZEy2BUPFKkO4L59uGl/dLKNkwvl LwnwQbKJHfQWqTJBMvD0xHFqJglI091zCiqBgEU80d34Qa7qt+jCt35y90368gpmJ7H18r EZQyc1gJGOsPlQuOlQyvrslU7dOlhq0= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-74b54cead6cso3606945b3a.1 for ; Tue, 15 Jul 2025 04:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752577518; x=1753182318; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PdyrYF2somcJWeVef/fvp9prs0ptIROm/PEHLAtgGIQ=; b=eTMZdxNUxCHOPl7z1AFLzx0xvhyxLR5djpfvK5mUkbrfnS7KA88AicE6l90rms/Gyv TLRLYOcb7y8lutzjKUCr2JeaOvxce+uUeHUonvxsZqV5KhWWHpiXtAVt8GwZ6C8H5oHa cRxWdHazAqxS1vaRMn5KAt1qEp3VYkwU3igwmgQb0ZESAAVLtJOgmCXABXhyfp0t5slv Mwc3veH28wI9KD6bMqM4oiCUOsIpC9J24yPmFal1sSz8Lzw+naDXrwvKH8W2XIs7UjH3 oY59S7NY96WhAMwtqiArkWmEv4xGuclBRpbKfsr4texP8YqEm0ALyAIqyVonB5ftC61O 8Jsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752577518; x=1753182318; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PdyrYF2somcJWeVef/fvp9prs0ptIROm/PEHLAtgGIQ=; b=D1WI7t58467eOC1Yn6G1WwtUoMLg1bziQM43VhvHGAc7Fyc6mAa2OW5NM1ha3FgSrK rxG7im05ZHagBwCpdXA8hjUIf6dXaYJT/NMnNGQXCc826Rc4ENiECSpF2XtzDC24tpno QxI6My8bUbjhtdFudy8RPoQfPGgImb4q9UfO2xzQe7IMr9wfurpO/goXFGy3mjd5YqTA vpDwPPsROaf5/yEO105uMo7jz19qUs7GL0nmv9PvrEK4yyTcrxXsBteE1+Seywj3O6yE XCkUJXz37R/ib85+LKAu5CYgEUkqwdd5D4CghMVcoDfhMBkNQadgGcfHa+I86cbc+fPT ZDUg== X-Forwarded-Encrypted: i=1; AJvYcCV7Ctqpw1MsQ52yrBs6X4dyEObmMdSj0fht0P+cv44P5c42ZoL7FGf/EOvpYGPG9kuQCyX1na5Gww==@kvack.org X-Gm-Message-State: AOJu0Yz5O0eyDgjVkHvMo4DwTX24knYiqS9Qj/4byKZ7/oy3Yk5DnadK PC5KI3qnR0rABoQRRTpqpAxxVys1VNMqe1pqVMiaqT0FqM9dEahKSGCx X-Gm-Gg: ASbGncv0c5VD9jrVDC+TLHiS6nCjVhg2HkIqP2lE0D6izdiE1mUODwj6yzdIgvjvhOc 48m1qwUMWluGXUVUy1DXZe66TPcxHe67eEJYkCeZb7MQI4hMvwtrhMizkBx0eSQQ1t69x9pED16 OKdIOtLMxKQ3EHS3Yk8LFXIm30MhCKwfGRzBOb+0SxjDNhoQyohIPgOg+gppmofXxuweZs439J3 itK/dwpz00N9ztBMac/MIXra3nUPeQkPq2ViJyhrwNehQZPjCTATqN47bAbIB5lhtfTiEUQ8Sx9 frCYo60prA4YOj9t8HqydvHQ1PYzErbX+QWig4JzosQpwGtKFG/ojk2G3Aph2CN9D42KTu0SbHQ 9g/4Ux5etEGUkahc0yr6zczt24NZ9UKL+AITbjzpuqh+i X-Google-Smtp-Source: AGHT+IHvaoN5oYUSaPoNNV8wa34UYow1jV/wQynQyE+HDVIwE4uylcfESipjeICXNaldk8QQGezczQ== X-Received: by 2002:a05:6a00:810:b0:748:e0ee:dcff with SMTP id d2e1a72fcca58-74ee295d75cmr22942281b3a.11.1752577518294; Tue, 15 Jul 2025 04:05:18 -0700 (PDT) Received: from DESKTOP-GIED850.localdomain ([114.247.113.178]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74eb9f4a050sm11802421b3a.119.2025.07.15.04.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 04:05:18 -0700 (PDT) From: wang lian To: lorenzo.stoakes@oracle.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, broonie@kernel.org, david@redhat.com, gkwang@linx-info.com, jannh@google.com, lianux.mm@gmail.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, p1ucky0923@gmail.com, ryncsn@gmail.com, shuah@kernel.org, sj@kernel.org, vbabka@suse.cz, zijing.zhang@proton.me, ziy@nvidia.com Subject: Re: [PATCH] selftests/mm: refactor common code and improve test skipping in guard_region Date: Tue, 15 Jul 2025 19:05:07 +0800 Message-ID: <20250715110507.5383-1-lianux.mm@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <5e2b88e0-84ef-4870-b472-bd2aa7e88c78@lucifer.local> References: <5e2b88e0-84ef-4870-b472-bd2aa7e88c78@lucifer.local> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B387240008 X-Stat-Signature: nozampzbjgxw8mqpiwsaymk495n5izfa X-HE-Tag: 1752577519-618227 X-HE-Meta: U2FsdGVkX1+AV1LM9XznQwcVuDMrrjyR74acQb1sdaLeDtDsY327osSDc9wnpdJ/xVq0S+QuWLr1BWJGmxlKXgBaSrlAXAU7tgp9vIDf6XoeKb6cwH5LrWZDfFA0d+E/s2LJ8k0YrUHSEcDdP2DQx+tP+TPhkeiuQgAZoTeYIJBRKZKCPE3dLpl37mBP+PkDO4iUXDukcge8pB7KnfYUo7S5CP2pZd6wPqDLAW/oUS8RZWZ58MPCjHvSFC6T+Ohk5mwT5MtsbJFlbr/37kBsy54Kcki1GbDdFepVx+kh5vFuKtX9wNBn9ttqfmbHwiZY7qTalw8v6P6kxPAnKxv9SSYR2sokogTUhF76orDnOKNd+xhXN1yZ95KTYyufN1rmTSn+7bFLVi0/rfZBAUMO305De7aIKzw1IlRAxYwAz4SqAbjJzxtwsGnO6oVwNoC9XJcDBg2uYxsmu9IoSnsXGGGT2lgkgmLA3/lLr5WlzxSh0wtbnpfIM8/XPJbYERF0Tdlq+8+6TLzBqqCaU2z9QyCa+9CXaK4Ni1mpzSWdpkLOMqkmZAmoQ1qvgDCa74JctE2oZ87u4fM12OnXobiyPLp9NDJuOrsR6RzsPqIlyjyQoRo9nm100TIalSPP6kQ44nOhgE+yq9RLcA7wdeqc2XhHwSbT5WMUMpCEwPlFN2gKtB65575RUQR66cnirneRJ4DRqgIFSG+gCgSso0XjBZ/Kfkep32iK5i7NoJN3UKeP2N6E51R9CT4/CJN6Pmv31lG1feIJJ73ebhFp2HJQa8D5UtMWlQ7k2TF1vfbH0u2Drw4KunrS4tJNg/ErLblvqZxxnhcpmaYqy3cmy4TPVBzbOszWGw6I/lI8z6QNhJE/fUJJpbRhqNA/3pyKgEkiFVdXQzEWUaiW8Ang4qEKYjhdwq8Bu/x318Yv39996tMmgfZaPvzTvSjCfl3k5hp4Ic5BRx1kmySYEcsvrEt w+St0N2f m4HYEgBra/GcMtLDfg5E394mYkCUCjlLnIvmbGdD1lI9uhuc9d78D39FcGJqAJmWz/0X82iLzw/maVqY32W5twPkk0NvsVLsWJ8ZDpdeeXMmgnuA7/5ETtYmaeNiBV0eJ7H2q5XKvYeg6AK+UNHSpdp8/bYJl2IlI2LZsFO7peS7Tsn5kxCCofqMyiV9ScfutXWLAjXYOVDbENWfmbQmvvKQEhzoPK/UCgpYZ6nj+i6ddND9IupKS9JSDeIBiPr13i5EdvnEqqjdxRhaLEsac/EPW51lIbNA/5Btf5zy1Ru8+V9kw+8UukC+OqBbb966c3jlox4CdpfhtPJ/amb9USYM2qDFC+qld4DhWeOHPs8cWnUXwV/cZ9lpoxYcPLgcSS5/o09Ro9Dh+2ZDxvt5QecAMTMjtDFZQTN6Qpo+lMC2zbpJv0nQLp3HxCj2YWxE+TNyPZ1tREaTfJ44afcNFM8eG1Zu/isA8VFYCDq0pux+hEd4WZ8Z3DS7MEUf1yzXlSJRLnC96CH+XyBIA34p92urH0LFFVgYKL6Bg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Mon, Jul 14, 2025 at 03:44:28PM +0200, David Hildenbrand wrote: > > On 14.07.25 15:39, Mark Brown wrote: > > > On Mon, Jul 14, 2025 at 09:00:09PM +0800, wang lian wrote: > > > > > > > Move the generic `FORCE_READ` macro from `guard-regions.c` to the shared > > > > `vm_util.h` header to promote code reuse. > > > > > > > > In `guard-regions.c`, replace `ksft_exit_skip()` with the `SKIP()` macro > > > > to ensure only the current test is skipped on permission failure, instead > > > > of terminating the entire test binary. > > > > > > These two changes look fine but they're not really related so should be > > > separate patches. Looking briefly at guard-regions.c I see a bunch more > > > use of ksft_exit_ functions that ought to be fixed as well, but your fix > > > is good. > > > > The FORCE_READ() could be factored out separately, and as part of the same > > patch, replace the "asm volatile("" : "+r" (XXX));" usage in > > > > * cow.c > > * hugetlb-madvise.c > > * migration.c > > * pagemap_ioctl.c > > * split_huge_page_test.c > Wang - Feel free to put my Reviewed-by in any such series assuming you do a > straight up replace. > > > > -- > > Cheers, > > > > David / dhildenb > > > Cheers, Lorenzo Thanks all for the helpful feedback and encouragement! I'll prepare include the straightforward replacements in the other tests as suggested. Thanks again! Best regards, wang lian