From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F53FC83F17 for ; Tue, 15 Jul 2025 10:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1CF58D0003; Tue, 15 Jul 2025 06:58:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCCFF8D0001; Tue, 15 Jul 2025 06:58:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C944D8D0003; Tue, 15 Jul 2025 06:58:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B4BC28D0001 for ; Tue, 15 Jul 2025 06:58:31 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 413E1B98D2 for ; Tue, 15 Jul 2025 10:58:31 +0000 (UTC) X-FDA: 83666200422.20.0059A9C Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf28.hostedemail.com (Postfix) with ESMTP id 52B73C0005 for ; Tue, 15 Jul 2025 10:58:29 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NuaHeGov; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752577109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ndUwURMf+U4OPYsflaAXYVKWP+i2ltXh1RMS/eDGRPY=; b=GKCpwR4jThC95TnWpchRu+n97S5mC7Umt/DfnEg18mIUfz6FgfKTxhqHUaXyzu1OHmHP0S FeV3cWay/5GtfLmLcQnJrrhpQ9jdabP9YtivON+1wr6R7n96MNFI1fM3F2qWocRdbmiv6F vr6PO27JFzK1uFhYErFMep3fjr5KccI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752577109; a=rsa-sha256; cv=none; b=3Our1XcFMFArjlVhdUONtgFSEETDD2z+fZZpPgR8IseJ9CET0eHs4RjMqll3WHYfq3Za3q eDAs/jCkz0YpG6lLdHnzQO3R7Ia5Nf43AUW5nzuKAffNHKW//wRQVp/R3AO3NtFD8ZRT65 KQJdOoVYiLGJ2lTYFsgPgIdFbh3CxeU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NuaHeGov; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-236377f00a1so49487105ad.3 for ; Tue, 15 Jul 2025 03:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752577108; x=1753181908; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ndUwURMf+U4OPYsflaAXYVKWP+i2ltXh1RMS/eDGRPY=; b=NuaHeGovlNN1LWL87kjoIuOmZhLscUvRWtwP1A3bAWjo5H8y9i0aWEblBdVsElZcME MZVJrPw241QQbPErf2BBWTWQQhA8+YPANj3f0pFwNMk9HGkSlN03sOMQkPi1NlJSrlrs E6vFV807THeGxT5A7saFiLOOCltw2jignDsyMdPIPN68+KcFezt70xrUrjpshoOR+H+w h0DHVfQ9zC88zrHS8+o4pHJFs1Al2wNj5I9VnNDmUh4/fgoXsrmt8ww1LP5K8FYpuqlg Q+AstgtpfdR2YrbvNUECTYDxoFIKFDIoz+5jjn0onBoVtKozJKGg8wmKEgtMS7OPcEep aUKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752577108; x=1753181908; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ndUwURMf+U4OPYsflaAXYVKWP+i2ltXh1RMS/eDGRPY=; b=mwOsJ87t4LCz7G4RbKRI+K2+O3/DtwOYPoMDDdCCVR2cqypPpfNxFSAMK9xa3ECsk4 Z029C3nYP6qr5quCVMv/2XPU0TVFtD1hRloVm+1d5rB8wwSzk1cFhuHI3Mu21H37upeo OFGfz3dQ7Z2wY32AId0nbHqZM2bOnY6ph+gKGF+VfEiFlXZoAvbh615mentrpqVDFNst 7swuqYGk2C3lhxqVxTiqvv3KGIVv6l6RGXGY34/YUKJBg2toQ/G2v/u9uzDtDk5sOi3v lWOMi1cytFM/Q/PeirHJRM62i1Bdcn4GeEF5E35JThxDytAHn5VJddJ9EhCT4R3FFUW4 EoVA== X-Forwarded-Encrypted: i=1; AJvYcCXkm2/YK0NonhpMXHDirA6NnSbaQOuI1W2dQGVwqiuL0TrLwsFefBM+k47x6kK9YQof+k9b8whIJQ==@kvack.org X-Gm-Message-State: AOJu0YwpK1ZTDzNX1jaxawI9ebZXwF/OpzmgYOZJEYZYPB/mHFevxgYJ /ZAYcORtfuPWbScRbhUY4+l4JRFlEUJHJigz7pq8D0fwhZIPG2O9Mt/N X-Gm-Gg: ASbGnctP53ftkJtqpOamlUADLQu7+cHByhFHlXJ+jTtmsiMtdTbj48voivGVbA4JpfX 0Ak5UUw2uY5LrY8GmX/tIFP/LP5Qp+gIDVJI7z16+Ntj8Kl6pcXO7WpE7oyfFwrS13HBhNXM1LS UCCX59+Fo+0LP2jSGuNx9G46LzLfWLTMYouzjym+Kdr/BpyPCO3Y/vGqq5HMtCCGCD34hv/t8Tb NYlCZ32jYvYXFvFjRKu2V/vJARY789t8oUnJZKZcljilFCOzh9jYQS8zEcoXoV+Ybf3z/+xsFxy XN0IUuerAdWI6U6KIVkplaJRrnn8OdABPPMnstTUwI8xz8u3CSijyRFr3Rtz+17yWJlJuYt5YoZ EQqcYuzIkCynu6r2tDJ45cTk+RQtd1MQnfk6k6drL2YMWQRks0IJOuUrwXFQ= X-Google-Smtp-Source: AGHT+IHZojJB4KCQsrcoAN7BT58wij39BFDsuKXOI/dCz++AseZJzBELnhlhFyg4t821B7aHJ1/pnQ== X-Received: by 2002:a17:902:ec87:b0:235:779:ede0 with SMTP id d9443c01a7336-23e1b191970mr34025165ad.35.1752577107918; Tue, 15 Jul 2025 03:58:27 -0700 (PDT) Received: from DESKTOP-GIED850.localdomain ([114.247.113.178]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de4322dbdsm110059255ad.127.2025.07.15.03.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 03:58:27 -0700 (PDT) From: wang lian To: broonie@kernel.org Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, david@redhat.com, gkwang@linx-info.com, jannh@google.com, lianux.mm@gmail.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, p1ucky0923@gmail.com, ryncsn@gmail.com, shuah@kernel.org, sj@kernel.org, vbabka@suse.cz, zijing.zhang@proton.me, ziy@nvidia.com Subject: Re: [PATCH v5] selftests/mm: add process_madvise() tests Date: Tue, 15 Jul 2025 18:58:05 +0800 Message-ID: <20250715105808.3634-1-lianux.mm@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=yes Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 52B73C0005 X-Stat-Signature: cg4p3cuo1o9akhm9zohuanu4zs4gajf5 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752577109-982853 X-HE-Meta: U2FsdGVkX19Dlr7cKSGPXz5wBTNxD5sLv6KdWSvPAh0iY9NglVos1FUi5uHYTapjKuAldfKCHoeqcQHg9RqF2pK2Ioc4bMq25kplA2zY+chMatWdlfwc+r/VzvvMECvTyeg8+gz5QOIM5uY/3ZIVASS4g/WVsO0akeJ4HdZrjKIMHUXXWsaccGk0ECBXpYHcXNss8Mob7bh3tKvziXeHWfb45zmEwwYMLrisRN3koqvcUL+IWe6bXty/rU/rPpsMR/5P8JLhd91UhjdcalQAKRHLPvrg5p53HZxC5jkDTC2XlmBloK2sy0S1fKIgreJMHfn4VXa7f5uyeVJx6hKp+Y6GTzuHzFdQgipbGwGY3lg7jgsdTUB8w/5Hryk+wnoVPtibF8bOyTrg04Hn5UAPhFcP0TmWofDaEbL2d4xM9szx3W0v0FsP6nzYK52QgxqUe5sxQuinye46SRe5mVYcM6xQ0zs26rCV9PjRfN5CvwRS5oz7INgwZWBibEwE9hXEUtRvfZ/SfN+eeSqPkwSLgFL37gMg+dqVL+80sYV/Be++3gJhxWcE4DwDNKpWeC3htc7QAgfejVKPm4uL7Oih/KxCpxzxMkowoeU9grj7AAjBL2iiy/FZ5zu9CVW7Akdw7Mywp+BB3+BPqMPZqPmAimCmVimyOi3fVbORuoC8Un7TrrwiQm7A61NXB35Wxri+CsYhGvrN8sCdhD1pkdq7jWhrkF+896jW9GvRc46O1qKs/R/MZkV4pKpQz0Vl9MckEXgHmJbFVVQ8LlgOYUmWmCONxCzDovyJDC34ogwIZK8tNr6b+98zZWSE+4GFhlHGQjhlsAMS1uhFwPq/Yd3UGu0BrpIu4fH38Y/Tn4lu9eGtOhZQOGYRKIBF9GrUwzfo42EpkLAkyMsn1ZGDvKx3/SPT7444yaKF2n8VvLjm9TI0XCr1fEfY1dN0dg06KhPSt6DTogBPWU3ilqsxsUb +i2+qjjH 7iresEDYCQYYT2G+9O8Xen3AzuD0tAAE8/CVwx20lkMaUysIa8TjCxeCVnoDpSJ9+yMu+eK1mIJobBsY3ZOzD74VtQolsXLI03tQncODfhp4eltibnrsOpBlVQa7/s/CbHALkqn7HLmmTe85BqCzm/AkDnWSCqHIKOWS6B0TH7Vz1PZgTsHT8i6mlypDGPEtOp+OtgJkA+oZ82agmqxiMVzQ88g7+X5zmtTmIUB04698OJ1P9Ky5eLhgK5YpOnjSl5CjHHrN7SM7KIkJaa3FJPnMahSBkE6Iw+mKrGP1mw0I3Uqh5jT6qKbQzifAObWNAV9y9ORfvwn5Wl5ak5YTYYc9dVzFkZ8pA5lajuuzKx5FXnUbKpW/7KgCZXWaQEk8vHSGBOZeCxXo+ExoJeyH9Xl/2aP6V0X4OY+oRo9UdKnSZZ7aMpxEm3gQUu87zeGikXaUZsAofCBKbR3gOan1mpACsSfkj8YI2307CNXwyMWa7mmkCx5KGmLdd2IXPCMrSiStEto262ahujS7JwOgXnH2r3GnJ0S5zSIJ5EV/y7qyBEv2iYqpZ09GFYVGRDsGcs5DU+l5SIASzR7Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Mon, Jul 14, 2025 at 08:25:33PM +0800, wang lian wrote: > > +TEST_F(process_madvise, remote_collapse) > > +{ > > + self->child_pid = fork(); > > + ASSERT_NE(self->child_pid, -1); > > + > > + ret = read(pipe_info[0], &info, sizeof(info)); > > + if (ret <= 0) { > > + waitpid(self->child_pid, NULL, 0); > > + SKIP(return, "Failed to read child info from pipe.\n"); > > + } > > + ASSERT_EQ(ret, sizeof(info)); > > + > > +cleanup: > > + /* Cleanup */ > > + kill(self->child_pid, SIGKILL); > > + waitpid(self->child_pid, NULL, 0); > > + if (pidfd >= 0) > > + close(pidfd); > The cleanup here won't get run if we skip or assert, skipping will > return immediately (you could replace the return with a 'goto cleanup') > and the asserts will exit the test immediately. This will mean we leak > the child. This isn't an issue for things that are memory mapped or > tracked with file descriptors, the harness will for a new child for each > test so anything that's cleaned up with the process will be handled, but > that doesn't apply to child processes. > I think doing the child setup in a fixture should DTRT but I haven't > gone through in full detail to verify that this is the case. Thanks a lot for pointing this out — it's a very reasonable concern. Fortunately, this situation is handled by FIXTURE_TEARDOWN_PARENT, which reliably takes care of cleanup when the test exits early via ASSERT_* or SKIP(). During earlier testing (in v3), I did run into an issue where a missing cleanup led to run_vmtests hanging,which prompted me to make sure that subsequent versions correctly rely on the fixture teardown mechanism for child process termination. So while your concern definitely makes sense, this specific case should be well-covered by the existing teardown logic. Thanks again for the careful review! Best regards, wang lian