From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 672DBC83F17 for ; Tue, 15 Jul 2025 01:47:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E80906B008A; Mon, 14 Jul 2025 21:47:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E318D6B008C; Mon, 14 Jul 2025 21:47:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D46ED6B0092; Mon, 14 Jul 2025 21:47:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C56E06B008A for ; Mon, 14 Jul 2025 21:47:48 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 564F51D971F for ; Tue, 15 Jul 2025 01:47:48 +0000 (UTC) X-FDA: 83664812616.30.8CFFE05 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf10.hostedemail.com (Postfix) with ESMTP id AE2F5C0006 for ; Tue, 15 Jul 2025 01:47:46 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MtetpuWC; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of kuba@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752544066; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dbqTRABwswn3JRd4H4zj9alMnHMECokVD9Qln3UCuVQ=; b=bLP69BPO6t0FhIxwcFf1vwBSH3BJwgOFvAHMxJEYLVZzIPkE0SGk0pMsrytnAKujnjiAqU rBv0l6T/fuO+F5j7dJprQBtDLkwrj3RMIz63WiG2qdFngzsmxikxPNHNHcBGnP/dxDL0DO 3il/nLHXo52+uU5mZpvtmEoyDPNqj2w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752544066; a=rsa-sha256; cv=none; b=qqaNfwiaJG3UZMFT0H0mRkireQtZ1i1woWTzNLs4EG/SOpeXxh6243quWdyJFWhlNE1N7A syRnF/Kd3uHul6DgVE6yOm60cz6StvHGx/ljs7JSzqkIpqv9OlonQdlwYsS+5Rsinj6Gfg Kz9aImFzI8hHv+aSH875hUJ1Sv7aPnM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MtetpuWC; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of kuba@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=kuba@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id D211961475; Tue, 15 Jul 2025 01:47:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D36DC4CEED; Tue, 15 Jul 2025 01:47:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752544065; bh=lFcq4wxGSvsVKN4bYe8ysyML0S4XmhUy9tpWtp9XPeo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MtetpuWCASEnnObzSkOaxLtEAqc4VJzz07xLYongI+ZgJ/xbYKu3n0Qlqi2A2nCeb DMUGqf8WLg+txwHuOtARf8vYZjhrrE16BjWDoAA1ZwEs0nVcmlOmf/0BDKcCnoPCyK BSz4iN4fIsvAMPWkg5XKUvVcY0lmLJg14s2Md41RmFJswdH7jaDfGNGseqQ8wnJTwy tU2jolZzc1yP0hF+q8rhsh32bUaG11On/r7d2W/SxmAws/Oh8S6YTl5HdVvT16pfuU gueXwAPvxcUpoWxsyBGoX3OwaEuVHZmVTuXd6TRgZvxjWJrP/SA1fJuKCNsHfNe3uF mVMGCUIDmY73A== Date: Mon, 14 Jul 2025 18:47:43 -0700 From: Jakub Kicinski To: Harry Yoo Cc: Vlastimil Babka , Byungchul Park , willy@infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, almasrymina@google.com, ilias.apalodimas@linaro.org, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com Subject: Re: [PATCH net-next v7 1/7] netmem: introduce struct netmem_desc mirroring struct page Message-ID: <20250714184743.4acd7ead@kernel.org> In-Reply-To: References: <20250625043350.7939-1-byungchul@sk.com> <20250625043350.7939-2-byungchul@sk.com> <20250626174904.4a6125c9@kernel.org> <20250627035405.GA4276@system.software.com> <20250627173730.15b25a8c@kernel.org> <20250701164508.0738f00f@kernel.org> <92073822-ab60-40ca-9ff5-a41119c0ad3d@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: m55b6cdz34r3jb6ntum4i3non4zykuqa X-Rspamd-Queue-Id: AE2F5C0006 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752544066-876361 X-HE-Meta: U2FsdGVkX1/1xWC41T/33JIqmwEagThmXndiZjDi5aIZRwtoc/3ZEs1UvHu2cwZ2qrFXeqks/jLWE/mLSMx3MjJ1qwmpeGTQ1ZrErLtU5vRdydkHf3sGyTPKlttEZdcixN7J/GHpe7GeuSMZNOZK14S0vRrZa1u0Eo6KQuN5UjMu9W+GiksvxOCMdOOJwk8gEQ80Hmbdj7KZO5w0llaVlVy6xYCGyRrN8PocNW4dN9GcrnvshNQ1bjGjz7GEQVkulbI5hC1rqSx1GGwz4vRUbDTzxlyuawWrDJLkMr9g5bpFLI328wsFFjns6W1+FSbWyXVq2oo1X1HNHIs9W9sGoWkgvuumnJJ+oL0rlyxY7qV1pYFsU4pdY+Vtwa8z7lCY0hxDdzSXwMmpB02PaQlRPwfywHEAwc0hlNnvkDD5Jk2Mt4IxaoaizQftQ6r9WRd4187SaZu+5c4IxyT/BSfh3h76jS1Huslmq7S1Q5cZZia6GTsmuvZbpf2Z6iR4WYV2K+/vjLowm9FMe/vbbgyX/Q1RINryN5ULRKbWcaArTjnj8SguC417et0t4iQGSMijEmTawRJXtLihyxk0sFolCJJoctm+VTrTs1rdwLXvttTDiJMM5BbCpkVwMQHjYRkQ+RPU4iIdd4J7mBqSamP2g84LSw7eRaX11fsd5/Ou7mRp5bMeoIrv8lIlUwFq+eVEx8WHRZC24f7I6FZwkQ38ZscBtT1z82SFmrkAzuGq7vYN30n3VlrIgzJRaP/6HJTd4+pqn0N5BwBlhcfe+keZTTfA5WtxNiiiSvj5VC6UPFbuR+Web2TDosFM9giWZ3NsVQDhdaOGEv7KQ6uOKIbU736Giu7E4qBtMXdhF3DrmXwRKv3/FcyKt3DOit766VLoN6/NMXZcjSOmuJeCdGydUygqDMaomXhpUKlJuPB4ArCsySS4LrdZwCUYSUrkARV4IxFooSMzCc/0jDUgPxb VPdWd3J7 ur55LH1lhFV+sueabDQXJ3JSQ7QSmYmXaMWtzDyMg/21Rfwqsepr2oPrBC/EdQTB64JTw9rx4sfNT5/3xZU5TSthbIgocf663u0cWz/PAjf/tPyndWYSUvFQqScpgVc4DWBp6gy7uE1pvCe2gZuKK6k8r64Nwq9/aBbnlcG/oqD/5RpOGyyfnVrztRmtNUKqyt1hI0yziw4n7mpU5UXBlKD6G5TOJjiMpqroN4LJ4dMooa/ng/Pt1TZuXDEZUZ9dCmme8j1akLvlTLWm/fAR74T5dDu56qZmFjiSZ96Ss36h3bSdkP2QUEelliBz+lMbn2CCHsxmHU0N/Esn+SQvCntkyKIYiWqiwXdVssRRy+MKO4lWKPWT+9QEV/96MYQ20rC0N X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 14 Jul 2025 22:58:31 +0900 Harry Yoo wrote: > > > Could you please share your thoughts on why it's hard to judge them and > > > what's missing from the series, such as in the comments, changelog, or > > > the cover letter? My main concern (as shared on earlier revisions) is the type hierarchy exposed to the drivers. Converting things back and forth or blindly downcasting to netmem and upcasting back to the CPU-readable type is no good.