From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 793C1C83F1B for ; Mon, 14 Jul 2025 15:25:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1B2E66B00A9; Mon, 14 Jul 2025 11:25:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18A746B00AA; Mon, 14 Jul 2025 11:25:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A0436B00AB; Mon, 14 Jul 2025 11:25:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EBBDD6B00A9 for ; Mon, 14 Jul 2025 11:25:47 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6E48910C9F9 for ; Mon, 14 Jul 2025 15:25:47 +0000 (UTC) X-FDA: 83663245134.25.C3FF335 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by imf14.hostedemail.com (Postfix) with ESMTP id 7FCCC100013 for ; Mon, 14 Jul 2025 15:25:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=1+vcVuNh; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf14.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.48 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752506745; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4zjJXXLh5+tZigrmWR5HYIKk25Y2UR8qF+dPi0kLozI=; b=qFojN9XUtcDjPInaM50aiX00OWpRqou+8f+TcyYcbjxvbYn64+jwpaQ55BFHHX7lRgwvIG 7t4IF7hxGSKRSL36ncLaFuNzKb8cM3p+9H89C3WF/6Guaj3KvgVGE3Mv6M64NSaoFzcKFO S/er/E6NFVxp131QJEoVKdq9/Hy5OhE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752506745; a=rsa-sha256; cv=none; b=kkZ6Nex1TDHhviHF6g+8BAOs4moPIP1pfC79TB4mEUVeTH53Xt33NvD/mq2/f+wNLekIa9 GsVbdTUWTX7JpfpVwbRn0igoAA/TzLCjcD2bFs8FbXKunQIRR/+06r49ci0scdcDf5VUlq T+za+6eYuPIeam/xljto9RhftUye0mM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=1+vcVuNh; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf14.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.48 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6fa980d05a8so33393396d6.2 for ; Mon, 14 Jul 2025 08:25:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1752506744; x=1753111544; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4zjJXXLh5+tZigrmWR5HYIKk25Y2UR8qF+dPi0kLozI=; b=1+vcVuNheyGDMoB5U4Nr2SbemqcHpiFmTDRfFWZReY44vY4M2rmnzV42I0d2X+jMa4 V7xORgDuna5RD/y+ghBpGJh2/DdIR6ckVZi7/PE0krTwUZ+pqJgeHAyef15h9GLlovgO sZdKsueT86TgDYo8tmMyJtAeqHGS89UsiZEwE+dxxZqusM60+TZF5sfMgfoUPJwCQSaf 7DiebZIS5qRzdexQNnk/vYvvwexNZY43NslydbHU1z95r9WCmViBi5cb1AuHlozgl0kU tRziGWYI6m+kBAxWG3QjL5utj1+YJB1NmLYZMmBqjJ/EzfpRFkahKoFyTnIKZ2w2RkiZ AfDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752506744; x=1753111544; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4zjJXXLh5+tZigrmWR5HYIKk25Y2UR8qF+dPi0kLozI=; b=Gz5Y1AuALjjm1iCK49VVnjoKXCeViX+1Gu4AuSbAchX8yRntmCve3qoWNu2OWyeu2s szritg+N5WkhT/2V/230gTgnxwFlL5LeFtOiwLDQHpjjQdbnStcLrubP0agdboNySlPD zc55Dh+K0SgH8Qkq5vuLy6I0rpy/VY5yWgkph0YLnAWDkU5ZP0BYdoPmxrhMZM8w/AYA rxVSAD3Q8MRF3baWXA4P59tWfkINaybNHwdXFYX76bT3fy296gT/yvY0jVYNgzDSIi0S HFP2RrbAH/lpCjx5PblB0/P99snzFIKm/NqeHb4c7uR8eQcmEjUVhI9jMuYUPxGJqZL8 4u+g== X-Forwarded-Encrypted: i=1; AJvYcCUhBZIrjB+VPOIieZWHHFsO8pXBvPc/NWoDkJA0OLzIpMryNVL17qnOFh9ph5ajPF6Vn/keYbw55g==@kvack.org X-Gm-Message-State: AOJu0YzGpJVWXw0GIPxaCsMpRvA1ViVAjBV5VaHWh/BU15DaMtXXEGrI u6m+dvHv/NJUyiuiAdLRqgqMymXUUski7FpuXTjuYUeLLpIsBS8Mh3U6VfcpvSf8lc8= X-Gm-Gg: ASbGncu99AWwjkq4OZ7lVkRPe1TgJdEmDreB6ouuxMuYM3fhnUadfVN9xamzd0zqiGx UUHM+g9esMpeCXOpP1iKxSHE6SHjawGyFDdH4lPMaZW6lHrrrVDvripAxwAoxa2lP4/cRsXVcov +EfDByJmYlwWSA6FfheFrwGJ0c/k74FubhW7iFvnQbaCqMFrGoXcJvumZMYLc/i8sHPFUT35R2g 68RSxtEYuFO2UUDPRq/H9YdqqECBStXayzAoHXSvMgXLqDIQzu6+Y8YBQgECx5+ep6gpNX94bTr kDGmKmZKd7QaKzX2DSSVpN5x5CbLWLaOwgPvc0ZQ63fy6m2t1W4aOPZ35gRslNRigjlt03j45zc GhKF/GTgH6JErXHlaIVRq3A== X-Google-Smtp-Source: AGHT+IGbamWt1AigSEs9ivKOwpf41eWX2oLFFTHNBKRPHLRWhi9iVPDjxP+wb0xJDZlOHCzLCGEF4g== X-Received: by 2002:a05:6214:519b:b0:702:daca:9038 with SMTP id 6a1803df08f44-704a70175c0mr227046206d6.22.1752506744629; Mon, 14 Jul 2025 08:25:44 -0700 (PDT) Received: from localhost ([2603:7000:c01:2716:365a:60ff:fe62:ff29]) by smtp.gmail.com with UTF8SMTPSA id 6a1803df08f44-70497d895eesm48174306d6.96.2025.07.14.08.25.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 08:25:43 -0700 (PDT) Date: Mon, 14 Jul 2025 11:25:43 -0400 From: Johannes Weiner To: Hugh Dickins Cc: Roman Gushchin , Andrew Morton , Shakeel Butt , Lorenzo Stoakes , Michal Hocko , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: skip lru_note_cost() when scanning only file or anon Message-ID: <20250714152543.GC991@cmpxchg.org> References: <20250711155044.137652-1-roman.gushchin@linux.dev> <8734b21tie.fsf@linux.dev> <21100102-51b6-79d5-03db-1bb7f97fa94c@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21100102-51b6-79d5-03db-1bb7f97fa94c@google.com> X-Stat-Signature: max3gjsdknwtqzdcnrzqaypkydi9nk7j X-Rspamd-Queue-Id: 7FCCC100013 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752506745-25699 X-HE-Meta: U2FsdGVkX19t0eQfqzIN8gRt7LMIFKC0+boWGK5fosUwGdRfV+BTssKQ1nkp1FUEFYUXdfbTQruiPG+panWj+VWUVVCAc1ed8Gq2hveCQXBofY5Hvgm4vJ21JLbR5CCpM4tzKre4PD5XmyDbom0COu5Vmec+j81qAuLowq0aMDYtOUIYp+LpQTL/Vtf70pezlOFc3M55UuCm51ZiBptyHEpYQCHS3QO/EjQAxEcTYuaudn9W9m3ZX/5YesuER6Tg4gEU2io8t7M3/X13CRIVmDApMDU+2G6jnrcAkcl9nd255oGeRECWThMK1lXy9t/perG1itoXqlJ8/zB2y91oZ3Ij0l5mVflC+t4pDHOmzu5uZD7tw804aM9ia6DPDgPOEZ/0fzWL4zNE95ykC1kbI1p5r4avSaKLqCCcJQtPnwGwfs6WhFo8jVOMe3Lm6wyGAV5hqvR/5EJVNneBIWuTkvnsxYwdT9WM9d5kCabpVOO7uQMHArXrwcwmhKb9tDe7hExSEl9QXqpIrLr4e+EhZ2/1BTnjDygwh+MnEptmxcdvt+s4senJ77MH8d0KngyNUh+aq8F4btF3bZIzvG06KMbtnb2wJyhTRlJhiDbghVT3kyWxMpgVoAVJr4JCt4nvILPoo5E2/MHmIwKoP8OXbCBy6y3gNnZAjW5kUyAdijdvE94yVqTQAkeARihEVaR+jqcWW8hhSotzzluvNiopS2XEGccUtgC8t/2XTAXTjGTjLfTnI3T/5c9k8flDy7wAL7WCq2uADgIkjaawktgWch6Jmrw+YIIdOO+hdqbAm9g9V6gKVhtlW89h7ddvtr9w9tTk+vBkHsMbIoFHao0l0ZQH9lTSmyhA+DZOlTkXp9jSqJLVN99YocRgL+Ln4riHq7p7dhqGp6Z5oTAxeZ9+kfSeXB7IvD04M8RrKY1+UWHVhSs1aMxoAEZtvonleZ3vVnGaTa8TWSqpBP5X0dk eYkxpQ4f sjvJl7W9BUzzZg2KKVXWBMuviGo0VF0nsildTicI/8FoIrhEztzOYf90L62KDeBaiIlGwiDtU1TOLPrbf1qRtqNZDdtMVLQ95SlSKF7ypMExtjtt5CLD+r4ztMfsNqNs9tCAuKFDgJ7rlckhIQyxLa7i96EO0qnnmr0gzFRIbX57mHnu5JyD5ZfbrauSG/CDGA49w+yXsvLxZf3ILDKITm/t4jDiVdu+TIzqGpIWA1ZUcpgmdNv/8ghNVjeNUmESIvANWXZfpfBNfNIMb8KhIiKWvSTQ6LxCxQB1Z0n7NzaE5OcajZbLNq4j48Hyy9/B64h6F/H/PuNhs86rJ5vmKbJVzJbvB9DT/QA7OSdfmQCrR6mL11aKekH+1c2PmzxfTO8h4cRnRKFHK2ypRZNVjtAo6slHZU8e0+2bgOACUxUA3AJiMH8yid9RGXEnI2RyfjivEEa8AHw9hFEimYb2lFa1OxNQ9tQhsbArPlPfUTldB6nneSPRpcdS9SrwDHQZDQuC1kypWKZlMispr2JjxLqQt4VS3O5I9EGA1M01t1n0/N+c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jul 13, 2025 at 12:57:18PM -0700, Hugh Dickins wrote: > [PATCH] mm: lru_note_cost_unlock_irq() > > Dropping a lock, just to demand it again for an afterthought, cannot be > good if contended: convert lru_note_cost() to lru_note_cost_unlock_irq(). > > Signed-off-by: Hugh Dickins Acked-by: Johannes Weiner