From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83F5BC83F1B for ; Mon, 14 Jul 2025 14:37:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 244128D0002; Mon, 14 Jul 2025 10:37:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21BFE8D0001; Mon, 14 Jul 2025 10:37:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 158E48D0002; Mon, 14 Jul 2025 10:37:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 082588D0001 for ; Mon, 14 Jul 2025 10:37:11 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B029A1401D4 for ; Mon, 14 Jul 2025 14:37:10 +0000 (UTC) X-FDA: 83663122620.12.C76FD3E Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by imf12.hostedemail.com (Postfix) with ESMTP id D833640004 for ; Mon, 14 Jul 2025 14:37:08 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=GEljmaWs; dmarc=none; spf=pass (imf12.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.175 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752503828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XyTDdbiheRnKMGdgHLnRikk86cXTsPCJomYNsFHd9a0=; b=qMmn8Rxb4OHxltJ5N1Rn1B0ucKkPU5itKpIG01VjoR9QYnfv3JvVUNoNcRlsfQSn7XCXaW +2bQYbvpqKPyRuC4CIofsHQ2RPbpSEhSzXMmF6AuRI5DCQVe7DsfnOY8Lidq58x4a3ZkjZ IwELZzjjHYwL7yFrxXVyBVpd7QVqKF8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752503828; a=rsa-sha256; cv=none; b=DTriAzX67qNvP/DiKnJdxdYb+WcZvQo/hhWpDBYGPBs0hHCsfdCK8rNIJwdTS6xy6oacVb 7J9nze5T88sMKXgvFgbreoyX9AyHin6BC8Yv9itNJMLdJKh/OansBk1Nsi31s91Xhrix+n Vf32L3OzNCOPw3E/9xrUuECfjXET+8c= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=GEljmaWs; dmarc=none; spf=pass (imf12.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.175 as permitted sender) smtp.mailfrom=jgg@ziepe.ca Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-7e32cf22fdfso64364085a.0 for ; Mon, 14 Jul 2025 07:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1752503828; x=1753108628; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XyTDdbiheRnKMGdgHLnRikk86cXTsPCJomYNsFHd9a0=; b=GEljmaWsS+uxBzs69SZqHzE9sCAmRj62cl4dybpefSx8ElxyZn5jFXGg6fPxCvGFkP xWxURHbpDs1WBx+jB5IetXYE4AMOaZtgwSgLNlpSL9D1ysAPUUkFrmeCu198eDcsLoOx fOl0F00SN50W/ZUES9L05kP0frnMhgoBJ+cTOnBhYUAStaHd4cQVL++OfEpZceoUJx+M QYNzNwuYKN5cJKcKVYATEwuXVX+WRU4bCm0aoDJ+Dz7rcImMnKW/V5EeSFNdeninAbuH YfXqyMu+qwUcrF/HYsldJgbjK1QxsIn//KDez0MWKEuv1oLghz24cJvyBwN37Yll0Mne sxlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752503828; x=1753108628; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XyTDdbiheRnKMGdgHLnRikk86cXTsPCJomYNsFHd9a0=; b=QBc3HUtfCjbn/kbrdBSy9PeALQ/3AHl7RJyXcbWvxyLm+rau5ILr0RlvUTFPK2Hj3s vmQXcjBx/0OlAUx7rp3SkfURcCScQdbvugWHJ8WsKiySe3YX8hPuTGefeY/b804z75G1 Scv7A16VhfG7gFIPoKkKHGED2WunI0Nk7oXxhfeekBCJJiJTcrELf1G3J4q6dxeRI3H+ AHAwoG0ePswbA8ugI+qx/OJjAHWBAqzCP3XedH4XqP6cxIiGu1an5SlZ6dKZ5E74Fu4L Z1hkxdOME0tki3BJn2XA2Mi77LFYMrJAN16eUGsJIyf0fAVnGQpIRekaAdDnerzoVlB4 0D2Q== X-Forwarded-Encrypted: i=1; AJvYcCVwOoIb2hZ+BksTBlHJjdtu9mQsS4Ta9AfwXUvTsWk8fzJfa59wg5HgFhJk3vDqnM1DyNMHfbkBLw==@kvack.org X-Gm-Message-State: AOJu0YxILEomqb31qx+kGsFiVMlogkABr8Z+3Ue6KFVKAkgc/mG0F9Mw lV+KVHsv5DhT3APvvpjt1F7l5HhuXetNlPtXsqVot6k88392bPUIRWNxlsJHXuYE3WI= X-Gm-Gg: ASbGncv4zk5rgwa9hlh6JSaFesyZbLP2Uj+0d6jh0hl0fiinBs87muUv+yJLLp0Pr6R tToDw/o7iMiVkfikoF1feJ4PhzJH0TtszDbYvs3w5f9PjuMOeEOoctPzioZUFa+nZfZixnPjIav tYgb/VDfAsLyOHwH0moZ0YooU3w5QmXmmNsyyFG2LDovgoOax2XvqIDhqrHfhQqmRvSOWpYbED4 TKTCU/mhTH3oxeFtkL1HAPV8yjNF3HPcz+5KVCYKerAgfkl9aEjcqwBgEn0hE+e9ZDTq4OUWgvb FOYpW/wDi0VgpQcT7x6nD9JsHO61rEmWccfYBV5oo2ErseyBXJGajywMCeoSzjND2GDldy24iUD uGS+wwE4IA9UIwVlG/VFK2NyQVE1JEdGdabpJZaZH3qqMbdF8YzBF793CwtJ+lDVOSRaL5yoLIw == X-Google-Smtp-Source: AGHT+IGzSh4U8zlkbAbt1sARjalYvKWSIgZ8I6Ou+Sz022y53ECOehZLFJYmOuZw9cPfaOr9xiWGcA== X-Received: by 2002:a05:6214:258f:b0:6fa:d956:243b with SMTP id 6a1803df08f44-704a39bb51dmr231977926d6.37.1752503827724; Mon, 14 Jul 2025 07:37:07 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497dae711sm47567726d6.100.2025.07.14.07.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 07:37:06 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1ubKIj-00000008fud-3bh6; Mon, 14 Jul 2025 11:37:05 -0300 Date: Mon, 14 Jul 2025 11:37:05 -0300 From: Jason Gunthorpe To: Andy Shevchenko Cc: Leon Romanovsky , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v1 1/1] locking/lockdep: Move pmd_to_hmm_pfn_flags() to the respective #ifdeffery Message-ID: <20250714143705.GG1870174@ziepe.ca> References: <20250710082257.663850-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250710082257.663850-1-andriy.shevchenko@linux.intel.com> X-Stat-Signature: yp1maywhaqnydxgzwk474153isdwb3ed X-Rspamd-Queue-Id: D833640004 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752503828-1240 X-HE-Meta: U2FsdGVkX1/AbPgdtd+lH55xGx+DUI/0IoINeeoSotHCvODc3LrZQdmpLTkRkydpoRd1kcvmNVzajtsoORgVHxg3jDBdWzicUajn+xHf76JpcC8CBTy4Z1UPG6eLLI/X+bOmzAIQtP571k2H0i6ewijNZiNglLMefrMgxRTANaWRQkkKRVKGdq6VDbXPGOUquSdIB07uxKioWWTz+yQMOHhA4FLjCUb2pAcIzuz0FvP+1n3TVGHElSsfbYRWZ4VELw0E0W7Z1mvCyseqFqVrJOy5kqlx74wEYlpgRMtjQWjPCtEvfkhd23Ur3FgL/m9CPp34Ssd4zKLN13elrqg0yVDnuvWEqHT7xEm1zEDcpK5l9Dnz+/wGqCI+o44HvUkWCTl8HR/ADuU2/5TE1zHxdWLTRu5A1RDYaiHdTD0wrHkQBycNdPd6Z6EJZWK4rjuKxulUsbI0hzmC+Fs79Yn9H3xBkUgRlV/jVGTR/rEa2omPWKeSqHI6R0mQCMcoQsmw+02vpqHG0N9XY7BACXMy8OH5ta3irqgjpL0Wrz1KEV+wrC0MZLHDSJyVmdytCfX8lzj9X5udHD3yKfX94LqCLoRoZl2cmFrKDqWa83j7RcK4HjbLsa5qDbY8QU2f9gYYivGvsL/ULPlFi6wlAcXWEYFdd72imn1lLY1ghfatBytxEu+3f5//vmBtc4lSmWHD4Twe4qPmYG00AEesiGC6vHqMPvS9hpIM2I+QUiLf0XQwDKlQKd1bHTHkOMjZgHyJsyiX7OwkpgCNhOfU/BYLcf/zOVtJi0L/qaiS5VyEeg6knadCcq1BVeQOeVHRcB2PRxnIn49G8hu1Oi4dNdVjWsKALgFpbTarz/pEQQ54frW7hpiXxthnl4RRXKcoXwGvbekEHBdkXE+iCx2vpSoR5a/wlOBcbFYQ2AAy0dwi1FJ56uR2uxP/WDGodJSwFDtZLxb/bOtl+sqwLFn5gos /vBNtA+0 xVIXhFvfifMpFY8Nyq8AZm9wDFkb4FFd9W4lZSQAv7RIpQDm8MG/TvTwh9UcfcRBUhmJLv7dG0zmR0v2rA7lh/RwCfoHGUHXrunSFjtk4jlh59PLHhg11/twjh9JEIMD6YCzcI7lNBUmHchG11Y0IuNLfTTmR80baoJcy5+P53PSVOcq30QW6pb0SwFmCskEPZWUQy4ZBVbjCYGZlNjqLfDwV0TiGwzkK99VMJORxmqr7TplfQvp4uTvT7DCrKcekpfxnr6VBc5I5DHteZQzuBmgnG8Oeh0/Ve+OjVrQSeZlGzA2PkJBimFvnMDI9hFLp/RC3nHbcx79sF4coeh1yAZ7EsrU/xpgGQbpjpn6yDuZmAxKnXhUhYiD2A2oLzvXKUfphSV8kGqXLCr9/wUqiSFmQiE4KvwbdzRm4Im3JzprgXQMKhMmZYpHF/uySljTz/AVBBjt4eOXW3YQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 10, 2025 at 11:22:57AM +0300, Andy Shevchenko wrote: > When pmd_to_hmm_pfn_flags() is unused, it prevents kernel builds with clang, > `make W=1` and CONFIG_TRANSPARENT_HUGEPAGE=n: > > mm/hmm.c:186:29: warning: unused function 'pmd_to_hmm_pfn_flags' [-Wunused-function] > > Fix this by moving the function to the respective existing ifdeffery > for its the only user. > > See also: > > 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build") > > Fixes: 9d3973d60f0a ("mm/hmm: cleanup the hmm_vma_handle_pmd stub") > Signed-off-by: Andy Shevchenko > --- > mm/hmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Jason Gunthorpe Jason