From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5BDC83F1A for ; Mon, 14 Jul 2025 16:22:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0930E8D0010; Mon, 14 Jul 2025 12:22:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 043808D0001; Mon, 14 Jul 2025 12:22:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9CDE8D0010; Mon, 14 Jul 2025 12:22:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D54C08D0001 for ; Mon, 14 Jul 2025 12:22:53 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AFB8C12B842 for ; Mon, 14 Jul 2025 16:22:53 +0000 (UTC) X-FDA: 83663389026.17.5CFE6D7 Received: from relay.hostedemail.com (unirelay08 [10.200.18.71]) by imf16.hostedemail.com (Postfix) with ESMTP id 1B0B7180010 for ; Mon, 14 Jul 2025 16:22:51 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752510172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dpezYqAJmzyR7wymXugHEk4TjLTf9dnnHDZ8AhZWoew=; b=3voTIu6e51oVhthwP5WTExy+OUFjKtSljp8SYKbmIirRa/8aNqA8VdsCjR4dZP0xOfPb6Z 6fOXVimAq+d+eE6Isi9IWVoAmWorXoKGdKia2s7r5BouMJ2hrdcnfLXzzvqIjjgqC28/S4 qtZ4GwBCI28xwSS+Qb1Apka5Dkmo+1s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752510172; a=rsa-sha256; cv=none; b=ORqVnBawpYlaCaP0vhsiqcOQ2A1bp6J8aUIjRKyfIy7hVE5cuXygCS7CVwNTLhMdGVBxJh KCrdUYD2wEtcFPnhXQaT7DKsCZ9UzQ+VYpNqXMH0kR8RredMT5ml+rh1qRAOLePWv/mpTc dLt04tR5oQ5liPRUr6hYYNwBkgoQvm4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; none Received: from omf16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0982C14021E; Mon, 14 Jul 2025 16:22:49 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf16.hostedemail.com (Postfix) with ESMTPA id 895B02000E; Mon, 14 Jul 2025 16:22:44 +0000 (UTC) Date: Mon, 14 Jul 2025 12:22:43 -0400 From: Steven Rostedt To: Mike Rapoport Cc: Andrew Morton , Andy Lutomirski , Borislav Petkov , Christophe Leroy , Daniel Gomez , Dave Hansen , Ingo Molnar , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , "H. Peter Anvin" , Peter Zijlstra , Petr Pavlu , Sami Tolvanen , Thomas Gleixner , Yann Ylavic , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 8/8] x86/ftrace: enable EXECMEM_ROX_CACHE for ftrace allocations Message-ID: <20250714122243.19c9ab59@batman.local.home> In-Reply-To: <20250713071730.4117334-9-rppt@kernel.org> References: <20250713071730.4117334-1-rppt@kernel.org> <20250713071730.4117334-9-rppt@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX1/oABu5KOy2BGyNBDoF58dzOuDvF5o4bxI= X-HE-Meta: U2FsdGVkX18IZtlRjXFC0Shaa3uvZtomzZV05f7tYUhGt4RkiFauQtQUurUuegTuoLcma+mw8FIVARA/Wj5NN1NslWhNKbTBwkarCYNoTHSkbMcATn/le9x0PhshvTnU8uVrOxG7pycAfALTcc1w3cikw76Rhkqux8yXlXh5WTjksBbCQeCbYMpBNd3INbvKLRw/hnvxlWCLKGtVZ9+yDZC30Ll6nlpiwdG3iVrbKeGPqb/hKi2pJEU3Oqx+wqWA5KH1rGRg7cYtHo5Zj8AMWeak61Y/2Zs92WL9JnS1HNjdUBv0L5qegHctcO56Pol5m+ivZUt/rbVfF9j0dom+ncrMn26ImeGxznLqJ7Kz8xGyzj/8gBNpFF8Rucy78NTn9lGP+OYWa31Abm9XEUayW1Tb47d+HsyCntzFaZksEAl2rM/KM6GRrhZa1XZ5n9x59+tLnFeOGEArptCfL7/bRQ== X-Rspamd-Queue-Id: 1B0B7180010 X-Stat-Signature: r5wb4pojfof4fa8g781jhh8kxo5zdy18 X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag-Orig: 1752510164-377651 X-HE-Tag: 1752510171-338834 X-HE-Meta: U2FsdGVkX18rVjUcZAOQLxQh9vC5YPTWBxRD/2bOZplQQEkxoPJ52Ri/z0WCAG69Tx/HP+0p6XNJOQl37HYeU68UIFrwLH1M0app97bdDze0wnKm/W3u9kKcltTbDGwekbjGTeaPd4E+EPrgLswKHbE+jsCpnPu2GCJF3dd7Thng4FYfhcPs+rWuf8jvQQJMVZS8FYj6f1JtASIV56R7OrGaBuHZ8k8Wg/6OwMWrOPI9OPfdxzzdbGfhdRS3WMKqAgCEKKhcKrqd5W1jFqXpXlA13exd1zAmvPw7GFrn4oulwqMv/LQaO2KF/J50gK0wMtTXussMLZgPBQwLYj9tSMyzcAzzX11fMwQ4s3eOl//oqtSo4suG53ns05bpSHn4ibkmnrtDSrRHIp3j1EYQ5gPCuqDiOiHUCusFwj7jlIWSaevO0FzHcCpg3NOIJPtOnyMXEspxw2ybP3g+5tGG6xMlb/CyITJtqiFKXI+L8gFYFyCcyiOuIO9MUfIkjP440t2kg93dfH7rca14cSTABe1P0V9iQa3oVPdASx1iQ8GrY+bU/Z5OanSyiQc0i5M/JInr+JyP6jIRUmh8az6XQ2OQO2idX8YmQWSHSMK+HpzN+OTC3Djggo2RVAIy1ysCLG3Yu5Wb9vcHnCn1SDnPuse49PhWrMnw3oEiwzRi9j9Ej5m4MWwrhP3ebv7gt+HJmkala17ObrFE561RTtf5BcQhvpjIhm54hJOdnti/YHR4ZNXqr/cPxPfBbmmd6LPRM7WSlg3e4htrpEXQxh3E9fCn2b7hLWgGqxyEp0ZXziw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 13 Jul 2025 10:17:30 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > For the most part ftrace uses text poking and can handle ROX memory. > The only place that requires writable memory is create_trampoline() that > updates the allocated memory and in the end makes it ROX. > > Use execmem_alloc_rw() in x86::ftrace::alloc_tramp() and enable ROX cache > for EXECMEM_FTRACE when configuration and CPU features allow that. > > Acked-by: Peter Zijlstra (Intel) > Signed-off-by: Mike Rapoport (Microsoft) Acked-by: Steven Rostedt (Google) -- Steve