From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20374C83F1D for ; Mon, 14 Jul 2025 02:45:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA2496B009C; Sun, 13 Jul 2025 22:45:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7A536B009D; Sun, 13 Jul 2025 22:45:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 990496B00A0; Sun, 13 Jul 2025 22:45:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8592C6B009C for ; Sun, 13 Jul 2025 22:45:39 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CDAF916047C for ; Mon, 14 Jul 2025 02:45:38 +0000 (UTC) X-FDA: 83661329556.06.3DC662D Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf05.hostedemail.com (Postfix) with ESMTP id D312C100005 for ; Mon, 14 Jul 2025 02:45:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OdShkcAJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752461136; a=rsa-sha256; cv=none; b=d5F34c4CcgiYo5b11T40uF/v/w2gU7R6zyGj15Rz1g8qVQ6OOWLRE80yILM7epjRAONeue mPyXEntnazrpEVe5RFfJeOgBwKJb3WZ5kHQkFrarHhVv3tAb3rNVXlRFNxjxLsE7ZIdBxb 3L03VE4ERaY+6GAhhJPto/PZy8xOopo= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OdShkcAJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752461136; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oG+EqU31LjDY0rxsVXRvh11h8jbd96upL75m845wWxc=; b=6cu49UYZJhLzgBsixnCLHbBxIDbw9aRXu9/cSYGOdxIk3Ylv7Swo0JLPlfKHy9bVtDsKgR Bk15ToUnJH6m43HH/nDdQPowMapNHn66eMmGJcsS+1mVClvuYfEFVPBvxisoFnAKvl6IJb ljzgH3d63/cPwgeqxUoXmCMuL3BcMt8= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-acb5ec407b1so679105566b.1 for ; Sun, 13 Jul 2025 19:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752461135; x=1753065935; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=oG+EqU31LjDY0rxsVXRvh11h8jbd96upL75m845wWxc=; b=OdShkcAJubJXDdt/eGjv56Ns9Ihh3TtrRBlUD4wgWwqcuTMeOf8/SabVfJ9e/uJ48x 2EVDDLz51NYZQxuKT1G0xZ3NNCq8wP+2c86c5aE0kgwPskbvbD4S0ex01OZunihhjoJs yzfOnE7VfieKvJTWxeEzN1T7KHNhgfFdAfJRPt6H5ME3laKJz2onxEMhzOvNRHbvLAWs lEGuPQ1ntXZLO2XeMvtcf/A3l2pD55GoZyfuuGhNsOnPoKKy2mGkhmbi+cmRP7EkA6Id xWUP8FmJanl7jXqxuFqPbMXRMRxQvudqJnzv/NWFoOfRw1I4qNTLSSI5eD/5gO11GfDi MRuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752461135; x=1753065935; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oG+EqU31LjDY0rxsVXRvh11h8jbd96upL75m845wWxc=; b=vA1/OSbrjRyLKEdDTUddqi4/v7wgzVNgoDsKlJOCucU0xe7BXB13vZzx4MOrUJR0S3 Q/M53vY8rlYLlXf4wSJ+Fhg7vNDlWtEZjcLX8QVAdn7J30sUfOc0j9UWPt/1ew67hmrw pxSR3INRBjSbh2pOaVHMH/CeRUDPQ1vzhNqTRAPDGhH8gstStpgMZmJOBHp1vMcjfBr8 HCmjZopCHUORrTnaXV6VGKh2A0Vs5RZx982mYL97+KnO7FCuZiHECeblEQ2KsmTKaLLe mE07colAw7Jpn76bx3QV6FVRIduFwH2iDWsulU9y2pIxsk8X0KUOHsGP/FJFricNkFuq KgbQ== X-Forwarded-Encrypted: i=1; AJvYcCXG0w2dvFrpmoi/pxP7X08Lz74n5+XF542YbLq8V8uoK95rt8ANNW+kfoLIxs0nDR1YrvPvXubTrA==@kvack.org X-Gm-Message-State: AOJu0YwwSBMlbJ+ok2cyEHhWGsYuWRuIDzlkM1jc9uAsnrjbzqEvV5C0 qR7VegbolqcVEpWa94tSM/3oWUq3iMPxFM3qq0+I6zAo+lvBjYWYlN4/ X-Gm-Gg: ASbGncu1YpathBbwyAEf774j2G2BOdckdWExt8eew2qbTlkA8Bhm5yav1OuokTZthVn K5oGqeJtkmyUvtjwuImFrvRAHJLDGYfN3BAq/yNTMdYBgSNcDeq/L1BFiqFK1BSiQTFGjiLRc+l e66g9nqKhQYx+0acFEqqrTI05zfkVPKI2opVDO+gjReneOOIJD1q+HtMRiL1l4fd7lsH+sL2PFQ DCkf2BX/7W72ytxIchdt8jpa2igHC4tl8FpcCrNUeIfJwDj3GBm3VTv86H73YMkTTljN+x4ss2U oHQyBMNM0S2ROFoQ/FeHotOTNALqfOfe2BEq2KgvuXIyZtCCpznuriZWHRL5LRAG6h62nmqCskC HEDiDNvC5C3mZCoOtoaNIaQ== X-Google-Smtp-Source: AGHT+IHGtRe8EFfh1hYadjrhzjsSqtJqAm/1G7H3WUAtna7LHp58rR5a4n8y5bN58JERDNV9pNojeQ== X-Received: by 2002:a17:906:f599:b0:ae3:5185:541a with SMTP id a640c23a62f3a-ae6fc11239emr1123267066b.54.1752461134976; Sun, 13 Jul 2025 19:45:34 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82645adsm743476766b.107.2025.07.13.19.45.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Jul 2025 19:45:34 -0700 (PDT) Date: Mon, 14 Jul 2025 02:45:33 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, riel@surriel.com, Liam.Howlett@oracle.com, vbabka@suse.cz, harry.yoo@oracle.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [RFC Patch 1/2] selftests/mm: put general ksm operation into vm_util Message-ID: <20250714024533.m3id5ovvsm7vhrwc@master> Reply-To: Wei Yang References: <20250604082145.13800-1-richard.weiyang@gmail.com> <20250604082145.13800-2-richard.weiyang@gmail.com> <5f7f1281-c75e-4cfe-b51f-8d6ed001200b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f7f1281-c75e-4cfe-b51f-8d6ed001200b@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D312C100005 X-Stat-Signature: ecb7po161iwtcy6p1jfkwyapjr1gf1iy X-Rspam-User: X-HE-Tag: 1752461136-528054 X-HE-Meta: U2FsdGVkX1/WA+DlpWXbjnphIRikLLqeKCD7/jwXV3W4UOK8dLAvdvzt374TqgQgy4dhf5umByyP0/zTWz9PH3pUloCuVGdfpBwMrSypqM7J6X7xUtMG0rCSNgNSItcCQ7Ysjdzj1loX3LVUC9OXSDg+M4rCm01Wl+IDSgOFRZtTqfe0qcCRZf5z/h5iU7qZb8+7xPVZLAy/hTZMr8OjUDURM4ulcd9yJHaLEbDoqycLQRr3F7aGKjSk5M8Bu7jrmF5DAMo5Vbxzbe0iRlp9jtEOspLvGz1yaTRH9qjqnk1O7a9Wab1/4rHznkdMuSOANgZUpI67jQQMZN6jJosBQg9VCSdKyUOiBCHU78IKwTSjty+gGrdz2zkIFsfh4LIsiJrj1OFC5SRNq7cq8+HkE09I/rR3jjXN6Eh7G3YrNcn14Qgsbhatpcib/Cjo35QEW2N12SEqTTHX1DKTkgrcmqQuFhhIxqc9chDCBosAMQw2sSUeuNo5xavJkSFIUegIw24LQ3bdS+g4i81+DaeNo+tXLCWgONdZDFM4rplHsDyrj+H0kmDi3Snw6TSZs87q2jm29qNAEOT3gTWSBQT0Y2NTBCh4XEXEfViJDkL6ALat/vPHWK9r5qJLYOWTUlJqByOVJiYJAu7I/RBw5D6+GJoEvv76xvVHtHGmrYStlwcZluGJnPgKyfROPSWSXOPNoSnW90EWMWmZoqvs24YiXUERWALWke6xwghQW5lGyvih4TvHiUv9ucMJI0uOYY1LbQVx94aLv+TgLInaRhOWTBUB2wjPP5IAGS+dYAbyGdi/rolsiWX+yAgPTg38kn0PoX4Lb5mTTmtxJyLjPdlyxEGDDu/Ctvtk18prTxEf7sdN/ulC1T1ukBaMWhtQj7pEzVxUGqIrhbMZUgmFMR/zlAIarGiT2DWK6/gkdzqLneP8ycPEz3fj7GSjwncx8whx5iIEKzzebMxBjnSjxwc LDCgNwVF Rj16Rxh30i0o+5rMy8FULJ1O+JQR8deg7qxy4gOzzg+3Fr6sEfFc8G1eg4UJ+KljcN88FUCxwKroNIuPos9bQBFIKa9JE5yaVv4upUlZNpJKutHdvFp0rEt6ZUOv1Zi1vgELHMXjQEeClnb7HmSwWimHQDhyzMJWsSCtnVKye9wDhYSBJZUIjHEgD7448MdMitcxjndXn9/s7tB2uRIfLRaC1bHXHdhTcQWdltUCkusnrAblyPle4EjmB0T2P1uT/7d6k12WDEku+wjhCcvGqDBTNPb5P0Bn9Dw/N5+Z4EzJmSeKUSzhWak4lctHmNVcRucdhVeenSfh2ON6Z3z+UA6hwX7eh4By1EKEZipB0hAvgEFPRygA/81NyPUyarWRCvU7VGkrZqaSTlDJJQZJHMq1kBYB12jAEKulL68fU9lJOznNLzY2vZ3eSxneXhFLf5lN1/hJehD7vgJNQCL7VnaTUplKg5ZApapQaZ+VI33S9kQP9bm9/qUKs7CdFC1l4K4qHF8sitAEhwRi57P9Fmkag1aCEKNvwbyTYIc/1Mk16x/cFKzoT68Pie5/3+WJQFkidD4qHJZJaWwzGylCDscvejNY+PozbXnzhl87nhaU125TYApkwRF4ocalrfnQkWbvubwidsCLXHo3IpkVTvZHMubuyP1UjNpdfiJ0sBxyM4etgzka7vz8KwzEtzDchA9F358UjwLjorIU4JQRD89y5YC42l1yeGeIYKd67WOA9PiYVvDC7g9mtjw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 11, 2025 at 05:37:54PM +0200, David Hildenbrand wrote: >> diff --git a/tools/testing/selftests/mm/vm_util.c b/tools/testing/selftests/mm/vm_util.c >> index 1357e2d6a7b6..115422e9eb68 100644 >> --- a/tools/testing/selftests/mm/vm_util.c >> +++ b/tools/testing/selftests/mm/vm_util.c >> @@ -486,3 +486,74 @@ int close_procmap(struct procmap_fd *procmap) >> { >> return close(procmap->fd); >> } >> + > >I think we should just let all these functions open/close the fds. So there >will not be a need to pass in the fds. > Sure. Will update it. >> +int ksm_use_zero_pages(int ksm_use_zero_pages_fd) >> +{ >> + return write(ksm_use_zero_pages_fd, "1", 1); >> +} >> + >> +int ksm_start_and_merge(int ksm_fd) >> +{ >> + return write(ksm_fd, "1", 1); >> +}> + >> +int ksm_stop_and_unmerge(int ksm_fd) >> +{ >> + return write(ksm_fd, "2", 1); >> +} > >Can we make all these functions return "0" on success? This, way, the "write" >will be an internal implementation detail. > >E.g., > >int ksm_stop_and_unmerge(void) >{ > int ksm_fd = ... > ssize_t ret; > > ... > > ret = write(ksm_fd, "2", 1); > close(ksm_fd); > return ret == 1 ? 0 : ret; >} > Sure will do it. -- Wei Yang Help you, Help me