From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 852D4C83F17 for ; Mon, 14 Jul 2025 08:13:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 232AF6B0092; Mon, 14 Jul 2025 04:13:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20A756B0093; Mon, 14 Jul 2025 04:13:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 120A26B0095; Mon, 14 Jul 2025 04:13:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F3B236B0092 for ; Mon, 14 Jul 2025 04:13:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A7C01C0458 for ; Mon, 14 Jul 2025 08:13:04 +0000 (UTC) X-FDA: 83662154688.27.2E04BA2 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id F3FE9180006 for ; Mon, 14 Jul 2025 08:13:02 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="P/e4KxYT"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752480783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TWaYTY/hstID9jBeyUr/JmiwBcbWdhr1WUaCDr06wDA=; b=c7WyBV58s73oGA6t6MWKCuvXhANrazq52op0hqjx0TLUo+bW2YZIwchwfAOu9suOCLYYcl NGQbYD7VwUkLr87bx/mTQXgbzegR8D9ZdrGPOjZBvxADbuNRHWMjohvi94zxmB1ExAnRY6 n+LRA5cyEIXjeDqntIVFuPprEEiP+GM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752480783; a=rsa-sha256; cv=none; b=KoVkhXiQRUp6IE17hFWuhaVIRvtqNpMc1d+0ZaQGWKal8/EwRsegQgj4OGfAmnUmlSgGaQ ylOhxoS6L+qr2GhnYXEzb3XMCmFtRe/jHe9WwjasNd5jNq/37YjasELcD4UC5ehjuQBveJ mnOKpqUOQSJdgM96wFZNZBJuLeEXN2E= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="P/e4KxYT"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf24.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E70065C5A34; Mon, 14 Jul 2025 08:13:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F2C4C4CEED; Mon, 14 Jul 2025 08:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752480781; bh=eYX9mlVmNIdiqs19RLbDyQSky0HEgi+QIUoV5j9P+zY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P/e4KxYTKu4jlOwPcroo4+UNuZsjPfHR2xBpjWdqyGeNIzT4J7HmVSa8cFABYww4p xYoD8x7nZcDn4d7G7nVzkQk3CNcydNxiiMTV33PZQyPjdUdR+fSv/OormbXxiDAIWh GH8Pu6tomvgHwde9I/xx5C9Nd4staFpwgBP11jdxTVZoRpenyORR3soAk4FOj3oS/M OSVUxtjQ1oaJgBIPKHBa+Q49cJRF9bfJiK69+ZXCa215ycojuFGb3mAPO1ZUFZE8YD oC1jdTeRNcUQW8m650eqtjt2nmloLAdwpQekHw3dhBvv9BeLiJPYwmoMdtn5EMkdB1 aWBkV/59JP0jA== Date: Mon, 14 Jul 2025 10:12:56 +0200 From: Christian Brauner To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Cc: Al Viro , Luis Chamberlain , Kees Cook , Jan Kara , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 06/15] fs,fork,exit: export symbols necessary for KUnit UAPI support Message-ID: <20250714-fernhalten-holzkisten-d085d5802884@brauner> References: <20250626-kunit-kselftests-v4-0-48760534fef5@linutronix.de> <20250626-kunit-kselftests-v4-6-48760534fef5@linutronix.de> <20250711123215-12326d5f-928c-40cd-8553-478859d9ed18@linutronix.de> <20250711154423.GW1880847@ZenIV> <20250714073704-ad146959-da12-4451-be01-819aba61c917@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250714073704-ad146959-da12-4451-be01-819aba61c917@linutronix.de> X-Stat-Signature: kc1ee9ed1j4kmwbeu939r6mw977rme3q X-Rspamd-Queue-Id: F3FE9180006 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752480782-377287 X-HE-Meta: U2FsdGVkX192RoBfepM0E1FbIt6gBopvyNLWCDz3scYDCeYhvUMT8xIdIGxuyrWrGmCLP0rZ6iyJY6IYHpAEJ1CRuxuy0f+Pda8B4r2/t7zrou9Uc4645yydd7haa1gu2D8CBOug2TElJB6pVS0JCZ39ZgC6Ool0nPupNlIsDzqnT88Hx18BVoyQ3p3fHfzFwtHhYb3ezdldx9u39ZHafOYjk4WuiEfQurZjyC4Q59suoqKf3NYbWufEV1nlnJ9jGxuJRP/OFLQzVkXqZxDwJjXnFPaAzziaf3o2bfaIYb1vy3uTnziN8sPRnM/DOoKbD3nLcV7C370CrTnWv4PxgGNF5KSvakgI4uyBZF6Vs4kVWgJs70BZ4Ew8D1zJVGbWK/CWpoBaM2g9Wf598nTdGsqTNNKaMbGzcbB7ECo0Akb+Whh8c0iiJIVi9Cg4ivSqdbswqohZLEB9CYGKCJirHVlqlzeBnMRjpccG66SOeXLSYgcUKbLzdk0C4sMcalbFupft2j6mhp06y5FDyCp7IzaAQ+egvZSf1GcNMVwmI74IqZ+fjvfAPyW8v2WPh2yIa7m6l4I7PqWGqr+XiVPo6XZFdLMNa93jhCG1mSgAfCdextctuS/RxD9ZpanHuZIdi6DdkAYOMD2N4ZsDoIK3JCfJNsePImX0B+3yMBOuHVvqZA/Ohez+uY3NsJzRyct1wAv2IPljOayjamvaFUAm3XOuh67H+7gIEdDWfo7zDOtcYfXz4eENYWIYtG5L/AWZT3VlDWb/16qQeCF1azmSRauqlHCmvTwfKKKm7zhw0IWxze+drSQV6buLumji03cQ727bI3bZ2S26OtoUTf8kwiz6ebDeG5JCdKosLEFcpnFCGcOhr+tsqVgo1WJvgk7WGs4yF5IE5IJbFv85cSXfnYSoS9USFZk9fXDvSWOgexW9FYZPnYRbXlJka2GP3Sm3MITlAA/8lyMxQYBBImi pSnKIPQf pepMoXh745aEARqmz44XNBGtwseq+BFS/H+8J6HFGc6c1jxFVByYxaJ/HfB8VYQpTrUhCsz0AaYocZziZqi/rOI6yRZFry0mlFxXbKIsA97XEctTieLUMFvKuCkzB+LrNO14ZAMUN3NnJB3iJnPgfUc+kh+KhGa32cOZswH09X5AXhSDOCkjJ2vZtNYSjMrAs1NLU3J2UEAFnmqT3+/fNRg/42sGtRVlhcvpYUhNv298fXAA0UOQWkaWzO2/PxMkLA+53NVApyh1xEdOsVl999WBGtrpx6ZZ/9y9q X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 14, 2025 at 07:52:27AM +0200, Thomas Weißschuh wrote: > (+Luis for the usermode helper discussion) > > On Fri, Jul 11, 2025 at 04:44:23PM +0100, Al Viro wrote: > > On Fri, Jul 11, 2025 at 12:35:59PM +0200, Thomas Weißschuh wrote: > > > Hi Kees, Al, Christian and Honza, > > > > > > On Thu, Jun 26, 2025 at 08:10:14AM +0200, Thomas Weißschuh wrote: > > > > The KUnit UAPI infrastructure starts userspace processes. > > > > As it should be able to be built as a module, export the necessary symbols. > > > > What's wrong with kernel/umh.c? > > It gets neutered by CONFIG_STATIC_USERMODEHELPER_PATH. That could be worked > around be overriding sub_info->path, but it would be a hack. > It does not allow to implement a custom wait routine to forward the process > output to KUnit as implemented in kunit_uapi_forward_to_printk() [0]. > That may be solved by adding another thread, but that would also be hacky. > > It would probably be possible to extend kernel/umh.c for my usecase but I > didn't want bloat the core kernel code for my test-only functionality. > > > > could you take a look at these new symbol exports? > > > > > > +EXPORT_SYMBOL_GPL_FOR_MODULES(put_filesystem, "kunit-uapi"); > > > > What's that one for??? > > What are you referring to? > > The macro EXPORT_SYMBOL_GPL_FOR_MODULES() will only export the symbol for one > specific module. Personally I'm also fine with EXPORT_SYMBOL_GPL(). No, we're going to use the new restricted macros going forward that limit exports to very specific modules. This is a good example. Though it will be renamed to EXPORT_SYMBOL_FOR_MODULES() anyway.