From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9C1AC83F10 for ; Sat, 12 Jul 2025 20:47:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 563306B00D6; Sat, 12 Jul 2025 16:46:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53A966B00D7; Sat, 12 Jul 2025 16:46:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 429526B00D8; Sat, 12 Jul 2025 16:46:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 376706B00D6 for ; Sat, 12 Jul 2025 16:46:59 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 077AB160290 for ; Sat, 12 Jul 2025 20:46:59 +0000 (UTC) X-FDA: 83656796958.10.C1EE3D2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf17.hostedemail.com (Postfix) with ESMTP id 7280840004 for ; Sat, 12 Jul 2025 20:46:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NQSKUBSW; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752353217; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gYRlhV48Gdj+Og1+O/T3wr/eIxOHm4ZZ5ZZ8ym71d2U=; b=S/1h81DBxZYsZ2J6woEquDK0NnupfIS+UJeSsWfKRRQQfw7Hh8ZRx/hZSh4VuPMmr5loqW XZsVdqUcax/y1iiGiZToDtyeCYLFR4iDHf1oc2v3nYBeDION1bjsINR7M9yl+On4nClQtb ZpyAzg5Ad/UW1pcS1OYtNnVS07HqWjg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752353217; a=rsa-sha256; cv=none; b=Zpb4wedjyAqWAFmQjTV5vZSjTf4372HafHXKUqO4AdQZqgmgSE4KlVliFZrYs29o3qwUSG zr1H1tecfuVl6084BQw324/B8XknZUbbZlUltcfuKPRCcx/aKh0mcFI4weG8QwmOZBwQ6t M8C3JKPW43lOCUA2QCKzvie/DM4lTfo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=NQSKUBSW; spf=pass (imf17.hostedemail.com: domain of sj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C50EC60007; Sat, 12 Jul 2025 20:46:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5373FC4CEF6; Sat, 12 Jul 2025 20:46:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752353216; bh=SptuOd03XywpvQiMEZUPNF5dCaw77lP6zwsmYKtYbTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NQSKUBSWj7FE+BZxkssA7T1mqK6ihBu5tZunnOUDyBPn263atqFNj3tnXfZPzNghg 0lLnzar8exVzdM0OMDrXbJOX5yguhctT0z3hAqhln7S2xbMDnnIvm1ionsTVNO4GcQ KDfUhRzZ04BF37p1t+fDt/ORQeHv5TFZE/7jLa2jQ5guGZyysSg2pFksub94/rGAy9 2lFbSvJbSt3JNeYn3uPFDvYNZfTxr0kXG9aNydGKk9MdJD/UUX4/Mu1QmKJl++P0bZ /UotQA9xo9avwGst7iZONhMjMm3kz6QuYlNDLUw9NqQc8KmC3r8zCXrsLHdSEIOHHF ZKzAJbCGVRR6w== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH 2/4] mm/damon/sysfs: implement refresh_ms file internal work Date: Sat, 12 Jul 2025 13:46:47 -0700 Message-Id: <20250712204650.155988-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250712204650.155988-1-sj@kernel.org> References: <20250712204650.155988-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7280840004 X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: 7z7by98gonf4m4jxwg9bsubsxekoyoid X-HE-Tag: 1752353217-431046 X-HE-Meta: U2FsdGVkX19hHVAR1sFxSsngxeZUU1nEvZJHpqWhN2AE62T70ZKrD/AwKGplFYwAvPXPcV0o296QWIzIAXcYfIGA8EQZ5qr8YI6TvMR0n0IHttrGuz/0j7voXmCLiHN7o/qP8jLn1jdZNUUmM22rYa1vK39zNsBvsuPOJwVh52mLVlqj2vW1BJjGRUdFBZ8rspBKhcCh5KB/p1McC1TSsspS1RFwy3eqqWbSVqTNdCpG3FRNDR5Cq5eCzeYbKgQYrMlFYEOE9HZ05NN4R4wouBDQbJB+w9rOT6FDoyu0qv8GzcQDdVkspZOxw3xu06i1fTT0zSQwrHY4fw2iypSKvDe64wFMl2OblGc0nyl3TwjECpNSjRDA4nIJwFmtpW0Q6yNcpg7M3p3S4xpCKTLVS7EC/6DT37Vxj0/PlGHu4nk8ZkS3ymNCjvc9KOj5gWNqNX1trV0QtyA80aUD51i0siRp5kGKlexsuNTis6AYZlIWwUg0zwCJKCwQzQsSQQKqz/fcDQSOJtkQ3UjECjSrGYJ1i55V8eIwd9bvKRSakfFfRqp4VnxYsPUi1rwT+SKUbEyL6Dag3voYsLGQUbHqu4x5ctrT/hNM268uJ6SMpHFAaByHHgRuUv0FyPKPvkEti/sCzjlby+OtfNe1n4vAQu39qTYUxxAiZQHFqEGRZnPGRqtCvl6HVKvyT4R0W5JLZdBxwAkOfeQHN/9Y2l5fpzS+VTRaqW7nqAsr48rxww4r+ot0nzsYmQ9Mg9wo+M/DFOzwgJ2oeVmDy6vkIzm+kui50/49FWxD1T4yP4d3x5RIH5qceCtfc88ksVoPAli3T1xelSTuyN+77HygiQw1Nyqh65HL8183+VJwpPtLCLOq8XvtJrPLqPa091BplVvsr4TstRqf4GXhCmq0vz8HH0BnwixiLEzD+FjnjnS/HnQ4dHcL3sP4E4XywB/bHjm2E8UqKAaVU9Q2ADrJQ2x vSiUsqeM PWuDELY67kJwd62jGjivA+P8nHscWszzhYWef7mxueVj488nkooBHR1YxMy8FVMc3cJMdmsWomSBlL0vpwzpIamTxcdtCeKa5gaCx81IZrsifMTwo2mM9lA/0WfoEQsPG4FUNmtKl19b8GrVu8zyijBRDeHaR5LR+Bf9nz+sySDgq1IOu4Go5lkIwqs4Aakz2OJyCnuRZb2F9hvbkhkrROHi5Rk2l8HtbYQb6ryQmnF4T/nTGy4mn9FqXufjbHJMjPOblqPefjv5kZC/0m0wPwi1RFLYYAXwnmCRVTvpboZ5dwtn0loq+esFpgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Only minimum file operations for refresh_ms file is implemented. Further implement its designed behavior, the periodic essential files content update, using repeat mode damon_call(). If non-zero value is written to the file, update DAMON sysfs files for auto-tuned monitoring intervals, DAMOS stats, and auto-tuned DAMOS quota values, which are essential to be monitored in most DAMON use cases. The user-written non-zero value becomes the time delay between the update. If zero is written to the file, the periodic refresh is disabled. Signed-off-by: SeongJae Park --- mm/damon/sysfs.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c index 4296dc201f4d..6d2b0dab50cb 100644 --- a/mm/damon/sysfs.c +++ b/mm/damon/sysfs.c @@ -1509,6 +1509,32 @@ static struct damon_ctx *damon_sysfs_build_ctx( return ctx; } +static int damon_sysfs_repeat_call_fn(void *data) +{ + struct damon_sysfs_kdamond *sysfs_kdamond = data; + static unsigned long next_update_jiffies; + + if (!sysfs_kdamond->refresh_ms) + return 0; + if (time_before(jiffies, next_update_jiffies)) + return 0; + next_update_jiffies = jiffies + + msecs_to_jiffies(sysfs_kdamond->refresh_ms); + + if (!mutex_trylock(&damon_sysfs_lock)) + return 0; + damon_sysfs_upd_tuned_intervals(sysfs_kdamond); + damon_sysfs_upd_schemes_stats(sysfs_kdamond); + damon_sysfs_upd_schemes_effective_quotas(sysfs_kdamond); + mutex_unlock(&damon_sysfs_lock); + return 0; +} + +static struct damon_call_control damon_sysfs_repeat_call_control = { + .fn = damon_sysfs_repeat_call_fn, + .repeat = true, +}; + static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond) { struct damon_ctx *ctx; @@ -1533,6 +1559,9 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond) return err; } kdamond->damon_ctx = ctx; + + damon_sysfs_repeat_call_control.data = kdamond; + damon_call(ctx, &damon_sysfs_repeat_call_control); return err; } -- 2.39.5