From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3B8C83F10 for ; Sat, 12 Jul 2025 19:50:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D36776B00C2; Sat, 12 Jul 2025 15:50:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C983B6B00C4; Sat, 12 Jul 2025 15:50:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5F3F6B00C6; Sat, 12 Jul 2025 15:50:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9C78F6B00C2 for ; Sat, 12 Jul 2025 15:50:32 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 772A212B0E8 for ; Sat, 12 Jul 2025 19:50:32 +0000 (UTC) X-FDA: 83656654704.07.BA89031 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf29.hostedemail.com (Postfix) with ESMTP id D63F5120009 for ; Sat, 12 Jul 2025 19:50:30 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ws49IYGo; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752349831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5CirKixUsHl4r4mNIEP3BBaNbaIC3AR8kVO2SahMQXo=; b=Dh7IayflKCMVq2bmxlFnsXdPJ5upgglM+5MwYLsj7FwnvBHnqDiesM1oX0E+bSsK1zhT/x eQuU9/Ltys3NhqvOl5K3TvFONMth6li7BPMbOwtD9gMryBus+tbFA/1TbyqnZSaGd3nq1u uptdCIVtuGx6CyJ/ITsKFH7Ayg8ZmaQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ws49IYGo; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752349831; a=rsa-sha256; cv=none; b=1upiYp+4YiMfEpbqRXfTTlUrfRplLE71zV0lj/tzlinMxsq7mbP9TUfD20l1PMWtIq37Uv JJG4JDpWsTDOOJic28iebzC7rBzmQBYMlPUcC+9chjZuxZbLDCN//03wqF+Bc8REdM8ZIo cRYYZiDZ4A5t9pq5fh+4o4IGpDV9SsA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id ED41F44840; Sat, 12 Jul 2025 19:50:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE51EC4CEF1; Sat, 12 Jul 2025 19:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752349829; bh=WnNs9PvTSxpuHsXeKNYiQH21hri+QkB7YdUTcuWeAPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ws49IYGooENIMBShzHJS2qwqqhXkR7Zuz+BYP6ebuoiAlWZok6MczK6dDFt4tZLYS Y6U4IgrFCbB2vTEUk6NaY0ePC6vQYJ34XmLTvTqiMCOqvYewtNjc0+tPLs4YU5gwOR E9cmJgucjSpKYHiRfWK6fwK5r3ACw4p4Z4MNHNgJRMfSya/gf2iX3BL4bYvWQ49j8p woppfYoiQ3NGrRRZNE8D/FzxoKGpiLBTQNtu5pLdw2Q+pEG12y4wnhPbzEdrTRWxS3 wuWHNvhPK2iY6JLGT5O3+sae63zLkrnRoKc10gNlqmn/qIj732q6KXxPnCrj7b1B5V utIrRfUt1N4gw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 08/14] mm/damon/core: do not call ops.cleanup() when destroying targets Date: Sat, 12 Jul 2025 12:50:10 -0700 Message-Id: <20250712195016.151108-9-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250712195016.151108-1-sj@kernel.org> References: <20250712195016.151108-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: D63F5120009 X-Rspamd-Server: rspam06 X-Stat-Signature: baytmg3ay94c5nwkxeu4brkmnf7581t5 X-HE-Tag: 1752349830-73306 X-HE-Meta: U2FsdGVkX18DvMPH2IwyiYM/wED/1iEeBvZsX9PxV/phLgN8JuJnRjAlvLF1uwC6yrL7insPvPm4o0MVHfPpu9CrdvbKapkZgoQhknelzci46om5imaIfmYql5mPNjqDAoTliYsVP0vFYSAsLnapiLit6jc2OV4qGLJmXLmrdTFlqTrHizH4EiNvYJKxw7pVedY+wR5kTfyPcuQFIGvPuhcFe970YLhBklR2QBQ+CKUxl0Q9xJbELW+UGApWTb+8HwVGqQ71L4rNXym0TZ3tqfh9k2pIPVqzztm3fGDrSTzKWvgf2mvhw9AJkikEoB0IZikSFrpahUwom2P/T37rk7czQwTiVKRmLgfrX7JRQHcPEKulkEJWzHzNm3hUZ1rnx6DVnZ6xtLaC+FldCxAlT2GP1IwCCapBUAMunAhdYuIgBVg6mhu/B4IVNYtc5dBfv37Q7R9o+DXIzP+3buV/v0yFfC8Zvhs/nsH02xUxtgMkFExmSNRh/n0Ig54a5u1REVtTe2ysDcaB7K3nDy+kDG1RZkT6sc1NjhVtcD9bqedB4/0DaysCjITY1hAjDvRhGYHF7/yI6DQMb5aOQMO7EEJ0iuHd45DKbe8w7Je2cuc0l8m5AEixY2tmlQaLJ9tDILpEyNBeOMrCqaUMEPYr9nFvXK/gUGKSS6tyKQ1+epCl7MxD0XPqfhAsqS6DVRpVhotRPRSKHBYByz1iYAeWM+VQoQk1EmKbNnymxYPmtG9aEvtpa53YmS6pTFw8OaCNWaOyc+1gUoawUulizqGzqYNG5ALlS9YgMRvr8Ms/siLxcpDsG4/ar1a6U7fCrdP9VzirrBhE7IPk3SNOJTe9JaHdqjRGZDzjMuYzjPRscKQyfBFZ4kAdpUxMBsNUvYZr1nU4PhwM9ZdyvEYdiAKf4SBiqcyuJFLCrxmmYtm5nxjULB3n/RGyEeGNBvTNiGY/+97VKdSXsXfL8y06hpI UQ7u8Kx/ OPElveTgOu+pqbXR7g3fbqkA1+4RSDz0590GmgPzOnkTt5j2T/kSfBSaZYqjd4tjgtAcHdchZxi/7rymGG1y2I2eTfjcssFazzg8aTQzTnIZmafWZlzcuy6hBdmygBI8kqFfJPJT9sicrzNDDDdUS7gUwZokkEHRVXaoyWCJezOQ4Oe9Cv0H4SNJDmXJ/zDf6RyqYFsKrWuIOAcXQlYoIHPIvV3CF+67vESs2OUPlCJbXQdQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: damon_operations.cleanup() is documented to be called for kdamond termination, but also being called for targets destruction, which is done for any damon_ctx destruction. Nobody is using the callback for now, though. Remove the cleanup() call under the destruction. Signed-off-by: SeongJae Park --- mm/damon/core.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index ffb87497dbb5..b82a838b5a0e 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -550,11 +550,6 @@ static void damon_destroy_targets(struct damon_ctx *ctx) { struct damon_target *t, *next_t; - if (ctx->ops.cleanup) { - ctx->ops.cleanup(ctx); - return; - } - damon_for_each_target_safe(t, next_t, ctx) damon_destroy_target(t); } -- 2.39.5