From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33D4C83F10 for ; Sat, 12 Jul 2025 19:50:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC60A6B00B6; Sat, 12 Jul 2025 15:50:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A02416B00B8; Sat, 12 Jul 2025 15:50:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7910E6B00BA; Sat, 12 Jul 2025 15:50:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 65F8A6B00B6 for ; Sat, 12 Jul 2025 15:50:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1FDC6140282 for ; Sat, 12 Jul 2025 19:50:28 +0000 (UTC) X-FDA: 83656654536.26.4BA6982 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id 8395D120006 for ; Sat, 12 Jul 2025 19:50:26 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SnBXbj9J; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752349826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=81MFybJcNb4tS5wPBbG+qeV3Npl+X0cMKaMCsyhqFcw=; b=OexBEjxmxiMgXL7yZ+9NrNpz4TzsQMUWLjhZOGWRA4iLTcdQtMMVoNjqwDPPXMgcQ6daGP MPQZmIwTJKFnvHvPxYraqvw7FQt5QC0+oRI2g/bxV7pstRqgizaKCSUBufZvfvpgsyskP8 1xvgnn9Uqaag6aF5je0Z8ANW0Zyv7yY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752349826; a=rsa-sha256; cv=none; b=lhQ6dFbJkeNCs3AedJ7T0KCZN4zz3aD9anf8wHQCbN9S5Jz9tivVHy0a+6oggchpZBzscg DLmEDOSH2xgXjmU4/ZQcg8xOjOXVe+x5qANWpEn4UMR2k+QPzZ+KF/TG4B97ZAs2mH6KpD FKIcgZNUezzPLploQpYAXsKFTES0POg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SnBXbj9J; spf=pass (imf29.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id E755AA54C5E; Sat, 12 Jul 2025 19:50:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68F0CC4CEF5; Sat, 12 Jul 2025 19:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752349825; bh=fAIXtGREPARQvCC1/X313DQcYGh4YYVNrncF7IRNX5A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SnBXbj9JLQ/68/CzvkH51wlCIhPyiwg8gTXIEr4W7DaJ8ASkufZ3vJ3yZBm2RI+9E +GyAELXBJre+9ftd1CCJU53fepM+WY1a0WDjQVRPvvVecuRWJvFwc6blCwn1IjyiXN /SSnQpWYVxbVqYJi6iS9cdvvXXgCkOs7LWpn00YpARWLYhlzmW3TH9FC6k9WqqM1KV 95ZFzjgtQBENj88W2DdFytayi5LoJb38TaT3cw/dsU/VyuTwIcdY9gZImUzV6n/jfw J854wJCjwLUf66wJl0v/6I61VTSml4gfmx57e6M5HRP3P9K9LrHH3qbEIPVm98W73/ VJRlj62cabWpw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 04/14] mm/damon/reclaim: use damon_call() repeat mode instead of damon_callback Date: Sat, 12 Jul 2025 12:50:06 -0700 Message-Id: <20250712195016.151108-5-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250712195016.151108-1-sj@kernel.org> References: <20250712195016.151108-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 8395D120006 X-Stat-Signature: yydd8f3m9nqsyb6s7qmm5xr7resybgok X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752349826-836614 X-HE-Meta: U2FsdGVkX19wnKbh08LpMJkJqpdPa1cSh/qTlBnNOObPI2xr6IWbhlO1AAteB6OfuuGHWgXThVC5Ica+dPQTwuFqIhAsZU/kJnQKFf1+2Ie+19QeNv8OdE3cdXrF0W3UivNiUWvGpi6oyB60xZ7fBk+RY+WPTzOsoxYGlpurUlUE8S5Yk/GG+c2A3WzhGRzVwAqEle1e2x/CF60fhYuaN2tD+DwwNJhImvMmIjtXXaNcurxxYpvO4e5AreH0T+jUyEy4YXOLw5FS8btrU8aSD3zY5cBwav1ib9vksqQGb/5+pcjK2WNtnKlopfJG9yr61Y/rEwtobfbj0wEd7j2nbFDQdetXjeu8qXexWz5Dg6TfmGwTo64hHc80wAi0HVbt2y9x0lruvga5el8uLAJVFHmu6skXodz03yhHi7bJy3GhlN2SrFWBic4fKrwpZ7kK9TQE64tEKHeUqWIo2vzzuAhq1+13QARVh+AiNW5d877lA/GnCth4XjI304es7+OunadvyTv2EDMum6kzMCu7gv7qAlAt+/PNowZO8woxWYmCwDVdmL8d37F7pKfkeC7r1rreDh9rVnCgiGzibu23a3HRcsKQVFHS7ltqNKrlWi5iJg/UTB35H/OeB+yWS0moQ67fFd3NhGeCnFPSxUX1/IIGM1GJA7lXICNS+EthXnGW7dFKjk50VbEO+yLZymbAVkbf7byhMQ6zxoKxut2LollAIS4SMvoFNYcINxvwYiqvuRakH0sClFZS2xRwDoxGSdRagZ4tH3s9ys4RqP5WKy3m6k8mY3G0CCVwSN/Zv5brrm5AxQ2eEBy+VeIlret0QlOSK2oerIyKqUrqNqdM2D1WPitrizptacAYExguPZyGSuyaru2ERWZOik+IWg0nAmx81As4z9DsVKU+U/yHJrtFnmAam8XMhnBRtZjgufBw515v3MVCLK2zOpi71ORLOnWkeLkSO29j+NtaiZo CCnbKNZG Wp2GcDidR5uVXJhkw+ZvArebjO7y0fqx1KktknJ+KdfLDnVA0XHc5b3DsOiqD/AgDMgkFnB4PZ1Eh5g/VAZBBQWMGQB7zkcePT155aBWaHVzhyl+O+zewpG3XJymfeZXblHuBTo/suaCeLB89Hgy2DUXhL5WhIkK7EN5iJXNHHoFMRXpd51vFtSsMBGVJwdZMT+XpXzyBF405lmvxo6ESSmeXxLGJGIlF4q6jhHYSB7cH2QU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: DAMON_RECLAIM uses damon_callback for periodically reading and writing DAMON internal data and parameters. Use its alternative, damon_call() repeat mode. Signed-off-by: SeongJae Park --- mm/damon/reclaim.c | 62 +++++++++++++++++++++++----------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index 0fe8996328b8..3c71b4596676 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -238,6 +238,35 @@ static int damon_reclaim_apply_parameters(void) return err; } +static int damon_reclaim_handle_commit_inputs(void) +{ + int err; + + if (!commit_inputs) + return 0; + + err = damon_reclaim_apply_parameters(); + commit_inputs = false; + return err; +} + +static int damon_reclaim_damon_call_fn(void *arg) +{ + struct damon_ctx *c = arg; + struct damos *s; + + /* update the stats parameter */ + damon_for_each_scheme(s, c) + damon_reclaim_stat = s->stat; + + return damon_reclaim_handle_commit_inputs(); +} + +static struct damon_call_control call_control = { + .fn = damon_reclaim_damon_call_fn, + .repeat = true, +}; + static int damon_reclaim_turn(bool on) { int err; @@ -257,7 +286,7 @@ static int damon_reclaim_turn(bool on) if (err) return err; kdamond_pid = ctx->kdamond->pid; - return 0; + return damon_call(ctx, &call_control); } static int damon_reclaim_enabled_store(const char *val, @@ -296,34 +325,6 @@ module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); MODULE_PARM_DESC(enabled, "Enable or disable DAMON_RECLAIM (default: disabled)"); -static int damon_reclaim_handle_commit_inputs(void) -{ - int err; - - if (!commit_inputs) - return 0; - - err = damon_reclaim_apply_parameters(); - commit_inputs = false; - return err; -} - -static int damon_reclaim_after_aggregation(struct damon_ctx *c) -{ - struct damos *s; - - /* update the stats parameter */ - damon_for_each_scheme(s, c) - damon_reclaim_stat = s->stat; - - return damon_reclaim_handle_commit_inputs(); -} - -static int damon_reclaim_after_wmarks_check(struct damon_ctx *c) -{ - return damon_reclaim_handle_commit_inputs(); -} - static int __init damon_reclaim_init(void) { int err = damon_modules_new_paddr_ctx_target(&ctx, &target); @@ -331,8 +332,7 @@ static int __init damon_reclaim_init(void) if (err) goto out; - ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check; - ctx->callback.after_aggregation = damon_reclaim_after_aggregation; + call_control.data = ctx; /* 'enabled' has set before this function, probably via command line */ if (enabled) -- 2.39.5