From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5650FC83F1D for ; Sat, 12 Jul 2025 22:25:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 88F466B00C6; Sat, 12 Jul 2025 18:25:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8403D6B00CC; Sat, 12 Jul 2025 18:25:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77D516B00CF; Sat, 12 Jul 2025 18:25:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 683246B00C6 for ; Sat, 12 Jul 2025 18:25:49 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1A93C1A02C3 for ; Sat, 12 Jul 2025 22:25:49 +0000 (UTC) X-FDA: 83657046018.08.3EAEFEE Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf08.hostedemail.com (Postfix) with ESMTP id 29591160008 for ; Sat, 12 Jul 2025 22:25:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rj8D72HC; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752359147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Cy9j6oYKnhzU2rO4UvCQiynhSTsyM23pVlfshIahcU=; b=CrWQ5nJzMXHfMT83emqeuQFM8LS/cpN+k9bu2u7277N0hhCMyKE0yhUAa6/I/FcUIoNnFS x6mp5TwDJb0WJStcl5HeABHjolZRlTkGj1FOfWyL/LFQw9k17vlS9Ft5pPcWCYHTvjzbIb UnkO/FTsxdCR0Ra83jLl2utXr3HMDXA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rj8D72HC; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752359147; a=rsa-sha256; cv=none; b=pqtH2ZJGljndw4IK8UHE8GSTSolhAHCZSQ+hyevDCHJyWvrYcjPPLTSnndkv1k+XmSoXbo SuPv5zS8cOiPL/mqP3qoXTcxNg2or9WpHq6f8XmdXfc6sI/GzTBActTbPRtV2sSTnFmQuw 13d4VJe7EnA9sXnIqh/u/4MGH8beQUI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id C7C794580A; Sat, 12 Jul 2025 22:25:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E61AC4CEEF; Sat, 12 Jul 2025 22:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1752359145; bh=pSh3mjR//rnmlWfjJ4Z9nm0B9/qkk0CHM9jWwGNd7xM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rj8D72HCwyU0hobnlvR8EllAN81WGIaQzcA/OOUokRki5KcSppE8ZQ4zJZP8sRRCL IZqboHhtLhHRWRGAV0+HN6g2u9MK+MHF0fN9iUk1/kYu8upJ3/IKvrMQF5QJxz5EiX DzV+NN2maEYxcUNc68LkbXq2sravQEDTdudSmmTg= Date: Sat, 12 Jul 2025 15:25:44 -0700 From: Andrew Morton To: Chi Zhiling Cc: David Hildenbrand , willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chi Zhiling , Ryan Roberts Subject: Re: [PATCH] readahead: Use folio_nr_pages() instead of shift operation Message-Id: <20250712152544.07f236ec277290c70a2a862f@linux-foundation.org> In-Reply-To: <661ccfa4-a5ad-4370-a7f5-e17968d8a46e@163.com> References: <20250710060451.3535957-1-chizhiling@163.com> <479b493c-92c4-424a-a5c0-1c29a4325d15@redhat.com> <661ccfa4-a5ad-4370-a7f5-e17968d8a46e@163.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 29591160008 X-Rspamd-Server: rspam06 X-Stat-Signature: eut1ammjzc8hidmdbcr5dfxrsrpyyxx7 X-HE-Tag: 1752359146-673282 X-HE-Meta: U2FsdGVkX19dP7fY2+CAdycZmKmuJpCb9EIyAV1LYs30Ist9nysID1NWtzmiCEOf/cpCIFxfYLA9eif5BuwBhpj3NtEWN1CyUc/P3OOqO8wu5tVciem9eqoFH2QwDLgiBscjIlf4UGRGyFjNn3lW5iPYLsm8BHL2UrhyvfwOk9u9NnxDFCImPg1/RtKiufkaq5ATCTOKQ8Gkq6BfhS+EaLL4H/0+2urOmKv+Gq0X02KYbFXcGwGQRmj8FFRS0fKYEFJIKibWDyBfCz5XEJH77EsRwCxSYzeNDkTxaXy282+oAYlHuF/9UKHM4h22/t6dRddoMWQtv2woM0K8FStY9YVHWTaG1Kb8h9NqdpM8iMxs+L+L4FzJjGF8bHsnLqraj2WCOLdqMuD73YnFhNbGS2B+PyirnOqXZs1FrImrhR/s9/93DJk1a167k3k9//vMdY8EWx8kY3zNCucGmqunktbsj3WRbFxhmKrQj3yRIjNKNEAtBtoqbT/kU1+CfHMfgDBx8weZ4mW8523vuqDyDOnv90+9HXgrVRvJcW/di3Ou9gjHL+Db5zI7flzHAWrZff0d3STKN44kWcA79iGG8bG5emT+fzDNAMIAHfWnUV4bSpWND62UCvP2Iy5/93k7m9dgz9ONCaZCRgQ2l4WVhMFtKk5NLBnSeqmtMXuV8v0XTbuyadwRYgCKejmua6RgC1PnN9oT7bMVSSoi0ws1VizkWnvFmaXZtKVKvdTY7BM+D1ciOrUPzGc5OuXLVo9oVoEFqajTenCkooB0XfBfUVVVGXf1Z4HKoaufRUzqX7iM0ON90rDQoH2dK43McWnf6IEMoIhGBDBYZjOxWtZM2kaNrCAHiJP3OoNqYXnWNuLeDCIECJTzXSUstZLD+jVBFbW0nrBbaae70G0UUKrQjjLXSLyZNo7nVSZ4eQ7rSEakZyVn4ZZdCLx10Y0Fa0lSDBf6t32b0Myf6H5U1ro 8KoUTI8/ wbGGrwA9U9QgyUQ/FKDazMwr5F7wypb3b59ykFysB1HBs+8th7evsna0fJh+YDquNyaSJa02E4WDzAFJ8ari49yzxC1l8o8q25yMd3M9Ad5H5MXio0HPdhF3T/XXXaLwK0fQ4vKkGFKfJayc4UaLDvqFq6KDeZwD6pqU6natuNouVRiiU29OToIfIQwjjVcdz8HOayr0llN9DJu+tSAyrpLV2f6jYxyubGIVIPilWWF/4GLm+loYrqtaJ8vDFYhTM+1FMTI9ETT5jLtJrtlTOJViWbZjcrgKqeN0igazU3q5JwIM/ndPrUmjjwd3ewW3uc6oIhBvuHOlVOvmawAjCN6JZmczMwd4g4YcTkWJUvnvKdk2xfCpX7F1UndKCa01d5W5Z4Pum9G4FnBqvdxS658e5vg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 12 Jul 2025 10:23:32 +0800 Chi Zhiling wrote: > On 2025/7/12 00:15, David Hildenbrand wrote: > > On 10.07.25 08:04, Chi Zhiling wrote: > >> From: Chi Zhiling > >> > >> folio_nr_pages() is faster helper function to get the number of pages > >> when NR_PAGES_IN_LARGE_FOLIO is enabled. > >> > >> Signed-off-by: Chi Zhiling > >> --- > >> =A0 mm/readahead.c | 2 +- > >> =A0 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/mm/readahead.c b/mm/readahead.c > >> index 95a24f12d1e7..406756d34309 100644 > >> --- a/mm/readahead.c > >> +++ b/mm/readahead.c > >> @@ -649,7 +649,7 @@ void page_cache_async_ra(struct readahead_control= =20 > >> *ractl, > >> =A0=A0=A0=A0=A0=A0 * Ramp up sizes, and push forward the readahead win= dow. > >> =A0=A0=A0=A0=A0=A0 */ > >> =A0=A0=A0=A0=A0 expected =3D round_down(ra->start + ra->size - ra->asy= nc_size, > >> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 1UL << folio_order(folio)); > >> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 folio_nr_pages(folio)); > >> =A0=A0=A0=A0=A0 if (index =3D=3D expected) { > >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 ra->start +=3D ra->size; > >> =A0=A0=A0=A0=A0=A0=A0=A0=A0 /* > >=20 > > This should probably get squashed in Ryans commit? >=20 > I have no objection, it's up to Ryan. "Ryans commit" is now c4602f9fa77f ("mm/readahead: store folio order in struct file_ra_state") in mm-stable. I'd prefer not to rebase for this!