From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 542C7C83F1A for ; Fri, 11 Jul 2025 22:36:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5AC66B00CC; Fri, 11 Jul 2025 18:36:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B32526B00CD; Fri, 11 Jul 2025 18:36:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A6F806B00CE; Fri, 11 Jul 2025 18:36:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 99D406B00CC for ; Fri, 11 Jul 2025 18:36:10 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 65D3010BB21 for ; Fri, 11 Jul 2025 22:36:10 +0000 (UTC) X-FDA: 83653443300.14.F79BD6D Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf04.hostedemail.com (Postfix) with ESMTP id 6CD5640007 for ; Fri, 11 Jul 2025 22:36:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=WjTLteBw; spf=pass (imf04.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.46 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752273368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R6jEezWUjvICh7/WW/Ivp+Swoo1QztjCMy3V/+iaOS4=; b=suK96MtYAF7Zku1MPddRRJTOhO2qFAnUUf+OLRMalKo3hHj75NSE8r2j2rnexcgCnrSDx7 dBQr+m0EdXQIOJD8cK8JyHo4YHzuwhG7qjIkfKVXr64raJkpQzos9M9MMYymzuPkOwaK1c qPuFWw1Qm8P73kJa5ESgCpuh1qfPWzs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752273368; a=rsa-sha256; cv=none; b=mOPL2drh5Fhd1BGHeITDJixPKFWNBxQACUv5lRkaxEm9bWdhuYNO+NsMVi7ghYCHWRz8xy 8OUyUU8lAP0atz/2S6GXWApb00bROxIxAVLd1sLB2r9qxaCPlchKiYNyR3P1zf8y1QTWfe rSHPjPFB8w591kxqYmNW9H1qkYE0u4k= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=WjTLteBw; spf=pass (imf04.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.46 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-701046cfeefso39728846d6.2 for ; Fri, 11 Jul 2025 15:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1752273367; x=1752878167; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R6jEezWUjvICh7/WW/Ivp+Swoo1QztjCMy3V/+iaOS4=; b=WjTLteBwVw9upw8XnY2ocilhFJhNExt6JF4zXvsXXCk+niKz1lR1JnupGGayQWfGE/ pP89iYhzKje0foZDjUV3U1dgAtt5xlsaO9WJWni409Ia9Cd4xwXM1KaCik7BqSKkB71V jyReuKzM0d/T71T0BDIiW99EoCLQaOTx1GGHyJPVHV0RXG6RRJIHMDY4p7+d41vTtt6r sZXdVgUAkLTbteS+dHRFeUYLFrUI/KcO6rGSAJNxWgFe0gpx3Ww+iqOYN8dz1IwRvHBR hFwkh4AILLe3p3D0reoPVlDzdAbJX6adJGuLoFPJYZ7KzxtEbxTF+6U2FDHvEmzilcMP 3n0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752273367; x=1752878167; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R6jEezWUjvICh7/WW/Ivp+Swoo1QztjCMy3V/+iaOS4=; b=IQvXRmiAArBnWENC9+Vq/DST+6IAugyqfyQ1yDdKdU+d0u//X337/84DS682HvlKbR QYQomzPOXse8W1b6ZprhcA93FF1/352qHpYJioUvTwl4j691vBTVyx6Rs7uPUNftfoiX /0LAcATenXVezlNP1VmCzI0Z9rvFr70P+JrntShUamAlnOyHPgOs+qnSH8o1H+Qw5R78 riy/DhgH2v+DcEuJ4I9pCpKiSI0dKk1nUXOybZMZP+g0hQ8yhFKIIGx/Q1Cq4URtFdRQ f5BeKayfJqxty0OXoP9dmdh0U3W1jSi5MrFoWsIlrLx1YaLZFeqaILD/zFnB5IguYFNU JSMw== X-Forwarded-Encrypted: i=1; AJvYcCXlkepAmCmyVYIncfPaoHkwHPmfYMetVF8A9IY77uEMRgiu14LLUdw/4Cv1HDb8+bHbkBJ4LSy2JA==@kvack.org X-Gm-Message-State: AOJu0YwRrIUbbZukEi8foeALnXQyv3wLGz41oEPGD1d6xjg0cyxui8fp rbndfV2qplXKq0wXFltJU203/tgRiwdY8rlDP8w+O5zdqFa+YiOgu+EAFQBS0qmJvRo= X-Gm-Gg: ASbGnctR7QEF+/piRAAngBUrJhUovgzfkIOkT6fyQg47d9aNXVNT87O9VrbGWRKxNZx VexIcC/RPbsLd1RHQSUkH6HfvjWcpKWsmTbZQa84+bdusbWUBcTmdf2oUTojKGFR3fb6QpHhCvU DD8GyXDEm85jT2HZ4LsZtq/rupZ3YHeAYwFzJ+e2bVEQwBSrtRxYpF7mwv+0IbBjUnJjTluhtoc WuVH9hF7PXxIx5wKgOMi/JO+/0NB6FmZ+4DN8TFYewvzjJyY5KwYSbsiwObSfv1ADLRcQdE+8+S TnFlcjLbs0K79BUABZ28KqtLsoWCUYV3TUht6d916JiebmzIEYC21/5Q18Yp19jtPHqo84+R4yT kBcfzvhKAJHTGipMXrWk+P5GoE6pAVUajb4DS9dY0+tdlLa+3GtFBqhbNVYTFAQn9o2G8NaPyPw == X-Google-Smtp-Source: AGHT+IHcy1eXPnyRzznoEf2npXkMyCOaTtdOXhPkzHUHvNfiFnAiR4oHyRzA4NVeqBX+We1cjFjHFg== X-Received: by 2002:a05:6214:2e8a:b0:704:ac9b:f69b with SMTP id 6a1803df08f44-704ac9bf745mr39098586d6.3.1752273367266; Fri, 11 Jul 2025 15:36:07 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d39728sm24160086d6.79.2025.07.11.15.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 15:36:06 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uaMLd-00000008LmF-3pds; Fri, 11 Jul 2025 19:36:05 -0300 Date: Fri, 11 Jul 2025 19:36:05 -0300 From: Jason Gunthorpe To: Alex Williamson Cc: lizhe.67@bytedance.com, akpm@linux-foundation.org, david@redhat.com, peterx@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 2/5] vfio/type1: optimize vfio_pin_pages_remote() Message-ID: <20250711223605.GE1870174@ziepe.ca> References: <20250710085355.54208-1-lizhe.67@bytedance.com> <20250710085355.54208-3-lizhe.67@bytedance.com> <20250711153523.42d68ec0.alex.williamson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250711153523.42d68ec0.alex.williamson@redhat.com> X-Rspamd-Queue-Id: 6CD5640007 X-Rspam-User: X-Stat-Signature: fmzrpp11fr94j8sibphdrg9ag56upnfk X-Rspamd-Server: rspam05 X-HE-Tag: 1752273368-365254 X-HE-Meta: U2FsdGVkX1+u/elqVPM/ecLCOZ4vyjUndxDWBfT0WKgA+GcBuYgE1QcFiuZ1pk6F9wz01LXz6/bGsjHzMx4vJxioYTAoPkPVgLLMAOiaubgZ1bqEro2rezp6WicE37sZflK3ShGEKrjLr9/7xYnIzunE0e0Tql/hmi0pZQRRBnXV4Y3tqXoJwnEJzKxG/czhhcl8FmtUVOLmqDMu57Ga8N8TvIHicpDscC7w0Lf20MyuTy6IDZvELulvwO1/qAR9QC8QazlNATjsoGQeGd31GSLTVrMnsbknspcypVp9fmiNaVXCcoWW5bQoswbZq0tA0nCrPS8UK0nvdGWjgDulvtv1b4l/UiYqpdYK3LibskMqYAHJ7QtwC3pbF5udIY+QlKLiyo+AgvAIQsHpiUr6umskae8YfpmG35zdIz4QA9+MeYaPMF585CffqweJpS59STt/CiT8gEoc3Rbgkszc+9KmG9xOL/OT1Z4fBgrZDJVX+9fEoOiXK7ncuXxcobbtqPY97w84/OS7QUqPyvUVod5k0Tpl60HAps+Pm1LcMCvrWkXEtfWqGFZpLCa7QgYIBYQzURo60LVcwec/7oTH6dwqKlxjYAsbfuuySMLo2KfeoimZcAusWGlk3w0djOMcJmJEpzArjm6FCvWMNCvW3BeU01vOdxYBiPupAPwmYnxRjC5AAtgLmDVjY3zflGIdyY6RnP3OBGuoMIRoiNktjC2Z2JbBB51NWI2qJTiaU9TMD/By8UhD2Faq73Y4yRP1CHGw4XYVxt5OCDpi0VvAyPH5A5FAgMpOJpZzz6ATOMIZdlzYBdE8xFm0SheUS8uGarWGOwUmiu7s+N0JM7xL10N5TXOXXUU9HuzuzuLf1mzv/b77ie4Q+0EBlmQC6uovaKMkAxk83rC+O82kXrI/0lZa261vF7ws3ebn4ZTLvchtC/Ni4JHwijyhH7Z9BlojFLDlMslW1SbOSMjv0VN lX+I/eCk rIDX+KXoAEexoI4XLa4K/xnshgdyXpE+wHTAXkxJ+K/yEcusrdKaYxRONeg1B3aGg09Sn4jN1Jyq2it0bJ6xg9ABdIZAbpnhynB4+E9kkHvNEvqMSfkdZRKM9qRvkTo6ztolJd58ST32mM51BVOHCxw3h+qKhMH+/nayu9GdONChTS5DgTrWQ4S7qUQfhUNVDbhLQzcF/31MPa1O+k35mWfqhRdmBjiNxZqXOvqC4lEOoP76H+EeA5tlSOfxZNAXJlmbtpmm3ZB5l9jLTeaiU92Lk0qQlQWHvJ7t1QwXx7FOHTonWnjjoNqItxE9Ed8VUIfsthHR9+Nhd/48= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 11, 2025 at 03:35:23PM -0600, Alex Williamson wrote: > Don't resend, I'll fix on commit, but there's still a gratuitous > difference in leading white space from the original. Otherwise the > series looks good to me but I'll give Jason a little more time to > provide reviews since he's been so active in the thread (though he'd > rather we just use iommufd ;). Thanks, It looks fine, I'm happy not to see any folio magic in vfio for this. Would be nice to see scatterlist use the new helper too Jason