From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A21EDC8303C for ; Fri, 11 Jul 2025 11:54:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 49E3C6B0088; Fri, 11 Jul 2025 07:54:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45E6C6B00A0; Fri, 11 Jul 2025 07:54:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39B946B00A4; Fri, 11 Jul 2025 07:54:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 29C946B00A0 for ; Fri, 11 Jul 2025 07:54:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D77741409AE for ; Fri, 11 Jul 2025 11:54:41 +0000 (UTC) X-FDA: 83651826762.17.57BB7B0 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf27.hostedemail.com (Postfix) with ESMTP id DEBB34000B for ; Fri, 11 Jul 2025 11:54:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752234880; a=rsa-sha256; cv=none; b=s7yvoMbWn1Q/kufV0xduaHxPPxxKxmSi4APCL4VGYaTtlYWwCvv6j6bq4sY9/QVwR6GYod 1IVEsCVcTX7yo1YZ/+fNDkUMkbd0N3MfXddSAUx0cAZYhuwnixV2jsMgMNSaVFu4LbF2Qh 0t6tbgko7ATmSu90wlZ/NCwNZDfkOck= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752234880; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hz2Y2XXBlVSsD0ujhohRc4qeLOJqXVC+eP3fnFk9s0g=; b=FgQOWKp6WlR0lG7AucTb0mLmk+n7eUnk8ZaoruILOzl1nREMb6NQA42lkt7MlV7NapaDnm 3FyJG/WvppHtCi6hpybPQVV9EFBU1umCQVnsIPlvTyg1i/JkImLQ/BQ8webJH9hxhw8Jdu yT1P5706e1l7Kwub1W2nxZUMID9R3jI= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bdqml1fHPz6L52V; Fri, 11 Jul 2025 19:51:19 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 3542B1402EF; Fri, 11 Jul 2025 19:54:37 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 11 Jul 2025 13:54:36 +0200 Date: Fri, 11 Jul 2025 12:54:34 +0100 From: Jonathan Cameron To: CC: Catalin Marinas , , , , , , , , Will Deacon , Davidlohr Bueso , Yicong Yang , , Yushan Wang , Lorenzo Pieralisi , "Mark Rutland" , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , , H Peter Anvin , Andy Lutomirski , Peter Zijlstra Subject: Re: [PATCH v2 1/8] memregion: Support fine grained invalidate by cpu_cache_invalidate_memregion() Message-ID: <20250711125434.000050f3@huawei.com> In-Reply-To: <686eedb25ed02_24471002e@dwillia2-xfh.jf.intel.com.notmuch> References: <20250624154805.66985-1-Jonathan.Cameron@huawei.com> <20250624154805.66985-2-Jonathan.Cameron@huawei.com> <686eedb25ed02_24471002e@dwillia2-xfh.jf.intel.com.notmuch> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To frapeml500008.china.huawei.com (7.182.85.71) X-Rspamd-Queue-Id: DEBB34000B X-Stat-Signature: xdct1gpank8nszzkpzy63bhaprxbjfjx X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1752234879-130085 X-HE-Meta: U2FsdGVkX1/FfFflj5rfrPbSs4oYJ/eH3KtHcKWsDBh0mV9oQ/bfRr+EHfn2stBpkkOiRNFqerv7763OrezuDV3JBUX8H2E5fWdv0aW6+QIFSCIYQW+nE00IHMA8z8TqG7RW+u9Q0SxhrQ41gRe2qXVTELJS2FD3lwyfyjFtuOl2SOIqBejvLPvZ6lH8kwS+5/NUUA5RP0XG5YGuFW2+XP2jga9ph3C8QioL/3SpZ7R9vYKYGnW7GheGNe6b8xFNxTE2NjTGTWEluv76Tqj7pkgICtk7TK1A/vs9rSlTbxUQ2xCyO99X1jfeuj35RgVC/t8Ujc5JnI6OhXcUSwKUJm9LIJHrj3Em14cXMwPQIgSM5nyUhEmAJarkQhhtRE5PlntBltBJleftJjiYEDCOs3iku/TxEVerBPTw3yshQ/Y2YabEgLigxCQ338OxC4AI62CSv9os1cAWgd3Xs6uZROeMmF4ubpEAh3gNP6Gsy9UGbYoDx5tZOlHtH3IsaPlrt9IIYbSSB/3Ve19wQHRquVIIQ0OEzDyQxJRJLfro0+/qkg1k+G82avsrt+QUCbIe6K4rAn7SbNk2oIvJZwzDHVoiNwqyA4Sj96EmnJQ5RHzzW0e7d9f3CszRJYnLyRrCEEIBfg0EpXdrFBTvFZElXtQ9wRLxa5M4v7IoYTTrq53EkUK2p8Xl0n9579zUERb3wWJrfcW+yelKPNkEK+sb5SjjelYvMf4A7YXb+FGn9WDSLF7fMaw9vT0idRMFXntyJyUQicm21oapgLQNXO5+3lI2hrPqqaoSgIuUBk62jV/aYxoUZjYCsIQ7tbuWzjZq+P5tXy20gaSDvvVXPNPawbFwQXCcWqvLRRHmz9u3FdifF6OXk4YC4aBc2YPPCzua2qY58HaHB6dV5ITs0tD5//0ORVvu40VD/8TOL/GlTGa8/kd6niruCGU6b2cWrYmDmmbO4N764+lgn+w6oUd VRFo+udU S+dDeACCS3JyO3SfXKuZ882mXY0Gooc9eiQATvt1qxTE0Lh1xraP9iGYEm+Zq0V9D68jz4SlDdSaWJrBSc2RTr/UcZVlkfJ/n25p+oXoYPpJ7v3qHfCDoknp4xTsHtgVp/3loyXzjhv9QnEkmg4EdBDhoUy3jDQ8SGQi8sn9ZMOiHL5E3ebRJoZGag3i+yq6Zr91MGtqViUbiXOfAgCx3tIlY30jveKsd6crefF9uPlLE1tF+BGOzbMw7qGwMPl1P60OXVyT3zSV74zt05CspizFxWT65umYFnk/e2j9KynGykFrrxJ9Ugq1Tuw9X21wBuxZtsRZeDXcj1WMB5oVI1kheSZTdaQsEYBeKyJm/CUfeBmxdnfNflouwjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 9 Jul 2025 15:31:14 -0700 wrote: > Jonathan Cameron wrote: > > From: Yicong Yang > > > > Extend cpu_cache_invalidate_memregion() to support invalidate certain > > range of memory. Control of types of invlidation is left for when > > s/invlidation/invalidation/ > > > usecases turn up. For now everything is Clean and Invalidate. > > > > Signed-off-by: Yicong Yang > > Signed-off-by: Jonathan Cameron > > --- > > arch/x86/mm/pat/set_memory.c | 2 +- > > drivers/cxl/core/region.c | 6 +++++- > > drivers/nvdimm/region.c | 3 ++- > > drivers/nvdimm/region_devs.c | 3 ++- > > include/linux/memregion.h | 8 ++++++-- > > 5 files changed, 16 insertions(+), 6 deletions(-) > > > > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > > index 46edc11726b7..8b39aad22458 100644 > > --- a/arch/x86/mm/pat/set_memory.c > > +++ b/arch/x86/mm/pat/set_memory.c > > @@ -368,7 +368,7 @@ bool cpu_cache_has_invalidate_memregion(void) > > } > > EXPORT_SYMBOL_NS_GPL(cpu_cache_has_invalidate_memregion, "DEVMEM"); > > > > -int cpu_cache_invalidate_memregion(int res_desc) > > +int cpu_cache_invalidate_memregion(int res_desc, phys_addr_t start, size_t len) > > { > > if (WARN_ON_ONCE(!cpu_cache_has_invalidate_memregion())) > > return -ENXIO; > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > > index 6e5e1460068d..6e6e8ace0897 100644 > > --- a/drivers/cxl/core/region.c > > +++ b/drivers/cxl/core/region.c > > @@ -237,7 +237,11 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr) > > return -ENXIO; > > } > > > > - cpu_cache_invalidate_memregion(IORES_DESC_CXL); > > + if (!cxlr->params.res) > > + return -ENXIO; > > + cpu_cache_invalidate_memregion(IORES_DESC_CXL, > > + cxlr->params.res->start, > > + resource_size(cxlr->params.res)); > > So lets abandon the never used @res_desc argument. It was originally > there for documentation and the idea that with HDM-DB CXL invalidation > could be triggered from the device. However, that never came to pass, > and the continued existence of the option is confusing especially if > the range may not be a strict subset of the res_desc. > > Alternatively, keep the @res_desc parameter and have the backend lookup > the ranges to flush from the descriptor, but I like that option less. > I'll do that as a precursor so we can keep the discussion of that vs the range being added separate. Jonathan