From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2406AC83F1A for ; Fri, 11 Jul 2025 08:02:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 989A96B007B; Fri, 11 Jul 2025 04:02:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 961916B008A; Fri, 11 Jul 2025 04:02:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89EB46B009B; Fri, 11 Jul 2025 04:02:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7A8316B007B for ; Fri, 11 Jul 2025 04:02:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0E333C2A3E for ; Fri, 11 Jul 2025 08:02:47 +0000 (UTC) X-FDA: 83651242374.07.42A527D Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 4623F1C0009 for ; Fri, 11 Jul 2025 08:02:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=K1dqZ6M+; dkim=pass header.d=linutronix.de header.s=2020e header.b=R+BZoBEd; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf21.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752220965; a=rsa-sha256; cv=none; b=40YKrXUKLy3tdWIOCuFsSoaADjs+1HgDIjviCOq/5xAiKnCVyitujNhLm7C5IUkHslrkeZ Dkowv/0QoeZJnTOUDR+Edxt86Zl25/HRpFw8ylEuIoVxmW6xjHpHqlSNch34XRBSYnshrX /TO+GRHCgnCZ+qtcqEC93vusZUlG8Co= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=K1dqZ6M+; dkim=pass header.d=linutronix.de header.s=2020e header.b=R+BZoBEd; dmarc=pass (policy=none) header.from=linutronix.de; spf=pass (imf21.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752220965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bFZ1IDLuf0P5MtghxDBAlCYYAF9UKN61gND6r3JMcGU=; b=VM2FI/CXjWX1NKdzBpFRKXCCl6f6A/zuG7fxe51HpIyN/VUuhHGMF/80GyTcNIGqsl21IJ p4C2Kcta71iKwyhd7SOTcLwUYdxA/dynL6ChWxa8s5a5XP0IjCOATyXlBMPUnRiBMlrRA5 udEOLcMEizuIz9exwkY8m0qM1ig0dd8= Date: Fri, 11 Jul 2025 10:02:41 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1752220963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bFZ1IDLuf0P5MtghxDBAlCYYAF9UKN61gND6r3JMcGU=; b=K1dqZ6M+S2jVtnHTtSVK4zbU3GbDyU34C4U4qAsYnfAxzQ8YjLGeWXr2sdFjA+m6YZBwu1 QS9e2tnQD6mByNYfp/BkpZMHL3h2buPTbokg3FVpf8EWpuZDbiCyZA5FThoUyH1ojeei8c QlJ0iHnuGNOUoB8Pfq3ivmPxCbLMrIcOah4RJFW3XPEm9B0UcfyA5S0cLQJcy25pv+nfHP HDuMr8SsmJHcd5qdsyvajsaXeswFs7qra6ZkYEhPn8n5Gh05dK5fuBzgi2Ntvm7YiRhKZ8 gXWWBIryZ/2QGL54x5cG3uI28r/2RL/xmhibaJ3oyOXa+Y2OD4VyJxTarMYr4g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1752220963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bFZ1IDLuf0P5MtghxDBAlCYYAF9UKN61gND6r3JMcGU=; b=R+BZoBEd+DGiHpH6ItOhW1Dzm6QBT6XTBHeIfhHNr4x8SFr++l6oKWoL367I2Tztx8wgZZ 9gDboTPLf8tZO5AQ== From: Sebastian Andrzej Siewior To: Alexei Starovoitov Cc: bpf@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, harry.yoo@oracle.com, shakeel.butt@linux.dev, mhocko@suse.com, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, rostedt@goodmis.org, hannes@cmpxchg.org Subject: Re: [PATCH v2 1/6] locking/local_lock: Expose dep_map in local_trylock_t. Message-ID: <20250711080241.-_BJecVz@linutronix.de> References: <20250709015303.8107-1-alexei.starovoitov@gmail.com> <20250709015303.8107-2-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250709015303.8107-2-alexei.starovoitov@gmail.com> X-Rspamd-Queue-Id: 4623F1C0009 X-Stat-Signature: enato31abcfs8569mfbtqyu5n4o4cxo6 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1752220965-978480 X-HE-Meta: U2FsdGVkX19JtiM3iW+PgFJS2F9ffkKyv50GksgwuotmMXWVCqJNx/zeipMwzZrXqIJnCZ8zzkN6s6N6OeACTyQu8H9JjhPVyPrgfPELeNK/zUu9me7Zy4yY/8dyMdq8j7csW3Fno0AHaw8QG8OTqLbUm+dj7SeMUytJCt4DEO9mLV6JRKC0OLvMfMTp3cqSD2WFiOmd15lfNmNR+x/FnO34aX/THK+/afIQDvcKhvz7GO8mFQDVmMt5ct/mOzOgsmxITR3mAaLaPDLI4oISP/njk/ssDF09hW2XwftsJs8kpvu1UDHY9PRIcSn15XYmMbPntEBdUWHkGj79O01vpcMpUh6guxAqdTxXTBxMBk43F0mp8rFjJqtD9+GNBA3Rxd4Yo9rQ6XZvyXR54brpiZKVSLpc48QbZCUk+8JBblMPG4qMS6qzyp0sdaVOIB80i4MqFMmbiZaG14KUBTJPUF+3UTx33GpkR+8zf1aVY+YYIcdB7XabaugXMv3FurediWSR+BBfkDR62M39atMskjpxkdSXItEeDYvCoWf2OR4GXKUzJeJ22rZblPo2LlBK30I7zyYwgD6ULIq4R5gdpUnygk5gk9hd/HpcGjYrZJ9Ge3QgZhxythfwRs9l0bVTYhWp0cbjXag5A15/wE+hizi68QSO1hbS+SYeE33hqLaRYeI2qtV0PiZ2eVFU515r1A7YDjLcj4u2DSj8AdTjZdTaUOWcGJkjCmQl1jOa6kEWQGPiKZcpIO2pwjR7i/GDIH7Iood4UDT8Wo2wrcqxf3OXn+QyEdQp1DYyE3WU6B/+FJTuSs2lhZVaOpeAHMCFbrA67W9j36Uqz7x12GcTmPnbeqbfl0h/wnz7Y4FKOx0OXg3ezEaExRUQSdFFtO5vVmRy9ZeJS2EQ3xq6kOXsaX7+F/Wa3wL1Vf51H0j5xmt9zOLwQVFXrKq8V7x1ZUoRII2I7chHbgRoG/pf0yO Z2OGBKP0 TjIf85qo+pD0a+MK29hV34wr0dWnvi9EX2Vz4h4FIZhNXW8OJcLrLhpZNByNpC3JHHzs25d2IkhkgdPjpSRtbX5J3YmQfwf2ujfD/Pj+VoVddhAqBTz4uFwW+q28QjOFfBn1dpzZbIgV2pokV0s7aQuqxY754fuerhQAf4z6SlCMPyWRVPTMpTgp6kifs7Ya2deHsk8Tn/MZOOlanGnY1+XZHBbbXaZcNA1+YBEKvqqPNs4mYUj8plECK9Ec86ctLmgAJPyNHi76TsOG5NgisUHu3A4pbqYjORSnn7RX4v7vj1nV0MgH6rTBaWJUtP6Ffav/2CDnOQbyeNitnWXeA+rKtAA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025-07-08 18:52:58 [-0700], Alexei Starovoitov wrote: > From: Alexei Starovoitov > > lockdep_is_held() macro assumes that "struct lockdep_map dep_map;" > is a top level field of any lock that participates in LOCKDEP. > Make it so for local_trylock_t. I am not very pleased with this. I would prefer one struct given that the functions below are shared and the _Generic construct is not as I would have preferred it. Anyway. I meant to redo it but didn't get very far. Since is reasonable for now Reviewed-by: Sebastian Andrzej Siewior Sebastian