From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EF8FC83F1D for ; Thu, 10 Jul 2025 11:40:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4428F6B0095; Thu, 10 Jul 2025 07:40:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 419D26B0098; Thu, 10 Jul 2025 07:40:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32F326B0099; Thu, 10 Jul 2025 07:40:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2260C6B0095 for ; Thu, 10 Jul 2025 07:40:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C0B5EC017E for ; Thu, 10 Jul 2025 11:40:42 +0000 (UTC) X-FDA: 83648162724.28.09AC301 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 8F7FC4000A for ; Thu, 10 Jul 2025 11:40:40 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f+JfKLQY; spf=pass (imf04.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752147640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0iRUdl962OfD5WdAy2WaNPadKxxM8rE6jjoKazsAV20=; b=JOqiry5SvS7XQhfD/u+OWioSLm8xG96Wg/57qkb7EJ+8Fx0PE/+RBbNHNml5UyTq97MAIV opIzdJekaVkd73tSA9gN4rNHz9CXTvUJST9ZoAwt6aqfkIbrbY5v8Nquv4tJcSeYnahjoD I59Tfm+3Pg85VUUcUV6EKtbp7IJDAy8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752147640; a=rsa-sha256; cv=none; b=P0Vp4Wf/2htW+uy31yO36aJ3VPwiUBmwpNT+lrTYDiASpeV883n6l9JpGM3/MWGrjiolUW N+Vw3zn465zRRjUkfhWIa/D+3iEWSlaFVNZi7LeehaOIl9qyqrNlYQQ9lQ4KZl81oEgqbC 4eq5Goei0n51hhuyvJBzPxkAPTTNTmc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=f+JfKLQY; spf=pass (imf04.hostedemail.com: domain of lianux.mm@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=lianux.mm@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-74af4af04fdso1613298b3a.1 for ; Thu, 10 Jul 2025 04:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752147639; x=1752752439; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0iRUdl962OfD5WdAy2WaNPadKxxM8rE6jjoKazsAV20=; b=f+JfKLQYXtx/uv4luJNwRpl2IZUg1c3Tba+GuvKlSvM6ELExprnuMn9mDxOMPrM2AB 047JZCXFW0oRvnfssZdGA00pnB36kJnmUlSpC32iXINWRK2hu8Xgb8TXn+RHZkOdnAVy JWzgPezt7aeS6U7tRdKKLgep8TeBaZ5BynKz2yvqTD3YnwjHzTNS+IHTRXNbnpu1TXeH fhxl6fpqsdOfqYtg+Xxe/vX2QMDZaX625G6K1BCA7rKy3L7Js+KRbaImH67hQkxm2jvA rc45TSaDYP1zi7LNWxbJre0qzmWalYlHoyH3dPa2DVoQgztu3ERSflWq6RhmyO9J4i3l N3Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752147639; x=1752752439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0iRUdl962OfD5WdAy2WaNPadKxxM8rE6jjoKazsAV20=; b=Oaqa0AkeDxIEcwK3a/t4jhMOba+IRRdSFIOkBSblaRr8Yfask5AUcdjU81xQ62AFYu AEOZsfm+UKXmAL3KSfAiTRoPXW1UvEzBqxrRSUGLfpCCrlwKHDclF7gKiEqzcMNnOBRy NyvmNi+gZ/CcI8fAGa92fvbGBExHpy0ixsTJ9Q0bIR0XE9qG4oxC2gcH9f0buIvV+UGX fBGhXEgX4d9I4TaALsqcqe8KcLyq0CxUxkMtSfvqhgcCquA7KcjSC7/xuL9gbD2jTd4/ HqPde1NAb1HMP9ZBOb4eLoe9B2ft7fyL90EOKMi+Ns7ks05EdZ+LaqF+SsZf79UaIxAh UTRg== X-Forwarded-Encrypted: i=1; AJvYcCUj53iG0URJlMyQDpGwy3atd7+vgDUt4jXpxbz89w7vVJs9JIEEPOWPFXoUq2hf/Z4Y60T1Bb5UTw==@kvack.org X-Gm-Message-State: AOJu0YwpZuior479BJwGJlED8icsDluOZ6gxs7MeG1WM6UioqPgGzyB0 u9XLKTef+agttMoRep6MI4UHdSUHN1UzoJJHbhYPi8CpW/epwnr/DoRMqCeU0coO X-Gm-Gg: ASbGncuUDmUPyYeKVk8sjBT1Wzhg1xTSmVDX4/6I3CsdO2nHOoMEqFcQ6pJ1mIFVMy+ 85Wd+FAjqNbE0o8r1J5XR747M4tu6dLim8YKkuN1wG5kIyVZXQeMA0CCtALsmT4EsHWebzD6dKb rgFThWtI8PuAyTbLBXA3zO+dyH/txvyegVm/PvE5DcCZtXAfVYhTAqapBm/z7e0Fvl7GsSoAa5d 1e860sb04LemyZPqXf3nlvEbVmqrF7NwL3uem+1dQeUDrTkRNVG9FS0uOql8DGgvoJLyQvuQk9/ JZxo/MwWtTjD5GmjoYV8G/B7DgAqRLtzYOqE9PWWisn5Rb01WlnsJil0BX4AGt05e/gWd/wpnSn ewR2lUVvdsY+p X-Google-Smtp-Source: AGHT+IG4jOvVrFVHKIwUQ3SJ4F00MMttTRUh8ul+FH0UmJKgEUH8VTKbVF2uEvCcsLoGiniMkUBLQg== X-Received: by 2002:a05:6a20:158b:b0:224:46a0:25ef with SMTP id adf61e73a8af0-22fc38bc880mr5213931637.16.1752147639233; Thu, 10 Jul 2025 04:40:39 -0700 (PDT) Received: from DESKTOP-GIED850.localdomain ([114.247.113.178]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74eb9f1d34dsm2136736b3a.104.2025.07.10.04.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 04:40:38 -0700 (PDT) From: wang lian To: ziy@nvidia.com Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, brauner@kernel.org, david@redhat.com, gkwang@linx-info.com, jannh@google.com, lianux.mm@gmail.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, p1ucky0923@gmail.com, ryncsn@gmail.com, shuah@kernel.org, sj@kernel.org, vbabka@suse.cz, zijing.zhang@proton.me Subject: Re: [PATCH v3] selftests/mm: add process_madvise() tests Date: Thu, 10 Jul 2025 19:40:32 +0800 Message-ID: <20250710114032.63278-1-lianux.mm@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8F7FC4000A X-Stat-Signature: twzpikyhff1e7a53u8fjdht8towrz4op X-HE-Tag: 1752147640-814120 X-HE-Meta: U2FsdGVkX1/l2AC68JahZ6cjvaX7P5d1fvOLyde/z7+jjPIEHWq6tri2ueVtVOSci55zhfsEZvGrnFjukGySj42yOPAKov9++rr7LNfb8WUojKCWSPHvd2Qz2C0LKLz5a57hfYsYJr83hGQ679I+w9JS6R1yQ3iFD1Ez3zrVHFcXLy+7DQvoVLad2ojymXSSOQ23orNJijz+Jx1W3PNKIWK2bz5l8ETIPI1ehKjgEFfFXo1VtpzHN7GvHmuxrcPuLfem94bVmz7N9uZwmUbaBvBiZxxsWBoD17v9kstyT+uVRfftGOJVo+2tLLmWdTsJfzzmFvxtsGb47g2A9SrlXDr7RQl4/SrIYi6rm0qJhN4CyUdFIrwM1yGtS1NWw+qLglSXN6HvU1FsVbNWwrIzVr3G6KIWNUD6HbXHUO5ZiGDagge+9MBJINGyYjmKqxnzJHjQcRkZqMc6I5+p9Cd7yut3U32Sq8U4aEzPIIdB8cJDhfZsW+1lxoCq8TmV6imysNyCIElyvaEy+G9b/SAeHannckJXYDilcYB57haoMHtmxPaZ7fAc57aEs7wEeyLMrqsYIxL4cVXTRk/EoRPfGCY7S6FEBafOptv44uHB8tmzjf8i2ds5g9uryehD0nx+0EQe82kHohW9MfUOJ9lDtFPgva7oQIc5dbM93SjTsImC4byPFaGfO4pLoktEbkg7OLXrcQc3leqSiR5u0COzYLnyGyOWQKMyIOBItYbEJBLDSkXF7wcttdgX/dv8ZhXdmIFSgA6lwriuauMCwEUYl7o7WQWi0LqtDvLL9zg7jJs0NiegdqeqzfpI2COWAkv45B7eXwA7Vlc4fo7YHdPnmR9M7/8DtGdqsoqTt6F/EpEWFp6zg+dSfmp1eYXiNt90HiVQVhOh6nP5PNJTMSaI0FKX6zg7z4AkC7aoNA3jXaMkVyx6S+MzhPgfvFeMcwMU5uZpW5j01+IDN1h2pEO kC70E61N LcZrjn6wIY4HQM3WOwrS4ofwX3b5jodi9LAjcOnzWEDVmU7aiwX+0i5udwJF3kFsaCsyzLBXJLBpd5qW9fPZThAKUh8wQy5Q9j60w5+csH7Avdbj73+rlgIfE77XyjlpYLbSvaav8rDhVclCKEzgFRfuaz8WFmu1cjRTM3Jh5pu8qkDFsMTJZiqm61o1kSSVSLfP6KgS1kGjFN85p3BWuIn2BvvJEpt52X9zmY10RV+7mDTYHZJxwIH0hpmwKgE1qMGCwpIv/v/9p8sGnRArH3lf3cvHRpTLya2Tss10PFiogtLyyStMZcVCqkA3X1WGg8eG8Q19GMiVzu6ttyXTFJwQcth3G2z7Dbzzx3eZAgu2C0RMLUjouexJVIlkTxJHLRvF9fK1xZU6MVlN7RYdphw6Xi8L466QbL3S/fZ/PA0wQfG8S58UXvf1Rk8iEBMt/66dscXK1phsiPJ7iFsQeSQrUE6F99zirFbr9WwfLYHUfvsIIfFf6aaNl6PYvFiYyA+XUiaCgJUAGxrkFLMhDtq4ajD6TWKBvGQuR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Zi, On , Zi Yan wrote: > On 9 Jul 2025, at 8:32, wang lian wrote: > >> Hi Zi Yan, >> Thanks for testing the patch and reporting this build failure. >> I don't have an arm64 environment readily available for testing, so I >> appreciate you catching this. I suspect this is caused by missing or >> older userspace headers in the cross-compilation toolchain. > > Right. My /usr/include/sys does not have pidfd.h. IMHO selftests > should not rely on userspace headers, otherwise we cannot test > latest kernel changes. > >> I will try to fix this in the next version. If the problem persists, a >> good solution would be to manually define the syscall wrapper to avoid >> the dependency on . > > Based on what I see in other mm tests, the following patch fixes my > compilation issue. > > [ ... patch snippet ... ] Thank you very much for not only identifying the root cause but also providing a concrete patch to fix the compilation issue. Your analysis that selftests should be independent of userspace headers is spot on, and this approach aligns perfectly with the feedback I've received. I have integrated your suggested changes into my local tree and will include them in the next version of the patch. I will also be sure to add your "Suggested-by" tag in the commit message to properly credit your contribution. Your help has been invaluable. Best regards, Wang Lian