From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66112C83F1F for ; Thu, 10 Jul 2025 10:11:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C763E6B007B; Thu, 10 Jul 2025 06:11:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C26A56B0093; Thu, 10 Jul 2025 06:11:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3CC26B0096; Thu, 10 Jul 2025 06:11:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2D4F6B007B for ; Thu, 10 Jul 2025 06:11:57 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5722610BE1D for ; Thu, 10 Jul 2025 10:11:57 +0000 (UTC) X-FDA: 83647939074.16.6E7689B Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf13.hostedemail.com (Postfix) with ESMTP id 9D63B20002 for ; Thu, 10 Jul 2025 10:11:54 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SDwPg+Zc; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of leon@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752142314; a=rsa-sha256; cv=none; b=qlSXHNPJPyJBnBgQuRxZI8SMul6tWjheK4smIb/c+RQHc8FouogaPRzGhT8k1QWLM1goVV 9ck2X5uqV7YvL35VSgnhyuFvduw/zsYpoxJXD3Qga2qBVxO8o2JNUjSE5SYkkDbTS35MWD rTqXL7xVC0Y3L7Nf05RDY3u0ThsE2ZM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=SDwPg+Zc; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of leon@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=leon@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752142314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1in3OG1v25OI1+jFMHX7LTSqqdIrYhIvN8VHR3YhAxA=; b=E1lUIDAcdZTMBqTF3o71FB1R5LOU2YmOZNtbA6KfB6TWrNHXxURzNwC4VMoBE+gWRbcoSA 4Iyl+ArA0aiA7b8kdtyeZEWYxo5wcO6oMGoxlrSTdD6aHZoaGB3Z2g23sPidhd7r9Xi1Su oQ0oP7oOIsksBfVoVKgCebY3BGalNY8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5B03E44E9D; Thu, 10 Jul 2025 10:11:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF2B6C4CEE3; Thu, 10 Jul 2025 10:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752142313; bh=sFjsKP5Kq+l7KUXAo36cOhptVGEGd+oXiRAsy4MAfYA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SDwPg+ZcvbYBu62jE1I2xJ+Ra8QPGDdZcJnn7uAxHUWWbh513ghHaAKeqeXbGAdqt D0cjV+zuglkbRzrc2JDXwt1XmKtbOXgBOfXhjiOtns4Y08Jg74R4ImR35vhjg8QWn6 dYAlZXTa4PLNbxCddpNr1UUZg25WhhP+XwACJFbSrDimsVBH+row6sLlUzUl8L7Jso DQlui7fisLyXECnmCjRSmUiMdamJlAZ+frgoiQk6oUo0+2T6By+heW1httL8pDLCs6 CiEN9QXTSKDhrTSF6Wbz4WVANhaMRPApj7DMQfzr0hSgZ3NKhrNBIebxY/O5kSSy9M oPm2WdhBxXpfQ== Date: Thu, 10 Jul 2025 13:11:48 +0300 From: Leon Romanovsky To: Andy Shevchenko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v2 1/1] mm/hmm: Move pmd_to_hmm_pfn_flags() to the respective #ifdeffery Message-ID: <20250710101148.GJ592765@unreal> References: <20250710082403.664093-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250710082403.664093-1-andriy.shevchenko@linux.intel.com> X-Rspamd-Queue-Id: 9D63B20002 X-Stat-Signature: oj697j84xoqso35o6hh7kb9tdwwyuzxt X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1752142314-503726 X-HE-Meta: U2FsdGVkX1/Wg8QA5V/qx63e1GF6M26T1pWMoAfiRaZDVUEl9tF7lsiEGzloHn2TDSzwEtzvJ39UbWrx7ksCkC7EC48AZ31pmngVa4yHiVJciK9tZPUGzkp64DoQSm3DWTL4Luy9I0OsPBRuDJPWoYjkl/AbrpdAuAAq1433ya76wt3yVY2KVvLWrfqJyvbf7AfZ2zGTcFQsx4HtOYcYE1bamB0JgtHfTBVIpgHVwmw1qnuKIu4E3xgFUsZReW58by9uWQkQZYwvX2FtrIc1DdpXHfmb9fyP4kOhJVdED4wxWmkU1QzSpF7A7G/2hU8/4cYhAZgaJ7IcGzvgawyhPDK3IF65JquszBC6pmdSwFUWx82/Fj2zaBTF0flvBS3aWTqKdJtWFi/dvOof3zLlC9C3ta2k4d64axU1KBs2jTgnUHM8ZVuoFtWQshD4qpitpnbpjvJ5/g1jQhkypntsHwwQ51dREn0PFGom5aF7sbtMBmYBF/PrQ0XtSFI3sMBVTaKWJ7Fix6LvHH7NnCVSIeUwhQNYzPqYn+dO27UJFLGirrCM3vl8AkyT+ak9GG8kJynee7GiUp/XIgqhlAGyOXRwhTA0JcYeB6XyvKdGemhjD6/KrR0BNwRwNGMDFPr4Uon6mH9u77afLEGYmCwLbQalyqBFbl/uHTojzwn8G5qVYHSBY9GX0O9Pc1/n+kXA/Ge6v0Cq2skbJR5ckd3yi3/BGhY0VDKmO2g4nZXXzpKUcXtkT2OZ3viNUtfpLCrXl140NXYkIRiABg1ENqq1PFLOfNQD2HEcuFeI9mcPyJBQeTREwquic8ty6mC4TasJ46swy9N1Wc8wG2NHaLvnRKDtHACC78Wd5fUhc6qfUgvxIZSIh2HE01qLgUQdAztu4HvJmCNOIzG8ihkrkwUCr82hBLtM0iB68HxRP2gn1fB13ynzoi89kU8bEeFytSTbV7Hyaf8gqOLEPCk+y4l iUq9Mh97 OawoYE/Y3VSzrl3p9X52mDZsSvkvkc79UftZ+07fElZwfTR0Q682S2HNPy/ETHYDC9dMef3hNLJlOZRDyCUinuCkO9UxllfoYvy4+igYGliUckWJKP8GSJHGmuB3A2zWf3gUv8cOS95BBE4L8KiStKjh9IWCSo+igXdQmYSBFSLihRla8x24DTEZYsfM+NzO6/2HqzLPXUyuRQmc9MOatM0KO5y8PeXPUHFo4Bziymr+JJS9owfDGBo9N4plHa3As4YIUSxK0AE75h75KYZRrRnY1qKgW50cqmQ/9V08trK7p2NhUZyd20B7o3eNhFCO5ChzCp1WIHvxFTP+LDWV8j1pNnPz5xXcPsVr6SDMlTZ4enfuf7X5u6lOvJLbc5JG2EMzS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 10, 2025 at 11:23:53AM +0300, Andy Shevchenko wrote: > When pmd_to_hmm_pfn_flags() is unused, it prevents kernel builds with clang, > `make W=1` and CONFIG_TRANSPARENT_HUGEPAGE=n: > > mm/hmm.c:186:29: warning: unused function 'pmd_to_hmm_pfn_flags' [-Wunused-function] > > Fix this by moving the function to the respective existing ifdeffery > for its the only user. > > See also: > > 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build") > > Fixes: 9d3973d60f0a ("mm/hmm: cleanup the hmm_vma_handle_pmd stub") > Signed-off-by: Andy Shevchenko > --- > Thanks, Reviewed-by: Leon Romanovsky