From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 990BAC83F03 for ; Wed, 9 Jul 2025 18:28:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 209F36B00A6; Wed, 9 Jul 2025 14:28:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B9BC6B00BF; Wed, 9 Jul 2025 14:28:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A8D66B00C7; Wed, 9 Jul 2025 14:28:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EA8F26B00A6 for ; Wed, 9 Jul 2025 14:28:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7203F1D8C6D for ; Wed, 9 Jul 2025 18:28:49 +0000 (UTC) X-FDA: 83645562378.19.FC5F54D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 9F3A3A000A for ; Wed, 9 Jul 2025 18:28:47 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="rQe5hD/X"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752085727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fo05BKnNJC8qIGfgaAwbs2BsHGb9tEIFwytluRjeBO4=; b=Rvk3sEsgwm1ShCO0ypZo0u6Yu2ZFAJoZTJ7uMDkghSr710X+MhFMd8qi9RcLQ2o1jRsDwP ca+YVqkkaV+XP+ZrUBaBc7tRkCZC2qsJGtR6gpvmHZvd4g7BSdkZd2DENOQOPS+NkfnRmu 0WanPLUwGsJgKENH9an5wrwIYzlO5hw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752085727; a=rsa-sha256; cv=none; b=2DjKm09h6r3tuo2vH0awWrs/+oq/Gh862FnISw4xOyOJesG/FQD8XtQnOi0ZCadhy0UzPl qE7b/2XnVEVOzts1W306AKsdyosW+aXTfYtwfKuczRWtLiu6mYUs9M++lItFICO6q4wMgL z+tNSOSF1k0F1qUSRqda4qP62XAF9hw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="rQe5hD/X"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 82A015C6AB8; Wed, 9 Jul 2025 18:28:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0CBBFC4CEEF; Wed, 9 Jul 2025 18:28:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752085726; bh=9fdOdgXFqFowyzNU5tXxjS4uhBhKB/MS4gO9Omh2uak=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rQe5hD/Xy2KnOs/bQB0lEgW4j3mQDC4PfqWXL07vLm2IdbrLSoh1i8OS5yTv9I69G HentD9Mbh4/GyVFaO/5UGpCitKYz2zIWnFvM4LdA2j0hnbCKTiN5vn78vF3oEtn57r WUOC+ZjrXr6CgsbnSUxBMl80DM28klUBJYS8bcz6Q5/pHvC6BQS8DMMR3vFUOcyMA1 wnZZ3O2mR8i+1phLiwuqaOMhZ8rYXW5zDvcys/+O7fuyqaE7jdbOmN1bZE/9Nf5CTW y/7u14FN1rLcV4/BNFXA1892o6y4j2x+hXZt9/4zChKhrW90fV5Z2a8ikf8XlO9a8g NW4bbjPKdSiiA== From: SeongJae Park To: Steven Rostedt Cc: SeongJae Park , Andrew Morton , Masami Hiramatsu , Mathieu Desnoyers , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/damon: add trace event for effective size quota Date: Wed, 9 Jul 2025 11:28:43 -0700 Message-Id: <20250709182843.35812-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250709122123.779c874f@batman.local.home> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 9F3A3A000A X-Rspamd-Server: rspam03 X-Stat-Signature: gz45fcccqf4y4gy5fzft8umkpunr8gxj X-HE-Tag: 1752085727-631290 X-HE-Meta: U2FsdGVkX1/3RWPlX1nrGovUbqYMyj+v61rDwBauwGYQUuuIvP0qxTqP8SoS++CGnCBe3BYYI7tCFIpFLf0JucAYhguZuNoIB+T05N+8d1DM3AhdWv9MZWscMfaVwvCfsOFKKLmGJR0unt27xGI36M8kywgIO40m8U1eIZO1JqEu7xSERYnkt4ZA9119gWnIFjmpmhQKWsxNvEQVlg6QvIHw63DdKAaiDEebR6MkqfHWonbpwAsz9mh28yHOZDTCMN34rzsZ44FzL0TvhimJES1THNJ7vGQkF8NEf11Ic3x6Q6lBdpF2Mk5k4pjVNqQToOZImsurzrh0GQ6qaK0ro5kRGgCXT9WKT/FrOvVbtPwmnZi9y8TIBs/5/XxWzMGiRXUKqnhhd9qfnr8ulT10AOZKomlXV8np+1OgbkN/mKNC1wbCGnrTAlo4a1gTWq7kmC1EkOL035e4vr069L3ZLZcJL6c0wBOvQ3U3JB7ba2OHpFbxRIagOWKxTL5aLPU4ibzNetXGi44DSEFI6wXZI90aPnsXJ1pwkCuEeQAO1qPZwXPSOO/wmWCT7CypmY5PIs25R3ZLXGeERKDXrFxD8zDWnmPgaSGS+CA7Ic2SDn7pRCNWA6iypa+lAdKCdzeOQj7OR2/raftUR24fKtMijy1hfX5dcGLc8n2KT44oMeGBwczCICY+xXNrqWeMla0kw36+zRpo0nawOy5vxUyE9r6WO4TaaQQT0am/3VE481mp31MX7jb9OAkHUAEsdBXoLqEwqWxOxXQHvRNLj3m1dwuXwVaoI9843Lr3qER8OxZ1SCzdC+LBoJ1BFFaTF8gEOTCo2Sci4waIf3q4XF+ISRBvlnZC2Ns3prNqWXHDcxag7G11XHmDmkfKZ42p/aVuflFHv1LLXp/AIYc47ewPO443bX1doiyy46jAZFIOfEzJelE8fjPNK/INQAYELOWyDe+f/OsFinwxo7zWgJt VJoee+2n Qaf/tVEd1DhFZ0HRm0gT/qE96/Qy/BzA0PcY80XhTsWaK6ajeiRT0ogL0VBSsTN6Az5Up8ca5LF79fk5h1V8YnKNmY6T1gdDKh6ojOwiSlC2cd/lePd56+L3KEiazZOz+r2ePJDRwMRVTI7EMdANrJJr4nuHAgE0T0l8AfZwfk2+gj9+0iJTkPUqHcr8y06JuUg+/hp3ANa08Sq+W6hL1PPLNelyNHwt30DZLlho+0y7f8v5mmJo7ODno3e7Hgkt5zRXQh65wo79SRkYoLc4hcGfzD86Pgxh3sQqj/dW5HyAYheZgSCS9u255InTcerj536Tp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Steven, On Wed, 9 Jul 2025 12:21:23 -0400 Steven Rostedt wrote: > On Fri, 4 Jul 2025 15:14:08 -0700 > SeongJae Park wrote: > > > Aim-oriented DAMOS quota auto-tuning is an important and recommended > > feature for DAMOS users. Add a trace event for the observability of the > > tuned quota and tuning itself. > > > > Signed-off-by: SeongJae Park > > --- > > include/trace/events/damon.h | 26 ++++++++++++++++++++++++++ > > mm/damon/core.c | 20 +++++++++++++++++++- > > 2 files changed, 45 insertions(+), 1 deletion(-) > > > > diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h > > index 32c611076023..36b2cdf47dce 100644 > > --- a/include/trace/events/damon.h > > +++ b/include/trace/events/damon.h > > @@ -9,6 +9,32 @@ > > #include > > #include > > > > +TRACE_EVENT_CONDITION(damos_esz, > > + > > + TP_PROTO(unsigned int context_idx, unsigned int scheme_idx, > > + unsigned long esz, bool do_trace), > > + > > + TP_ARGS(context_idx, scheme_idx, esz, do_trace), > > + > > + TP_CONDITION(do_trace), > > Please explain to me why you are using a conditional here? There is no reason to make this conditional. Maybe I was out of my mind. [...] > > --- a/mm/damon/core.c > > +++ b/mm/damon/core.c > > @@ -2011,12 +2011,26 @@ static void damos_set_effective_quota(struct damos_quota *quota) > > quota->esz = esz; > > } > > > > +static void damos_trace_esz(struct damon_ctx *c, struct damos *s, > > + struct damos_quota *quota) > > +{ > > + unsigned int cidx = 0, sidx; > > + struct damos *siter; > > + > > + damon_for_each_scheme(siter, c) { > > + if (siter == s) > > + break; > > + sidx++; > > + } > > + trace_damos_esz(cidx, sidx, quota->esz, true); > > It's set to true, so it's not even a conditional anymore. The compiler > will likely optimize it out! You're right. Andrew, could you please add below fixup patch? Thanks, SJ =================== >8 ====================== >From 13975534cad603410837c5eca299f0a24ad802a1 Mon Sep 17 00:00:00 2001 From: SeongJae Park Date: Wed, 9 Jul 2025 11:22:39 -0700 Subject: [PATCH] mm/damon: make damos_esz unconditional trace event It has no reason to be conditional. Make it unconditional trace event. Fixes: 9a365a71b830 ("mm/damon: add trace event for effective size quota") # mm-unstable Closes: https://lore.kernel.org/20250709122123.779c874f@batman.local.home Reported-by: Steven Rostedt Signed-off-by: SeongJae Park --- include/trace/events/damon.h | 8 +++----- mm/damon/core.c | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h index 2e4d7d281fa7..fc2c61ccc887 100644 --- a/include/trace/events/damon.h +++ b/include/trace/events/damon.h @@ -9,14 +9,12 @@ #include #include -TRACE_EVENT_CONDITION(damos_esz, +TRACE_EVENT(damos_esz, TP_PROTO(unsigned int context_idx, unsigned int scheme_idx, - unsigned long esz, bool do_trace), + unsigned long esz), - TP_ARGS(context_idx, scheme_idx, esz, do_trace), - - TP_CONDITION(do_trace), + TP_ARGS(context_idx, scheme_idx, esz), TP_STRUCT__entry( __field(unsigned int, context_idx) diff --git a/mm/damon/core.c b/mm/damon/core.c index 0f7d8b37c91d..775e097b6538 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -2223,7 +2223,7 @@ static void damos_trace_esz(struct damon_ctx *c, struct damos *s, break; sidx++; } - trace_damos_esz(cidx, sidx, quota->esz, true); + trace_damos_esz(cidx, sidx, quota->esz); } static void damos_adjust_quota(struct damon_ctx *c, struct damos *s) -- 2.39.5