From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FCFDC83F0A for ; Wed, 9 Jul 2025 17:47:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BBCD6B0148; Wed, 9 Jul 2025 13:47:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86CD16B0149; Wed, 9 Jul 2025 13:47:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 783326B014A; Wed, 9 Jul 2025 13:47:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 687C06B0148 for ; Wed, 9 Jul 2025 13:47:14 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 114DBC037F for ; Wed, 9 Jul 2025 17:47:14 +0000 (UTC) X-FDA: 83645457588.23.DDFFE29 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf06.hostedemail.com (Postfix) with ESMTP id 463CD180002 for ; Wed, 9 Jul 2025 17:47:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O8QwZ3+7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of suresh.k.chandrappa@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=suresh.k.chandrappa@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752083232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=xdJCSh+a/a0vurjEEgP9Hf7+uRN4IVWDqJmRDGG9p1I=; b=fobFz5MjYAa77OCb7TWvbvmIAFP3wsEkZgzlXEZRA8DqlDTPHCZL7sQKnHYl5aNepeHrch DoBsEHDtOPpVQIAFTHhqVXEBngOiWV4JJJQYMrRYY3hAOdaYs6cfIp/EuGUTZ+pp9Z/NKd i7qxiexF+rdDq83N6OJwwkE7yCyREKQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=O8QwZ3+7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of suresh.k.chandrappa@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=suresh.k.chandrappa@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752083232; a=rsa-sha256; cv=none; b=OAhXhHMJKLAPZMkddNGjbBv+NUydm7r9aiUIoW73Q9xKknr8GPhiE4WnHwIhXqiXozRFm0 FQIFrZlEolC/KBqZ4zPVfxwdzVgLfaQbQNE7XRnNV08JG98Mgw7kSEb48iqEjf6aJHLaHL MTEkcWMnD2QcZFsVwgC9YhfDMJHA5as= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-74b54cead6cso114686b3a.1 for ; Wed, 09 Jul 2025 10:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752083231; x=1752688031; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xdJCSh+a/a0vurjEEgP9Hf7+uRN4IVWDqJmRDGG9p1I=; b=O8QwZ3+7PoOebgIhOY4Rtf3uJnNt/QoqZfwh4FEpyMUgxnJeHJfmVPNdlIV27SDv+/ wXuHGLTCBVtt0oYPe0jWptVs8VqrF7i1GWkCr2y/tcDvdpCt4fJV3xiSNldtbKgtIeYY qPJzzVVwyNoLq2Rljfhgf6hNfzlFSkfNIkBrbLol5iguTxbk+PNlFXrZHEGtvt8PIpaP jd0oAEYSPJjuaZU1VM+/ZMo5UJOU1kTJhgcvzeppCRbVpFNy9xLn/jwHWNkDB24VxHY/ FX63FxiJavJnoPih8lh7EpQFjH32dclLFWYwNrKAmBwEA17zScaLtWZiHntVw9/0+aKA mKvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752083231; x=1752688031; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xdJCSh+a/a0vurjEEgP9Hf7+uRN4IVWDqJmRDGG9p1I=; b=avFBD8ZJOdD7j3k3t6Qam8u6Ezm2Jb98gAnOsc45Eg0iYESagbaAt1+JOZC4GdiO6a 6FaCPS/GQopu7SkhghhSeoDdP7qFZG8hAolzzBe5NGDzaaSOh1e9w9asDTNo3TC4ZrAB tv6bgd0gGrzJboeJ8VACPUvXFEhDVJfDQKZhTpCz84fuq/DNDnzd+FVL+qs6SJ0pU+rq 1H/0xIwnhwhDQ6v3DhDC8l10n6wHLg8WLv1N0NC8arKuc+pEQ3esu/3Ft0XWZzZpZS6Q mDJd7OC7KcAVFspABWPwGFlgt+WMDuaR+W/1sAU9Gr4OYOUiKrZ30fSQ1Z48HEtrS5pw RNlQ== X-Gm-Message-State: AOJu0Yz5+tzklJVghBpyN3+iXSopIn9Mk1qxaIHd1CqruyVpAoCjk6yo DSqGjhK2DHhjUnDSKELA1BEgYnJmIo4AOW6QGVLjXiOLt8yA90sftOOvqMzAqMX6FYc= X-Gm-Gg: ASbGnctbiSXfnRqJ21TTwX9fv9XR9Jr6zsYDjnpExD9GXXxd76pLjWx/m99cPlPUE4x S/Gb8U0QQJlOk8B5LxckUDf1I4vVSwKxFTLfuxB91Lk6FQZWeYyq0fX3sq5+6H9JsLjBwoeSYRC AOzTDjl707eOQgi63mBsMB07jgcTMFQenFa1bUkKUkiOSur0rsjECt+e0AM8HrOvSMbEqT7/S8J Vx/KFhIrRpQbko9gCQsYED24eChUKkfZh2ET+bUDNq8nAH0PSli1ngGM38bid5TLsng7fuue+ds 2vUoC4BPe1FR/5YdbGLUTsOLwlx1LoKntlRR8/IkVajHGrOPBGW74CCc4ljNYi4= X-Google-Smtp-Source: AGHT+IGiDIPsjHUYET9EGq1pGVgz8JIHHC3QtQVJFTR9ANYfbQ8ajG6QIGQGyNAJoMLajgRSLbeZlg== X-Received: by 2002:a05:6a00:bd90:b0:748:68dd:ecc8 with SMTP id d2e1a72fcca58-74eb566a8f1mr460576b3a.22.1752083230927; Wed, 09 Jul 2025 10:47:10 -0700 (PDT) Received: from skc-Dell-Pro-16-Plus-PB16250.. ([132.237.156.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74ce42ab1f1sm16323750b3a.142.2025.07.09.10.47.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 10:47:10 -0700 (PDT) From: Suresh K C X-Google-Original-From: Suresh K C To: nphamcs@gmail.com, hannes@cmpxchg.org, joshua.hahnjy@gmail.com, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Suresh K C Subject: [PATCH v3] selftests: cachestat: add tests for mmap Refactor and enhance mmap test for cachestat validation Date: Wed, 9 Jul 2025 23:16:57 +0530 Message-ID: <20250709174657.6916-1-suresh.k.chandrappa@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 463CD180002 X-Stat-Signature: 1xzsx9owqy7riri6pyad899yffaupeqr X-Rspam-User: X-HE-Tag: 1752083232-707514 X-HE-Meta: U2FsdGVkX1+Fo/fFeEafHQcI28narSJVHrTIHmcsAqMpVV75QO3bczsHCTvEp8oAKGJFi2zdawmL7GF3KkoCByO0F6z790xPFuxkoDhbcq6CcyHIm6LfwvxMuG83ZHLEwBJooFYsd8q739CgcdVXT0ouwAEzWBmDPTM0jGYbzdS+M1b926JkVJ/qHO1ub6GT5fUdjxg6qfrZxlB4dW0HT8o7HwZb3C+xk2fqM31brcLUXUm6c2HgBlU349yeDAFMsVtQE6f5Tsc0/fp709dTkmddev5eZGy+VtcvvRnu341gFeREEauJFz+QxefG6UOWChaxs3D5AfhaZlipg7q8JI7mbc5wV2M7/0d8nCTEiAQUF507g2yp4coWalIZhyy8VTTwJyYpoxpS5fSDe2fHa91YHfIMlpmyA+dSFUoc6rAW1YakGOF55Ftm11yWj2jW2no5BTa5f2qPCTjW114mtwtA0k5mPNvIYlZlyv7a+r2fsF1blqZfhMEmK83P4rVrGipsbDCv+EiNnToJHyol3RPd++vYxKHfrRvQ2n2yNAOtVstW5Izvt0FfeNf/CAen9Gp1F5R9eo8yoLTR91ClEMrxTggDVBPOUpek64Jn+wNUz+Pe1O/vmVNgkhSMI8g9DBjy5nMgIdOMdhsb8Sgj2Sx42tmtawN92rAQnMjmq505h+0Hcw9jVXjMq3+J7Vs3lF4CiskYQ7+fxdrd5jmeR50hjzfTHdxdZe2TCZm/8EiZIziwVCnG5D63g9HcGGjzM4emg2UyHkytrxfSnvGOopndj9GCcspNM9IFahcdGUHa1UDI/HadrZVI0c4GqpNpycgOxtsXBOf53JBMb4xYH87+4y6oxLv4ALhCxYCyZia1XPrF1uGHigk9aiE197aQMW2u+xIeQObd7hgi5C7wChmVA0os+hMl9g6pVLR2IEejV5xgYhpmT0x1gAotOoEg0u6oBWBKD3J8wSgjdNc G3RkPo9k O5PQvYmFEDJIBH+PLAHnEp58GKrkizstc83y0m7lAJHLAG1Pgh1b1d785wjVTqgzPmVmAOr+xthTKTIOlyQIGv2FCv5yvASNA0rQT13G2W1M+GwN9epFbBSdyH+kBy7ohVBghVlEK65Xvzbomk3geFGsYTAS0YmLdvSqeRmsfv58OokdTeNT6mEojVrluIIZL23nXqbF0f8Hj7lWC8rjQH6UrzfGEnAxzdQNEaTkHPvHBf3PwuD5KgpqUW1ho4sJNX9n0Dy90yd+qyOsrvXC8BhFgDLF51leLIg5fzh4+zqHWjfg7X64f+5FZepbnibBw2ZpW/ohpNadU1LYs3tRlKeah3+Ax0Dz+tXZ/1bjH484qK1ACNqE/x1Ec2N42Dz+/zveVfJfyZ30OXyM0nAIcSvblHeM9nB+W0HbPakiZzKNjYHslMHUJJDRyHWteY1gl6qNJzTaQA8v+a+/BQCLTG96c2NZw6jtPRCKoiT03lf4xNYauROKOMP7ljar6eJDL8Qmd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Suresh K C This patch merges the previous two patches into a single, cohesive test case that verifies cachestat behavior with memory-mapped files using mmap(). It also refactors the test logic to reduce redundancy, improve error reporting, and clarify failure messages for both shmem and mmap file types. Changes since v2: - Merged the two patches into one as suggested - Improved error messages for better clarity Tested on x86_64 with default kernel config. Signed-off-by: Suresh K C --- .../selftests/cachestat/test_cachestat.c | 66 +++++++++++++++---- 1 file changed, 55 insertions(+), 11 deletions(-) diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c index 632ab44737ec..18188d7c639e 100644 --- a/tools/testing/selftests/cachestat/test_cachestat.c +++ b/tools/testing/selftests/cachestat/test_cachestat.c @@ -33,6 +33,11 @@ void print_cachestat(struct cachestat *cs) cs->nr_evicted, cs->nr_recently_evicted); } +enum file_type { + FILE_MMAP, + FILE_SHMEM +}; + bool write_exactly(int fd, size_t filesize) { int random_fd = open("/dev/urandom", O_RDONLY); @@ -201,8 +206,19 @@ static int test_cachestat(const char *filename, bool write_random, bool create, out: return ret; } +const char* file_type_str(enum file_type type) { + switch (type) { + case FILE_SHMEM: + return "shmem"; + case FILE_MMAP: + return "mmap"; + default: + return "unknown"; + } +} -bool test_cachestat_shmem(void) + +bool run_cachestat_test(enum file_type type) { size_t PS = sysconf(_SC_PAGESIZE); size_t filesize = PS * 512 * 2; /* 2 2MB huge pages */ @@ -212,27 +228,49 @@ bool test_cachestat_shmem(void) char *filename = "tmpshmcstat"; struct cachestat cs; bool ret = true; + int fd; unsigned long num_pages = compute_len / PS; - int fd = shm_open(filename, O_CREAT | O_RDWR, 0600); + if (type == FILE_SHMEM) + fd = shm_open(filename, O_CREAT | O_RDWR, 0600); + else + fd = open(filename, O_RDWR | O_CREAT | O_TRUNC, 0666); if (fd < 0) { - ksft_print_msg("Unable to create shmem file.\n"); + ksft_print_msg("Unable to create %s file.\n",file_type_str(type)); ret = false; goto out; } if (ftruncate(fd, filesize)) { - ksft_print_msg("Unable to truncate shmem file.\n"); + ksft_print_msg("Unable to truncate %s file.\n",file_type_str(type)); ret = false; goto close_fd; } - - if (!write_exactly(fd, filesize)) { - ksft_print_msg("Unable to write to shmem file.\n"); - ret = false; - goto close_fd; + switch (type){ + case FILE_SHMEM: + if (!write_exactly(fd, filesize)) { + ksft_print_msg("Unable to write to file.\n"); + ret = false; + goto close_fd; + } + break; + case FILE_MMAP: + char *map = mmap(NULL, filesize, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + if (map == MAP_FAILED) { + ksft_print_msg("mmap failed.\n"); + ret = false; + goto close_fd; + } + for (int i = 0; i < filesize; i++) { + map[i] = 'A'; + } + break; + default: + ksft_print_msg("Unsupported file type.\n"); + ret = false; + goto close_fd; + break; } - syscall_ret = syscall(__NR_cachestat, fd, &cs_range, &cs, 0); if (syscall_ret) { @@ -308,12 +346,18 @@ int main(void) break; } - if (test_cachestat_shmem()) + if (run_cachestat_test(FILE_SHMEM)) ksft_test_result_pass("cachestat works with a shmem file\n"); else { ksft_test_result_fail("cachestat fails with a shmem file\n"); ret = 1; } + if (run_cachestat_test(FILE_MMAP)) + ksft_test_result_pass("cachestat works with a mmap file\n"); + else { + ksft_test_result_fail("cachestat fails with a mmap file\n"); + ret = 1; + } return ret; } -- 2.43.0