From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFCBC83F0A for ; Wed, 9 Jul 2025 17:04:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D27126B00AB; Wed, 9 Jul 2025 13:04:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD7D86B00AC; Wed, 9 Jul 2025 13:04:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC6E86B00B7; Wed, 9 Jul 2025 13:04:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id ABADC6B00AB for ; Wed, 9 Jul 2025 13:04:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 63A5F57DAD for ; Wed, 9 Jul 2025 17:04:08 +0000 (UTC) X-FDA: 83645348976.06.4BAEE81 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by imf01.hostedemail.com (Postfix) with ESMTP id 6D5A740005 for ; Wed, 9 Jul 2025 17:04:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kYDG2nll; spf=pass (imf01.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752080646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CnIaGfpNrt4K83qo5+MvNHV88ocMGD0HtklYZ77xixo=; b=ktDVM7yJIOHX2Thro0ISLDAscr26OiqC4npVB00blc2mYFffTSxXxTlGuaHn/hwLXlGizl hDbzGabSQ1JRPwe62aGBGP9ebqFEWHLfewuhurjJQjV/j+4g+j4QyklbxG03Qt+jih4lCs 2ZfC2Ax6GiUb16xyEnF8MVkZN//Guc0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kYDG2nll; spf=pass (imf01.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.219.179 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752080646; a=rsa-sha256; cv=none; b=sCv3mH4COAkzQSgbzKlAcBHVs+oTwSIhO1eJpLD4jc4KNV2aD7a5KD3NtKIc6FUkld1a0B FiUImrXbVSWrqXlBzlxnKwhwXIq4SIeXo3PNz52e3GOfkYhR9hIy4xaC+yOGWWKU3e9GPc uI9rM1W15kW5uPdLqg9Z+/EE8J2zTfQ= Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-e81f311a86fso21997276.3 for ; Wed, 09 Jul 2025 10:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752080645; x=1752685445; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CnIaGfpNrt4K83qo5+MvNHV88ocMGD0HtklYZ77xixo=; b=kYDG2nllnpiNZzBKhuME+VW9IDWcKPrLYy7DrrFV/lKyhwr/WN2HezcnlyxY0xFw/S 2frElzpayPGleoevA/J/58Hoz4q5c0Ifd9JOSJVg6aF0zSi3IfIsPjVLfwosiCK3Yy9K 5rxKOZOa8WFfpYEj/KCAi2djafrCRWgjOa4QIO4NsvBbFa9NMmPnqVymVaYvae5Mjp2+ S7nqtvCwoBY/b6DWYErAY7Wfd2rIBVPPdLIfy6TH1ks05SX/PDoK+v8+LNfTmD6xgNRa QoGEmn79weY8xVTX8fBbbVXyEZ2SqusYw/Hle8uGXarcaKF9UITWi7XWJHsqM2BpfShH Kvmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752080645; x=1752685445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CnIaGfpNrt4K83qo5+MvNHV88ocMGD0HtklYZ77xixo=; b=wnucrsw8qDd3z571Mhsa+/YzlRQNoagHW1A8MPH9TjsFIzyNqYVkliMqwIfcGt+W/t fcKCURJIJ0lmeqkDwSndvQeWEwT8SytLg/NDN9dfbZ68ZwVboYQj3WaltaVNsqo8baZL epnlKLcRSKBxU98hzlhH1z0KiMes+aTQV12f53zP6h11ZZMOzk0JdPgNFU4PqSzF4FJ9 vXjztkT4oFZi9KeWgvY9Qq1JpS1kWO/PT8DLtAD+wF+esg3i5EYOJ1qIDOhTz8JV/WKn a2yP5lepp9AYgFLQepUSVwepKm9FaPUTZxQr5sTKmyhvP/qiHH+mb/yJgZuF6LEIrHNZ 7uhA== X-Forwarded-Encrypted: i=1; AJvYcCUas3OAaidFnPqxDNLcQ9zFUhz0FKmzAAPBQshn56+3DsZSnUx9IkIEr0xi0iIMY6DF1FSwowoXng==@kvack.org X-Gm-Message-State: AOJu0YwNFCu8U8VURhhf1sYzP/Rf/ao8yT+mu/j/xYrXKhRZ8aL36jI5 39RMK1daQVv3oFKNIXNQTYd4tbTMWd0Qdj7H6dJg6DCwqOTy99d08PwYHt4t3g== X-Gm-Gg: ASbGncs3Ua5SoDARzo2pa832z4v4wSa/tUZ69P4lXTFdvATILEveFjMbe7HbB2eD2O1 S32KEqfKDTKE78TIWO3qyhIJtFNZNeXcNL4r+xZ3MX8a//nEku48jCdREwGkaXApH479Pu+KiFy zExkcCwsb+J/V8coGTJ/4kbQg2/pIlEF98hAY+62Djh5sBYIjCfBjDkLkMOO+7RW0nFCw13tDas gbd6gzTG4Izopy7dRvSlw5kh9/XweEeZ5zFHXKKs9+z94wm2ALRJ9p4XjygUSW+L4JVPsEVmnVm VaFtZX7upKlYdGvpa3vOm5jK/3J46huriEc55DPpMXNU2+zYi6foj6F628OKOw== X-Google-Smtp-Source: AGHT+IHgRm6QHNJ36Cz4IWv+BXPReTKk7xvpcxLloQ17ROogfogPufIjdTMNs8dQuMvuz/H7K04QNA== X-Received: by 2002:a05:690c:6d10:b0:70e:185b:356d with SMTP id 00721157ae682-717b169e13bmr50960737b3.14.1752080645173; Wed, 09 Jul 2025 10:04:05 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:48::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-71665b12c88sm25985487b3.94.2025.07.09.10.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 10:04:04 -0700 (PDT) From: Joshua Hahn To: Suresh Chandrappa Cc: nphamcs@gmail.com, hannes@cmpxchg.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] selftests: cachestat: add tests for mmap Date: Wed, 9 Jul 2025 10:03:56 -0700 Message-ID: <20250709170403.2453228-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 6D5A740005 X-Stat-Signature: 58xzzj1hp6qow76eoccpcm188ph3t63m X-Rspam-User: X-HE-Tag: 1752080646-657010 X-HE-Meta: U2FsdGVkX1/TnZ5YgUSMknGRTB2rxrXEvkl30gYI8DCyqPE1XHZ5QBYrL0kYsAaqnY2WvLp6jFTImZ3+X+veOB0HrmZ0vFyPzjfC37UIC2LCghw3WDuUqjMZ4DEUU5NypHBokOFS7794KQpOS/umxmtw0RibT2nyvm0VXiwwaDCo+UfLi+x+uv+JIe22YeZ3nN4/5UW/1O/GGqLkpSIxTdbuf3W2qmrLvh0G79hkYcbdBkDyksAEh13eiMZa30Bx0WDA/NodkoTqxkasuCxj0N6WwrFfQ0TJ4Ce3JHLo2QZq2qjy2Vh+hIQXjBOpqt6XksbK8u4DInLgHYrUSsv+7qVZq0bMJFzYu3DydWVmqht7qkc4Ti7UpkFpy2GxEUnfLcD5L0sxk6SdrSHyM4DyW43ZWPykTxDR2gf/s8kC+l5T7UdlX1XLVAfW7b+y2+tJYQ2hFnRjrLq0pZfgiXFMWxck3Ya3KihNhv9YyNpL0afyqcmEs9Mur8KBRgBHk/gXZByATzfZurVaIsUdiz7Hsn3R7iGz7vilT5nw0LMeRos3gpCYSwFnj6NFjvjeZmRfpSRZUqlJdCjogLD+VeltGxC47UFJdc5hDI68p7jn4EDEtMS7zv+ESHOCMydLc3UNlBHOafEMwlhTGdNJb0g1TJ3b4TYKDO6A9SZ9uQ5ANEHeXCTrv0TS7qg4PDEmVglkV5wBPr3Iw9vKGnygOxqxLLuTba9mpGFzpoUjUv11BJFSYeeYZSofcXxnDej3rE6vbHIItzS78EnTcHK3gmYn7usrawIZwzJEQUMKkl4vhgrN1CHcM/XYI9sUWr773u1kJuUCAbigUxZBDEeoMyFLB3eDPkNNfeywd7Hy8VOou+OPN0WeSIkLZlGjS7gpXt5lt43oHylU5aEGwkQWETRORnXxofG2cYFQ8s9Uv44DFpcPWxRjpXEeKrlMn6czgGLPOxdi6+wZ5rHJk+Qsain rvemyCdx ic2MRiVHzoagWmjPiyx+n1nx+LsmdBjmuFt0abUrDIDLjU+3S5nh/H5wiQP+jVm24Js1ezQM/kvUQuUiW5pbc1rNOqtbv3JuUS8sJL41QQ0HAzJH1N7xcGYh2ZqnE2qKyUlN+COEabBc+7XR+JRMlkAD9zguwQwybsScKyQIysmOyc7BZASWUKFhagkkcEREFXKCc8BaPbh+400QDGKXU1aVFg9/ZcjPnCq6gsUdXaiuEwk5ebnQ/Jloz7Gk5gVoZHI41PkYbjX+w18Sy0NANsMWPE0vzLTxSBJYCDpVUllnZuIussHPkMpGywJ+BlhPyzTxdHcQN/4JpS9GD+Y+bibd2ItAniGVOpCINW9p0AJJEYUaKkH1brQk4DLi9YT7OvVqD94zLYF3+IJaEy1AFmXSJPCIH1i6iq7Sqb9NsSjwbut14b3vZxpTTXB7T3zqATXOSOS3A9IgzkwwNVb9Qe1pKd+3vqRo7Cbr0i7oiPd80bMcYGKh0ZsEIOVhnZxxVmp40G8XKVtdcNZ1/fAzGpQx+cXqoCVajAW0PbpQnU4SaR4W41rdxeoeIsrMqAg8Ft1NtxmQe7288SlqMuFyqGr2vCByQVVZrEuPKUJ6cA353g43nbchHViihdGl+xaQgB+8u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 8 Jul 2025 23:13:01 +0530 Suresh Chandrappa wrote: > Hi Joshua, > > Thanks for the feedback! In the first patch, both shmem and mmap operations > are present, but I hadn’t introduced any logic to distinguish between them > yet. That distinction is added in the second patch through a new API. Hi Suresh, Yes, this makes sense to me. I think what I was getting at was that we could still make a conditional statement like if (type == FILE_SHMEM) ksft_print_msg("Unable to create shmem file.\n")' else if (type == FILE_MMAP) ksft_print_msg("Unable to create mmap file.\n"); (or use a switch statement) ... And just refactor it in patch 2, as opposed to changing the behavior. But this is mostly a nit. If you are planning to merge both patches in one patch in the next version, then all of these comments shouldn't matter : -) Looking forward to the next version, have a great day! Joshua Sent using hkml (https://github.com/sjp38/hackermail)