From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E71C83F03 for ; Wed, 9 Jul 2025 11:01:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB8CB6B00E3; Wed, 9 Jul 2025 07:00:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B90D36B00E4; Wed, 9 Jul 2025 07:00:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A81156B00E5; Wed, 9 Jul 2025 07:00:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9306A6B00E3 for ; Wed, 9 Jul 2025 07:00:32 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 639DF1A0154 for ; Wed, 9 Jul 2025 11:00:32 +0000 (UTC) X-FDA: 83644432704.05.068B1A0 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf25.hostedemail.com (Postfix) with ESMTP id 7D51BA0003 for ; Wed, 9 Jul 2025 11:00:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2oPKj78j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of 3zUtuaAUKCGgZGHHGMUUMRK.IUSROTad-SSQbGIQ.UXM@flex--tabba.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3zUtuaAUKCGgZGHHGMUUMRK.IUSROTad-SSQbGIQ.UXM@flex--tabba.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752058830; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AOxTG6i7FEjwgO78cp+SZydc4yJ2EnAl5OEX1LUXtxU=; b=k4ag2h011owppQwRh4emAUJ1YVdOdlHQKPwE8z//jpbTaZlhh7FGNR8tGomdMy35uZh8zs ENz/rZGNVlIUOJfMF3uKOh0A23+nAhqgd/dMWQOWFFnIPXIhHv1LAvCAVEhBVVC/YaxyWc NKSirXSlnsdcfU0d1j1s7o5Dr8Yg7yI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752058830; a=rsa-sha256; cv=none; b=G/dm9C5wEaxHFT2O4hCwYlhxvhXrxfWsy7A20MmiUpSLKcCOkn6Sw8MZ4AvUt2s2aDdxvm 39bLVJdtsu/sBoBbfNteau/uW1GM4GAlKh5Dy6Kr3AvYZoTAT8BmBNW+JFiGuRUALPgWZT fKkX486PzmG0oyXwrxo4opdzJA68qHk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=2oPKj78j; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of 3zUtuaAUKCGgZGHHGMUUMRK.IUSROTad-SSQbGIQ.UXM@flex--tabba.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3zUtuaAUKCGgZGHHGMUUMRK.IUSROTad-SSQbGIQ.UXM@flex--tabba.bounces.google.com Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-45320bfc18dso4421795e9.1 for ; Wed, 09 Jul 2025 04:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752058829; x=1752663629; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=AOxTG6i7FEjwgO78cp+SZydc4yJ2EnAl5OEX1LUXtxU=; b=2oPKj78jdxrDdOnbAzN04juL8YuAI5NFr85lomR0WrPWnNqCpWnae4G6Y4fUdxzlD/ ld2JMkr8iY7kCzyKGfwWdi5gB2qOIMq1fzTWkogQnRUMoyD3LzUy9iDZnQ56Z2QJLmMA M9oy10pt1grWItOUmQPF+VqGMReAk9F1eRWPOYuPDlAXmWpkU7x5ZK0aPfNtVqO+VcCJ OmlIWJI7qLUMTC3Wiu6Pu0/hBCaXJ8GqTVQ1PupUfPIJNUF0YxeihWCiCKriCLAeAqGD BXjVV9aTomj0QEt04jgwTm7M+8/1dbDe4rRx6sUNizdaYvdFKXKJmgc7oN5AXVRoNHYs smRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752058829; x=1752663629; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AOxTG6i7FEjwgO78cp+SZydc4yJ2EnAl5OEX1LUXtxU=; b=TxprfbyxDWrcE0IkpR+7yamQPFsi2vqUx/tgSdcoqR0Z4UKPIGHkeCEkrEy4fEHnY2 XL7wxBYMX0CW45J60PXlEuuRv6C9v0Yxq8h2AcHWh64kBi6qoZI+/fUbNGdpFtcKEl0P ApStkJhuKC7UuNr0SlGhDj3wzoWZPrqdVNLnx9f4VzFuzlUDA9tZFAA5d6P/y148v1Sc O5GJeplGax+2zldEFBdcYqL+dOLRM5/CP4sFmI14pgm25KffpGlm4uNJ1eSmW+ijCXAm dv5+NHYla1QkmI6jq+TYEHBcAMjFPy/b+C/iYd32X4FkMb5oNyAdDvAFvUXkwnET2ZFY hJgA== X-Forwarded-Encrypted: i=1; AJvYcCXdP98lNya1pzfkC7gSBLcRGg4DWov3tJQFEvFcAsjL7yU8kE5/Idc+8FAwTY75QappYKrpnJkU+g==@kvack.org X-Gm-Message-State: AOJu0Yzm4rf9kf4lMqu3r4v8dYu2GN2oc+Ur2h0kuLYhh76St6FhX+c6 zpiuvTKiOcxy51WcOHlTIBEQvUq02l2ZIPAtjHSPxGKMt44YGypt8TjHzvnHN9qjQAtg7FVmCPv aJQ== X-Google-Smtp-Source: AGHT+IFdSwxkFLAEN6CNFwVXxFriwP42Gm3qhGkZfCyvKknZ+QLqzKDU3WwX4X8QMks3hlpMifs1nostZg== X-Received: from wmbjh11.prod.google.com ([2002:a05:600c:a08b:b0:454:ab4e:3223]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:580a:b0:43d:5264:3cf0 with SMTP id 5b1f17b1804b1-454cd680a76mr46079365e9.11.1752058829176; Wed, 09 Jul 2025 04:00:29 -0700 (PDT) Date: Wed, 9 Jul 2025 11:59:45 +0100 In-Reply-To: <20250709105946.4009897-1-tabba@google.com> Mime-Version: 1.0 References: <20250709105946.4009897-1-tabba@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250709105946.4009897-20-tabba@google.com> Subject: [PATCH v13 19/20] KVM: selftests: Do not use hardcoded page sizes in guest_memfd test From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7D51BA0003 X-Stat-Signature: 6ewn8t7icf89oik9k84gybrktsuiz1qr X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1752058830-208751 X-HE-Meta: U2FsdGVkX19jtPZWRsXyoxtpmkIA5ubgTFYnX6XOCt4sB7eLq4Kn7aCSFsDwdbOu+GIFRnLXyAbWupekbja7GyKNWWJXGLd4X2ABw+boaFHPLOujnoLOwNTW+jOO9LsQxRAFY7i9FyEzWKSb/MmmsNbv6JOC/lIMF4bBoKBQp/tFce/kewFJttgNA7pIqYHoOJSO+c1ZmbX5ECIoAhJf0Jfr+5tmTrPP8ucAR0H4KTjJz2TMYGcxfTRPrs7zyE70Km57IbgTXs7UCr28r1fS1qVNJUjTNRIyrc7e8715cK7k+WgNrE36YKq8RUGsAmJ1BJ2hvAbD3LatpluG8YFI4YarfWjjOfAKmo8I1/yxllqq4Y/rSkvxyFCmVPQoKitX6qyM2NinJMyZdJlbZBpZ1Ca4TUPn7qv/xgLWiZUN0ceyn2K/AvJKiVrO1w5JIxM7ybH4QosmqefoocYTOFokXyOeGYh3DV/9NQaRzZPYzYNgb2q3kClye0Bq7a0//C1UFpvRxxvA69hT8TiyYpMNog/uIM/KtTeQgRF8hjaw/JvJo3NSyvWjQGN9sgTcVxNag8kCh0+IMf9QwRJo4T2jsD+7t6MvLeT+4r/j8+S7RXyNUCNXHokZGteQ9aYHTga7MYW9w1p9T7ZTqaHxppQEbUsGgnSqRE94kv2KdPhMEgRt6i6kzRIyNxWKkxe0MrfSR0ToSH9G0POxK8e/Gk8tgfDE5m+KWcuvFb4E99LI+xJlrHcS5IVRGe7wcfCEJtRx+ysGAoYWBK+vPY+LLAFKhrHVwN2XZiEFBYiccjRmyQznqilKTz/2Aj1ENSgGbPuK6QPGxQjXv4gsvvJqWDv2CzJmNLkamno3zxFhS0dOukN8yw7DkCpAcaHOac8K8McBvL677Ft5DWEC5YKcfeRiOX7L8X3esR0lYExWm3sPHQe2dXupokO2phCcnthObSgl12Bbq4sZ5Rgy6dzk2uJ 40rRIprm H4Mw+MkC1dWpTYDXHZfO60LLuoRuIlAb60N3S0Q94uhetR3ogWIDJmiLUEOuVFrKum7d95mADPsUTqY9k9n+zkwQBjbfrjDlffuy3Yk5+kOKu+r7pFJRA2hVSyUE/VqC527rDwr6i3AAP3BNmIxEBdfyXlrkbVwP4kXDVrhgVQL1AeRUxf2ZUqPBwNF5bw6XHhYL2uyePadxb2F7UumdhK9WeZRhUHos7sBvzJf/tQiH+il+64UbBg6VM7OdUslRiQhPuQNc+OMHlzG5ygQXa2hpMtRjSFJUsQ0GtNK8M1ZY+6BZu2HtKh55GUsw8pUMgE7t7vL5DZsk4F75ABQeeN5WafhZ4EyPkP0O6Ow8LAzc/gZLbPwjX+w8tg9h6jEjIQoV8SzWqVTKvuziyw9LKwGUFvoHyc9Z2yvsv7CQYYKDZLBrRn+Q4SYnax+DZkKO6gop1i/XcBpPi7xM9UN3pLKnUQMi0YWtMVHItQ0zarYxZGjLxSI/8p8u/Wp4Urrwlzh0NAHQOIeFzj3DLb3LkgDO39VsCMTMTZvaPZB429AR+1chtJ2dJYNMTP4RBD4NQ77EnEXCgoc1N+8RCczt/aRQc8NYJELQLif73onuE3qG0C8AUdnC6NV9muTfPTHG6TxlPaun9Nj77r3KhbshBRTDD8jXiJD0DzN+bI5A8jwCh5DAdFJlMt1roTuglrWpbqB/y X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Update the guest_memfd_test selftest to use getpagesize() instead of hardcoded 4KB page size values. Using hardcoded page sizes can cause test failures on architectures or systems configured with larger page sizes, such as arm64 with 64KB pages. By dynamically querying the system's page size, the test becomes more portable and robust across different environments. Additionally, build the guest_memfd_test selftest for arm64. Reviewed-by: David Hildenbrand Reviewed-by: Shivank Garg Suggested-by: Gavin Shan Reviewed-by: Gavin Shan Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + tools/testing/selftests/kvm/guest_memfd_test.c | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index 38b95998e1e6..e11ed9e59ab5 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -172,6 +172,7 @@ TEST_GEN_PROGS_arm64 += arch_timer TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test TEST_GEN_PROGS_arm64 += get-reg-list +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += memslot_modification_stress_test TEST_GEN_PROGS_arm64 += memslot_perf_test TEST_GEN_PROGS_arm64 += mmu_stress_test diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..341ba616cf55 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -146,24 +146,25 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) { int fd1, fd2, ret; struct stat st1, st2; + size_t page_size = getpagesize(); - fd1 = __vm_create_guest_memfd(vm, 4096, 0); + fd1 = __vm_create_guest_memfd(vm, page_size, 0); TEST_ASSERT(fd1 != -1, "memfd creation should succeed"); ret = fstat(fd1, &st1); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st1.st_size == 4096, "memfd st_size should match requested size"); + TEST_ASSERT(st1.st_size == page_size, "memfd st_size should match requested size"); - fd2 = __vm_create_guest_memfd(vm, 8192, 0); + fd2 = __vm_create_guest_memfd(vm, page_size * 2, 0); TEST_ASSERT(fd2 != -1, "memfd creation should succeed"); ret = fstat(fd2, &st2); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st2.st_size == 8192, "second memfd st_size should match requested size"); + TEST_ASSERT(st2.st_size == page_size * 2, "second memfd st_size should match requested size"); ret = fstat(fd1, &st1); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st1.st_size == 4096, "first memfd st_size should still match requested size"); + TEST_ASSERT(st1.st_size == page_size, "first memfd st_size should still match requested size"); TEST_ASSERT(st1.st_ino != st2.st_ino, "different memfd should have different inode numbers"); close(fd2); -- 2.50.0.727.gbf7dc18ff4-goog