From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E55CC83F09 for ; Wed, 9 Jul 2025 01:00:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9230D6B009C; Tue, 8 Jul 2025 21:00:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D3BF6B009D; Tue, 8 Jul 2025 21:00:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C2066B009E; Tue, 8 Jul 2025 21:00:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 675166B009C for ; Tue, 8 Jul 2025 21:00:30 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1444F127EC5 for ; Wed, 9 Jul 2025 01:00:30 +0000 (UTC) X-FDA: 83642920620.15.C5129EB Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf22.hostedemail.com (Postfix) with ESMTP id 59BC9C001C for ; Wed, 9 Jul 2025 01:00:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hvTrCvUn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of bijan311@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=bijan311@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752022828; a=rsa-sha256; cv=none; b=Ub5XAtpLMWLil6s5s2URjtJw8ya1/mmM1Ag45iQyJljUIFyekybbWul/UOpkSsyZiN6y6J xLQT0lYNDiznVQcgq/JKk/guvclv6gDBeF8RnYwNdGsXWPi/CCgzEQ5EyolvgTQg238Yft RMDwx61rxG6crJDsRtfVzHN6zYozggU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hvTrCvUn; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of bijan311@gmail.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=bijan311@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752022828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fwKG6sHtooB+0pjFJ6ZV0sLHha49Q9YzgcCRLM4NWHU=; b=HE4bFp4ZQG5MMAw0xKX0znWC9Hq+8ij7C8HkuNhReXOxnCAqDl4Jotv6bnDQ941hNtkJGp dgjGfr4ZR5CJnaahTeK33i3u1X8ntTvbcyE2aK8X4DQPLMjF4NA83DdKIsJcOMfCTqeRwp PAaBQ7CPeSWJQ8NbrpeS8/JMOHG1wmo= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-e81749142b3so4049393276.3 for ; Tue, 08 Jul 2025 18:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752022827; x=1752627627; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fwKG6sHtooB+0pjFJ6ZV0sLHha49Q9YzgcCRLM4NWHU=; b=hvTrCvUnC2x8y+Ond+0UuRP0A5bQ7vzrA8ep8HpHmG0vepC45fXR07zr2Uxzh4vD72 iPBBl/RNA57mKCbGWzDUdd3JJLuQ0CwFgVgQi09J73VpM9wwI9b+w4UBvp1QB4ZGCQnZ MGMvnVrk8NRNTsJgeeeFyjiiYhdkI8kUFo/rZFhRd3BCaI4N2Hg/sASx4xJmM9e7gMUM ZvfuzCK7qU/u5NKwplReXPbsT7HhoPugM9L/EMkyTWrUBIqelVKYNWM0ciB/sLAmixyW T9N56rw5kFZ+ikyJzjvuAUOqWPugK0st68ZJ/silENFNnP32BhLORsxZkwbjTYu3fb1X A8Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752022827; x=1752627627; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fwKG6sHtooB+0pjFJ6ZV0sLHha49Q9YzgcCRLM4NWHU=; b=mn5Ho779tKGVdVmyF6tRbp/9VDw0Pxik7RYi8+002WyIMCZXc01df3WErjgagnITzp nnr9UsnfFWJeQKcIU1XHa89avhJ3Jc910JEot/qBdu8SNKOPGAwd6/RsxaQc+3HfvGMk Afd7rIO9wXmHkA/jVY4bFMEY0mmmZ942mtnon6o2+vZPOUtqSdhhQDx+Tp82qsaNGucA gDRujpztWBIqd8P3dbati4Kkwj8e7QXxP/LgRk2RIGnOKD9RuQ3aeT+Qg0wyeFgLfTmt SpeF85ByjI8sWCPzjfsutWyleTAa8lzYW81SXqGDzIF2FRa51Hmcfj/l5QjlM15YO/7o LU6g== X-Forwarded-Encrypted: i=1; AJvYcCVaAZyyQij5XDY3shlBIh8z6agzhxBsxoITCYHE/1NjJFQNH2bz7AyHzxSdgYdmbTjUHHMxAGgxUg==@kvack.org X-Gm-Message-State: AOJu0YygLlaXg4pKq5ks6yGY2ms1sLznYBfDK7fGxnxid5hQwWjxp8St EhxPSQkxwNTyPuTtnix+QQhae+mtaFROqkvXBoQ/OvqeglLQ46ozTTbj X-Gm-Gg: ASbGnctayBtACgOCBddjxGhPaQN5Sa04P8992Pnp45KkCidphYq8HT2RHyWaNZBfxqV g/v3UK3pAm+uKGYLDDrEGmAzIZ+xVM5NpQTKDXhU9Kw0x9Y1f3NdZEA+HLvESo1jPu62nSDzZhr ZOKmOu+WqgZYenqjH0Iap/BQsrasi4H0+vEURwnHRyUpheS+9DWrR9E4D3+jSOuSO50Ls4ch+B8 HNstPaXUQ5IqnS/MfXph01YGPn80BqTzIrGfRgd+tSBpkh7VVNzzgC26IRyQtd6aHU5ZT/FE9fm YaT//8x0m07zVd26tmnwqwdwhTr7Y0kQHlCZ40A+m+NssNzybalqrNTB/H/FFRYi52YB/dl/S7H d4IRclNFkKnvr/UeBtg== X-Google-Smtp-Source: AGHT+IGeQ1u4AoGhlYo8kgmCKQenafouUCLlNX4fxfebzGsC3hfoSv6y546S9TcBswJHKfgNZJfd/Q== X-Received: by 2002:a05:6902:6b0a:b0:e8b:411a:64a8 with SMTP id 3f1490d57ef6-e8b6e14faaamr725647276.24.1752022827080; Tue, 08 Jul 2025 18:00:27 -0700 (PDT) Received: from bijan-laptop.attlocal.net ([2600:1700:680e:c000:235f:99bb:f36e:a060]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e899c43ed8asm3656043276.26.2025.07.08.18.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 18:00:26 -0700 (PDT) From: Bijan Tabatabai To: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: sj@kernel.org, akpm@linux-foundation.org, corbet@lwn.net, bijantabatab@micron.com, venkataravis@micron.com, emirakhur@micron.com, vtavarespetr@micron.com, ajayjoshi@micron.com Subject: [PATCH v4 03/13] mm/damon/sysfs-schemes: implement DAMOS action destinations directory Date: Tue, 8 Jul 2025 19:59:33 -0500 Message-ID: <20250709005952.17776-4-bijan311@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250709005952.17776-1-bijan311@gmail.com> References: <20250709005952.17776-1-bijan311@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: doeki7mezwipof3pk9rgach7y1mcb546 X-Rspamd-Queue-Id: 59BC9C001C X-HE-Tag: 1752022828-124909 X-HE-Meta: U2FsdGVkX1/Hwq3YEEu3V9J3Od6eElNR+4w3tJ24ZMRHSsqTKf5zf4/6+3jVoOOzU+kvoOPgy4no6E65iypYJw2zr3av+vIanNQGVrN2K7SMPOJer7sBgatyAZOiZrh5egY0HvUVla4Vbo7DUR0OoOLiztOZj4cQRKVh4bIBb1CzF0ChpLwHMbpayhQHWdZWRdIN32HxHP68TCW7xag3WG/AKJNmpf12Sh3jV+cxfsF+sa5qeIir1qWtMSg807tUEVSdixgejD6cuUqy74TNr1IvUeSHM0KHSBYQ9ioi0vsONXoIfFSzD3fM+Mvyy0JkkiyFbt5Tmcz8A8cLhVe3D2U2kQp7RipdIAhoOo56MhiEw6lYD82Yrdv6jIFdW+05FxSogRU2DL2jorijsVG0WNE56NXT9j/6qKzHXmqkdDNvWctbis3zY7xDQjEXDnFFpA8Ewu949qGL9xdZKemyR2KMBYIhiNacKNlTKZLHtPAM3NGeWDVaVqdvZZQlvVhpHB0F6iDGeP8MBjN8sFzHOYvtQK1S/AMqP7Uiw7EWlGKppn26H1qNEarqzgEjSsuq99b7BhXP88jfcmB+7S2nxbm3kzyMlMvTSzd5AGBCVDORf3IGXjqgVY3JnSzWvRpHmj5MR4YxTPSv6e0u7ShY8bdV8MiQy1rvm22sp4PifMZ4FCMdNrzThzvC5UV5fCOPktGdMlC0DC80rr3yg/vkeYzRu32pSNYopzPJy45fWMJnREeG4NJbm5m7wdv8y659FrWN7tanS51NssFCvBZty6alUzC+/m4WP4Ch3Bapu4tApfPAUlGTkqDYdKaX+DjZCUx9uTkCVsQO3fAVEAqoArTGTsnsJD6rAXxLMubL2zV6KAyPGb0oSYOlwiqhmmL3RV/0QhBGql2Xda2FLSxhpmu+42ODFUwtQBJEhOxCQ50CM4IWrfN/hXLonIlgnMDJoBQ3Yoft5IOHDdT1btx h1CydAIm THPnqYFiBF1FNQl0GYg0XcWbzIIJvrjHlxArIR+M/WxJu2y5fD9WJ8Am4Sw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: SeongJae Park DAMOS_MIGRATE_{HOT,COLD} can have multiple action destinations and their weights. Implement sysfs directory named 'dests' under each scheme directory to let DAMON sysfs ABI users utilize the feature. The interface is similar to other multiple parameters directory like kdamonds or filters. The directory contains only nr_dests file initially. Writing a number of desired destinations to nr_dests creates directories of the number. Each of the created directories has two files named id and weight. Users can then write the destination's identifier (node id in case of DAMOS_MIGRATE_*) and weight to the files. Signed-off-by: SeongJae Park --- mm/damon/sysfs-schemes.c | 225 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 224 insertions(+), 1 deletion(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 601360e9b521..b9434cdaacdc 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1655,6 +1655,204 @@ static const struct kobj_type damon_sysfs_access_pattern_ktype = { .default_groups = damon_sysfs_access_pattern_groups, }; +/* + * dest (action destination) directory + */ + +struct damos_sysfs_dest { + struct kobject kobj; + unsigned int id; + unsigned int weight; +}; + +static struct damos_sysfs_dest *damos_sysfs_dest_alloc(void) +{ + return kzalloc(sizeof(struct damos_sysfs_dest), GFP_KERNEL); +} + +static ssize_t id_show( + struct kobject *kobj, struct kobj_attribute *attr, char *buf) +{ + struct damos_sysfs_dest *dest = container_of(kobj, + struct damos_sysfs_dest, kobj); + + return sysfs_emit(buf, "%u\n", dest->id); +} + +static ssize_t id_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damos_sysfs_dest *dest = container_of(kobj, + struct damos_sysfs_dest, kobj); + int err = kstrtouint(buf, 0, &dest->id); + + return err ? err : count; +} + +static ssize_t weight_show( + struct kobject *kobj, struct kobj_attribute *attr, char *buf) +{ + struct damos_sysfs_dest *dest = container_of(kobj, + struct damos_sysfs_dest, kobj); + + return sysfs_emit(buf, "%u\n", dest->weight); +} + +static ssize_t weight_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damos_sysfs_dest *dest = container_of(kobj, + struct damos_sysfs_dest, kobj); + int err = kstrtouint(buf, 0, &dest->weight); + + return err ? err : count; +} + +static void damos_sysfs_dest_release(struct kobject *kobj) +{ + struct damos_sysfs_dest *dest = container_of(kobj, + struct damos_sysfs_dest, kobj); + kfree(dest); +} + +static struct kobj_attribute damos_sysfs_dest_id_attr = + __ATTR_RW_MODE(id, 0600); + +static struct kobj_attribute damos_sysfs_dest_weight_attr = + __ATTR_RW_MODE(weight, 0600); + +static struct attribute *damos_sysfs_dest_attrs[] = { + &damos_sysfs_dest_id_attr.attr, + &damos_sysfs_dest_weight_attr.attr, + NULL, +}; +ATTRIBUTE_GROUPS(damos_sysfs_dest); + +static const struct kobj_type damos_sysfs_dest_ktype = { + .release = damos_sysfs_dest_release, + .sysfs_ops = &kobj_sysfs_ops, + .default_groups = damos_sysfs_dest_groups, +}; + +/* + * dests (action destinations) directory + */ + +struct damos_sysfs_dests { + struct kobject kobj; + struct damos_sysfs_dest **dests_arr; + int nr; +}; + +static struct damos_sysfs_dests * +damos_sysfs_dests_alloc(void) +{ + return kzalloc(sizeof(struct damos_sysfs_dests), GFP_KERNEL); +} + +static void damos_sysfs_dests_rm_dirs( + struct damos_sysfs_dests *dests) +{ + struct damos_sysfs_dest **dests_arr = dests->dests_arr; + int i; + + for (i = 0; i < dests->nr; i++) + kobject_put(&dests_arr[i]->kobj); + dests->nr = 0; + kfree(dests_arr); + dests->dests_arr = NULL; +} + +static int damos_sysfs_dests_add_dirs( + struct damos_sysfs_dests *dests, int nr_dests) +{ + struct damos_sysfs_dest **dests_arr, *dest; + int err, i; + + damos_sysfs_dests_rm_dirs(dests); + if (!nr_dests) + return 0; + + dests_arr = kmalloc_array(nr_dests, sizeof(*dests_arr), + GFP_KERNEL | __GFP_NOWARN); + if (!dests_arr) + return -ENOMEM; + dests->dests_arr = dests_arr; + + for (i = 0; i < nr_dests; i++) { + dest = damos_sysfs_dest_alloc(); + if (!dest) { + damos_sysfs_dests_rm_dirs(dests); + return -ENOMEM; + } + + err = kobject_init_and_add(&dest->kobj, + &damos_sysfs_dest_ktype, + &dests->kobj, "%d", i); + if (err) { + kobject_put(&dest->kobj); + damos_sysfs_dests_rm_dirs(dests); + return err; + } + + dests_arr[i] = dest; + dests->nr++; + } + return 0; +} + +static ssize_t nr_dests_show(struct kobject *kobj, + struct kobj_attribute *attr, char *buf) +{ + struct damos_sysfs_dests *dests = container_of(kobj, + struct damos_sysfs_dests, kobj); + + return sysfs_emit(buf, "%d\n", dests->nr); +} + +static ssize_t nr_dests_store(struct kobject *kobj, + struct kobj_attribute *attr, const char *buf, size_t count) +{ + struct damos_sysfs_dests *dests; + int nr, err = kstrtoint(buf, 0, &nr); + + if (err) + return err; + if (nr < 0) + return -EINVAL; + + dests = container_of(kobj, struct damos_sysfs_dests, kobj); + + if (!mutex_trylock(&damon_sysfs_lock)) + return -EBUSY; + err = damos_sysfs_dests_add_dirs(dests, nr); + mutex_unlock(&damon_sysfs_lock); + if (err) + return err; + + return count; +} + +static void damos_sysfs_dests_release(struct kobject *kobj) +{ + kfree(container_of(kobj, struct damos_sysfs_dests, kobj)); +} + +static struct kobj_attribute damos_sysfs_dests_nr_attr = + __ATTR_RW_MODE(nr_dests, 0600); + +static struct attribute *damos_sysfs_dests_attrs[] = { + &damos_sysfs_dests_nr_attr.attr, + NULL, +}; +ATTRIBUTE_GROUPS(damos_sysfs_dests); + +static const struct kobj_type damos_sysfs_dests_ktype = { + .release = damos_sysfs_dests_release, + .sysfs_ops = &kobj_sysfs_ops, + .default_groups = damos_sysfs_dests_groups, +}; + /* * scheme directory */ @@ -1672,6 +1870,7 @@ struct damon_sysfs_scheme { struct damon_sysfs_stats *stats; struct damon_sysfs_scheme_regions *tried_regions; int target_nid; + struct damos_sysfs_dests *dests; }; struct damos_sysfs_action_name { @@ -1762,6 +1961,22 @@ static int damon_sysfs_scheme_set_access_pattern( return err; } +static int damos_sysfs_set_dests(struct damon_sysfs_scheme *scheme) +{ + struct damos_sysfs_dests *dests = damos_sysfs_dests_alloc(); + int err; + + if (!dests) + return -ENOMEM; + err = kobject_init_and_add(&dests->kobj, &damos_sysfs_dests_ktype, + &scheme->kobj, "dests"); + if (err) + kobject_put(&dests->kobj); + else + scheme->dests = dests; + return err; +} + static int damon_sysfs_scheme_set_quotas(struct damon_sysfs_scheme *scheme) { struct damon_sysfs_quotas *quotas = damon_sysfs_quotas_alloc(); @@ -1894,9 +2109,12 @@ static int damon_sysfs_scheme_add_dirs(struct damon_sysfs_scheme *scheme) err = damon_sysfs_scheme_set_access_pattern(scheme); if (err) return err; - err = damon_sysfs_scheme_set_quotas(scheme); + err = damos_sysfs_set_dests(scheme); if (err) goto put_access_pattern_out; + err = damon_sysfs_scheme_set_quotas(scheme); + if (err) + goto put_dests_out; err = damon_sysfs_scheme_set_watermarks(scheme); if (err) goto put_quotas_access_pattern_out; @@ -1927,6 +2145,9 @@ static int damon_sysfs_scheme_add_dirs(struct damon_sysfs_scheme *scheme) put_quotas_access_pattern_out: kobject_put(&scheme->quotas->kobj); scheme->quotas = NULL; +put_dests_out: + kobject_put(&scheme->dests->kobj); + scheme->dests = NULL; put_access_pattern_out: kobject_put(&scheme->access_pattern->kobj); scheme->access_pattern = NULL; @@ -1937,6 +2158,8 @@ static void damon_sysfs_scheme_rm_dirs(struct damon_sysfs_scheme *scheme) { damon_sysfs_access_pattern_rm_dirs(scheme->access_pattern); kobject_put(&scheme->access_pattern->kobj); + kobject_put(&scheme->dests->kobj); + damos_sysfs_dests_rm_dirs(scheme->dests); damon_sysfs_quotas_rm_dirs(scheme->quotas); kobject_put(&scheme->quotas->kobj); kobject_put(&scheme->watermarks->kobj); -- 2.43.0