From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F34C8303C for ; Wed, 9 Jul 2025 00:57:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E94E6B008C; Tue, 8 Jul 2025 20:57:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C0D06B0092; Tue, 8 Jul 2025 20:57:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D7176B0095; Tue, 8 Jul 2025 20:57:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D2C26B008C for ; Tue, 8 Jul 2025 20:57:20 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C0C7F128A45 for ; Wed, 9 Jul 2025 00:57:19 +0000 (UTC) X-FDA: 83642912598.18.5B7F959 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf14.hostedemail.com (Postfix) with ESMTP id D3AAB100012 for ; Wed, 9 Jul 2025 00:57:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nuf3qWnp; spf=pass (imf14.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752022637; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yuv900OZtyE0GQehzzQcdouDbli84sMKyYn/4IFBbp8=; b=VHsQDhTMY0qvCOwkSS1e32bwTYvEU3lHGkzbWIMF73z7JO/IiMHnAIX2va3inysXSQNNE2 hafjVPrq6f8lKkv+UvU4p4bDmqrxHaKn8aDoq9Lk+gjx5jekTMgmt+/XoQHEyBNcYIIhea omHuUQ1dTcPDqbBHyJDLi2ahyO71cVA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nuf3qWnp; spf=pass (imf14.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752022637; a=rsa-sha256; cv=none; b=W5tK8PZevasPWbSSaTQqV/fLV84c4Ic0313Dt8fpn7tm/Ig2c+hJnRPoAohT9RrD69zXWH SR7Luhlwai4mvnxFjfAU1TCIToYTQBXF0cfpsWAHaEjVy5dc3cChK6bQNcndx+zTeyd+uO 1v9bywu1M6qQWNmBo84irsEkBKRANgU= Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ae36dc91dc7so883109466b.2 for ; Tue, 08 Jul 2025 17:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752022636; x=1752627436; darn=kvack.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Yuv900OZtyE0GQehzzQcdouDbli84sMKyYn/4IFBbp8=; b=Nuf3qWnpGJX681t19wb6Mu6YiZN8tP1uqM86zlZxW2Udkm6gBUa4OLnu7fQirDglGu lRKi24ZLWvSmMe5SWvJmBnq8GFSaOhlTkiDLmBMZj65Xrp+dFtqC5crM7D5iSVojwZsD Jk6mOt6yJ4KwXd+AvLJWtXBhUQG7NOhwejNtJf6klBy2FlHCmIuUdG6fdcwsfLRo0JiY TlhcD8sDxCpOceDsO+ileldDulYtKBbwsaa2ZptUhuRZJBo8CSv1dxk+LYhCcjjHegqj sHOt7HeIRlEnUYe5tAwfEbYBbA27s4xeTlGrELjOc7BpfvfJzTaglB4q+bf146qXILyt pZwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752022636; x=1752627436; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Yuv900OZtyE0GQehzzQcdouDbli84sMKyYn/4IFBbp8=; b=SbwW6AdRaaXKmi3lZxNvZvrhL8FsBjaXYgex/p/tSVh/xUnsF0f6ZWsHyOdRFwVGcu jzUD5KULZby/tkBNJZ0uVXNgJtoRiPryE6uAt96erWzc3Ts09SbvKLnvaWt+9wN+TW5s 0YFpM1phjG84UTdSSBYzV9wtD2Hn0k2jhAj6v1CUkLct1GJ60TspI0mcUIPnAj/h9ufC l5sKvEHAuT/Z7g9hC4n4lnrzw1ybruwPFzHsz+e/4HLrndj5FId0moBrPimcw3Z6CH9a hUA+sHwUDZBT1uSGPpA8mw6NEk4kJp3b9uw1Y59GHiK858Mx8FZsoznb+BA9gGWLVfwp bBXA== X-Forwarded-Encrypted: i=1; AJvYcCXN1VP7CV77RaHm0QC0kMrCG26+VGZkzOq+vLBvmESPaMnsu+fZO4k9cuJ22oHTWCqlg9f91IbfGw==@kvack.org X-Gm-Message-State: AOJu0Yzlv4rTynLBjPiE0sVv3AtFQ5B/E0oLTM7se/dDYLE+g1HCz8L+ BG9k7FnFjWhfMbnCqrJOd/JqeBTtmTtkID+tYQjJIho0YxjxaSXyXchh X-Gm-Gg: ASbGncu1/35i7TUeFWSkuNliK/RaAZyfbR1gQNCLq+3RP9KTCh+LTq+jSR0AeYCbM1v ZAN+0Bnu7A31OQ+dONxsi0JNjTlRX9cSJx57Hgy1JZGRDW1dTwE0cpr+OCkLDmJ6as49UmxvZzS sdBP5JfTiFvbdSUj1UNX2i05oQ1hl5FVYzk0bC3HBqxqaD15FD+J27A2/pKe+OBJR6uflALHEES yDfovfDVw008EB+yc1cvKi1NYAsxCVQgIG+GxpK+1JLtffJLW5WcLCiacee2z3H87580gmhaGaF p5xKwH6usZfsrfgRkDfFnEG/NMCuTXLSDr8llOqrdPKrjUbmy2hbUjcKBnS30Q== X-Google-Smtp-Source: AGHT+IE9TIZIFkxYE8/ThWedjkKXX9vTlD+eKHfvFRbcsU7KxQVpm+hFBWxM528yLc24xCmwt4uAVQ== X-Received: by 2002:a17:907:f495:b0:ae3:b371:e7d3 with SMTP id a640c23a62f3a-ae6cf5c53b4mr55502166b.22.1752022635945; Tue, 08 Jul 2025 17:57:15 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae3f6b07fbesm993846066b.135.2025.07.08.17.57.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Jul 2025 17:57:15 -0700 (PDT) Date: Wed, 9 Jul 2025 00:57:15 +0000 From: Wei Yang To: Joshua Hahn Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, John Hubbard , David Hildenbrand , Zi Yan , Matthew Brost , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple Subject: Re: [PATCH] mm/migrate: remove the -EEXIST conversion for move_pages() Message-ID: <20250709005715.q72ujnkzcl5cnxq2@master> Reply-To: Wei Yang References: <20250707065711.18056-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: D3AAB100012 X-Stat-Signature: dqfgti3qw5uysk9ar4qshdcbtrh9hgwq X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752022637-568180 X-HE-Meta: U2FsdGVkX18VKqduo8yoYZ3YI3RhIZBvnio6GIzQTDkVA1q7juzFnc1nsf2vDC0N28oUQGNAgR2Fuh0tSz8pYhfMSKugxJe220nO1prsVJsMzLTnS0pdeFxQdhK9re93Lv6nFXJB5+EFLv/0f0ADSKAD/7JLQPcbQQQ91i8t2+xMIhLJ+3mcqI/wGrf5DEiyJjnUsdHL17wBqvWKeGPLoTBnYU5QhqHKD3jhs2vX4WQ4kVxNF/AGU2yCf52xydeRGdAx0zqXQo/LCR+eP0yB5fTjlsWogheSqfhKXyQZf2motqscDCAnis+giZ+5rHCwOKycDYWvf9z1WwcEvmxhdOIzVGxGgb3f8MImmhBVxCbEx1eq/4RoW8BuUMp8w1pZMwPz8s5tJSo/Yv2KG1xgSwZjr3Vm85DaxsS/lIOd0KjI9JzWks9h5vM6NEentOlob9PdGf4Q98RTQIv43NeRfY60fM2KpsReg1b675bbjPX7IxcHxkJPBRsdsjWtQr100ycgg2IpT5lhHlKgcuGFzYi6q9nrEo5nDwSM6oUWpNFhcF3RTZqyZfYVd+zvtz6D8PQojFk1Zo0SUtEGHD1DK8H0z8zEHtfOt8cdJmUfA9bkTy2kexbPBQDZ3WT5pjmeZFvr+cZgFSssHIFYC202uzIzBgqz44ZNHQUAzjlTMbsEdPolr1WQl2KZ30ECt8USg7QC0cxSv4h1gcIYaSi5uZligNV4AVX0El085cQJEIkjNaVz1uQTewHGdIX5LKLBelrgUbEE4anvATPUAjGRcgDCBE1qHlQs7KT0HIK1VbCUCRqur4CJbDw4UFXGWfKayAR/hKgvU5zN0uKiMRLUVHfKZ3hcBoztc4qKBg3grwvPEQllzVZ+xxt0VCcsT/q2bsZySK/5cFiyaAMK/7MCDd0ySRvt0gmnsH9lbi7Snt0vo9XV10I8ZuJX4lS+rFFkZ/mzFqbuWaqJcso4lVc oL51pIDX QdbiHgNh+Lm+vJHgoj15j4BglB4x4+EE685aLI48VuWAaM5VZ7eVwZOdATGbOig88mrpEoXluklLWNfdFxQJOFEPFfEnayoncW6xIc1rYfrfJo1of+YuIgPW9pTVrE3mIj6mxxd5wjGs0K0ADDcbi7fnzShSLKc4RJFnJrZiflrSOR2tJyd3KgKR7Srx4cmOrF3TKIT7ew6xPPNRCJe4dz1fGnjqimbCLS22ZK5KvNadzqvJWKyKr9fZxVFtX4q4NpEc5Sqmuq4UmKdl/1+twyXFzE1ECcIBM9NQGVPtT30EHXoNYmMO/c719SJX8TDokKkUf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 10:10:58AM -0400, Joshua Hahn wrote: >On Mon, Jul 7, 2025 at 2:57 AM Wei Yang wrote: >> >> The -EEXIST conversion is introduced in commit 65462462ffb2 ("mm/gup: >> follow_pfn_pte(): -EEXIST cleanup"), since follow_page() may call >> follow_pfn_pte() which may return -EEXIST. >> >> But after commit 7dff875c9436 ("mm/migrate: convert >> add_page_for_migration() from follow_page() to folio_walk"), it use >> folio_walk instead. This limit the error code and won't return -EEXIST. >> >> Remove the error code conversion here. >> >> Signed-off-by: Wei Yang >> Cc: John Hubbard >> Cc: David Hildenbrand >> Cc: Zi Yan >> Cc: Matthew Brost >> Cc: Joshua Hahn >> Cc: Rakie Kim >> Cc: Byungchul Park >> Cc: Gregory Price >> Cc: Ying Huang >> Cc: Alistair Popple > >Hello, > >This makes sense, thank you for spotting this! >Reviewed-by: Joshua Hahn > Thanks :-) >Have a great day! >Joshua -- Wei Yang Help you, Help me