From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7C68C83F0F for ; Tue, 8 Jul 2025 07:38:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AA236B0374; Tue, 8 Jul 2025 03:38:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 382376B0375; Tue, 8 Jul 2025 03:38:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BF856B0376; Tue, 8 Jul 2025 03:38:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1B0246B0374 for ; Tue, 8 Jul 2025 03:38:17 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A8E081A0324 for ; Tue, 8 Jul 2025 07:38:16 +0000 (UTC) X-FDA: 83640294192.11.0B79722 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf14.hostedemail.com (Postfix) with ESMTP id 2685E100006 for ; Tue, 8 Jul 2025 07:38:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LZwL65+u; spf=pass (imf14.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751960295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rjk3Xv8dcLy6ARXnvbadCqeCDK8ooTHnPJs8sDEEEss=; b=PZ//CG8MQdT93bIH1fggcuSDAIUy2pgVoTDKkoZ/Wbnq5OdA9XaaSsdOQ1km25M7j2dK47 q6S707SBkcda3GGHbKU/AO1UTZCFkPLZmAbolvfzSMOAGB4DukxaElN0NKXYMGUATQl1lP 1uLuHJzwKzW4taUp1/wIGVn80f0C6Jo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LZwL65+u; spf=pass (imf14.hostedemail.com: domain of brauner@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751960295; a=rsa-sha256; cv=none; b=YVI56D/98UqG0T/vp4c59hNbGv5BDh1NVQElBe+LAaQ7BJ4SiC2HUz36YzNDDauQPF8/BF haWD/EsOHI1XTc2Lp75pmhIWjixzmaa8RPoVcyIRRltGs3D55n9UI+luqTbIAx7mioqniA u1CESr/k/sNtSBHR0HAr1K/kK63/JEA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B06A6457BD; Tue, 8 Jul 2025 07:38:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B1FAC4CEED; Tue, 8 Jul 2025 07:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751960293; bh=UYi0NzDcV9SBdoEkVAoH+UjBMnrLDiE5bGNgW1hW058=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LZwL65+uxin3bwR7v/pHJGQjKLQhEqdy4PkxqedaENuEFFiVy5caUb1SKHGPdC4nD 5fdT0D0BAVU5ETH4EgELBbndk71dF8h1fuNLmDgLMPNl3HdbGAMNUnKMYy4eHYv3La /jJVVwnp+jusmnFenLTJkhvzzQH3Ze5PT5mDaOOhDaLCqdqCHFZNDr2MmGvOPAxpfq FGi13nYdblnSk9pB3EXPpvmJUTfQvnUE3BrI19QNnoei5o6DwF5b1UFaeirBff6Wcr bEXwZHa015BVN05eYpysXcYFIAQcKk7YFyncU09qsdGrPdJfsmrBzG6p2JkDzDD2gv 5T248/fdleu9g== Date: Tue, 8 Jul 2025 09:38:08 +0200 From: Christian Brauner To: Al Viro Cc: Jens Axboe , syzbot , jack@suse.cz, kees@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Mike Rapoport Subject: Re: [PATCH] secretmem: use SB_I_NOEXEC Message-ID: <20250708-wegrand-jungpflanze-a5940464908f@brauner> References: <20250707-tusche-umlaufen-6e96566552d6@brauner> <20250707-heimlaufen-hebamme-d6164bdc5f30@brauner> <20250707171735.GE1880847@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250707171735.GE1880847@ZenIV> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2685E100006 X-Stat-Signature: xpwwyfboucmamexsb9zctpwbiz8er5mx X-Rspam-User: X-HE-Tag: 1751960294-276304 X-HE-Meta: U2FsdGVkX1+esWteq9uDgajXL0iaGqiPMXvozUkKHjEY3Wux/fjWFm+nJV//vWA122kSrWJxJXI2tj2Av99TSsoOpRftMs7xSkDALaQHQHpwhWNigma44AqcRt935pDKAEM+ANmZxdHOKToMI6IsKwG3GUJTFdIea27VwZ4H8a11o/JNLXmMZ84PDkcoSTYb9W7YOAD5sj2iUcyntIe4Os+hi7a0+gqTn4UquG7UkhSoFP3NkWG82SR4TqfvVJynxgh3KXSEc4LXoPmTBJZYcOYbq+cg6dd7iF9L0x2Dj8+QYibJx0pbiF5ZM40HbSeco+ao0+8fY5Dv/+9K6gupStaYl/5bkHjRl2pR991jTk2IyQ6TU4BvIMgKgCoyqp26yR1hozxhNoayaSFrVtHC/1T5kBfcZBfK3zmUmuyRFYG4zQS/xGec1sZosM2d20Wg3la2Pv7m6n1n2Hkk3XR47G/FTMSSPWCUYKV4aMolPuXKJVebdZ+GZQOD4qzFOLEpKRqxpU4vbjXtP2modU3yMIl4ThzxWpfF/WYMpevpWqwUPPitE4vyIlL/jEq6pDU9W5L9KRvsRiA7bBttQworwBvoyBLuv4eD35vG0m8+V5Lmw4whHAQb+ozrLoD5CBgxH4I18g06fSceP2JZ7uHlpGppNRliX98ypv31mLkYrh8+QzwFf5bu7ATbQwn24GaQ6JgxjpKle3OW/z0M4mzUJ8pai9Rm/SfWBsmy+JCOjPVK/MN68YQcsbF3MW4qm99EaNqNhkEZAAclM1dBzEaWg4vg8MQK3aG4qI6CMGWzkRf+l2NOgVTrFCSlNFh6hoUD84SIKSoXZ0GOKKsTePmYrVPqOWowJ/cjTwRRI8+szVnM7aamhiAKAmgh/02kFOb+q7LDOwGKUZxFe+rNmSOFETNLDYa1Ku9j8D9ZvuGQ/6r7VRBuycTcuVor50OR2SFLrFmS04o9m/zB6wO2koR +KeGYU/H Gy/15y9WUbz1TT59+Kte5tzw9HO10zkPNKhJcrqA5tMko278j4eh+LhjUPjM+qIt2BseHyLdhaac6vxQ2/qTjjhEtOXZytjLv4sDkwzfoV7lRWCRNnmqc46/yrEfaiMCO2zFRb5E3NoS78Aur8wCOItksMA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 07, 2025 at 06:17:35PM +0100, Al Viro wrote: > On Mon, Jul 07, 2025 at 02:10:36PM +0200, Christian Brauner wrote: > > > static int secretmem_init_fs_context(struct fs_context *fc) > > { > > - return init_pseudo(fc, SECRETMEM_MAGIC) ? 0 : -ENOMEM; > > + struct pseudo_fs_context *ctx; > > + > > + ctx = init_pseudo(fc, SECRETMEM_MAGIC); > > + if (!ctx) > > + return -ENOMEM; > > + > > + fc->s_iflags |= SB_I_NOEXEC; > > + fc->s_iflags |= SB_I_NODEV; > > + return 0; > > } > > What's the point of doing that *after* init_pseudo()? IOW, why not simply > > static int secretmem_init_fs_context(struct fs_context *fc) > { > fc->s_iflags |= SB_I_NOEXEC; > fc->s_iflags |= SB_I_NODEV; > return init_pseudo(fc, SECRETMEM_MAGIC) ? 0 : -ENOMEM; > } > > seeing that init_pseudo() won't undo those? Seemed cleaner to do it the other way around and get rid of the ? while at it. I don't think it matters either way.